{"id":17816,"url":"https://patchwork.libcamera.org/api/patches/17816/?format=json","web_url":"https://patchwork.libcamera.org/patch/17816/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221118203951.89812-1-Rauch.Christian@gmx.de>","date":"2022-11-18T20:39:51","name":"[libcamera-devel,v2] kms: flag 'request' as 'maybe_unused' to avoid 'unused-parameter' warnings","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b4b76085745dbc91cf4711d219e2ec460e2e4a24","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/?format=json","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17816/mbox/","series":[{"id":3620,"url":"https://patchwork.libcamera.org/api/series/3620/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3620","date":"2022-11-18T20:39:51","name":"[libcamera-devel,v2] kms: flag 'request' as 'maybe_unused' to avoid 'unused-parameter' warnings","version":2,"mbox":"https://patchwork.libcamera.org/series/3620/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17816/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17816/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A3FFBD16B\n\tfor ;\n\tFri, 18 Nov 2022 20:40:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B67E96309B;\n\tFri, 18 Nov 2022 21:40:02 +0100 (CET)","from mout.gmx.net (mout.gmx.net [212.227.17.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CBC3E6308D\n\tfor ;\n\tFri, 18 Nov 2022 21:40:00 +0100 (CET)","from voyager ([46.183.103.17]) by mail.gmx.net (mrgmx104\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 1N8XU1-1p01xG0aUT-014Win;\n\tFri, 18 Nov 2022 21:40:00 +0100"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668804002;\n\tbh=uN/NZb2krpnizgpg/rbNzi1UqrShwdydj24pz+D+MoU=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=jZMBqFLXaHWBXgCj0kwIYAavpfrXRSC7kDH3POvUokeRpyxUGYtSfngJvU8A32J53\n\t1W4QfcdKuKZJibqw4NpSc2SIiI9fGWts/dk4k64y7KJC1jxHQXycMfuuF1NlZx4FBM\n\tyRkHlvlwNfxNL+BMBDuSlUNxim3bDJ7ew2MoKVTzIHQeyIxJLbCJVKqGe22XrPLUlc\n\tDaYd1/qp8x2/2hCd9s50c4J0BQdAgwJJbAqLFDhxukk+Lld1QwUdb1S2xqFjHnUeqK\n\txqUX02huObDnofhyKY3x5a3adRirMY2p7h8JnJRlcR9JplcIXSP5wbESnyYjczrJJJ\n\t+hOsD3beG2RYw==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; \n\tt=1668804000; bh=uN/NZb2krpnizgpg/rbNzi1UqrShwdydj24pz+D+MoU=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date;\n\tb=D7svM4lf3n8UWztrYrZtTIHE9tNlhfKbp/SoI1131O/cRv+c/zX1FQKhPGAwzg7vT\n\tsYBGzAj7trHjI1YXl5H7pdOz7tMbL93rI9B75SjTS1dE/rZ12kmOfIkt8wSQMJkQAg\n\t/0GMMxYzGDeHJbAY+yqPxKffVy3fDflTa5u7MYnItTMqbQlKrSTZCI24Z+dimZRVzL\n\tZLYX/xS0gvcs1cyN7XBXWUj0a+jSaqawdTB2I4PJ3X6NgJP3vHE83diH5WZu9punCt\n\tvEBjJ68d4B1D47qZfJSkHLhzYJyF21DmzliWw3RcES/Lsj+i6XvMb7clsRVBHcfV/A\n\tl9z0sLT91Vraw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmx.de header.i=@gmx.de\n\theader.b=\"D7svM4lf\"; dkim-atps=neutral","X-UI-Sender-Class":"724b4f7f-cbec-4199-ad4e-598c01a50d3a","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 18 Nov 2022 21:39:51 +0100","Message-Id":"<20221118203951.89812-1-Rauch.Christian@gmx.de>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:wcxJ2zYJV3inhm6fNif74CvjNg9zKkOpB+UncvOzYgIW9lMhQea\n\tZlUt8esHK2y17uCCSdgkrQvGC+YyMTJzNiXinXSWJ7taHZrwdS2Ph52Kqnyst+fBkDYZ9Ri\n\t8Hie1djdAGfBHdDgga3BcOazyB/ctrJa6fk7T5FeQE8Yn9mOZ20KP8Pq36IeYigUqMCAE9N\n\tTibZseSmz/YewFGIktlTg==","X-Spam-Flag":"NO","UI-OutboundReport":"notjunk:1; M01:P0:gsGU53zXHjE=;\n\tEESZDD9lBO9GALCATzx9xAl42kv\n\tFVd6+YuyHsccrx1Dhwtqv2cZfs7QciUJ/A0B8PRFeGp6Rkt2UMpp5s89wt7cmsqYHx+T/qdQ3\n\tsEMYSwz3/SBdqfamiK4gFGhmvuk2G9rBiubmI1eQXhmOV8WjJLoK1uYhyTmXVZOzpd/CFbazB\n\tKflegawdMejZIr/LpMkv20j2yVXacZy02cYy/0YJ8fOw/KdWZ6Ibt0066KSDVw+Mwq+iCGhQ2\n\tmMJrHrGmEUFu6A2S0cboRd+HzS52/qkEecXXyZ9c1SuZr/cxLM3S+NZfj3Q0NLheibbJiRW1Q\n\tShmVB07zeYM+/8evGFO22aGytBLqrcA4RYOGWkSN2CLwcWtAmJPL8fMKd5dPJgl2U0WiNQn7r\n\tsCWs6oGKJkEPKI6LhrfnY5Ztfn3vlqujBE+UupwGmGRGm98I8K2dpFANLwGdg9zrd/+0gSkLb\n\tEPVXygibkZijPN9e8X43KGN6NhLE/fQXVpDUU61T8Dk+EpoDkqa8S4673lG93KhkUFf6io+sc\n\tPnGeWUWodYZJhB6u4g80A2Y/6FGXXvNkSFBaHqd7Ajx66/q4dOxTPVxS2Vf6UfhBh5H5PY/+o\n\tzMh43c9hp/A5zhCQ+838thwxGctngvX0NOY0PY6NBJsOrANy8X2MwPRKtSpxluSuXSsy5se55\n\tGEBXKEwZUDyRzIZX9OiLRZsni0N2ag4NVjydZm+v7BWxuBJ6CZJH3J2EWxrBDZWp0NBqo4KiR\n\tUAzqYRd+dwCssrYgoKy2hmimaOhLyhc0VG44cfSAuwzX6t1bBFIRDM1o6DFcflGMt3pA5T82O\n\txuUqnt0pdEU3sKBHxXeGzBOfMFeolSGaDcv2EEtAvfROO4iBBXYcUL1bQUeKC2mLAD+jM5qHm\n\tgd2D32C1Sc+0LBcinQbrJKwOa4LacXzMkkrNitYsOFrjI5R+FWVETvwgFzS2VGajSg0gNpxxE\n\tgFPnIeakBApYI1REO9rZ5o92tLk=","Subject":"[libcamera-devel] [PATCH v2] kms: flag 'request' as 'maybe_unused'\n\tto avoid 'unused-parameter' warnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The parameter 'request' is only used in an assert. assert is only defined\nfor debug builds and release builds will not use the parameter, resulting\nin warnings messages only for non-debug builds.\nFix this by flagging the parameter as 'maybe_unused'.\n\nSigned-off-by: Christian Rauch \n---\n src/apps/cam/kms_sink.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.34.1","diff":"diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\nindex 754b061e..353209cd 100644\n--- a/src/apps/cam/kms_sink.cpp\n+++ b/src/apps/cam/kms_sink.cpp\n@@ -517,7 +517,7 @@ bool KMSSink::processRequest(libcamera::Request *camRequest)\n \treturn false;\n }\n\n-void KMSSink::requestComplete(DRM::AtomicRequest *request)\n+void KMSSink::requestComplete([[maybe_unused]] DRM::AtomicRequest *request)\n {\n \tstd::lock_guard lock(lock_);\n\n","prefixes":["libcamera-devel","v2"]}