[{"id":25824,"web_url":"https://patchwork.libcamera.org/comment/25824/","msgid":"","date":"2022-11-18T20:10:30","subject":"Re: [libcamera-devel] [PATCH] kms: void-cast 'request' to avoid\n\t'unused-parameter' warnings","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Christian,\n\nThank you for the patch.\n\nOn Fri, Nov 18, 2022 at 09:00:46PM +0100, Christian Rauch via libcamera-devel wrote:\n> The parameter 'request' is only used in an assert. assert is only defined\n> for debug builds and release builds will not use the parameter, resulting\n> in warnings messages only for non-debug builds.\n> Fix this by a no-op void cast.\n> \n> Signed-off-by: Christian Rauch \n> ---\n> src/apps/cam/kms_sink.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\n> index 754b061e..de0af51e 100644\n> --- a/src/apps/cam/kms_sink.cpp\n> +++ b/src/apps/cam/kms_sink.cpp\n> @@ -521,6 +521,7 @@ void KMSSink::requestComplete(DRM::AtomicRequest *request)\n> {\n> \tstd::lock_guard lock(lock_);\n> \n> +\t(void) request;\n\nThe standard way to do this in C++ is to declare the function as\n\nvoid KMSSink::requestComplete([[maybe_unused]] DRM::AtomicRequest *request)\n\n> \tassert(queued_ && queued_->drmRequest_.get() == request);\n> \n> \t/* Complete the active request, if any. */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0B4CBE08B\n\tfor ;\n\tFri, 18 Nov 2022 20:10:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 368F26308F;\n\tFri, 18 Nov 2022 21:10:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E5FB6308D\n\tfor ;\n\tFri, 18 Nov 2022 21:10:46 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE70149C;\n\tFri, 18 Nov 2022 21:10:45 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668802248;\n\tbh=2oWhjoBoWSM4UUK6BLiBXknPhaEwgTpcjIPgqZJgtWk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dvhoc5L9rnCQCvPegLBibMRXW+MiunWeSlYLdKrpzbQwYHJuRRU5iL94gQ8LRo6eT\n\t5MuKnUnu1jG/Nk++NbWeT1RADGP8fopaZWe9lE8A8SrnbLDL9btdqSPh1+lXgA0WxC\n\tIxETcuKYC0tUWtJfN90+44kQzkJnrOOEWtfnmVkxMSAKMfi+9UveK5r0+gCpKwFVNL\n\tV30ORPXc5BKR/rWAFjBE6jMQM4KNe0/HjUIeWna2TiRdVfiIJFVihmr/xVyC1985su\n\tSN8BevzSgjH9xS72xrBdCxrLm6MQQEg0NIphGGyibRbv/+B1V5yaiRQmJo5/SyhvaJ\n\t0fTolC8XWaQQg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668802246;\n\tbh=2oWhjoBoWSM4UUK6BLiBXknPhaEwgTpcjIPgqZJgtWk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gKSpO1xy0f6zmxVENJIXmsAp2nIzs8bcTMed8tk5glsGK3OPLkd70qoSMf89H2WF3\n\t7L7ZMpMeaAWtR3kzZIDNsh4AOScAlJrf/xkLvV8UzGbhvk5QrsxY4ffq7C3wFGRk7a\n\tVGkiqEEFbGxh1G8ZMnJ9qr6iHasQcMgScUokdi0U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gKSpO1xy\"; dkim-atps=neutral","Date":"Fri, 18 Nov 2022 22:10:30 +0200","To":"Christian Rauch ","Message-ID":"","References":"<20221118200046.51305-1-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221118200046.51305-1-Rauch.Christian@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH] kms: void-cast 'request' to avoid\n\t'unused-parameter' warnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]