[{"id":25828,"web_url":"https://patchwork.libcamera.org/comment/25828/","msgid":"","date":"2022-11-19T00:32:03","subject":"Re: [libcamera-devel] [PATCH] libcamera: imx8-isi: Enumerate\n\tsupported stream formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Nov 18, 2022 at 05:40:35PM +0100, Jacopo Mondi via libcamera-devel wrote:\n> Add to the formats map all the supported ISI video capture\n> stream formats.\n> \n> This allows to populate the list of stream formats for all the non-RAW\n> use cases, as the ISI can perform colorspace conversion between YUV and\n> RGB.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 62 +++++++++++++++++++-\n> 1 file changed, 59 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> index 14d699b7a42b..a3dfd3fc529c 100644\n> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> @@ -188,11 +188,51 @@ const ISICameraConfiguration::FormatMap ISICameraConfiguration::formatsMap_ = {\n> \t\t{ MEDIA_BUS_FMT_YUV8_1X24,\n> \t\t MEDIA_BUS_FMT_UYVY8_1X16 },\n> \t},\n> +\t{\n> +\t\tformats::AVUY8888,\n> +\t\t{ MEDIA_BUS_FMT_YUV8_1X24,\n> +\t\t MEDIA_BUS_FMT_UYVY8_1X16 },\n> +\t},\n> +\t{\n> +\t\tformats::NV12,\n> +\t\t{ MEDIA_BUS_FMT_YUV8_1X24,\n> +\t\t MEDIA_BUS_FMT_UYVY8_1X16 },\n> +\t},\n> +\t{\n> +\t\tformats::NV16,\n> +\t\t{ MEDIA_BUS_FMT_YUV8_1X24,\n> +\t\t MEDIA_BUS_FMT_UYVY8_1X16 },\n> +\t},\n> +\t{\n> +\t\tformats::YUV444,\n> +\t\t{ MEDIA_BUS_FMT_YUV8_1X24,\n> +\t\t MEDIA_BUS_FMT_UYVY8_1X16 },\n> +\t},\n> \t{\n> \t\tformats::RGB565,\n> \t\t{ MEDIA_BUS_FMT_RGB888_1X24,\n> \t\t MEDIA_BUS_FMT_RGB565_1X16 },\n> \t},\n> +\t{\n> +\t\tformats::BGR888,\n> +\t\t{ MEDIA_BUS_FMT_RGB888_1X24,\n> +\t\t MEDIA_BUS_FMT_RGB565_1X16 },\n> +\t},\n> +\t{\n> +\t\tformats::RGB888,\n> +\t\t{ MEDIA_BUS_FMT_RGB888_1X24,\n> +\t\t MEDIA_BUS_FMT_RGB565_1X16 },\n> +\t},\n> +\t{\n> +\t\tformats::XRGB8888,\n> +\t\t{ MEDIA_BUS_FMT_RGB888_1X24,\n> +\t\t MEDIA_BUS_FMT_RGB565_1X16 },\n> +\t},\n> +\t{\n> +\t\tformats::ABGR8888,\n> +\t\t{ MEDIA_BUS_FMT_RGB888_1X24,\n> +\t\t MEDIA_BUS_FMT_RGB565_1X16 },\n> +\t},\n> \t{\n> \t\tformats::SBGGR8,\n> \t\t{ MEDIA_BUS_FMT_SBGGR8_1X8,\n> @@ -546,6 +586,7 @@ PipelineHandlerISI::generateConfiguration(Camera *camera,\n> \t\treturn nullptr;\n> \t}\n> \n> +\tbool isRaw = false;\n> \tfor (const auto &role : roles) {\n> \t\t/*\n> \t\t * Prefer the following formats\n> @@ -553,6 +594,7 @@ PipelineHandlerISI::generateConfiguration(Camera *camera,\n> \t\t * - ViewFinder/VideoRecording: 1080p YUYV\n> \t\t * - RAW: sensor's native format and resolution\n> \t\t */\n> +\t\tstd::map> streamFormats;\n> \t\tPixelFormat pixelFormat;\n> \t\tSize size;\n> \n> @@ -614,6 +656,9 @@ PipelineHandlerISI::generateConfiguration(Camera *camera,\n> \t\t\tsize = data->sensor_->resolution();\n> \t\t\tpixelFormat = rawPipeFormat->first;\n> \n> +\t\t\tstreamFormats[pixelFormat] = { { kMinISISize, size } };\n> +\t\t\tisRaw = true;\n> +\n> \t\t\tbreak;\n> \t\t}\n> \n> @@ -622,9 +667,20 @@ PipelineHandlerISI::generateConfiguration(Camera *camera,\n> \t\t\treturn nullptr;\n> \t\t}\n> \n> -\t\t/* \\todo Add all supported formats. */\n> -\t\tstd::map> streamFormats;\n> -\t\tstreamFormats[pixelFormat] = { { kMinISISize, size } };\n> +\t\t/*\n> +\t\t * For non-RAW configurations the ISI can perform colorspace\n> +\t\t * conversion. List all the supported output formats here.\n> +\t\t */\n> +\t\tif (!isRaw) {\n> +\t\t\tfor (const auto &[pixFmt, pipeFmt] : ISICameraConfiguration::formatsMap_) {\n> +\t\t\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(pixFmt);\n> +\t\t\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n> +\t\t\t\t\tcontinue;\n> +\n> +\t\t\t\tstreamFormats[pixFmt] = { { kMinISISize, size } };\n> +\t\t\t}\n> +\t\t}\n> +\n> \t\tStreamFormats formats(streamFormats);\n> \n> \t\tStreamConfiguration cfg(formats);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EACFFBD16B\n\tfor ;\n\tSat, 19 Nov 2022 00:32:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 640A96309B;\n\tSat, 19 Nov 2022 01:32:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F02A961F31\n\tfor ;\n\tSat, 19 Nov 2022 01:32:19 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EBAE749;\n\tSat, 19 Nov 2022 01:32:19 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668817941;\n\tbh=QoD5WDvm6/TqeeEaPHuxN4yFCQgk330HmZb3KeIml7Q=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xEvDDgJnv0n7cAlFUqFTkEKG/Mj5kd4PZ5T3YhM9PQWUKn8zbAOPsFgGWD2YbyzSE\n\tfMZMKCqBpncNbvfmrJYxslg5qkxzdP/vI/06ZWMqjR70RkUDsyNf48AAHn+7Do0rPB\n\tdYFHKwyKaOoOvjT6L2IC3grdO+lCClHqhsxXzB5HoCj528tj5tdLwwieUYo8b0IJBN\n\tUeBXRrRKMoA1nGYnbXg/X8nglF37pNKLZ3hRn0bZIgh8j34DS5P9vfbm/DAz99d7IW\n\tvUkGh7gtvy7kX4GzPfpSRckcfEy6nihPy2iOQku25GpkqaRa+iJUUshGWWRWP3RhC7\n\tmkwCo6ECPl/zw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668817939;\n\tbh=QoD5WDvm6/TqeeEaPHuxN4yFCQgk330HmZb3KeIml7Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GOhiWcqopdx8eDPbv1xQDiWIGcqphjdy+KxJ1OZh5P+gBFsj4qmxN+aNBUDPd1Th8\n\tKnyAbGanPPn/in9Up9zCULAL8GzeaRDg5Td89r/L6Iq0rHUkE2V9mIX02JM24Sfols\n\thfzdZ0RcghS7lKGXGcM3kOL9hw7p5C82TZmrPYyM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GOhiWcqo\"; dkim-atps=neutral","Date":"Sat, 19 Nov 2022 02:32:03 +0200","To":"Jacopo Mondi ","Message-ID":"","References":"<20221118164035.23740-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221118164035.23740-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: imx8-isi: Enumerate\n\tsupported stream formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]