[{"id":25823,"web_url":"https://patchwork.libcamera.org/comment/25823/","msgid":"","date":"2022-11-18T18:29:01","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Do not lookup controls by\n\tid","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn 11/18/22 9:51 PM, Jacopo Mondi via libcamera-devel wrote:\n> The libcamerasrc element looks for the availability of the\n> FrameDurationLimits control by looking it up by numeric control id.\n>\n> The ControlinfoMap::find(unsigned int i) function searches the control\n> numerical identifier on the ContorlInfoMap::idMap_ class member, which\n> might be not initialized if the pipeline handler does not register\n> any control, causing an invalid memory access.\n>\n> Avoid looking up the control by numerical id and use the ControlId\n> instance instead to prevent that.\n\nNice spot.\n\nI wonder if it's specific to ISI Pipeline-handler (probably yes) that \nyou hit this non-initialization situation.\n>\n> Fixes: ccfe0a1af77c (\"gstreamer: Provide framerate support for libcamerasrc\")\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Umang Jain \n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index 64d197010008..36b9564c4cb4 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -436,7 +436,7 @@ void gst_libcamera_clamp_and_set_frameduration(ControlList &initCtrls,\n> \tif (!gst_structure_has_field_typed(element_caps, \"framerate\", GST_TYPE_FRACTION))\n> \t\treturn;\n>\n> -\tauto iterFrameDuration = cam_ctrls.find(controls::FrameDurationLimits.id());\n> +\tauto iterFrameDuration = cam_ctrls.find(&controls::FrameDurationLimits);\n> \tif (iterFrameDuration == cam_ctrls.end()) {\n> \t\tGST_WARNING(\"FrameDurationLimits not found in camera controls.\");\n> \t\treturn;\n> --\n> 2.38.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 485DDBE08B\n\tfor ;\n\tFri, 18 Nov 2022 18:30:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B066E6308F;\n\tFri, 18 Nov 2022 19:29:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFDB86308D\n\tfor ;\n\tFri, 18 Nov 2022 19:29:57 +0100 (CET)","from [192.168.1.104] (unknown [103.251.226.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 98E6C4AE;\n\tFri, 18 Nov 2022 19:29:56 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668796199;\n\tbh=ngviC1WElV9CP2s9B6Vv8xSjwhjK/UEufbZxnu8EBeo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rSwiL8vgMdzFf8GynPmqSGgAHJKca7cuxAIes244DYJhoC0G+iji+ls+GSKdxguPm\n\tcejeZt7AibKq31FcnYwEm5Wi2z7hf5G/UdWWr5L8xScwpw/FUUvRBY64r/ZzUEIo1B\n\tdpZ4/ujPsLsmrL4MbyhH29/IsYSobR9WZxzP66Q7btcyu/isq/qoTnca6FYCLWSqDJ\n\t6fCVquBShdQkzPB4JBbzBIMM+CPlDjcHRIDZGJSRePjr0apHLYRTeCxA9q8O8UgHl6\n\tnQ1g+AVt1MzHhheECgbxySrZhjFsSlrNpZYOBaMURvsxTVMnzTUNt/BPyg/hjmo0MK\n\tJL7JEnDQemxMg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668796197;\n\tbh=ngviC1WElV9CP2s9B6Vv8xSjwhjK/UEufbZxnu8EBeo=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=nMmdIyNWkkmnMp2WFXPrx4acu037xXfqzO9Rqs7r3NFRYBBxqr1JJUHHd2Z5M7FyG\n\tFbIZY2dNCqe6TGwfYVg8JyvoJLlUqekZKKwJJUNveonZL1Z+IOLAIrEKwtCA2dlqq4\n\tee0cxSCil7+pDzRDjgrgAf8IglkR2UWBPoeLiOc8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nMmdIyNW\"; dkim-atps=neutral","Message-ID":"","Date":"Fri, 18 Nov 2022 23:59:01 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.4.1","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20221118162129.22866-1-jacopo@jmondi.org>","Content-Language":"en-US","In-Reply-To":"<20221118162129.22866-1-jacopo@jmondi.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Do not lookup controls by\n\tid","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"Rishikesh Donadkar ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25825,"web_url":"https://patchwork.libcamera.org/comment/25825/","msgid":"","date":"2022-11-19T00:26:04","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Do not lookup controls by\n\tid","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Fri, Nov 18, 2022 at 11:59:01PM +0530, Umang Jain wrote:\n> On 11/18/22 9:51 PM, Jacopo Mondi via libcamera-devel wrote:\n> > The libcamerasrc element looks for the availability of the\n> > FrameDurationLimits control by looking it up by numeric control id.\n> >\n> > The ControlinfoMap::find(unsigned int i) function searches the control\n> > numerical identifier on the ContorlInfoMap::idMap_ class member, which\n> > might be not initialized if the pipeline handler does not register\n> > any control, causing an invalid memory access.\n> >\n> > Avoid looking up the control by numerical id and use the ControlId\n> > instance instead to prevent that.\n> \n> Nice spot.\n> \n> I wonder if it's specific to ISI Pipeline-handler (probably yes) that \n> you hit this non-initialization situation.\n\nIt's because the ISI pipeline handler doesn't expose any control. That's\nnot supposed to be a common situation, and will likely be fixed, but\nit's still better to use find(Control *) than find(int).\n\n> > Fixes: ccfe0a1af77c (\"gstreamer: Provide framerate support for libcamerasrc\")\n> > Signed-off-by: Jacopo Mondi \n> \n> Reviewed-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> > index 64d197010008..36b9564c4cb4 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.cpp\n> > +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> > @@ -436,7 +436,7 @@ void gst_libcamera_clamp_and_set_frameduration(ControlList &initCtrls,\n> > \tif (!gst_structure_has_field_typed(element_caps, \"framerate\", GST_TYPE_FRACTION))\n> > \t\treturn;\n> >\n> > -\tauto iterFrameDuration = cam_ctrls.find(controls::FrameDurationLimits.id());\n> > +\tauto iterFrameDuration = cam_ctrls.find(&controls::FrameDurationLimits);\n> > \tif (iterFrameDuration == cam_ctrls.end()) {\n> > \t\tGST_WARNING(\"FrameDurationLimits not found in camera controls.\");\n> > \t\treturn;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D480BE08B\n\tfor ;\n\tSat, 19 Nov 2022 00:26:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77B346309B;\n\tSat, 19 Nov 2022 01:26:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6470661F31\n\tfor ;\n\tSat, 19 Nov 2022 01:26:20 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F43E749;\n\tSat, 19 Nov 2022 01:26:19 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668817582;\n\tbh=PovIHUZKq/tMkMZ8DaqMgyi+zkFmQA/aaLQ0HHbYnQs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=NklA0YL7XfveFeMDXjM8/SMrUeyRUiP27s35QTG8xqiWr0wb0uNdbTxDBITBmhC9f\n\thkKzWzMWNnmMirwyNxpMKMvi0Es6l24ZIN59KaxiyqSPT/7Grx8qg1vS8so5qL72p9\n\tVFhHjQm5f+mcEd/CZFpyK9q2AMHESsI+Ttep3DqI+m+6afYArnzevoCaf9KNEvGPJM\n\toUGPAD2aq+Gvle3GCIkiXJo/rCyXn6q7nvDTN4ZL0aMLOMOl5zFDOMTYcsjAKhGsUz\n\tbTX8xQ+u0kUIinD2hx2BCxm45Ibxrr6YXlKwrJN8T3NV7opXhMyu8Y/gEqZijO/GT7\n\tmpxDAy4oPFOgw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668817579;\n\tbh=PovIHUZKq/tMkMZ8DaqMgyi+zkFmQA/aaLQ0HHbYnQs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hIcRDCxFD/NcX5oEE2QUcridiT2TwOWrutuQjC6U1daKUa6Dvpv4ZyTrSm5TvvLqx\n\tebCOXxNbHtw/5pAiCFI0FwsRPyWlD0FGiFeLXzrr40cZfQ0wtfZMyNZmOajFWyoMdu\n\tz3eKX79rRk/J76qVF0gPqeI++JZO/F0aUAcvUUzc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hIcRDCxF\"; dkim-atps=neutral","Date":"Sat, 19 Nov 2022 02:26:04 +0200","To":"Umang Jain ","Message-ID":"","References":"<20221118162129.22866-1-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Do not lookup controls by\n\tid","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Rishikesh Donadkar ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]