[{"id":25886,"web_url":"https://patchwork.libcamera.org/comment/25886/","msgid":"<20221123173220.7dwva4h52oua5sk2@uno.localdomain>","date":"2022-11-23T17:32:20","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX519\n\tsensor properties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Tue, Nov 15, 2022 at 08:48:15PM +0530, Umang Jain via libcamera-devel wrote:\n> Add an entry for Arducam IMX519 sensor which has 1220x1220 pixel array\n> and supports four test pattern modes.\n>\n> Signed-off-by: Umang Jain \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index e5f27f06..04d80d6d 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -102,6 +102,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t.unitCellSize = { 1550, 1550 },\n> \t\t\t.testPatternModes = {},\n> \t\t} },\n> +\t\t{ \"imx519\", {\n> +\t\t\t.unitCellSize = { 1220, 1220 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n> +\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 2 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n> +\t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n> +\t\t\t},\n> +\t\t} },\n\nI don't have documentation, so it looks reasonable to me :)\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> \t\t{ \"ov2740\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {\n> --\n> 2.37.3\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4F4BBDE6B\n\tfor ;\n\tWed, 23 Nov 2022 17:32:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24AC76331A;\n\tWed, 23 Nov 2022 18:32:23 +0100 (CET)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::223])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B2C063311\n\tfor ;\n\tWed, 23 Nov 2022 18:32:22 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 82AED60005;\n\tWed, 23 Nov 2022 17:32:21 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669224743;\n\tbh=aE+ZcsIzBFCGcLdDT9DAZtRIVFHJwydDK9ERUKWzNHA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tqRIQ+xily7/8QcbRFU+ERzvPQ/sVmmmXa6PNhKRHOt4WyPtj5KrbgkkG/3UX3CJH\n\tv97y/wbruRjL1Pkw9/nyh1LGXf23XqiUD6unT5S4PmL2Va85nyyhlfLab/3o9UEPz8\n\tSUb8fvpH56mmnpNOeaOZk5IcAZ+Cr48HL4GvxGusmha4niJTwLQ5POnF0LFafDpHFY\n\tZD2cOngMo7u8gIy5Dv1HEc22O5vSH08Tzgybl5mk7xpA08+KIDJq0Vm5RmM9pWE+7m\n\tiFj2wlDd48mOWgKek4gIUR8QlMRLbRtIOLFs9j7NjNJUhu3ryl27zA+xCAvFFUvwok\n\tUG9f5OOuYHL3Q==","Date":"Wed, 23 Nov 2022 18:32:20 +0100","To":"Umang Jain ","Message-ID":"<20221123173220.7dwva4h52oua5sk2@uno.localdomain>","References":"<20221115151816.16078-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221115151816.16078-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX519\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25887,"web_url":"https://patchwork.libcamera.org/comment/25887/","msgid":"","date":"2022-11-23T17:58:37","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX519\n\tsensor properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Nov 23, 2022 at 06:32:20PM +0100, Jacopo Mondi via libcamera-devel wrote:\n> On Tue, Nov 15, 2022 at 08:48:15PM +0530, Umang Jain via libcamera-devel wrote:\n> > Add an entry for Arducam IMX519 sensor which has 1220x1220 pixel array\n\nIt's the pixel size, not the pixel array.\n\n> > and supports four test pattern modes.\n> >\n> > Signed-off-by: Umang Jain \n> > ---\n> > src/libcamera/camera_sensor_properties.cpp | 10 ++++++++++\n> > 1 file changed, 10 insertions(+)\n> >\n> > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > index e5f27f06..04d80d6d 100644\n> > --- a/src/libcamera/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > @@ -102,6 +102,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > \t\t\t.unitCellSize = { 1550, 1550 },\n> > \t\t\t.testPatternModes = {},\n> > \t\t} },\n> > +\t\t{ \"imx519\", {\n> > +\t\t\t.unitCellSize = { 1220, 1220 },\n> > +\t\t\t.testPatternModes = {\n> > +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> > +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n> > +\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 2 },\n> > +\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n> > +\t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n> > +\t\t\t},\n> > +\t\t} },\n> \n> I don't have documentation, so it looks reasonable to me :)\n> \n> Reviewed-by: Jacopo Mondi \n\nUmang, do you have access to that camera module ? If so, have you been\nable to compare the test patterns with the CCS specification ? If so,\nwith the commit message update,\n\nReviewed-by: Laurent Pinchart \n\n> > \t\t{ \"ov2740\", {\n> > \t\t\t.unitCellSize = { 1400, 1400 },\n> > \t\t\t.testPatternModes = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA29DBE08B\n\tfor ;\n\tWed, 23 Nov 2022 17:58:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22E326331A;\n\tWed, 23 Nov 2022 18:58:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14F9163311\n\tfor ;\n\tWed, 23 Nov 2022 18:58:54 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D97C890;\n\tWed, 23 Nov 2022 18:58:53 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669226336;\n\tbh=jlXM9FMEyJuQ9ZEBY3Vci7hVdmNhG8Je5Xh2f/xRJSk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MW/VrMvotAeu0K2kieZ1axS6lxRtdoGCb3zRvwP/zFrLTICgigVUSTq2JvgsI/X7v\n\t+rrSEe7M2vJnG5jxD4S7hgLjbQu9vg5KoPNwMPB1PcjtT5nAHTJmkuSzlV+oUTDApB\n\tIE5gpj8ZLoMrxLZqXwwP1+k7Z0hp03Re3/0NyrFXtngjwuFai7UTgObTe63pnUuc0P\n\tssCmSdgaDHeTKB3ox1hryxMNUCyJ9Meex5RQVb90fGG3VrREZd8nUV5eH+zxtF5U9a\n\tRsGtL1CeExCNtsNmvdy+i7cOqTA/SB3YTE9yGY29rrcZSLRIn276OT5ekZWVR7cRgt\n\tYjtSCvcFXpwxQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669226333;\n\tbh=jlXM9FMEyJuQ9ZEBY3Vci7hVdmNhG8Je5Xh2f/xRJSk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DHh9CVbk3C+ZC4ttmwczKfSRRSgCrJhX0U4wATrOJYpEQHQLe4Sn6RlA8ROIOu/qC\n\t7TmRrLGIBu1b2L4F6IqUYbVzjAZaaJUvaETF8npVUga3C+31BO0ScqHoFAZj/Tnqtx\n\t92uvwH+tzpzsdSBbcCjGARqXQgR5lwphH7ooJurU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DHh9CVbk\"; dkim-atps=neutral","Date":"Wed, 23 Nov 2022 19:58:37 +0200","To":"Jacopo Mondi ","Message-ID":"","References":"<20221115151816.16078-1-umang.jain@ideasonboard.com>\n\t<20221123173220.7dwva4h52oua5sk2@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221123173220.7dwva4h52oua5sk2@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX519\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25946,"web_url":"https://patchwork.libcamera.org/comment/25946/","msgid":"<810dbbb1-bd16-9d57-c666-57a6578b3d64@ideasonboard.com>","date":"2022-11-30T17:45:35","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX519\n\tsensor properties","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 11/24/22 1:58 AM, Laurent Pinchart wrote:\n> On Wed, Nov 23, 2022 at 06:32:20PM +0100, Jacopo Mondi via libcamera-devel wrote:\n>> On Tue, Nov 15, 2022 at 08:48:15PM +0530, Umang Jain via libcamera-devel wrote:\n>>> Add an entry for Arducam IMX519 sensor which has 1220x1220 pixel array\n> It's the pixel size, not the pixel array.\nack\n>\n>>> and supports four test pattern modes.\n>>>\n>>> Signed-off-by: Umang Jain \n>>> ---\n>>> src/libcamera/camera_sensor_properties.cpp | 10 ++++++++++\n>>> 1 file changed, 10 insertions(+)\n>>>\n>>> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n>>> index e5f27f06..04d80d6d 100644\n>>> --- a/src/libcamera/camera_sensor_properties.cpp\n>>> +++ b/src/libcamera/camera_sensor_properties.cpp\n>>> @@ -102,6 +102,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>>> \t\t\t.unitCellSize = { 1550, 1550 },\n>>> \t\t\t.testPatternModes = {},\n>>> \t\t} },\n>>> +\t\t{ \"imx519\", {\n>>> +\t\t\t.unitCellSize = { 1220, 1220 },\n>>> +\t\t\t.testPatternModes = {\n>>> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n>>> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n>>> +\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 2 },\n>>> +\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n>>> +\t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n>>> +\t\t\t},\n>>> +\t\t} },\n>> I don't have documentation, so it looks reasonable to me :)\n>>\n>> Reviewed-by: Jacopo Mondi \n> Umang, do you have access to that camera module ? If so, have you been\n> able to compare the test patterns with the CCS specification ? If so,\n> with the commit message update,\n\nSo there are couple of things off with test patterns I obtained.\n\n- The CCS specification say [1] for Solid Color and [2] for 100% Color \nBars. IMX519 got these indexes swapped while reporting via v4l2-ctl atleast\n- There is no 'ColorBars' and 'ColorBarsFadeToGray' patterns in my \ntesting  which comply with CCS's patterns atleast.\n\nWhat I obttained is the following:\n\n[0]: (disabled)\n[1]: Two color bars only Aqua and Yellow (Does this count as color bars?)\n[2]: Solid Color (white)\n[3]: Same as [1]\n[4]: PN9 seems fine\n\nIf you need visual samples let me know, I'll send it to you.\n>\n> Reviewed-by: Laurent Pinchart \n>\n>>> \t\t{ \"ov2740\", {\n>>> \t\t\t.unitCellSize = { 1400, 1400 },\n>>> \t\t\t.testPatternModes = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7911BDE6B\n\tfor ;\n\tWed, 30 Nov 2022 17:46:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2999363336;\n\tWed, 30 Nov 2022 18:46:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E64361F23\n\tfor ;\n\tWed, 30 Nov 2022 18:46:37 +0100 (CET)","from [192.168.10.186] (unknown [210.186.188.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E6DEB6D6;\n\tWed, 30 Nov 2022 18:46:35 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669830399;\n\tbh=9gOt8MzfsnYpHRtwZzecCmWZfKxgiOLgfXHpjWnpVpY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rY5b/cm4mKcxciTx1wF2SrBsxBcNttONysZ1ciWHWaAje2X8lqeHVQZOb2/xwp2DD\n\tY1RN5rjdnyOeTNOYi3f2LLhaiaMumGfERfpXZYVJnTrWvzctMG8gTdbotNQak1NYuQ\n\tS5YQ0qUsTZbP3t5Gul0w/4UFuKmvQrTm5B62+2owwe1KukKxaKZg/70GBrpTtvDVfo\n\triahl84iOp/n6+2p2hj44afe81C1JA7QOo7aMgeZycG6uR1ny/doiByxp1U3NIx0Vd\n\tOSuepQAO1JEBhAMdvU5JNME+gp4XPFwRUENls+z/UMXzFYfz8oFWjBRn7sxbi23WOa\n\tQhO2KhWjP7+Dg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669830396;\n\tbh=9gOt8MzfsnYpHRtwZzecCmWZfKxgiOLgfXHpjWnpVpY=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=Axd5cY2o7feE3FyiSnwdYR0efANHJzj8iGwCS5bSU+JpcgfufqniESZCD8LOgLIeR\n\t3gl5X+6UfQ2dPXuAP6/XTDozJlffznxUlhruis1JSj/2M8oN6YlOL7Fx1NYar9VLoc\n\tqDf5iE1qTm9fBFfBBfI/D/lgo+gn7erBLFb6U69w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Axd5cY2o\"; dkim-atps=neutral","Message-ID":"<810dbbb1-bd16-9d57-c666-57a6578b3d64@ideasonboard.com>","Date":"Thu, 1 Dec 2022 01:45:35 +0800","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.5.0","To":"Laurent Pinchart ,\n\tJacopo Mondi ","References":"<20221115151816.16078-1-umang.jain@ideasonboard.com>\n\t<20221123173220.7dwva4h52oua5sk2@uno.localdomain>\n\t","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX519\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25948,"web_url":"https://patchwork.libcamera.org/comment/25948/","msgid":"","date":"2022-12-01T04:30:28","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX519\n\tsensor properties","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 12/1/22 1:45 AM, Umang Jain via libcamera-devel wrote:\n> Hi Laurent,\n>\n> On 11/24/22 1:58 AM, Laurent Pinchart wrote:\n>> On Wed, Nov 23, 2022 at 06:32:20PM +0100, Jacopo Mondi via \n>> libcamera-devel wrote:\n>>> On Tue, Nov 15, 2022 at 08:48:15PM +0530, Umang Jain via \n>>> libcamera-devel wrote:\n>>>> Add an entry for Arducam IMX519 sensor which has 1220x1220 pixel array\n>> It's the pixel size, not the pixel array.\n> ack\n>>\n>>>> and supports four test pattern modes.\n>>>>\n>>>> Signed-off-by: Umang Jain \n>>>> ---\n>>>>   src/libcamera/camera_sensor_properties.cpp | 10 ++++++++++\n>>>>   1 file changed, 10 insertions(+)\n>>>>\n>>>> diff --git a/src/libcamera/camera_sensor_properties.cpp \n>>>> b/src/libcamera/camera_sensor_properties.cpp\n>>>> index e5f27f06..04d80d6d 100644\n>>>> --- a/src/libcamera/camera_sensor_properties.cpp\n>>>> +++ b/src/libcamera/camera_sensor_properties.cpp\n>>>> @@ -102,6 +102,16 @@ const CameraSensorProperties \n>>>> *CameraSensorProperties::get(const std::string &sen\n>>>>               .unitCellSize = { 1550, 1550 },\n>>>>               .testPatternModes = {},\n>>>>           } },\n>>>> +        { \"imx519\", {\n>>>> +            .unitCellSize = { 1220, 1220 },\n>>>> +            .testPatternModes = {\n>>>> +                { controls::draft::TestPatternModeOff, 0 },\n>>>> +                { controls::draft::TestPatternModeColorBars, 1 },\n>>>> +                { controls::draft::TestPatternModeSolidColor, 2 },\n>>>> +                { \n>>>> controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n>>>> +                { controls::draft::TestPatternModePn9, 4 },\n>>>> +            },\n>>>> +        } },\n>>> I don't have documentation, so it looks reasonable to me :)\n>>>\n>>> Reviewed-by: Jacopo Mondi \n>> Umang, do you have access to that camera module ? If so, have you been\n>> able to compare the test patterns with the CCS specification ? If so,\n>> with the commit message update,\n>\n> So there are couple of things off with test patterns I obtained.\n>\n> - The CCS specification say [1] for Solid Color and [2] for 100% Color \n> Bars. IMX519 got these indexes swapped while reporting via v4l2-ctl \n> atleast\n> - There is no 'ColorBars' and 'ColorBarsFadeToGray' patterns in my \n> testing  which comply with CCS's patterns atleast.\n>\n> What I obttained is the following:\n>\n> [0]: (disabled)\n> [1]: Two color bars only Aqua and Yellow (Does this count as color bars?)\n> [2]: Solid Color (white)\n> [3]: Same as [1]\n> [4]: PN9 seems fine\n>\n> If you need visual samples let me know, I'll send it to you.\n\nLet me just provide it to here while I have sensor attached to my RPi.\n\n\nTest patterns reported by `v4l2-ctl   --list-ctrls`\n\n```\nImage Processing Controls\n\n                    test_pattern 0x009f0903 (menu)   : min=0 max=4 \ndefault=0 value=0\n                 0: Disabled\n                 1: Color Bars\n                 2: Solid Color\n                 3: Grey Color Bars\n                 4: PN9\n```\n\nSamples available at\nhttps://drive.google.com/drive/folders/1XVVNttu2utey66QfXwPcMJc1OY4LZDgf\n```\n\nI think we need report this finding on the driver patches as well ? [1]\n\n[1] https://lore.kernel.org/linux-media/20221116091855.00007ebd@arducam.com/\n\n>>\n>> Reviewed-by: Laurent Pinchart \n>>\n>>>>           { \"ov2740\", {\n>>>>               .unitCellSize = { 1400, 1400 },\n>>>>               .testPatternModes = {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66B23BDE6B\n\tfor ;\n\tThu, 1 Dec 2022 04:31:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4A2A63336;\n\tThu, 1 Dec 2022 05:31:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 272C161F22\n\tfor ;\n\tThu, 1 Dec 2022 05:31:29 +0100 (CET)","from [192.168.10.186] (unknown [210.186.188.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD88D33F;\n\tThu, 1 Dec 2022 05:31:27 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669869090;\n\tbh=3XwuOJpi0DRGvUDWZxPznhIDzW5kJrinSWvA4erbVtk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Zo0Fa+cpr81dpAFpw2aE5vKf8V6DocEzVrAmqFH4MEIXVvQh+EGkB+pnku+A8/Qma\n\ttB+0rEEMIiDP6H9dc5mgSplQRVbFJbHFdTvxUMXSRl87oFhXntq8ugXsZk1hxKeHrg\n\t/MaT9/HppvtdcM1C6Ckr9zZgAWrl//G+zfSZI/1BMByryJqdPZwmPvwiWjgBAe/xxz\n\tYLmmCTUDMQPQ3+dsChF4lYFFO2n6aLpvw8D9xD0th6eFjVnK2r6PFCuSNAqk4DAZQE\n\tchongBgYIDonAFie4e9KX/CKZMox3Hwvarq5K5+ti7KftApK1swSOSM0kq+7VFuOF5\n\tKYePDY9HGpUEg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669869088;\n\tbh=3XwuOJpi0DRGvUDWZxPznhIDzW5kJrinSWvA4erbVtk=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=SfWBHxzx3GgyinBNtkWltdMUxvRMmNZqvV2A8x4nMOIn53FKZqYZT00zOpfLMMSah\n\tWreGnnb3YclRm2UvhZ/fv5VWv1dDwr+iHtwdxI9RRpbNNKWMFwGW5nOPnqQ3G8zs+L\n\tM+Yt0PBw5uvTIc92TvLYdHrxX4mxuUuOUtUlUcYg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SfWBHxzx\"; dkim-atps=neutral","Message-ID":"","Date":"Thu, 1 Dec 2022 12:30:28 +0800","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.5.0","To":"Laurent Pinchart ,\n\tJacopo Mondi ","References":"<20221115151816.16078-1-umang.jain@ideasonboard.com>\n\t<20221123173220.7dwva4h52oua5sk2@uno.localdomain>\n\t\n\t<810dbbb1-bd16-9d57-c666-57a6578b3d64@ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<810dbbb1-bd16-9d57-c666-57a6578b3d64@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX519\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25949,"web_url":"https://patchwork.libcamera.org/comment/25949/","msgid":"","date":"2022-12-01T07:35:25","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX519\n\tsensor properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nOn Thu, Dec 01, 2022 at 01:45:35AM +0800, Umang Jain wrote:\n> On 11/24/22 1:58 AM, Laurent Pinchart wrote:\n> > On Wed, Nov 23, 2022 at 06:32:20PM +0100, Jacopo Mondi via libcamera-devel wrote:\n> >> On Tue, Nov 15, 2022 at 08:48:15PM +0530, Umang Jain via libcamera-devel wrote:\n> >>> Add an entry for Arducam IMX519 sensor which has 1220x1220 pixel array\n> >\n> > It's the pixel size, not the pixel array.\n>\n> ack\n>\n> >>> and supports four test pattern modes.\n> >>>\n> >>> Signed-off-by: Umang Jain \n> >>> ---\n> >>> src/libcamera/camera_sensor_properties.cpp | 10 ++++++++++\n> >>> 1 file changed, 10 insertions(+)\n> >>>\n> >>> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> >>> index e5f27f06..04d80d6d 100644\n> >>> --- a/src/libcamera/camera_sensor_properties.cpp\n> >>> +++ b/src/libcamera/camera_sensor_properties.cpp\n> >>> @@ -102,6 +102,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> >>> \t\t\t.unitCellSize = { 1550, 1550 },\n> >>> \t\t\t.testPatternModes = {},\n> >>> \t\t} },\n> >>> +\t\t{ \"imx519\", {\n> >>> +\t\t\t.unitCellSize = { 1220, 1220 },\n> >>> +\t\t\t.testPatternModes = {\n> >>> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> >>> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n> >>> +\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 2 },\n> >>> +\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n> >>> +\t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n> >>> +\t\t\t},\n> >>> +\t\t} },\n> >>\n> >> I don't have documentation, so it looks reasonable to me :)\n> >>\n> >> Reviewed-by: Jacopo Mondi \n> >\n> > Umang, do you have access to that camera module ? If so, have you been\n> > able to compare the test patterns with the CCS specification ? If so,\n> > with the commit message update,\n> \n> So there are couple of things off with test patterns I obtained.\n> \n> - The CCS specification say [1] for Solid Color and [2] for 100% Color \n> Bars. IMX519 got these indexes swapped while reporting via v4l2-ctl atleast\n\nThat's not an issue as such. The V4L2 test pattern control values are\ndriver-specific. The whole point of testPatternModes is to handle the\nmapping between the V4L2 test pattern values for a particular driver and\nthe libcamera test pattern control values.\n\n> - There is no 'ColorBars' and 'ColorBarsFadeToGray' patterns in my \n> testing  which comply with CCS's patterns atleast.\n\nThen we shouldn't report those two in testPatternModes.\n\n> What I obttained is the following:\n> \n> [0]: (disabled)\n> [1]: Two color bars only Aqua and Yellow (Does this count as color bars?)\n\nThat's a weird one. It may also be that the sensor is misconfigured by\nthe driver.\n\n> [2]: Solid Color (white)\n> [3]: Same as [1]\n> [4]: PN9 seems fine\n> \n> If you need visual samples let me know, I'll send it to you.\n> \n> > Reviewed-by: Laurent Pinchart \n> >\n> >>> \t\t{ \"ov2740\", {\n> >>> \t\t\t.unitCellSize = { 1400, 1400 },\n> >>> \t\t\t.testPatternModes = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F2AFBE08B\n\tfor ;\n\tThu, 1 Dec 2022 07:35:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78F5263336;\n\tThu, 1 Dec 2022 08:35:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AC8B61F22\n\tfor ;\n\tThu, 1 Dec 2022 08:35:43 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 511CB33F;\n\tThu, 1 Dec 2022 08:35:42 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669880144;\n\tbh=DfFqakFEQzdig00Wc9CqCj7DbTODZcLdAyI2jLminhg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=g7STYSYZKiaERTh9nxbx7ed1uQ77E0dkGJUpwzXo9qYTdZ3uKYgTm8OEgGR9F+c5f\n\tJpW8S9O9aIVE7HY8wiwZqygtvkrwW2W73PlhTPT7C4I1gKa8qIDwVID868zaboOI6s\n\tVCTSCh2SQ1d3lfsyHhybPtfG7PkFyqNR8SprttOq9yApYDX8tAgvIeCNQ7B9OMgbBS\n\tbZhs3Mo6S9seaKl6sVPA03ZSiibEnW8cClUSbWxuBMy7E2iX8RDFBFtNYISGmRrBDY\n\tFp5oVJmGJ3ejVCALdgqK7IrJg8Z3/q8W9uLB6zIA3muyGgUqeO3zB+RkoWnspXX4L0\n\tMgQKwMu25CYSQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669880142;\n\tbh=DfFqakFEQzdig00Wc9CqCj7DbTODZcLdAyI2jLminhg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sA0RquImkWsExj1sKh/5GARIXKZ6REoDY/kRcX3xP1yscqSz7aC5/68B5oyxPI51C\n\t7w9TaqrRL69BzX1fAIrfMKVp4pvX9ewgbHiQhcEOXlN6eXq1/py/wisgHqP2QEDREH\n\tdaIiC0LfznzS18HlyORhVxOt74QnkY3BohkXHf9M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"sA0RquIm\"; dkim-atps=neutral","Date":"Thu, 1 Dec 2022 09:35:25 +0200","To":"Umang Jain ","Message-ID":"","References":"<20221115151816.16078-1-umang.jain@ideasonboard.com>\n\t<20221123173220.7dwva4h52oua5sk2@uno.localdomain>\n\t\n\t<810dbbb1-bd16-9d57-c666-57a6578b3d64@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<810dbbb1-bd16-9d57-c666-57a6578b3d64@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX519\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]