[{"id":269,"web_url":"https://patchwork.libcamera.org/comment/269/","msgid":"<20190109153858.GA24252@bigcity.dyn.berto.se>","date":"2019-01-09T15:38:58","subject":"Re: [libcamera-devel] [PATCH] libcamera: Update libcamera.h","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-08 16:30:20 +0200, Laurent Pinchart wrote:\n> libcamera.h hasn't been updated with the recently added public headers\n> event_notifier.h, signal.h and timer.h. Add them.\n> \n> The event_dispatcher_poll.h header, which used to be public, is now\n> private, but hasn't been removed from libcamera.h. Remove it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/libcamera.h | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/libcamera.h b/include/libcamera/libcamera.h\n> index 2dcaeda49812..c0511cf6d662 100644\n> --- a/include/libcamera/libcamera.h\n> +++ b/include/libcamera/libcamera.h\n> @@ -10,6 +10,8 @@\n> #include \n> #include \n> #include \n> -#include \n> +#include \n> +#include \n> +#include \n> \n> #endif /* __LIBCAMERA_LIBCAMERA_H__ */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5300860B2D\n\tfor ;\n\tWed, 9 Jan 2019 16:39:00 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id v1-v6so6889364ljd.0\n\tfor ;\n\tWed, 09 Jan 2019 07:39:00 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tx204sm13650054lfa.5.2019.01.09.07.38.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 09 Jan 2019 07:38:58 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=xUEjhQctKQMRwBvm1mKRX5/qHGobdFuut8oR2a5jNbM=;\n\tb=0ADLARZrnCrkeA/YQeYm2j4rzrnsvPh1M57yARCPOIOiMV1mKewHpzfLa2wnO6r+AA\n\tV2ZmzHwE7YFzhnak0Dvy9TDXs4hP7QdJt2ggR7qzjXTLwccLOqDMAKjfILEjAhnuW7xs\n\tPlm/BmVcWAKlL3gGCHPRUMg8byGXP6crP9Khj6P8nauI7En+EzhAYI62A3UJuzBCHOxB\n\tNET9gCllf5HL8I/6vAO/b3U0WZ+U8/iqmvyPyvBcDsILAoWn3118afjElZ/4hLgGujpb\n\t8zrademlDcHwlTqssG9JxUiCZ55hTE+jgGAIilVAk5wXreyRrtw3Ii0KZwCGk2jgaODu\n\t9aDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=xUEjhQctKQMRwBvm1mKRX5/qHGobdFuut8oR2a5jNbM=;\n\tb=qeWXD/FXyaJJ8t/vGP60mcKFXslpoB0jkEzR8+BdseT9xvksX0vev1SQEhoKpDdFWU\n\tuQI4AIS8/kEtC7jVUofgUN/W0TSOxMUvL1gh+c82/SxmCysRxBPZQMTulOv8RMLN4NP4\n\tcf7KqJb/2hKgU0V+mmBR8TQLdVUXqvkRgPB7hk0oWEn2YgKg7+O+5HnFHQp1IzDEFJKN\n\tyx2JL8a48wXek2eBwztZrhvlUuPCPbZIYhaFTPNKhc8w+VUigkCUu8IjgZaEEAJIXjzW\n\tRzik9pEMJUwx3eTA/Cx9TF27ZtNiSGUHb3rO9nxjB/w2thfUrJy+i0pEAT20ZvH1wmUV\n\tKvCw==","X-Gm-Message-State":"AJcUukedUCGNtvU6NXe5IkrJ3a7F+FEhqYn2iGSRhupyNqeCVBsOUFKW\n\t+C4xwBflw/31EAxIGsj0bLo6hw==","X-Google-Smtp-Source":"ALg8bN46CorwvpjPLkdaksBDoxBOgCZKY7lJGFSshiaFjKhY2/29GopsLJTWtj1mEVtgVnXejBX2mQ==","X-Received":"by 2002:a2e:7f04:: with SMTP id\n\ta4-v6mr4124666ljd.156.1547048339217; \n\tWed, 09 Jan 2019 07:38:59 -0800 (PST)","Date":"Wed, 9 Jan 2019 16:38:58 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190109153858.GA24252@bigcity.dyn.berto.se>","References":"<20190108143020.9820-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190108143020.9820-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Update libcamera.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 09 Jan 2019 15:39:00 -0000"}}]