[{"id":25801,"web_url":"https://patchwork.libcamera.org/comment/25801/","msgid":"","date":"2022-11-15T13:46:28","subject":"Re: [libcamera-devel] [PATCH v6 2/8] pipeline: raspberrypi: Switch\n\tto RPi::DelayedControls","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch.\n\nOn Tue, 15 Nov 2022 at 09:08, Naushir Patuck via libcamera-devel\n wrote:\n>\n> Switch the Raspberry Pi pipeline handler to use the DelayedControls\n> implementation in the RPi:: namespace. This will allow us to use Raspberry Pi\n> specific API changes in future commits.\n>\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 343f8cb2c7ed..f3be4ee3b730 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -33,7 +33,6 @@\n> #include \"libcamera/internal/bayer_format.h\"\n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> -#include \"libcamera/internal/delayed_controls.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/framebuffer.h\"\n> #include \"libcamera/internal/ipa_manager.h\"\n> @@ -41,6 +40,7 @@\n> #include \"libcamera/internal/pipeline_handler.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n>\n> +#include \"delayed_controls.h\"\n> #include \"dma_heaps.h\"\n> #include \"rpi_stream.h\"\n>\n> @@ -243,7 +243,7 @@ public:\n> RPi::DmaHeap dmaHeap_;\n> SharedFD lsTable_;\n>\n> - std::unique_ptr delayedCtrls_;\n> + std::unique_ptr delayedCtrls_;\n> bool sensorMetadata_;\n>\n> /*\n> @@ -1294,13 +1294,13 @@ int PipelineHandlerRPi::registerCamera(MediaDevice *unicam, MediaDevice *isp, Me\n> * Setup our delayed control writer with the sensor default\n> * gain and exposure delays. Mark VBLANK for priority write.\n> */\n> - std::unordered_map params = {\n> + std::unordered_map params = {\n> { V4L2_CID_ANALOGUE_GAIN, { result.sensorConfig.gainDelay, false } },\n> { V4L2_CID_EXPOSURE, { result.sensorConfig.exposureDelay, false } },\n> { V4L2_CID_HBLANK, { result.sensorConfig.hblankDelay, false } },\n> { V4L2_CID_VBLANK, { result.sensorConfig.vblankDelay, true } }\n> };\n> - data->delayedCtrls_ = std::make_unique(data->sensor_->device(), params);\n> + data->delayedCtrls_ = std::make_unique(data->sensor_->device(), params);\n> data->sensorMetadata_ = result.sensorConfig.sensorMetadata;\n>\n> /* Register initial controls that the Raspberry Pi IPA can handle. */\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE1C0BE08B\n\tfor ;\n\tTue, 15 Nov 2022 13:46:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4056063088;\n\tTue, 15 Nov 2022 14:46:41 +0100 (CET)","from mail-pl1-x633.google.com (mail-pl1-x633.google.com\n\t[IPv6:2607:f8b0:4864:20::633])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71ADB63079\n\tfor ;\n\tTue, 15 Nov 2022 14:46:40 +0100 (CET)","by mail-pl1-x633.google.com with SMTP id 4so13242483pli.0\n\tfor ;\n\tTue, 15 Nov 2022 05:46:40 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668520001;\n\tbh=GTgn7PoOCzCVNAgQUuQzoL7WLG0CdPaxZ5ABM1fxTuE=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ojsrZwUiMHF6m9M0gXi75gMrmcUuGDR72QOk9CIUV1bNa3XkEVvHm6exWm+CljKqL\n\tPVPVmOjCq97K6H+bULNk0Qeb1OgzgiaNQSF1MaUxgMdd1K8B3hSaBlAyh2t56h57YB\n\tDVmFGfAyIGoj5SF8efPRjbg29aWQpRsPwaKh6AaTjv24b4/MgkeJjAWiPMjixBzwOM\n\tLw6Uq5hQ9vHOmqWyuWs1PDBKoqXNYVO4Zgf2XX+ZwX/e4JrD92gIoaAQaH3ULn3zBG\n\t92zEl/NBbeupdZAcN1Qm4+g5AIw+WvXtT4pGxeE3FYMf1dpmF0bBjf5X7p2LjGFyUJ\n\tYrlCiCRKwVubQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=EReGEsRabSRyOE8DwqQJspkN1jdWsEKv30XccNrHp2w=;\n\tb=bS0gjHDpyuOVuTv88ppAgnhUvwuwLmJY5iDaKnQVtZGSRMMK51j2j7KS5Wc4O6570s\n\tnbRG5alQfI+2Z1UWPHt0kxx/sr1vUtekkMVbiuBupiKGDH6h/29JrCrTvSOLdnyp+ysv\n\trz1H/zR6C+WzqNG3TtmDt49Odcx7JjzYOZl+2JUOSj9y/R8z8EjciQiDBa+ukwvDpVDG\n\t7dPPfNNvCVhttziiV6Neo2lm5iKWjWM0ElLvlGooUEQPyHuNhN8oUS2pT9Ysw+qJe0JN\n\tVhOLlJ/a/mp2/YPos+T1McEvEgKXEjtG9I6/fITLaRPSBpsBcoJY9wGtHvsEesAViYOf\n\tpZfg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"bS0gjHDp\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=EReGEsRabSRyOE8DwqQJspkN1jdWsEKv30XccNrHp2w=;\n\tb=rwVTgKP4j/3j95Shw9ytsT4++mwbV4PRYQYeXpr4dVpYPqhFt2eRJuJEbiuThBCKe+\n\tqqV7A1Qi931MeWlL23vRA0q9lKiW40bUeqbodJ3yIAVHTITyfn63esfxF/wF8HsCGR+h\n\tKAjxd2wGIUzqzfYK4u6kLIi+JulBd7bn3PDCXe6tWELV8RkV6ojyH70ZFD27svv34tmn\n\tMF7X9Gfrai+u/Pk7A0ZhKbDeAwMXl40Y2ZzE1vaTTazA5QYlCqcpJ1lpSwv4Bq3yzuCI\n\taCuYcyWToo9ra2SRlXBBXNtVczfappWnxhQgb3UC8ZxQz1qp0Kz4wtZQ8eQja+Ls5eA8\n\tcw0Q==","X-Gm-Message-State":"ANoB5pnzixhzUlv8O0LeNMgDHyONbPRqaYSBRLFZ6T8m3///xYauPCex\n\t4NTndyOO70a0Syyh5eFTh4W+6W0ncYOvi0eABhcl0GYnvK0=","X-Google-Smtp-Source":"AA0mqf4uMqTxoDv15mWuR7vz8z7hRq1XIonML6QgJBqdFXXmlwWLI/k8v2LOMNumQLANeSrpO3MqmGPKrx1POgpG42I=","X-Received":"by 2002:a17:90a:aa16:b0:205:fa0b:798c with SMTP id\n\tk22-20020a17090aaa1600b00205fa0b798cmr577094pjq.179.1668519999034;\n\tTue, 15 Nov 2022 05:46:39 -0800 (PST)","MIME-Version":"1.0","References":"<20221115090755.2921-1-naush@raspberrypi.com>\n\t<20221115090755.2921-3-naush@raspberrypi.com>","In-Reply-To":"<20221115090755.2921-3-naush@raspberrypi.com>","Date":"Tue, 15 Nov 2022 13:46:28 +0000","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v6 2/8] pipeline: raspberrypi: Switch\n\tto RPi::DelayedControls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]