{"id":17794,"url":"https://patchwork.libcamera.org/api/patches/17794/?format=json","web_url":"https://patchwork.libcamera.org/patch/17794/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221115090755.2921-3-naush@raspberrypi.com>","date":"2022-11-15T09:07:49","name":"[libcamera-devel,v6,2/8] pipeline: raspberrypi: Switch to RPi::DelayedControls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4c9f4922199fea757b14bad49747534ae2c42937","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17794/mbox/","series":[{"id":3609,"url":"https://patchwork.libcamera.org/api/series/3609/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3609","date":"2022-11-15T09:07:47","name":"Raspberry Pi AGC digital gain fixes","version":6,"mbox":"https://patchwork.libcamera.org/series/3609/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17794/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17794/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1E3EBE08B\n\tfor ;\n\tTue, 15 Nov 2022 09:08:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD43663095;\n\tTue, 15 Nov 2022 10:08:04 +0100 (CET)","from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1844063079\n\tfor ;\n\tTue, 15 Nov 2022 10:08:02 +0100 (CET)","by mail-wr1-x42c.google.com with SMTP id j15so23120680wrq.3\n\tfor ;\n\tTue, 15 Nov 2022 01:08:02 -0800 (PST)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tp25-20020a05600c1d9900b003c64c186206sm15143696wms.16.2022.11.15.01.08.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 15 Nov 2022 01:08:01 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668503284;\n\tbh=aMyrgkzUOkwUYQTup5cASIlz0rdgebhBWZ2ofkFbw4g=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=SYoz3pKuX9mg0TVvuO/ZP7RnYyYJYVBivJZjeSvcQ+8tXBPT96LJXBUwzLR52Lef5\n\txuKxRJ6Ab50LFq8wnRutSN6OLbFwtvnFZ8+tcn79H1OrB3iX5F0X7JW+153+HrX4Ak\n\tRIpv6HYr+ca/zCNKFOhHjG/iNuSGB7fBkw8+J8aeIPG9ZlaQOtTHtI7arCpxQ0xmO4\n\tOSMvYN00dagUA43SFIhAZl46LAkG9AXzCVK0o/12ua4cb1AK+gHlx7oto13bvpHj8k\n\tbveG6VL+WOIyy/BbPDlr4UWqyETpjTLkNnAyHQpPdiNuBQPmAUaYhTRYNrhpfrZsz5\n\t1pg+XKz4j7ubw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=9/S6c5LA/uGjh5irR7dj+to8pxwOG/wP47q4LrRMbC8=;\n\tb=qBnZbjlYrrd6D4FBjccvVqbbFzyFbQ+93kw6V4qQTeD07KsXSFqDTot5RxsTDesoL0\n\tsfDd8MD/I64C9xSiQkUDzX0Ht6VI7qZ6XNuUEucSUIGs8BBXca1cgfizhLQKebYioFtC\n\tYKIzaryIZQvcrKQw1CUMU+c5eYWUKgyVNo03UA7HcXThc5WMdlmq/K2IH3vtoJ/D2RLT\n\tTy6KmnjxH1xF+u5rBHjkdsCOVAncLlimsLhcqDENdyRSAsG1zA38xeyHdGRZ6F6C9g+i\n\tFl4QhYJ3KfatL0bWO3lb77ITCCgoEJ3YHKmqOLCFAVRO4Xd+Tdm8/usqT943rJu41rDY\n\tJLMg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"qBnZbjlY\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=9/S6c5LA/uGjh5irR7dj+to8pxwOG/wP47q4LrRMbC8=;\n\tb=1Vt+wAJe2B3ds9aj6fy8vhQgMzLC0PCpKsogkAGK+/fS9+dvxN21ZRl18og5Y/X3ex\n\tEmdI35rSrQxHnkSpZWp8QpfgARLU8oBRqHR5INkyBJ7CG/E5Z+rwKizgAn8VJxMt9C5A\n\tRThyFqcw0qqDED1f6UhY5Gs+cMgRmA/Prbs5LC/YeX6wkCNWp1uTQAfZ8JL3qneHlfvL\n\t6TS04ZZCDxVWWkZbZovLfz18umscn5vUfWL2wnjVBEOJr0uwsr6jjKX5DEsq3U85ixLp\n\tKTlL9IBWqNOvQtnVnG0/KriR63lZHPsBdngGMEomXpOxBlxgf/33cXL4z9L8huCxIEIC\n\tZE2w==","X-Gm-Message-State":"ANoB5pm/CJ2TyDzEcv3P3DL0Zjx1s2A8URufHu4onA02Fqeg5U8tmcgq\n\tP2vEu9toKTie8NfJ81HypelNuYgoJ/7d2Q==","X-Google-Smtp-Source":"AA0mqf7HTr44cTeoudvCbfO6JwyrGnuLwjDy4nZcKPQkCZab6SrpM5IQlvIXMZB8LmM7GYbstLlKgg==","X-Received":"by 2002:a05:6000:12d0:b0:22e:2c8b:993d with SMTP id\n\tl16-20020a05600012d000b0022e2c8b993dmr9590821wrx.523.1668503281582; \n\tTue, 15 Nov 2022 01:08:01 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 15 Nov 2022 09:07:49 +0000","Message-Id":"<20221115090755.2921-3-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20221115090755.2921-1-naush@raspberrypi.com>","References":"<20221115090755.2921-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 2/8] pipeline: raspberrypi: Switch to\n\tRPi::DelayedControls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Switch the Raspberry Pi pipeline handler to use the DelayedControls\nimplementation in the RPi:: namespace. This will allow us to use Raspberry Pi\nspecific API changes in future commits.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 343f8cb2c7ed..f3be4ee3b730 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -33,7 +33,6 @@\n #include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/camera_sensor.h\"\n-#include \"libcamera/internal/delayed_controls.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n@@ -41,6 +40,7 @@\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n+#include \"delayed_controls.h\"\n #include \"dma_heaps.h\"\n #include \"rpi_stream.h\"\n \n@@ -243,7 +243,7 @@ public:\n \tRPi::DmaHeap dmaHeap_;\n \tSharedFD lsTable_;\n \n-\tstd::unique_ptr delayedCtrls_;\n+\tstd::unique_ptr delayedCtrls_;\n \tbool sensorMetadata_;\n \n \t/*\n@@ -1294,13 +1294,13 @@ int PipelineHandlerRPi::registerCamera(MediaDevice *unicam, MediaDevice *isp, Me\n \t * Setup our delayed control writer with the sensor default\n \t * gain and exposure delays. Mark VBLANK for priority write.\n \t */\n-\tstd::unordered_map params = {\n+\tstd::unordered_map params = {\n \t\t{ V4L2_CID_ANALOGUE_GAIN, { result.sensorConfig.gainDelay, false } },\n \t\t{ V4L2_CID_EXPOSURE, { result.sensorConfig.exposureDelay, false } },\n \t\t{ V4L2_CID_HBLANK, { result.sensorConfig.hblankDelay, false } },\n \t\t{ V4L2_CID_VBLANK, { result.sensorConfig.vblankDelay, true } }\n \t};\n-\tdata->delayedCtrls_ = std::make_unique(data->sensor_->device(), params);\n+\tdata->delayedCtrls_ = std::make_unique(data->sensor_->device(), params);\n \tdata->sensorMetadata_ = result.sensorConfig.sensorMetadata;\n \n \t/* Register initial controls that the Raspberry Pi IPA can handle. */\n","prefixes":["libcamera-devel","v6","2/8"]}