[{"id":2427,"web_url":"https://patchwork.libcamera.org/comment/2427/","msgid":"<20190817140558.GE16603@wyvern>","date":"2019-08-17T14:05:58","subject":"Re: [libcamera-devel] [PATCH 01/18] libcamera: object: Make\n\tmessage() method protected","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-08-12 15:46:25 +0300, Laurent Pinchart wrote:\n> The message() method shouldn't be called externally (except by a few\n> friend classes), make it protected.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/object.h | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/object.h b/include/libcamera/object.h\n> index 5c251a822d9a..3d08d69a9044 100644\n> --- a/include/libcamera/object.h\n> +++ b/include/libcamera/object.h\n> @@ -26,11 +26,13 @@ public:\n> \tvirtual ~Object();\n> \n> \tvoid postMessage(std::unique_ptr msg);\n> -\tvirtual void message(Message *msg);\n> \n> \tThread *thread() const { return thread_; }\n> \tvoid moveToThread(Thread *thread);\n> \n> +protected:\n> +\tvirtual void message(Message *msg);\n> +\n> private:\n> \ttemplate\n> \tfriend class Signal;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-ed1-x541.google.com (mail-ed1-x541.google.com\n\t[IPv6:2a00:1450:4864:20::541])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 719D4600F9\n\tfor ;\n\tSat, 17 Aug 2019 16:06:01 +0200 (CEST)","by mail-ed1-x541.google.com with SMTP id x19so7438546eda.12\n\tfor ;\n\tSat, 17 Aug 2019 07:06:01 -0700 (PDT)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tm26sm1660762edd.19.2019.08.17.07.05.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 17 Aug 2019 07:05:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=yuhJwm59Nax7b064lNFwTpmPP3WrtK6NsWh5rrMlYRc=;\n\tb=c7qJI8jHX5VB51iG5KV3R5doApwgQ6Ee1SMuK2mu2366rHb/Ro38EABdZRYKFmDHv1\n\tB6SB2fBuj3J4YvxKIIjOFyYKxgDDLmU+BvMWtsYTfuXSCwxYNQQXuK3PymJiLE3QclQD\n\t7tSgyc8iZjAf01vq5O7SDYOtayiu9aZkczHmzeRrCaSBauhqkryKPmyaGFIhWsKh7uVL\n\tV7uHx2xq7o67rHU3mbmGlWtfeYub1hPUTQtLHCUZJUJn6BA+OTjOE4sYFlkWpAdSiX3k\n\ts+rqvOxISCNOoA1jwOev/qXoC/4IcnHFDk3zgu0vaLJGeJ18ALCBKtaaM8RBO5YvYOls\n\tnVrQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=yuhJwm59Nax7b064lNFwTpmPP3WrtK6NsWh5rrMlYRc=;\n\tb=EYcyX0nN9PzPcKByxKTJcQ1Aw8eCDP9aTgKuWmmtCB09t3h+93mirS5KE4SQk95U0l\n\t3VNDocrlDncPgALZZ1O6pziOVBxKOrUxYTsbo/5sQXtiHl2h+1rC8idqif6U71HHlGkU\n\tiI8oNknuMM6kgRAw67X8RTyXq1xJcpkfRAS7gObUnpOPRNVF8MiYrTb6hxsPy9c1ULjO\n\tGYUcB9YdiQMJ2bL7JRWwf6zYsCFytOMa+aMS6PPxTmhX+2Rpl7RdQXVKeIupUrgHO6q7\n\tBtfdXWHwIRdB5NizQVRPtSyuKAjK571rH4qG3ue9xEuxVRcdHJknd21yjyFNne6/UHhu\n\t5NCA==","X-Gm-Message-State":"APjAAAVfcAjNJF4jff5lcG292caYOK3ZRH8Jcj/wlCT8RXl3MLbnLF2i\n\tbrNR+rC4ptPcpFWLfIX75aIRz17J4SM=","X-Google-Smtp-Source":"APXvYqxta0gxQXtzERATtgWZe7pyI3hcyerfobOFvIQaLAaYeT2RGfMcR3iuAq8guN7UnLfbNjGtag==","X-Received":"by 2002:a17:906:a452:: with SMTP id\n\tcb18mr7294893ejb.280.1566050760540; \n\tSat, 17 Aug 2019 07:06:00 -0700 (PDT)","Date":"Sat, 17 Aug 2019 16:05:58 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190817140558.GE16603@wyvern>","References":"<20190812124642.24287-1-laurent.pinchart@ideasonboard.com>\n\t<20190812124642.24287-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190812124642.24287-2-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 01/18] libcamera: object: Make\n\tmessage() method protected","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 17 Aug 2019 14:06:01 -0000"}}]