{"id":17788,"url":"https://patchwork.libcamera.org/api/patches/17788/?format=json","web_url":"https://patchwork.libcamera.org/patch/17788/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221111133025.3102-3-david.plowman@raspberrypi.com>","date":"2022-11-11T13:30:25","name":"[libcamera-devel,2/2] libcamera: pipeline: raspberrypi: Free buffers when a camera is released","commit_ref":"d2636d59644fd6c597ac1705836e8a8406f22d90","pull_url":null,"state":"accepted","archived":false,"hash":"b14689b9054ee075e8eba1a00df7e72e31c6a900","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17788/mbox/","series":[{"id":3606,"url":"https://patchwork.libcamera.org/api/series/3606/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3606","date":"2022-11-11T13:30:23","name":"Notify pipeline handlers when a camera is released","version":1,"mbox":"https://patchwork.libcamera.org/series/3606/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17788/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17788/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59BCBC3285\n\tfor ;\n\tFri, 11 Nov 2022 13:30:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D190963087;\n\tFri, 11 Nov 2022 14:30:32 +0100 (CET)","from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FA216307E\n\tfor ;\n\tFri, 11 Nov 2022 14:30:31 +0100 (CET)","by mail-wm1-x331.google.com with SMTP id\n\tr203-20020a1c44d4000000b003cfa97c05cdso3868250wma.4\n\tfor ;\n\tFri, 11 Nov 2022 05:30:31 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tbk11-20020a0560001d8b00b002416f0f1e96sm1511487wrb.43.2022.11.11.05.30.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 11 Nov 2022 05:30:29 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668173432;\n\tbh=ezy0mYD0YxRPxt1lRUUw8BL2nEP7GeoH4VvjV61NBdE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=l9PM3Dhp8IMju35vrYXBTwYAjZewMHYqSR0MspCPdTeyNHNzRFUhHtZZn01qM906O\n\tooWj61uebOZpfcn9mkw0tI/d/bbMKaUHVHqYzFnqeSAiPAJWX9tT4T2cr1Li0NXIxd\n\tfsAaWNK+k2CSpbCR6BaA0BNJRRo9hfrdChnFqnsw5RpdLjTkMSvoNZ0b3aMOhLEV4z\n\tjzM3IQz+SVoJzlwJ0YWPISYo/RTXIShCsXkcVkS5SqcN5v3KhGDzvqB5fNYdshaCTR\n\t+iQgqg9ovIvLxq0SPlpZ7T6f379i3U1/vwFyxP6eVLXdHZSoqmQkYEmg34dF4dpNG0\n\tHQwp4OdGxsi8Q==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=IhibtisHB+sjCPzG5P0lOz5qlZRGGKdQlitZDDgL3Zo=;\n\tb=sOPY69TpQIM7/ZSGESGo9Jybfd5IpauOrEOlgQsHAaUzm5/v3SuTxanwuBBr/T77/V\n\tEOuSJls+kUNSzMiBdFsE2iF5qaHo1kkWFtt8Z4wkGFoA4gTByUG9Z+EneI3z2GV6+qgP\n\tnHgaKd0m5fHTCdN8Wzh28sPQmVVUaL2bS+ZtxZrRG2DVQgYrDmSN3bB93K2ws1ULKXit\n\tqzbOskFQD658pUysiU3Fv7bJHadb0TsQ18Y4xv++fL1N5j9iFLLnr4iIp8znD+Q40T8+\n\tE9qndmjzFyRT82gDdq6R2z5w+UxWYNZNNB7EYtAO30oI+Wg8TM3dHrlZvxm8d+O2blhW\n\tkOLg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"sOPY69Tp\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=IhibtisHB+sjCPzG5P0lOz5qlZRGGKdQlitZDDgL3Zo=;\n\tb=l3vgn7oh76bI9SQFQeWfPA15PypDFY/gVn75MZjusRNEOuv987asrnz1v3oFYoEk0F\n\tJBiscNbIaF4nqFDJE80gIbaagK5Nlqs6/o4aEKXHKjkC3vkiamYTFLC8R0nOIK4Z3hCq\n\t6bn8szR9tabd4hw/nT9ucV1fR2CxwbwMOFtGnR5AFjWZlJkzMy6eJmnJI1L7yfs40yd0\n\t5Xs3JPK9R2IzqJsu6rztYh2hNRSB+FOTL/jnhBVO9PyiKeuWT02TgWIyHYCq5JOrvTUz\n\t2fHNT7D3545+LS3uHUfuM54ZufHaI/imew4dxZMKs5sXblfBByR7OFIhz8HTbiqUJFHs\n\tTNtg==","X-Gm-Message-State":"ANoB5plYFJwlloHmH+vstab/R2Bg1EzjfDK4BjN98/n60Y/76RDzPucX\n\tjYljRB+Lx5fvt6haCt9mNKTCPA456j3x1A==","X-Google-Smtp-Source":"AA0mqf5GjGNTb6OFBubTsANLZT2/FNs/oIf4BCYx0ONN/cH7O/rV2VFONPBG2WW/GtNyfyLcCl5i3A==","X-Received":"by 2002:a05:600c:3b03:b0:3cf:b49e:1638 with SMTP id\n\tm3-20020a05600c3b0300b003cfb49e1638mr1262382wms.50.1668173430639; \n\tFri, 11 Nov 2022 05:30:30 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 11 Nov 2022 13:30:25 +0000","Message-Id":"<20221111133025.3102-3-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20221111133025.3102-1-david.plowman@raspberrypi.com>","References":"<20221111133025.3102-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] libcamera: pipeline: raspberrypi:\n\tFree buffers when a camera is released","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Implement the PipelineHandlerRPi::releaseDevice method which allows\nus to free any allocated buffers when a camera is released.\n\nSigned-off-by: David Plowman \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex f15fa28b..785eddf9 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -337,6 +337,8 @@ public:\n \n \tbool match(DeviceEnumerator *enumerator) override;\n \n+\tvoid releaseDevice(Camera *camera) override;\n+\n private:\n \tRPiCameraData *cameraData(Camera *camera)\n \t{\n@@ -1193,6 +1195,12 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \treturn !!numCameras;\n }\n \n+void PipelineHandlerRPi::releaseDevice(Camera *camera)\n+{\n+\tRPiCameraData *data = cameraData(camera);\n+\tdata->freeBuffers();\n+}\n+\n int PipelineHandlerRPi::registerCamera(MediaDevice *unicam, MediaDevice *isp, MediaEntity *sensorEntity)\n {\n \tstd::unique_ptr data = std::make_unique(this);\n","prefixes":["libcamera-devel","2/2"]}