{"id":17754,"url":"https://patchwork.libcamera.org/api/patches/17754/?format=json","web_url":"https://patchwork.libcamera.org/patch/17754/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221103132041.64644-3-umang.jain@ideasonboard.com>","date":"2022-11-03T13:20:38","name":"[libcamera-devel,v3,2/5] libcamera: base: thread: Apply clang thread safety annotation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"aba32da1b96dd80ee14cc9a438c0abba4c42ac13","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/17754/mbox/","series":[{"id":3596,"url":"https://patchwork.libcamera.org/api/series/3596/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3596","date":"2022-11-03T13:20:36","name":"Apply clang thread safety annotation libcamera-core and v4l2","version":3,"mbox":"https://patchwork.libcamera.org/series/3596/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17754/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17754/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 531CBBDB16\n\tfor ;\n\tThu, 3 Nov 2022 13:20:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE1EC6307F;\n\tThu, 3 Nov 2022 14:20:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 531AA63079\n\tfor ;\n\tThu, 3 Nov 2022 14:20:55 +0100 (CET)","from umang.jainideasonboard.com (unknown [103.251.226.107])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EAFBB4B2;\n\tThu, 3 Nov 2022 14:20:52 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1667481656;\n\tbh=Nau0p4nP5MV8MRZIcHSlvqOY1c6oJkKKFVEptY/PLBQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=fNBMxJmiWmDrfqqGiK5rXMJM7JzIeF7NOI+5SnnbMHYU+OycJDQKxkUBz0F2e6jij\n\tjWctBEcXFPDeFfyXVmV97OhW6witRJV62wT1Lin1F4ugE3hL3/MU8uu4ouViehDfVR\n\tXf6Wj3gMGSgIaN+JjxezVNIummOhTNJ5YXWS83ejc6nuM6ziwJq10c9hDLdvTdADeQ\n\tPADfFbwlx4srVoPU0Jpr7Al+4t1ZkjABK7AO+KckUfM6ZCYbiaixeKUII2eMSLjwnX\n\tj3wz51S+XFbuDKzK1gGh8WLnGwLGQUfUkFdLs0gPH/Z+yTCFnL0eQUi/33F/1r/5V0\n\tdPFmB+deCj/yg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1667481654;\n\tbh=Nau0p4nP5MV8MRZIcHSlvqOY1c6oJkKKFVEptY/PLBQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hmwLGu1SzaMCxMuGYof6gEAHBrIBLDlGiaE97/jFO/T32Kq87eqeMKSkfQZ+WlcxQ\n\tJxbIN/weELTU9aQVICxtPtAfSi7P+iw7aNB0+hQfmxmxG5HjGgepA4IPpm9PvkSZmQ\n\tlJpytTYIyhefTNnw/oh4IKu0iqrjCShZdcpnRUyw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hmwLGu1S\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 3 Nov 2022 18:50:38 +0530","Message-Id":"<20221103132041.64644-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.37.3","In-Reply-To":"<20221103132041.64644-1-umang.jain@ideasonboard.com>","References":"<20221103132041.64644-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 2/5] libcamera: base: thread: Apply\n\tclang thread safety annotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Hirokazu Honda \n\nThis annotates member variables of ThreadData by clang thread\nsafety annotations.\n\nSigned-off-by: Hirokazu Honda \nSigned-off-by: Umang Jain \nReviewed-by: Laurent Pinchart \nReviewed-by: Umang Jain \n---\n src/libcamera/base/thread.cpp | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\nindex 6bda9d14..b96951ac 100644\n--- a/src/libcamera/base/thread.cpp\n+++ b/src/libcamera/base/thread.cpp\n@@ -151,7 +151,7 @@ private:\n \tfriend class ThreadMain;\n \n \tThread *thread_;\n-\tbool running_;\n+\tbool running_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n \tpid_t tid_;\n \n \tMutex mutex_;\n@@ -422,11 +422,15 @@ bool Thread::wait(utils::duration duration)\n \t{\n \t\tMutexLocker locker(data_->mutex_);\n \n+\t\tauto isRunning = ([&]() LIBCAMERA_TSA_REQUIRES(data_->mutex_) {\n+\t\t\treturn !data_->running_;\n+\t\t});\n+\n \t\tif (duration == utils::duration::max())\n-\t\t\tdata_->cv_.wait(locker, [&]() { return !data_->running_; });\n+\t\t\tdata_->cv_.wait(locker, isRunning);\n \t\telse\n \t\t\thasFinished = data_->cv_.wait_for(locker, duration,\n-\t\t\t\t\t\t\t [&]() { return !data_->running_; });\n+\t\t\t\t\t\t\t isRunning);\n \t}\n \n \tif (thread_.joinable())\n","prefixes":["libcamera-devel","v3","2/5"]}