{"id":17734,"url":"https://patchwork.libcamera.org/api/patches/17734/?format=json","web_url":"https://patchwork.libcamera.org/patch/17734/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221030230500.74842-6-nicholas@rothemail.net>","date":"2022-10-30T23:05:00","name":"[libcamera-devel,v6,5/5] ipa: libcamera: add support for ov8858 sensor","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3956f0ba305d7437f2f80ccb601b307e33480587","submitter":{"id":137,"url":"https://patchwork.libcamera.org/api/people/137/?format=json","name":"Nicholas Roth","email":"nicholas@rothemail.net"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17734/mbox/","series":[{"id":3589,"url":"https://patchwork.libcamera.org/api/series/3589/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3589","date":"2022-10-30T23:04:56","name":"[libcamera-devel,v6,1/5] ipa: workaround libcxx duration limitation","version":6,"mbox":"https://patchwork.libcamera.org/series/3589/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17734/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17734/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 092B0C3287\n\tfor ;\n\tSun, 30 Oct 2022 23:05:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1DD1D6303F;\n\tMon, 31 Oct 2022 00:05:25 +0100 (CET)","from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com\n\t[IPv6:2607:f8b0:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD84563030\n\tfor ;\n\tMon, 31 Oct 2022 00:05:20 +0100 (CET)","by mail-ot1-x32f.google.com with SMTP id\n\tw26-20020a056830061a00b0066c320f5b49so3617992oti.5\n\tfor ;\n\tSun, 30 Oct 2022 16:05:20 -0700 (PDT)","from nroth-pc.attlocal.net\n\t(104-5-61-214.lightspeed.austtx.sbcglobal.net. [104.5.61.214])\n\tby smtp.gmail.com with ESMTPSA id\n\tu4-20020a056871008400b0013c8ae74a14sm2269403oaa.42.2022.10.30.16.05.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 30 Oct 2022 16:05:18 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1667171125;\n\tbh=e+8IwqVi/c7EJiL3s4FzMtHpcKsgZKb9Ahldqi9AONs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=jzy4O4KV8t9Jn8gqWz08RUtvB4zdo2vztDsBQkeOLVleUB2OVe8wGrMuYWV5mHjvO\n\tdFpjx70KEf/ago1Hpe1t/3ybIGCJxUK8rY4FcPpg0ceNHKYumnS0vx6KGnmpkwKPHS\n\t6TbuAuVMUmrn9l/TyDfiImEL57ljDvA8W1DmtdV1JJ28K6F7mzxxH88drsW5oD8Q0i\n\tCYayuDtgFdXSo9ep2pnDv+H1/rH3JDQ51ZDOx3ptAFZE7LzmogYeD8CJYvD58vV17I\n\tmvnYS/g624E1/oXJPFJsmq/VUzBTU1a5qRverNjHDP8lmIQeuWhH3X6LMawDMKo6RR\n\t8Kw03b1uSh3tA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=mR05dEDGrNfuxWaMNIDSUORfQ6Kz6zmdMqsBUnLIkK8=;\n\tb=HGmmMx87k5VnFYJ9T3obOW3TS0cmJYaYukTzf2wQIHuuek28STrGW+LZ2LVbQ7vtRw\n\tes1jUhNK/JlEY1Xspix21RMeubGCVmA2fVkIOnh6KfTvKDU7dIiDsRT4AXzyXrnWtT7h\n\tZju9egrhcmam9qhvu0ir0+/5aIpXM87/rZnmnNVLL0sl717fNTW/WZU+7zqpyg22GCFg\n\t6a8UPHvfFS0ojMwW+bsnK0LVc2fAQAcuOjtkWMB/LABt/Vua2/ovfjPQ+9p4p7RULZMI\n\ta63tKuIS/t+lVHLVRHbG+NVbOXTxTGARoAT7jtF/LzPrhq2Oo/Ak1HWg0ysIi3y2V4Kt\n\t+efQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"HGmmMx87\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=mR05dEDGrNfuxWaMNIDSUORfQ6Kz6zmdMqsBUnLIkK8=;\n\tb=AEW+EDi8FeLW8x8c3jWZG1AbANpL+N4UU3ea4gWDsuadiQVJ9d75nSjJCL8xgr0jA5\n\talGzXFgzL2qBy7KGSi71BsZFN9/aXdZTIuONh6by57hfyMMdlfiqz/YCYnPugIDx81p2\n\t6OoQEl/KjXR9PiuSnes3te8zrObqSOwni0PlSRA3yuETypLoRMeOp8XSRyqn7GtHQmtv\n\tqGPa83JSvS0Ko1I5x2sulpe+uFKkThhL+nzW0NrNpeDyYb+NKgohcHPInMItdzPODgo+\n\ttB2PisGeSD2hB2KN15DrrP5Xe180ZI+J827FzV91wjfZuMbaOGuUpRaHklw9jhGNPLBI\n\tM4iQ==","X-Gm-Message-State":"ACrzQf33Jzw7/ak5zHBPOcPSp8QLvGzwevYoRczJVi+ZYoIBg3lkl0H1\n\tjr2HnViJVX5HVVWOQRrURGCgRjQ11y9iUg==","X-Google-Smtp-Source":"AMsMyM6I0wLpBZE02VBDquMXbswPGsK2lS14P1qwLFsshKgMfICs05WVraMHBNxmzQICIDz4b+gtJQ==","X-Received":"by 2002:a05:6830:4115:b0:661:a2c4:3bcd with SMTP id\n\tw21-20020a056830411500b00661a2c43bcdmr5325743ott.368.1667171119243; \n\tSun, 30 Oct 2022 16:05:19 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 30 Oct 2022 18:05:00 -0500","Message-Id":"<20221030230500.74842-6-nicholas@rothemail.net>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20221030230500.74842-1-nicholas@rothemail.net>","References":"<20221030230500.74842-1-nicholas@rothemail.net>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 5/5] ipa: libcamera: add support for\n\tov8858 sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicholas Roth via libcamera-devel ","Reply-To":"Nicholas Roth ","Cc":"Nicholas Roth ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Currently, libcamera does not have information for the ov8858 sensor\nused in the PinePhone Pro, a phone designed to run Linux.\n\nThis commit adds metadata, especially that sensor gain is reported and\nset in 1/16 discrete increments.\n\nFor more information, see \"5.8 manual exposure compensation/ manual\ngain compensation\" in [0] and the driver in [1].\n\n[0] http://www.ahdsensor.com/uploadfile/202008/55322e75316871.pdf\n[1] https://github.com/megous/linux/blob/orange-pi-5.19/drivers/media/i2c/ov8858.c\n\nSigned-off-by: Nicholas Roth \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++\n 2 files changed, 25 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 35056bec..f2040cbd 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -476,6 +476,17 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n \n+class CameraSensorHelperOv8858 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperOv8858()\n+\t{\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 1, 0, 0, 16 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"m00_f_ov8858\", CameraSensorHelperOv8858)\n+\n class CameraSensorHelperOv8865 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\nindex e5f27f06..d0757c15 100644\n--- a/src/libcamera/camera_sensor_properties.cpp\n+++ b/src/libcamera/camera_sensor_properties.cpp\n@@ -146,6 +146,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t */\n \t\t\t},\n \t\t} },\n+\t\t{ \"m00_f_ov8858\", {\n+\t\t\t.unitCellSize = { 1200, 1200 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t\t/*\n+\t\t\t\t * No best corresponding test pattern for:\n+\t\t\t\t * 1: \"Vertical Color Bar Type 1\",\n+\t\t\t\t * 2: \"Vertical Color Bar Type 2\",\n+\t\t\t\t * 3: \"Vertical Color Bar Type 3\",\n+\t\t\t\t * 4: \"Vertical Color Bar Type 4\"\n+\t\t\t\t */\n+\t\t\t},\n+\t\t} },\n \t\t{ \"ov8865\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n \t\t\t.testPatternModes = {\n","prefixes":["libcamera-devel","v6","5/5"]}