[{"id":25736,"web_url":"https://patchwork.libcamera.org/comment/25736/","msgid":"<166748593815.15935.10725002495573722030@Monstersaurus>","date":"2022-11-03T14:32:18","subject":"Re: [libcamera-devel] [PATCH v6 4/5] android: add makefiles to\n\tbuild inline with AOSP","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Nicholas,\n\nI've tried to make my way through this.\n\nThere's quite a bit of unknowns to me, so extra block comments on\nvarious sections that are doing work would possibly be helpful to\nexplain what/why they are doing things.\n\nBut overall, it's still something that I think we can get in - but we\nneed a bit more cleanup/understanding.\n\nIt feels like there's various things going on here due to not making use\nof meson correctly - (like installing to the right folders?) which if we\ncan just configure meson correctly would simplify a lot of this - *and*\nprevent it bitrotting in the future when new pipelines or configuration\nfiles are added for instance.\n\n\nSame with the hardcoded version - if we can just read that from\nmeson.build - it won't rot.\n\n\nQuoting Nicholas Roth via libcamera-devel (2022-10-30 23:04:59)\n> Currently, while libcamera advertises Android support, there is no easy\n> way to integrate libcamera into an Android distribution.\n> \n> This commit adds makefiles that allow libcamera to build inline with\n> AOSP, with one example of how to do so documented in [0].\n> \n> Note that meson_cross.mk is adapted from the Mesa project [1].\n> \n> As Android support matures, it will be useful to document how to\n> integrate libcamera for distribution owners [Bug].\n> \n> [0] https://docs.google.com/document/d/1Sly_VH3w6wFIdE72WXijQegoHZh8IxEnJ9m0hH7GodU/edit\n> [1] https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/android/mesa3d_cross.mk\n> Bug https://bugs.libcamera.org/show_bug.cgi?id=164\n> \n> Signed-off-by: Nichoals Roth <nicholas@rothemail.net>\n> ---\n>  android/Android.mk     |  86 ++++++++++++\n>  android/meson_cross.mk | 298 +++++++++++++++++++++++++++++++++++++++++\n>  2 files changed, 384 insertions(+)\n>  create mode 100644 android/Android.mk\n>  create mode 100644 android/meson_cross.mk\n> \n> diff --git a/android/Android.mk b/android/Android.mk\n> new file mode 100644\n> index 00000000..ff0d1472\n> --- /dev/null\n> +++ b/android/Android.mk\n> @@ -0,0 +1,86 @@\n> +# SPDX-License-Identifier: Apache-2.0\n> +#\n> +# Copyright (C) 2021, GlobalLogic Ukraine\n> +# Copyright (C) 2021, Roman Stratiienko (r.stratiienko@gmail.com)\n> +#\n> +# Android.mk - Android makefile\n> +#\n> +\n> +ifneq ($(filter true, $(BOARD_LIBCAMERA_USES_MESON_BUILD)),)\n> +\n> +LOCAL_PATH := $(call my-dir)\n> +LIBCAMERA_TOP := $(dir $(LOCAL_PATH))\n> +LIBCAMERA_MESON_VERSION := .0.0.1\n\nI'm intrigued, is there really supposed to be a '.' before the first 0\nthere?\n\nIt's a real pain having this hardcoded here - but it could get updated\nby the utils/release.sh script.\n\nCan we do anything like\n\nLIBCAMERA_MESON_VERSION=$(shell grep -E \"^ *version : (.*)\" meson.build)\n\n? (Perhaps with a bit more filtering on the string to get it how you\nwant/need )?\n\n> +\n> +include $(CLEAR_VARS)\n> +\n> +LOCAL_SHARED_LIBRARIES := libc libexif libjpeg libyuv_chromium libdl libyaml\n> +MESON_GEN_PKGCONFIGS := libexif libjpeg yaml-0.1 libyuv dl\n> +\n> +ifeq ($(TARGET_IS_64_BIT),true)\n> +LOCAL_MULTILIB := 64\n> +else\n> +LOCAL_MULTILIB := 32\n> +endif\n> +include $(LOCAL_PATH)/meson_cross.mk\n> +\n> +ifdef TARGET_2ND_ARCH\n> +LOCAL_MULTILIB := 32\n> +include $(LOCAL_PATH)/meson_cross.mk\n> +endif\n> +\n> +#-------------------------------------------------------------------------------\n> +\n> +define libcamera-lib\n> +LOCAL_MODULE_CLASS := SHARED_LIBRARIES\n> +LOCAL_MODULE := $1\n> +LOCAL_VENDOR_MODULE := true\n\nIs LOCAL_VENDOR_MODULE used or needed ?\nPerhaps that's an integration with the android build?\n\n> +LOCAL_MODULE_RELATIVE_PATH := $2\n> +ifdef TARGET_2ND_ARCH\n> +LOCAL_SRC_FILES_$(TARGET_ARCH) := $(call relative_top_path,$(LOCAL_PATH))$($3)\n> +LOCAL_SRC_FILES_$(TARGET_2ND_ARCH) := $(call relative_top_path,$(LOCAL_PATH))$(2ND_$3)\n> +LOCAL_MULTILIB := both\n> +else\n> +LOCAL_SRC_FILES := $(call relative_top_path,$(LOCAL_PATH))$($3)\n> +endif\n> +LOCAL_CHECK_ELF_FILES := false\n> +LOCAL_MODULE_SUFFIX := .so$(${4})\n\nOh - that's why you're adding a . in the version...\n\n> +include $(BUILD_PREBUILT)\n> +include $(CLEAR_VARS)\n> +endef\n> +\n> +__MY_SHARED_LIBRARIES := $(LOCAL_SHARED_LIBRARIES)\n> +include $(CLEAR_VARS)\n> +LOCAL_SHARED_LIBRARIES := $(__MY_SHARED_LIBRARIES)\n> +\n> +# Modules 'libcamera', produces '/vendor/lib{64}/libcamera.so'\n> +$(eval $(call libcamera-lib,libcamera,,LIBCAMERA_BIN,LIBCAMERA_MESON_VERSION))\n> +# Modules 'libcamera-base', produces '/vendor/lib{64}/libcamera-base.so'\n> +$(eval $(call libcamera-lib,libcamera-base,,LIBCAMERA_BASE_BIN,LIBCAMERA_MESON_VERSION))\n> +# Modules 'ipa_rkisp1', produces '/vendor/lib{64}/ipa_rkisp1.so'\n> +$(eval $(call libcamera-lib,ipa_rkisp1,,LIBCAMERA_IPA_RKISP1_BIN,))\n> +# Modules 'ipa_rkisp1', produces '/vendor/lib{64}/ipa_rpi.so'\n> +$(eval $(call libcamera-lib,ipa_rpi,,LIBCAMERA_IPA_RASPBERRYPI_BIN,))\n> +# Modules 'ipa_rkisp1', produces '/vendor/lib{64}/ipa_ipu3.so'\n> +$(eval $(call libcamera-lib,ipa_ipu3,,LIBCAMERA_IPA_IPU3_BIN,))\n> +# Modules 'ipa_rkisp1', produces '/vendor/lib{64}/ipa_vimc.so'\n> +$(eval $(call libcamera-lib,ipa_vimc,,LIBCAMERA_IPA_VIMC_BIN,))\n> +\n> +# Modules 'camera.libcamera', produces '/vendor/lib{64}/hw/camera.libcamera.so' HAL\n> +$(eval $(call libcamera-lib,camera.libcamera,hw,LIBCAMERA_HAL_BIN,))\n> +\n> +LOCAL_SHARED_LIBRARIES += libcamera libcamera-base ipa_rkisp1 ipa_rpi ipa_ipu3 ipa_vimc\n> +LOCAL_REQUIRED_MODULES := libcamera libcamera-base ipa_rkisp1 ipa_rpi ipa_ipu3 ipa_vimc\n> +\n> +$(shell mkdir -p $(TARGET_OUT_VENDOR_ETC)/rkisp1/)\n> +$(shell mkdir -p $(TARGET_OUT_VENDOR_ETC)/rpi/)\n> +$(shell mkdir -p $(TARGET_OUT_VENDOR_ETC)/ipu3/)\n> +$(shell mkdir -p $(TARGET_OUT_VENDOR_ETC)/vimc/)\n> +$(shell cp $(LIBCAMERA_IPA_RKISP1_CONFIGS)/* $(TARGET_OUT_VENDOR_ETC)/rkisp1/)\n> +$(shell cp $(LIBCAMERA_IPA_RASPBERRYPI_CONFIGS)/* $(TARGET_OUT_VENDOR_ETC)/rpi/)\n> +$(shell cp $(LIBCAMERA_IPA_IPU3_CONFIGS)/* $(TARGET_OUT_VENDOR_ETC)/ipu3/)\n> +$(shell cp $(LIBCAMERA_IPA_VIMC_CONFIGS)/* $(TARGET_OUT_VENDOR_ETC)/vimc/)\n\nIs there no 'install' phase that would do this - with correctly\nconfigured datadir during meson configure?\n\n> +\n> +#-------------------------------------------------------------------------------\n> +\n> +endif\n> diff --git a/android/meson_cross.mk b/android/meson_cross.mk\n> new file mode 100644\n> index 00000000..7a222f9c\n> --- /dev/null\n> +++ b/android/meson_cross.mk\n> @@ -0,0 +1,298 @@\n> +# SPDX-License-Identifier: Apache-2.0\n> +#\n> +# Copyright (C) 2021, GlobalLogic Ukraine\n> +# Copyright (C) 2021, Roman Stratiienko (r.stratiienko@gmail.com)\n> +#\n> +# meson_cross.mk - Android makefile\n> +#\n> +\n> +# Turn \"dir1/dir2/dir3/dir4\" into \"../../../../\"\n> +define relative_top_path\n> +$(eval __s:=) \\\n> +$(foreach tmp,$(subst /,$(space),$1),$(eval __s:=$(__s)../)) \\\n> +$(__s)\n> +endef\n> +\n> +MY_PATH := $(call my-dir)\n> +\n> +AOSP_ABSOLUTE_PATH := $(realpath .)\n> +\n> +libcam_m_dummy_$(LOCAL_MULTILIB) := $(TARGET_OUT_INTERMEDIATES)/LIBCAM_DUMMY_$(LOCAL_MULTILIB)/dummy.c\n> +\n> +$(libcam_m_dummy_$(LOCAL_MULTILIB)):\n> +       mkdir -p $(dir $@)\n> +       touch $@\n> +\n> +LOCAL_SRC_FILES := $(call relative_top_path,$(MY_PATH))$(libcam_m_dummy_$(LOCAL_MULTILIB))\n> +LOCAL_VENDOR_MODULE := true\n> +LOCAL_MODULE := libcam.dummy.$(LOCAL_MULTILIB)\n> +\n> +# Prepare intermediate variables by AOSP make/core internals\n> +include $(BUILD_SHARED_LIBRARY)\n> +\n> +LOCAL_PATH := $(MY_PATH)\n> +\n> +link_deps := \\\n> +       $(built_static_libraries) \\\n> +       $(built_shared_libraries) \\\n> +       $(built_whole_libraries) \\\n> +       $(strip $(all_objects)) \\\n> +       $(my_target_libatomic) \\\n> +       $(my_target_libcrt_builtins) \\\n> +       $(my_target_crtbegin_so_o) \\\n> +       $(my_target_crtend_so_o)\n> +\n> +# Build using intermediate variables provided by AOSP make/core internals\n> +M_TARGET_PREFIX := $(my_2nd_arch_prefix)\n> +\n> +LIBCAMERA_LIB_DIR := lib$(subst 32,,$(LOCAL_MULTILIB))\n> +\n> +MESON_OUT_DIR                            := $($(M_TARGET_PREFIX)TARGET_OUT_INTERMEDIATES)/MESON_LIBCAMERA\n> +MESON_GEN_DIR                            := $(MESON_OUT_DIR)_GEN\n> +MESON_GEN_FILES_TARGET                   := $(MESON_GEN_DIR)/.timestamp\n> +\n> +$(M_TARGET_PREFIX)LIBCAMERA_BIN := $(MESON_OUT_DIR)/install/usr/local/lib/libcamera.so\n> +$(M_TARGET_PREFIX)LIBCAMERA_HAL_BIN := $(MESON_OUT_DIR)/install/usr/local/lib/libcamera-hal.so\n> +$(M_TARGET_PREFIX)LIBCAMERA_BASE_BIN := $(MESON_OUT_DIR)/install/usr/local/lib/libcamera-base.so\n> +$(M_TARGET_PREFIX)LIBCAMERA_IPA_RKISP1_BIN := $(MESON_OUT_DIR)/install/usr/local/lib/libcamera/ipa_rkisp1.so\n> +$(M_TARGET_PREFIX)LIBCAMERA_IPA_RASPBERRYPI_BIN := $(MESON_OUT_DIR)/install/usr/local/lib/libcamera/ipa_rpi.so\n> +$(M_TARGET_PREFIX)LIBCAMERA_IPA_IPU3_BIN := $(MESON_OUT_DIR)/install/usr/local/lib/libcamera/ipa_ipu3.so\n> +$(M_TARGET_PREFIX)LIBCAMERA_IPA_VIMC_BIN := $(MESON_OUT_DIR)/install/usr/local/lib/libcamera/ipa_vimc.so\n> +$(M_TARGET_PREFIX)LIBCAMERA_IPA_RKISP1_CONFIGS := $(MESON_OUT_DIR)/install/usr/local/share/libcamera/ipa/rkisp1\n> +$(M_TARGET_PREFIX)LIBCAMERA_IPA_RASPBERRYPI_CONFIGS := $(MESON_OUT_DIR)/install/usr/local/share/libcamera/ipa/raspberrypi\n> +$(M_TARGET_PREFIX)LIBCAMERA_IPA_IPU3_CONFIGS := $(MESON_OUT_DIR)/install/usr/local/share/libcamera/ipa/ipu3\n> +$(M_TARGET_PREFIX)LIBCAMERA_IPA_VIMC_CONFIGS := $(MESON_OUT_DIR)/install/usr/local/share/libcamera/ipa/vimc\n\n\n> +\n> +LIBCAMERA_BINS := \\\n> +       $($(M_TARGET_PREFIX)LIBCAMERA_BIN) \\\n> +       $($(M_TARGET_PREFIX)LIBCAMERA_HAL_BIN) \\\n> +       $($(M_TARGET_PREFIX)LIBCAMERA_BASE_BIN) \\\n> +       $($(M_TARGET_PREFIX)LIBCAMERA_IPA_RKISP1_BIN) \\\n> +       $($(M_TARGET_PREFIX)LIBCAMERA_IPA_RASPBERRYPI_BIN) \\\n> +       $($(M_TARGET_PREFIX)LIBCAMERA_IPA_IPU3_BIN) \\\n> +       $($(M_TARGET_PREFIX)LIBCAMERA_IPA_VIMC_BIN)\n> +\n> +MESON_GEN_NINJA := \\\n> +       cd $(MESON_OUT_DIR) && PATH=/usr/bin:/usr/local/bin:$$PATH meson ./build \\\n> +       --cross-file $(AOSP_ABSOLUTE_PATH)/$(MESON_GEN_DIR)/aosp_cross           \\\n> +       --buildtype=release                                                      \\\n> +       -Dandroid=enabled                                                        \\\n> +       -Dipas=$(subst $(space),$(comma),$(BOARD_LIBCAMERA_IPAS))                \\\n> +       -Dpipelines=$(subst $(space),$(comma),$(BOARD_LIBCAMERA_PIPELINES))      \\\n> +       -Dsysconfdir=/vendor/etc                                                 \\\n\nShould the -Dprefix be set to be able to install directly to\nM_TARGET_PREFIX?\n\nand -Dlibdir=/vendor/lib{64}/ ?\nand -Ddatadir=/vendor/\n\nI'm weary that by manually moving files around - libcamera hasn't been\n'informed' of the updated locations and is possibly not looking in the\nright places to load these files!\n\nCan you check the output of the summary when the meson configure phase\nis run?\n\nFor instance on my system :\n\n  Paths\n    LIBCAMERA_DATA_DIR       : \"/usr/share/libcamera\"\n    LIBCAMERA_SYSCONF_DIR    : \"/etc/libcamera\"\n    IPA_PROXY_DIR            : \"/usr/libexec/libcamera\"\n    IPA_CONFIG_DIR           : \"/etc/libcamera/ipa:/usr/share/libcamera/ipa\"\n    IPA_MODULE_DIR           : \"/usr/lib/x86_64-linux-gnu/libcamera\"\n\nThose definitions are *important* and I expect the current means of\nmoving files around means that they won't be set correctly (they are\ndetermined from the datadir/libdir set by meson).\n\n\n\n\n> +       -Dtest=false                                                             \\\n> +       -Dwerror=false                                                           \\\n> +       -Dallow_unsigned_ipas_in_process=true\n> +\n> +MESON_BUILD := PATH=/usr/bin:/bin:/sbin:$$PATH ninja -C $(MESON_OUT_DIR)/build\n> +\n> +$(MESON_GEN_FILES_TARGET): MESON_CPU_FAMILY := $(subst arm64,aarch64,$(TARGET_$(M_TARGET_PREFIX)ARCH))\n> +\n> +define create-pkgconfig\n\nIs this a hack/workaround ? Can it be commented clearly to say why/what\nit's doing here please?\n\n> +echo -e \"Name: $2\" \\\n> +       \"\\nDescription: $2\" \\\n> +       \"\\nVersion: $3\" > $1/$2.pc\n> +\n> +endef\n> +\n> +# Taken from build/make/core/binary.mk. We need this\n> +# to use definitions from build/make/core/definitions.mk\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_GLOBAL_C_INCLUDES := $(my_target_global_c_includes)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_GLOBAL_C_SYSTEM_INCLUDES := $(my_target_global_c_system_includes)\n> +\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_TARGET_GLOBAL_CFLAGS := $(my_target_global_cflags)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_TARGET_GLOBAL_CONLYFLAGS := $(my_target_global_conlyflags)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_TARGET_GLOBAL_CPPFLAGS := $(my_target_global_cppflags)\n> +\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_2ND_ARCH_VAR_PREFIX := $(M_TARGET_PREFIX)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_CC := $(my_cc)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_LINKER := $(my_linker)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_CXX := $(my_cxx)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_CXX_LINK := $(my_cxx_link)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_YACCFLAGS := $(LOCAL_YACCFLAGS)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_ASFLAGS := $(my_asflags)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_CONLYFLAGS := $(my_conlyflags)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_CFLAGS := $(my_cflags)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_CPPFLAGS := $(my_cppflags)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_CFLAGS_NO_OVERRIDE := $(my_cflags_no_override)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_CPPFLAGS_NO_OVERRIDE := $(my_cppflags_no_override)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_RTTI_FLAG := $(LOCAL_RTTI_FLAG)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_DEBUG_CFLAGS := $(debug_cflags)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_C_INCLUDES := $(my_c_includes)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_IMPORTED_INCLUDES := $(imported_includes)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_LDFLAGS := $(my_ldflags)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_LDLIBS := $(my_ldlibs)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_TARGET_GLOBAL_LDFLAGS := $(my_target_global_ldflags)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_TIDY_CHECKS := $(my_tidy_checks)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_TIDY_FLAGS := $(my_tidy_flags)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_ARFLAGS := $(my_arflags)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_ALL_SHARED_LIBRARIES := $(built_shared_libraries)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_ALL_STATIC_LIBRARIES := $(built_static_libraries)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_ALL_WHOLE_STATIC_LIBRARIES := $(built_whole_libraries)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_ALL_OBJECTS := $(strip $(all_objects))\n\nPerhaps avoiding this strip step would fix the signatures?\n\n> +\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_ARM_CFLAGS := $(normal_objects_cflags)\n> +\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_TARGET_LIBCRT_BUILTINS := $(my_target_libcrt_builtins)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_TARGET_LIBATOMIC := $(my_target_libatomic)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_TARGET_CRTBEGIN_SO_O := $(my_target_crtbegin_so_o)\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_TARGET_CRTEND_SO_O := $(my_target_crtend_so_o)\n> +##\n> +\n> +define m-lld-flags\n> +  -nostdlib -Wl,--gc-sections \\\n> +  $(PRIVATE_TARGET_CRTBEGIN_SO_O) \\\n> +  $(PRIVATE_ALL_OBJECTS) \\\n> +  -Wl,--whole-archive \\\n> +  $(PRIVATE_ALL_WHOLE_STATIC_LIBRARIES) \\\n> +  -Wl,--no-whole-archive \\\n> +  $(if $(PRIVATE_GROUP_STATIC_LIBRARIES),-Wl$(comma)--start-group) \\\n> +  $(PRIVATE_ALL_STATIC_LIBRARIES) \\\n> +  $(if $(PRIVATE_GROUP_STATIC_LIBRARIES),-Wl$(comma)--end-group) \\\n> +  $(if $(filter true,$(NATIVE_COVERAGE)),$(PRIVATE_TARGET_COVERAGE_LIB)) \\\n> +  $(PRIVATE_TARGET_LIBCRT_BUILTINS) \\\n> +  $(PRIVATE_TARGET_LIBATOMIC) \\\n> +  $(PRIVATE_TARGET_GLOBAL_LDFLAGS) \\\n> +  $(PRIVATE_LDFLAGS) \\\n> +  $(PRIVATE_ALL_SHARED_LIBRARIES) \\\n> +  $(PRIVATE_TARGET_CRTEND_SO_O) \\\n> +  $(PRIVATE_LDLIBS)\n> +endef\n> +\n> +define m-lld-flags-cleaned\n> +  $(subst prebuilts/,$(AOSP_ABSOLUTE_PATH)/prebuilts/, \\\n> +  $(subst out/,$(AOSP_ABSOLUTE_PATH)/out/,             \\\n> +  $(subst -Wl$(comma)--fatal-warnings,,                \\\n> +  $(subst -Wl$(comma)--no-undefined-version,,          \\\n> +  $(subst -Wl$(comma)--gc-sections,,                   \\\n> +  $(patsubst %dummy.o,,                                \\\n> +    $(m-lld-flags)))))))\n> +endef\n> +\n> +define m-cpp-flags\n> +  $(PRIVATE_TARGET_GLOBAL_CFLAGS) \\\n> +  $(PRIVATE_TARGET_GLOBAL_CPPFLAGS) \\\n> +  $(PRIVATE_ARM_CFLAGS) \\\n> +  $(PRIVATE_RTTI_FLAG) \\\n> +  $(PRIVATE_CFLAGS) \\\n> +  $(PRIVATE_CPPFLAGS) \\\n> +  $(PRIVATE_DEBUG_CFLAGS) \\\n> +  $(PRIVATE_CFLAGS_NO_OVERRIDE) \\\n> +  $(PRIVATE_CPPFLAGS_NO_OVERRIDE)\n> +endef\n> +\n> +define m-c-flags\n> +  $(PRIVATE_TARGET_GLOBAL_CFLAGS) \\\n> +  $(PRIVATE_TARGET_GLOBAL_CONLYFLAGS) \\\n> +  $(PRIVATE_ARM_CFLAGS) \\\n> +  $(PRIVATE_CFLAGS) \\\n> +  $(PRIVATE_CONLYFLAGS) \\\n> +  $(PRIVATE_DEBUG_CFLAGS) \\\n> +  $(PRIVATE_CFLAGS_NO_OVERRIDE)\n> +endef\n> +\n> +define filter-c-flags\n> +  $(subst -std=gnu++17,, \\\n> +  $(subst -stdlib=libc++,, \\\n> +  $(subst -fno-rtti,, \\\n> +  $(patsubst  -W%,, \\\n> +    $1))))\n> +endef\n> +\n> +define m-c-includes-common\n> +$(addprefix -I , $(PRIVATE_C_INCLUDES)) \\\n> +$(if $(PRIVATE_NO_DEFAULT_COMPILER_FLAGS),,\\\n> +    $(addprefix -I ,\\\n> +        $(filter-out $(PRIVATE_C_INCLUDES), \\\n> +            $(PRIVATE_GLOBAL_C_INCLUDES))) \\\n> +    $(addprefix -isystem ,\\\n> +        $(filter-out $(PRIVATE_C_INCLUDES), \\\n> +            $(PRIVATE_GLOBAL_C_SYSTEM_INCLUDES))))\n> +endef\n> +\n> +ifeq ($(shell test $(PLATFORM_SDK_VERSION) -ge 30; echo $$?), 0)\n> +# Android 11+\n> +define m-c-includes\n> +$(foreach i,$(PRIVATE_IMPORTED_INCLUDES),$(EXPORTS.$(i)))\\\n> +$(m-c-includes-common)\n> +endef\n> +define postprocess-includes\n> +endef\n> +else\n> +# Android 10,9\n> +$(MESON_GEN_FILES_TARGET): PRIVATE_IMPORT_INCLUDES := $(import_includes)\n> +define postprocess-includes\n\nWhat calls this?\n\nCould we get a comment block explaining what is going on or why it needs\nto be done please?\n\n> +       echo \" $$(cat $(PRIVATE_IMPORT_INCLUDES)) \" > $(MESON_GEN_DIR)/import_includes && \\\n> +       sed -i  -e ':a;N;$$!ba;s/\\n/ /g'                                  \\\n> +               -e 's# \\{2,\\}# #g'                                        \\\n> +               -e 's# -isystem # -isystem#g'                             \\\n> +               -e 's# -I # -I#g'                                         \\\n> +               -e 's# -I# -I$(AOSP_ABSOLUTE_PATH)/#g'                    \\\n> +               -e 's# -isystem# -isystem$(AOSP_ABSOLUTE_PATH)/#g'        \\\n> +               -e \"s# #','#g\" $(MESON_GEN_DIR)/import_includes &&        \\\n> +       sed -i \"s#<_IMPORT_INCLUDES>#$$(cat $(MESON_GEN_DIR)/import_includes)#g\" $(MESON_GEN_DIR)/aosp_cross\n> +endef\n> +define m-c-includes\n> +<_IMPORT_INCLUDES> $(m-c-includes-common)\n> +endef\n> +endif\n> +\n> +define m-c-abs-includes\n> +  $(subst $(space)-isystem,$(space)-isystem$(AOSP_ABSOLUTE_PATH)/, \\\n> +  $(subst $(space)-I, -I$(AOSP_ABSOLUTE_PATH)/, \\\n> +  $(subst $(space)-I$(space),$(space)-I, \\\n> +  $(subst $(space)-isystem$(space),$(space)-isystem, \\\n> +    $(strip $(m-c-includes))))))\n> +endef\n> +\n> +$(MESON_GEN_FILES_TARGET): MESON_GEN_PKGCONFIGS:=$(MESON_GEN_PKGCONFIGS)\n> +$(MESON_GEN_FILES_TARGET): MESON_GEN_DIR:=$(MESON_GEN_DIR)\n> +$(MESON_GEN_FILES_TARGET): $(sort $(shell find -L $(LIBCAMERA_TOP) -not -path '*/\\.*'))\n> +       mkdir -p $(dir $@)\n> +       echo -e \"[properties]\\n\"                                                                                                  \\\n> +               \"c_args = [$(foreach flag, $(call filter-c-flags,$(m-c-flags) $(m-c-abs-includes)),'$(flag)', )'']\\n\"             \\\n> +               \"cpp_args = [$(foreach flag, $(call filter-c-flags,$(m-cpp-flags) $(m-c-abs-includes)),'$(flag)', )'']\\n\"         \\\n> +               \"c_link_args = [$(foreach flag, $(m-lld-flags-cleaned),'$(flag)',)'']\\n\"                                          \\\n> +               \"cpp_link_args = [$(foreach flag, $(m-lld-flags-cleaned),'$(flag)',)'']\\n\"                                        \\\n> +               \"needs_exe_wrapper = true\\n\"                                                                                      \\\n> +               \"[binaries]\\n\"                                                                                                    \\\n> +               \"ar = '$(AOSP_ABSOLUTE_PATH)/$($($(M_TARGET_PREFIX))TARGET_AR)'\\n\"                                                \\\n> +               \"c = [$(foreach arg,$(PRIVATE_CC),'$(subst prebuilts/,$(AOSP_ABSOLUTE_PATH)/prebuilts/,$(arg))',)'']\\n\"           \\\n> +               \"cpp = [$(foreach arg,$(PRIVATE_CXX),'$(subst prebuilts/,$(AOSP_ABSOLUTE_PATH)/prebuilts/,$(arg))',)'']\\n\"        \\\n> +               \"c_ld = 'lld'\\n\"                                                                                                  \\\n> +               \"cpp_ld = 'lld'\\n\\n\"                                                                                              \\\n> +               \"pkgconfig = ['env', 'PKG_CONFIG_LIBDIR=' + '$(AOSP_ABSOLUTE_PATH)/$(MESON_GEN_DIR)', '/usr/bin/pkg-config']\\n\\n\" \\\n> +               \"llvm-config = '/dev/null'\\n\"                                                                                     \\\n> +               \"[host_machine]\\n\"                                                                                                \\\n> +               \"system = 'linux'\\n\"                                                                                              \\\n> +               \"cpu_family = '$(MESON_CPU_FAMILY)'\\n\"                                                                            \\\n> +               \"cpu = '$(MESON_CPU_FAMILY)'\\n\"                                                                                   \\\n> +               \"endian = 'little'\" > $(dir $@)/aosp_cross\n> +\n> +       #\n> +       $(foreach pkg, $(MESON_GEN_PKGCONFIGS), $(call create-pkgconfig,$(dir $@),$(word 1, $(subst :, ,$(pkg))),$(word 2, $(subst :, ,$(pkg)))))\n> +       touch $@\n> +\n> +$(MESON_OUT_DIR)/.build.timestamp: MESON_GEN_NINJA:=$(MESON_GEN_NINJA)\n> +$(MESON_OUT_DIR)/.build.timestamp: MESON_BUILD:=$(MESON_BUILD)\n> +$(MESON_OUT_DIR)/.build.timestamp: $(MESON_GEN_FILES_TARGET) $(link_deps)\n> +       rm -rf $(dir $@)\n> +       mkdir -p $(dir $@)\n> +       mkdir -p $(dir $@)/build\n> +       # Meson will update timestamps in sources directory, continuously retriggering the build\n\nReally? What has inferred that meson is updating timestamps of the\nfiles. I don't believe that should be happening - so something else\ncould be afoot here.\n\n\n> +       # even if nothing changed. Copy sources into intermediate dir to avoid this effect.\n> +       cp -r $(LIBCAMERA_TOP)/* $(dir $@)\n> +       $(MESON_GEN_NINJA)\n> +       $(MESON_BUILD)\n> +       touch $@\n> +\n> +$(MESON_OUT_DIR)/install/.install.timestamp: MESON_BUILD:=$(MESON_BUILD)\n> +$(MESON_OUT_DIR)/install/.install.timestamp: $(MESON_OUT_DIR)/.build.timestamp\n> +       rm -rf $(dir $@)\n> +       mkdir -p $(dir $@)\n> +       DESTDIR=$(AOSP_ABSOLUTE_PATH)/$(dir $@) $(MESON_BUILD) install\n> +       touch $@\n> +\n> +$(LIBCAMERA_BINS): $(MESON_OUT_DIR)/install/.install.timestamp\n> +       echo \"Build $@\"\n> +       touch $@\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70359BD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  3 Nov 2022 14:32:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CAB0363036;\n\tThu,  3 Nov 2022 15:32:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D749361F42\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  3 Nov 2022 15:32:21 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 52F1B4E6;\n\tThu,  3 Nov 2022 15:32:21 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1667485943;\n\tbh=eVi0Gd/gwJFTskWUG8+cDUNs0flgu1WGpp9r9YyMpAk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JI5KCF6OB4Bxz7fOeT8hxQhDNFVxieJPFhejTNCWohoCRagUuUAfO7rPaNUMNY2C3\n\tppuTYn/GWulcX4Hx7PTiHwfVW902VUaLFIBpoxlUXrN4ak5WUXgu1gAf5cu0EXUj1u\n\tESYJMtViQ1rVdkV2aMCb9FuN1ojqxER8l3eyJYRiX+GNM1MBNfKzOSOU6X5rfnJ5p0\n\tUsNiVTEr2QmqDsqxvrTNmEWM34Q9vw+DRImgVHkyO54Esjs7eEOcySPsF9kmNKHyv5\n\th5p05I9nBryelyOquUlOuGp54cL9gmu1NamRWlZZXjKhEIgQabKuJK4OUQkxjrPK03\n\t6B8x0ukSYa/SA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1667485941;\n\tbh=eVi0Gd/gwJFTskWUG8+cDUNs0flgu1WGpp9r9YyMpAk=;\n\th=In-Reply-To:References:Subject:From:To:Cc:Date:From;\n\tb=fSrz2ikI1d5RZe1vQbuUGhrpA3t61BIHE1zpma1H8AAt+L7OHTKv1PqetoDd510zV\n\tTm7dRaCj2fwj3+VIbd76UmnVyLlMZ5VEG86RX6X4CFK5OUWJLzlTRkyaWeCcltI7aY\n\t7PWjZwMBOWf4Y6o6lpdn+kf83sepUlm1FZ9pywxs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fSrz2ikI\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221030230500.74842-5-nicholas@rothemail.net>","References":"<20221030230500.74842-1-nicholas@rothemail.net>\n\t<20221030230500.74842-5-nicholas@rothemail.net>","To":"Nicholas Roth <nicholas@rothemail.net>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 03 Nov 2022 14:32:18 +0000","Message-ID":"<166748593815.15935.10725002495573722030@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v6 4/5] android: add makefiles to\n\tbuild inline with AOSP","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Nicholas Roth <nicholas@rothemail.net>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]