[{"id":25691,"web_url":"https://patchwork.libcamera.org/comment/25691/","msgid":"<166717489990.1873815.16844793049732888945@Monstersaurus>","date":"2022-10-31T00:08:19","subject":"Re: [libcamera-devel] [PATCH] libcamera: Add todo comment in\n\tmeson.build about switch to dependency('dl')","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-10-30 16:27:55)\n> The dlopen() & co. functions are provided by libdl on some systems, and\n> but the C library on others. Starting from version 0.62.0, meson handles\n> this behind the scenes when using dependency('dl'). Add a todo comment\n> to remember we should replace the manual implementation with a\n> dependency() call when updating to meson 0.62.0.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 0494e808f7d0..65b0ed047b48 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -67,6 +67,7 @@ subdir('proxy')\n> \n> null_dep = dependency('', required : false)\n> \n> +# TODO: Use dependency('dl') when updating to meson 0.62.0.\n\nThat's very predictive that we will only update /to/ 0.62.0 next, and\nnot beyond ... ;-)\n\nI guess it depends on what makes it into the next LTS/stable releases on\nthe distros?\n\nBut either way,\n\nReviewed-by: Kieran Bingham \n\n\n> libdl = null_dep\n> if not cc.has_function('dlopen')\n> libdl = cc.find_library('dl')\n> \n> base-commit: 2f0987d1dbd4a1529a701720c11d693a4fcdef3e\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1707BD16B\n\tfor ;\n\tMon, 31 Oct 2022 00:08:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D2A9E63031;\n\tMon, 31 Oct 2022 01:08:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E010262FFC\n\tfor ;\n\tMon, 31 Oct 2022 01:08:22 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 60E75706;\n\tMon, 31 Oct 2022 01:08:22 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1667174904;\n\tbh=+7D9tJPM01zSJDO5dMDYJ4s6q9jlMMz4qkW769YTBFI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=f0Fz7uTG5CZnVMedmsGM4V6eGI1IisPBg9xLH3i6xIqnRtONHeaQbM9Zn5U10Oy6V\n\t+tuAHyj9nVyjAsOlctyIq9ZujJ5xn0yzDLVp3Ui/7Dklkf6vm7hMPnUTQTSB7+zmnD\n\tb8uzV5tIM55JhyfZ7FzrMW4368AyQ0kD5t2I69hNlMytNRrsgpEnRxvn4KSNcvy1nP\n\tSa/pAyQCa71V9TmFn3k7ctUeo9vWK7J3s4mtOb6+gWRDI/BXSBIc4ondhYIia8uAqo\n\t1Iycp1jLuKKy1djWeW87n8L7VHMCj35qTiL8S/bqVPbjF5vrvzOWGV4tCQ57muKauJ\n\tCquP7LoTXjSCA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1667174902;\n\tbh=+7D9tJPM01zSJDO5dMDYJ4s6q9jlMMz4qkW769YTBFI=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=I9tutVN5zUIHP8aB5UIENQtKlS8T6avqKIKbsOLc+Cc8W7XLV6/H2XOWlBN8R5OUW\n\tsjlKr+ZukAUlCsgyYHg25MADLygDgZXrKJdBPlip6ev1gy3MhdMacYFzk1YyBPVlcV\n\tZgXqN4U1IUOX9Kjy2IfpeKj8f3j6jDQrM1CsdCqI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"I9tutVN5\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221030162755.6347-1-laurent.pinchart@ideasonboard.com>","References":"<20221030162755.6347-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 31 Oct 2022 00:08:19 +0000","Message-ID":"<166717489990.1873815.16844793049732888945@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Add todo comment in\n\tmeson.build about switch to dependency('dl')","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]