[{"id":25668,"web_url":"https://patchwork.libcamera.org/comment/25668/","msgid":"","date":"2022-10-28T13:37:07","subject":"Re: [libcamera-devel] [PATCH v1 2/2] pipeline: raspberrypi: Do not\n\tunconditionally free buffers on close","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch!\n\nOn Fri, 28 Oct 2022 at 12:52, Naushir Patuck via libcamera-devel\n wrote:\n>\n> When a camera is terminated, do not unconditionally free buffers in the\n> RPiCameraData destructor. Otherwise, this causes harmless error log messages\n> to be displayed if no buffer have previously been allocated.\n>\n> Signed-off-by: Naushir Patuck \n\nAll looks good!\n\nTested-by: David Plowman \nReviewed-by: David Plowman \n\nThanks\nDavid\n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 343f8cb2c7ed..31107e1338bf 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -191,7 +191,8 @@ public:\n>\n> ~RPiCameraData()\n> {\n> - freeBuffers();\n> + if (buffersAllocated_)\n> + freeBuffers();\n> }\n>\n> void freeBuffers();\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D38BCBDB16\n\tfor ;\n\tFri, 28 Oct 2022 13:37:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E48A62FE1;\n\tFri, 28 Oct 2022 15:37:51 +0200 (CEST)","from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com\n\t[IPv6:2607:f8b0:4864:20::102c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 820D561F4A\n\tfor ;\n\tFri, 28 Oct 2022 15:37:49 +0200 (CEST)","by mail-pj1-x102c.google.com with SMTP id\n\tm14-20020a17090a3f8e00b00212dab39bcdso9897989pjc.0\n\tfor ;\n\tFri, 28 Oct 2022 06:37:49 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666964271;\n\tbh=4BcKClfpk9H5upLe2x4UD74TiHFKxQbjWXzzGomT4rM=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XMSfAi/R8Wu9BJGEO5kiznIgwJ7kOZPrCy7kICaBV9dOYUyh8u700jdJ3lEarRQTt\n\taAKWOxpyHyKPcnD8Z7AeisIbZNKuTIE03Q/AoLF8LM/kkr3QZLM5lMSHSd14g9XKIi\n\tLxSlDuLGt5nZTaXdV+qhRhwBuPRQrDfM8ooD/9SqwwC/YYNBXfk0ybDmjnuMaZu4/P\n\tK8rJ22yo9JTx6aBpnhlFWa6zhRWa7p3lenNdMMNY8C9jmTiIDjAgB9QJJVKGa9wFan\n\tYx5Fv79fotrM0hffnscbS64dXcVwpfYu1USbfcPkCl53S2jn5VFAy6B5rL4dk5GeAo\n\t/BAoRawhYU0pQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ZLZ1Ln+pHAanuwGrXnPMiLo+/2FeqpZKZ0FvC0ryTnI=;\n\tb=cTeTyV3o+to5pqMhhPBJxPBuAuRttXbfTSM6V6oJfb0GGZYUIOCY+jeU9AaKUEYDLF\n\ti7bCLdOjt1pAuI72gpNBuoiRSHWofI9tEDBZLJFyhFe8T9NPiZ0QryAC9j+ygTLsIAmb\n\ts5j7qTm4zUFIIq90m2I20qHPLAdj7Uh5gqKFTjPxZ7Oux47uqNOFTVY1cnCk+w6iD71N\n\t3X4bb7JevtgDvCDWzAN2fLND6AUN69hRW64FVZ6hi1WSadUkcFY9SneR95KG4C9VopLY\n\tpvZJTx79cWiB0XmjyPe6Pc71RNqfK7h/rNsbMyry36mIureddKM685DM4yBpBYI8vDKt\n\tjH+g=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"cTeTyV3o\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ZLZ1Ln+pHAanuwGrXnPMiLo+/2FeqpZKZ0FvC0ryTnI=;\n\tb=yEgQRziKkVPZYnHWGb6Oa4ec3cwxu+Vb5yyhTw1sn8I2+01dpXqiFaWlDEr1m3U7Sj\n\tIGaV3wmEOQsxaFZEq41Am3ErYZHsqLtXoW3ox7lweNEHproQxkX714MqXfV0Dhiz7+EY\n\tPXOfEmoQV21/vo5KA4szwHqPfLFXf+PjZD0nDMRKRIyQvWAhlgevZTqQ0GexFb994min\n\tAh5ddkm8tGzs9cYDmS8zOHAQVgprxVMI7C3ycUvwR9WiBs+xryS3Qpapo+dYLB/rGU1J\n\tdt8sF7yyidgEevfF1U+RBWN2TEoD/PsM3Uy7hxIgMP/DVPeBJNAdCmHt4qkvCXXwZuU7\n\t327g==","X-Gm-Message-State":"ACrzQf0oNzsWAI96bE8MmCnOdl3OAdKePbNtcfdzXeEgWnoCkz7dlpPK\n\tr03r8Q3Cq4d60eQxv9ZZUNfgSgVttqNXbJw4cmE795Q30xZOrg==","X-Google-Smtp-Source":"AMsMyM6rRxLtVIKPY/yBRQKE0PZ3Djj0xwV+E3qyc/Mliia90eb/Lg9KGU+HojkEVd7BBkqcCix0C2isT0yDtHzY9dU=","X-Received":"by 2002:a17:902:f54d:b0:185:4ca4:2641 with SMTP id\n\th13-20020a170902f54d00b001854ca42641mr53791134plf.50.1666964238596;\n\tFri, 28 Oct 2022 06:37:18 -0700 (PDT)","MIME-Version":"1.0","References":"<20221028115200.8138-1-naush@raspberrypi.com>\n\t<20221028115200.8138-3-naush@raspberrypi.com>","In-Reply-To":"<20221028115200.8138-3-naush@raspberrypi.com>","Date":"Fri, 28 Oct 2022 14:37:07 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v1 2/2] pipeline: raspberrypi: Do not\n\tunconditionally free buffers on close","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25673,"web_url":"https://patchwork.libcamera.org/comment/25673/","msgid":"<166696475694.15935.4307213973768725716@Monstersaurus>","date":"2022-10-28T13:45:56","subject":"Re: [libcamera-devel] [PATCH v1 2/2] pipeline: raspberrypi: Do not\n\tunconditionally free buffers on close","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2022-10-28 12:52:00)\n> When a camera is terminated, do not unconditionally free buffers in the\n> RPiCameraData destructor. Otherwise, this causes harmless error log messages\n> to be displayed if no buffer have previously been allocated.\n> \n\nMuch like the V4L2 patch, I would think putting this check into\nthe beginning of void RPiCameraData::freeBuffers() would be safer.\n\nI see freeBuffers is called a few times, (configure, start), which I\npresume already ensure they are allocated ... but catching this for sure\nfor all cases could make sense.\n\nAnyway, that's up to you, however you prefer:\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 343f8cb2c7ed..31107e1338bf 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -191,7 +191,8 @@ public:\n> \n> ~RPiCameraData()\n> {\n> - freeBuffers();\n> + if (buffersAllocated_)\n> + freeBuffers();\n> }\n> \n> void freeBuffers();\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 907A3BD16B\n\tfor ;\n\tFri, 28 Oct 2022 13:46:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FB7562FE7;\n\tFri, 28 Oct 2022 15:46:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81E6D61F4A\n\tfor ;\n\tFri, 28 Oct 2022 15:45:59 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 120B3105;\n\tFri, 28 Oct 2022 15:45:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666964761;\n\tbh=lXXunH3GHl6oRtq6rtnjK6AL+Mto3XUkUp6cDJnFxYk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=UabEFhuZDFQOM0GdchKonDemarHgfqtYYTShxnTzr+IhbIXRiq8lT9Bx8vAqrY2fl\n\tRlb+WWFbzUEOlys0VZFdFUqaEIepaJaGDVZ3sRaLPVV15iobk2268O07QC1bJ+he/m\n\tl73Bnlk59wqVjNJGVbpj8NMVJL0tX4h77NB4QHros3c8Ls7EYRYBqNBXm9LCzybqYE\n\thHRNslC7CsUnftufY05JX48yDq5epzYPn8pwntY1Du2yuyk3FEGMB0d7euNR2ymN/+\n\tRzz/APc1RrkZyOjJxau0oYMIlETQR5qUg3cWmVZR0KTrMAYdvwAezLzzTdsfVISFaH\n\tVLaOFfshTCtaQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666964759;\n\tbh=lXXunH3GHl6oRtq6rtnjK6AL+Mto3XUkUp6cDJnFxYk=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=MLAMOEtpUjmlKusgzFsizZTk9CIedm0izUz2ZMYDxCcKYBxSxCxOVNIdUai87KSPh\n\tnIbeOvzmH50yEzKF7IXX/y/YU3VFGzAWMsgizeubIWBWEqGkrN1HhpDipCjSQgYDe6\n\tJtlU5/aJWNc451BQTAvn/x5PwUDUSkjYctioX3xE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MLAMOEtp\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221028115200.8138-3-naush@raspberrypi.com>","References":"<20221028115200.8138-1-naush@raspberrypi.com>\n\t<20221028115200.8138-3-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 28 Oct 2022 14:45:56 +0100","Message-ID":"<166696475694.15935.4307213973768725716@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 2/2] pipeline: raspberrypi: Do not\n\tunconditionally free buffers on close","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25674,"web_url":"https://patchwork.libcamera.org/comment/25674/","msgid":"","date":"2022-10-28T13:49:03","subject":"Re: [libcamera-devel] [PATCH v1 2/2] pipeline: raspberrypi: Do not\n\tunconditionally free buffers on close","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nThanks for the review.\n\nOn Fri, 28 Oct 2022 at 14:46, Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Quoting Naushir Patuck via libcamera-devel (2022-10-28 12:52:00)\n> > When a camera is terminated, do not unconditionally free buffers in the\n> > RPiCameraData destructor. Otherwise, this causes harmless error log\n> messages\n> > to be displayed if no buffer have previously been allocated.\n> >\n>\n> Much like the V4L2 patch, I would think putting this check into\n> the beginning of void RPiCameraData::freeBuffers() would be safer.\n>\n> I see freeBuffers is called a few times, (configure, start), which I\n> presume already ensure they are allocated ... but catching this for sure\n> for all cases could make sense.\n>\n\nAgree, I'll make the update shortly. Again, I blame Friday!!\n\nNaush\n\n\n>\n> Anyway, that's up to you, however you prefer:\n>\n> Reviewed-by: Kieran Bingham \n>\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index 343f8cb2c7ed..31107e1338bf 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -191,7 +191,8 @@ public:\n> >\n> > ~RPiCameraData()\n> > {\n> > - freeBuffers();\n> > + if (buffersAllocated_)\n> > + freeBuffers();\n> > }\n> >\n> > void freeBuffers();\n> > --\n> > 2.25.1\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA838BD16B\n\tfor ;\n\tFri, 28 Oct 2022 13:49:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E37962FEA;\n\tFri, 28 Oct 2022 15:49:22 +0200 (CEST)","from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com\n\t[IPv6:2607:f8b0:4864:20::82d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6446361F4A\n\tfor ;\n\tFri, 28 Oct 2022 15:49:20 +0200 (CEST)","by mail-qt1-x82d.google.com with SMTP id bb5so3442358qtb.11\n\tfor ;\n\tFri, 28 Oct 2022 06:49:20 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666964962;\n\tbh=iDa4U6HYhN8hQSM9nsuOY1Ezz4KCiJVHXJ+fRF+HRSM=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=N3s2O8J0CwRWhA6nUFJh854uFKG2MSS0xLxNp2qonc+o0OzEzatfUNBH+nP2pL7w3\n\tG7wm+SpCHuNscvOqk0Q9eGXX3pll1LP8z2uTrrrx9jqDCpiUVjuwEFD5tf2nXLLlgi\n\t1fwKnIRVF5IUSQEk8zR2InwIOETKk6H6qp8Ybb5z7F4qoZdqynzJQYHjYwXqBg4KZ0\n\tWalJuezfQUYv7J1ziNKVx/7+xOvOEsIJ1ODN1nmak5FPKT57fWAM0nTKqIzJLksyJy\n\tsyOL2kuygA3mI9N1VkG+Oc9sOZiUsesDwV6ZJqWbuGqi1z0aBSMansxhH25Ilcw4T+\n\tvBAbFWLxdbPxg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=oXC7fAP6JaquZrGgiKCaM1H7CJSnDgtuvGtntBeytsA=;\n\tb=JXYBELgkZ8wSZrioB31F1lP84QM9Vv3cJFgE0C8cJz8JZofF8vnRZ0PvKw4FGZUEwg\n\tvPYcB2gsh84QHKO9cKwI3qRRJehaFf4gSkET9EzQAH0dI1elMQCKD3tHeGVB3FjJMp9e\n\tj06b6YGsc0oH08cf8+wa/U8CWKks1j6t3NIKcFZFyMEWDhFAdQ3MesNK2JnxmBeyLgMn\n\tqVpBi0PJzXrDxO7e2pIKI2lbe+AXhbMwFmRoMQx9ZZZBvEb/Zm9CrX2q6dfEczrrFoas\n\tPML4q3S1W70qTQYVpAb5HpN/9wSmTRqzVzbMFNZ9TZ72BzydyGSZNfZiuSmB6eLt7iSc\n\tjvGg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"JXYBELgk\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=oXC7fAP6JaquZrGgiKCaM1H7CJSnDgtuvGtntBeytsA=;\n\tb=N2R/fD9qR4Y+WWv6z3hVZv3PdCV/kqQz+coHCGq4t/09OxhSq1SvrqqWh5vHeDDEw/\n\tF0qxV24Gu7rIV68f4j1+mIP73yQT0g6PTg9pkhlnG3iqjECv2+DCDbYzvH/gvOfxZu42\n\tYNSGdC/pjTVxy0XF9FIGuTSVWyzp5weHcMU/g4qo2vcv3c87jwGWjA8S7mVjyuQSoRND\n\tnbVXpgZoPKI6/4XAIVDYmAY9Z5cJOzJ2m+CZHLlIkU+R3ZMvmkZKCeDbssEyOb4CiaNG\n\tCYu6+bxxVaD37x2RQycjumGlyYFKkGVVsA+tpkK+pBembPTQW+ye4um6czwcq3unqO5H\n\t9aSQ==","X-Gm-Message-State":"ACrzQf055SiiY1XSbP1+nG75orSBC8qEuhHaniRu+d+DUyz+G6x8Hqzh\n\tQLHPBVtpDqJJp/pwaZ+E8SDPWfzbfSjMKev3RFMexr28m0Q=","X-Google-Smtp-Source":"AMsMyM4O/Iddnq2aOPT2lOCsxgDejYHDgi+Vd6FNE9MYuPEBQFcIy5Zqzl4mk9CIpc6agqmggxKTd3rDIXj3joEkdEQ=","X-Received":"by 2002:ac8:5a83:0:b0:39c:e110:c05b with SMTP id\n\tc3-20020ac85a83000000b0039ce110c05bmr46466691qtc.156.1666964959357;\n\tFri, 28 Oct 2022 06:49:19 -0700 (PDT)","MIME-Version":"1.0","References":"<20221028115200.8138-1-naush@raspberrypi.com>\n\t<20221028115200.8138-3-naush@raspberrypi.com>\n\t<166696475694.15935.4307213973768725716@Monstersaurus>","In-Reply-To":"<166696475694.15935.4307213973768725716@Monstersaurus>","Date":"Fri, 28 Oct 2022 14:49:03 +0100","Message-ID":"","To":"Kieran Bingham ","Content-Type":"multipart/alternative; boundary=\"00000000000041815905ec18864c\"","Subject":"Re: [libcamera-devel] [PATCH v1 2/2] pipeline: raspberrypi: Do not\n\tunconditionally free buffers on close","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]