[{"id":25652,"web_url":"https://patchwork.libcamera.org/comment/25652/","msgid":"<166695303435.3974115.16121126827431669604@Monstersaurus>","date":"2022-10-28T10:30:34","subject":"Re: [libcamera-devel] [PATCH v5 07/10] libcamera: make libdl\n\toptional when provided","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Nicholas Roth via libcamera-devel (2022-10-28 04:17:23)\n> From: Nicholas Roth \n> \n> Currently, libdl is always required. Sometimes, the C++ runtime includes\n> a dynamic loader, which is the case for Android. Additionally, Android\n> 11 does not have libdl. This fix allows libcamera to build on Android.\n> \n> Signed-off-by: Nicholas Roth \n\nThis is fine with me:\n\n\nReviewed-by: Kieran Bingham \n\n\nAnd from Jacopo on an earlier version:\n\nReviewed-by: Jacopo Mondi \n\n> ---\n> src/libcamera/meson.build | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 5f39d2e2..0494e808 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -65,7 +65,12 @@ subdir('ipa')\n> subdir('pipeline')\n> subdir('proxy')\n> \n> -libdl = cc.find_library('dl')\n> +null_dep = dependency('', required : false)\n> +\n> +libdl = null_dep\n> +if not cc.has_function('dlopen')\n> + libdl = cc.find_library('dl')\n> +endif\n> libudev = dependency('libudev', required : false)\n> libyaml = dependency('yaml-0.1', required : false)\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D412BD16B\n\tfor ;\n\tFri, 28 Oct 2022 10:30:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BCD961F4A;\n\tFri, 28 Oct 2022 12:30:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D10661F4A\n\tfor ;\n\tFri, 28 Oct 2022 12:30:36 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CC126BE;\n\tFri, 28 Oct 2022 12:30:36 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666953038;\n\tbh=kOE10F3a5NZpF18Ug7oCveDYLp1BmhRSKsTpDNMScLY=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ScIhxeW8kxsbcczGAs657LOWAtSEu/MKgsFewIEPqMRdli22dcYhW9pDD2Z+zS0eB\n\t/6TlEc19YS3RACX56Z1Ud6VMoO9HQmL59TVRGQRvrLupWduyv7vNHzil6QkkiEJe6A\n\tDOQShEW2qRGU0UMOeEh3L89RuL1sa5n1NqHCXTYG/CeuJbjM+ejBfFxAi1gRJSfk+B\n\tWgGgbCMOktyOtNSgzXwuO7ZzkJRogrdgDZm2iPQ3BXvq2vLIMhaJKw14blxc9NEqLI\n\tCyN5D0vIhfscO0iY2t6QvEIoQHSRibADHCQ/4LeJvbjJYhW76PlE+LpDt9fHQN5IkM\n\tX41JI6rZl4H5g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666953036;\n\tbh=kOE10F3a5NZpF18Ug7oCveDYLp1BmhRSKsTpDNMScLY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=cQPLcBJwWCMGcBAOyMpPGNTmJT2b+ZA5zKo5Iaxp62t0o1BXBfo78DJcJywx81afo\n\t4YRasXsMdGhz6U0ZzWp0LGnaZoUBsyikD5aNlcIzL0Ep+/dSppsp0Si+74t4mjg3RM\n\tPIDYipqaSk0+bn9NNE6LOXwkGPQ27IQe83XABhmI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cQPLcBJw\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221028031726.4849-8-nicholas@rothemail.net>","References":"<20221027224135.348115-1-nicholas@rothemail.net>\n\t<20221028031726.4849-1-nicholas@rothemail.net>\n\t<20221028031726.4849-8-nicholas@rothemail.net>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 28 Oct 2022 11:30:34 +0100","Message-ID":"<166695303435.3974115.16121126827431669604@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v5 07/10] libcamera: make libdl\n\toptional when provided","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"nicholas@rothemail.net","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]