{"id":17714,"url":"https://patchwork.libcamera.org/api/patches/17714/?format=json","web_url":"https://patchwork.libcamera.org/patch/17714/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221028031726.4849-3-nicholas@rothemail.net>","date":"2022-10-28T03:17:18","name":"[libcamera-devel,v5,02/10] ipa: add missing thread-safety annotations","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"be333057b7218ae3f599e181a7a22692226e737e","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/?format=json","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17714/mbox/","series":[{"id":3583,"url":"https://patchwork.libcamera.org/api/series/3583/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3583","date":"2022-10-28T03:17:17","name":"[libcamera-devel,v5,01/10] ipa: workaround libcxx duration limitation","version":5,"mbox":"https://patchwork.libcamera.org/series/3583/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17714/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17714/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A943CC3285\n\tfor ;\n\tFri, 28 Oct 2022 03:17:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4767F62FC0;\n\tFri, 28 Oct 2022 05:17:37 +0200 (CEST)","from mail-oa1-x29.google.com (mail-oa1-x29.google.com\n\t[IPv6:2001:4860:4864:20::29])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7AB662FA5\n\tfor ;\n\tFri, 28 Oct 2022 05:17:32 +0200 (CEST)","by mail-oa1-x29.google.com with SMTP id\n\t586e51a60fabf-13ba9a4430cso4960140fac.11\n\tfor ;\n\tThu, 27 Oct 2022 20:17:32 -0700 (PDT)","from nroth-pc.attlocal.net\n\t([2600:1700:20:20c0:293a:90ce:6463:244d])\n\tby smtp.gmail.com with ESMTPSA id\n\tfp19-20020a056870659300b0013626c1a5f6sm1527738oab.10.2022.10.27.20.17.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 27 Oct 2022 20:17:30 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666927057;\n\tbh=17Ukq0I3hqoas+gx0WV6KuuhC12XYREv+g1mUc9xNoQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0V6cMTJvK7a82Kiu67QpdRe9ZNe0/KQgU+Yrx+00HKdihUwNcPoTBETzNDfLp2W7J\n\tXCc+ZSCLaPqYIRA/5ZuSIj+VNOngxVQ5CTaFg7K3FkU6+XfmjYyV4YerwSfcPLrMz6\n\tn0A9VTez1pgXt5oWyxyqEw+701PkqclDYn63gexd2y4gY1dYDOHSdQWV427uyN+W15\n\tcVWbaSaFPLnUy1z1p5D0V/06QBAmiTcnN572UMnR7NYGg6FknX3N0lmIxnsrZRZSrl\n\t1qheggzINI7UOBbTZmtFyZ15PW2Bc72+YuwFZANKn9fYFWm1tKxjFZUPI3IRKoaBi8\n\tboj2floaf5LiQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=1mfxtU8lTzXIpkx/hUjfyntGA0NGDWGeGZDezQGJzxA=;\n\tb=B+2oZXzpxfR3KvDIsb26hBjGDCnit7CK7p5Hn8satZesWBzO1aFioGZhZFeKRKl9MH\n\tkmS5zTEHUsZ0NVtz7kwmhWrKt0A+0TF6h9Qj0RedzJ0DcETEkvQ7mM06mts7bkdgbn9V\n\tYGU9FK2Sn4AGtzz92x0+mww81TX8/Ktmd8hUkwXq7hJGw78MpnVOJRc9hnuiE0ALy1r1\n\tOMAzbYIDWvYkjprakLi4I+QwyDzkJXM1DnzoviLEvwTHqDd8OvfAAmnDiIICzhOmWDFi\n\tSl62e9AdzA7JmpmGhtZh5wNXZVGCM3BRm1/hChuKUJE84PYoJjGAmqgU21S55HMg9aiq\n\tZl7g=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"B+2oZXzp\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=1mfxtU8lTzXIpkx/hUjfyntGA0NGDWGeGZDezQGJzxA=;\n\tb=QsJAXrZxgyQuaF+lkYaIlFHNuXdPzDGgFh0CowfKzebjKbhliiyn3TUskd4WYR7HZt\n\taVURCAcecu8DGQx5FPadqL1KuhjVijXxdAUkak7/EAlCs1qDTD1aoFJ2gGDe0has9CCb\n\tO/1jGXjnyEQOZjsMfx9sO11DKLS9jQLjC2V60ISINerSOZjs3qbCMaD1T19/wybVwN6r\n\tPmz0KgU5LFX/itOMxemTmLX8r3qI0NAT9Zr2xxTE5RMOaRAhi83p1r8WWLlOkLsii/2P\n\tmBfK/zU14VNiPu040FwP20TDRw57pzJ6Y+fYo7b/SHaN6NSIcJdkge8whsTsgNmlKS5B\n\tofyQ==","X-Gm-Message-State":"ACrzQf2Qbhscx5u3XShOIFH1DqFaZsSOTe5C7P4fKwCh8kCMOIwgcdJ5\n\tHdesbws7vhcluno69uNq8mLaMymZnfJJ55kmHWA=","X-Google-Smtp-Source":"AMsMyM5smXSmKBb8eosTavUrHi/j0tmtR29zuLt7/QwcYbRsG1ualyN+WuL5eWuYxiiBwMRNyawAZA==","X-Received":"by 2002:a05:6871:b2b:b0:13b:6c86:2f40 with SMTP id\n\tfq43-20020a0568710b2b00b0013b6c862f40mr7722202oab.51.1666927051157; \n\tThu, 27 Oct 2022 20:17:31 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 27 Oct 2022 22:17:18 -0500","Message-Id":"<20221028031726.4849-3-nicholas@rothemail.net>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20221028031726.4849-1-nicholas@rothemail.net>","References":"<20221027224135.348115-1-nicholas@rothemail.net>\n\t<20221028031726.4849-1-nicholas@rothemail.net>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 02/10] ipa: add missing thread-safety\n\tannotations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicholas Roth via libcamera-devel ","Reply-To":"libcamera-devel@lists.libcamera.org","Cc":"nicholas@rothemail.net","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Nicholas Roth \n\nThe raspberrypi IPA is missing thread-safety annotations, which breaks\nthe build.\n\nAdd required thread-safety annotations.\n\n../src/ipa/raspberrypi/controller/metadata.h:108:31: error: mutex\n 'mutex_' is still held at the end of function [-Werror,-Wthread-safety-analysis]\n void lock() { mutex_.lock(); }\n ^\n../src/ipa/raspberrypi/controller/metadata.h:108:23: note: mutex\n acquired here\n void lock() { mutex_.lock(); }\n ^\n../src/ipa/raspberrypi/controller/metadata.h:109:25: error: releasing\n mutex 'mutex_' that was not held [-Werror,-Wthread-safety-analysis]\n void unlock() { mutex_.unlock(); }\n ^\n\nSigned-off-by: Nicholas Roth \n---\n src/ipa/raspberrypi/controller/metadata.h | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/metadata.h b/src/ipa/raspberrypi/controller/metadata.h\nindex 0f7ebfaf..870b6e26 100644\n--- a/src/ipa/raspberrypi/controller/metadata.h\n+++ b/src/ipa/raspberrypi/controller/metadata.h\n@@ -13,9 +13,11 @@\n #include \n #include \n \n+#include \n+\n namespace RPiController {\n \n-class Metadata\n+class LIBCAMERA_TSA_CAPABILITY(\"mutex\") Metadata\n {\n public:\n \tMetadata() = default;\n@@ -103,8 +105,8 @@ public:\n \t * locks with the standard lock classes.\n \t * e.g. std::lock_guard lock(metadata)\n \t */\n-\tvoid lock() { mutex_.lock(); }\n-\tvoid unlock() { mutex_.unlock(); }\n+\tvoid lock() LIBCAMERA_TSA_ACQUIRE() { mutex_.lock(); }\n+\tvoid unlock() LIBCAMERA_TSA_RELEASE() { mutex_.unlock(); }\n \n private:\n \tmutable std::mutex mutex_;\n","prefixes":["libcamera-devel","v5","02/10"]}