[{"id":25628,"web_url":"https://patchwork.libcamera.org/comment/25628/","msgid":"<20221027164647.dhqkmoztsla4ihmr@uno.localdomain>","date":"2022-10-27T16:46:47","subject":"Re: [libcamera-devel] [PATCH 07/10] libcamera: make libdl optional\n\twhen provided","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Nicholas\n\nOn Thu, Oct 27, 2022 at 12:55:12AM -0500, Nicholas Roth via libcamera-devel wrote:\n> From: Nicholas Roth \n>\n> Currently, libdl is always required. Sometimes, the C++ runtime includes\n> a dynamic loader, which is the case for Android. Additionally, Android\n> 11 does not have libdl. This fix allows libcamera to build on Android.\n>\n> Signed-off-by: Nicholas Roth \n\nI'm not the best person to comment on build-system related issues, but\nthis seems ok to me\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/meson.build | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 5f39d2e2..0494e808 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -65,7 +65,12 @@ subdir('ipa')\n> subdir('pipeline')\n> subdir('proxy')\n>\n> -libdl = cc.find_library('dl')\n> +null_dep = dependency('', required : false)\n> +\n> +libdl = null_dep\n> +if not cc.has_function('dlopen')\n> + libdl = cc.find_library('dl')\n> +endif\n> libudev = dependency('libudev', required : false)\n> libyaml = dependency('yaml-0.1', required : false)\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4683ABD16B\n\tfor ;\n\tThu, 27 Oct 2022 16:46:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9168262F9C;\n\tThu, 27 Oct 2022 18:46:54 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::224])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A58C562F89\n\tfor ;\n\tThu, 27 Oct 2022 18:46:53 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id ED718E0004;\n\tThu, 27 Oct 2022 16:46:51 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666889214;\n\tbh=wJDaeBx3xqAOQut6Kzcb9vrprtRq3YZ5Gl761PL9FNQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=GMOq4yQZh9AMvth1HVIj3WLwZgioiBLvKYn8xT3PJfive83d2S+QgozsfCAzIgRXg\n\tI8KibKNpvisImp6IUn6aJYelPF3TAYyB3jc33uFHSbxniUEjkzm4zN5dqQPhWSdoOp\n\tVfLdeJW06AKc4BSkfFCxi8WtzKNHEYt2zqEoYrsq9ssN7j/A3OWN6cmsNMzBlKK9WZ\n\t/JHyEA4EnBxbSs00wKBBriT8Q8tzy9y1L31jaPAo5xjXSQA5LF0vep+NObOkOlRTNc\n\tS5cBgO3x+3c8EX4c/J5KHKdVdrFSpJlMuf+9ugoTaVHukHV/V1pKMnRNuwLttpFvYH\n\tfwOA2LlSDbRyg==","Date":"Thu, 27 Oct 2022 18:46:47 +0200","To":"Nicholas Roth via libcamera-devel ","Message-ID":"<20221027164647.dhqkmoztsla4ihmr@uno.localdomain>","References":"\n\t<20221027055515.321791-1-nicholas@rothemail.net>\n\t<20221027055515.321791-8-nicholas@rothemail.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221027055515.321791-8-nicholas@rothemail.net>","Subject":"Re: [libcamera-devel] [PATCH 07/10] libcamera: make libdl optional\n\twhen provided","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"nicholas@rothemail.net","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]