[{"id":25543,"web_url":"https://patchwork.libcamera.org/comment/25543/","msgid":"<166661179900.2560709.15928262106168148540@Monstersaurus>","date":"2022-10-24T11:43:19","subject":"Re: [libcamera-devel] [PATCH] apps: cam: Fix compilation error with\n\tclang when libtiff-4 is not found","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-10-24 11:46:38)\n> When libtiff-4 is not found, the private camera_ member of the FileSink\n> class is set but never used. This causes a compilation error with clang:\n> \n> In file included from ../../src/apps/cam/file_sink.cpp:19:\n> ../../src/apps/cam/file_sink.h:39:27: error: private field 'camera_' is not used [-Werror,-Wunused-private-field]\n> const libcamera::Camera *camera_;\n> \n> Fix by making the camera_ member field conditional on HAVE_TIFF.\n\nUgh, this feels like an ugly fix. I hate it when compiler warnings\n(which I want to keep enabled) work against us like this.\n\n\nAny other proposal is probably just a different ugly workaround on an\nunused arg so lets fix the build and ...\n\nAcked-by: Kieran Bingham \n\n> \n> Fixes: 6404b163bcbb (\"cam: file_sink: Add support for DNG output\")\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/apps/cam/file_sink.cpp | 8 ++++++--\n> src/apps/cam/file_sink.h | 2 ++\n> 2 files changed, 8 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/apps/cam/file_sink.cpp b/src/apps/cam/file_sink.cpp\n> index 9d60c04e1cf4..4dfacc103c54 100644\n> --- a/src/apps/cam/file_sink.cpp\n> +++ b/src/apps/cam/file_sink.cpp\n> @@ -21,10 +21,14 @@\n> \n> using namespace libcamera;\n> \n> -FileSink::FileSink(const libcamera::Camera *camera,\n> +FileSink::FileSink([[maybe_unused]] const libcamera::Camera *camera,\n> const std::map &streamNames,\n> const std::string &pattern)\n> - : camera_(camera), streamNames_(streamNames), pattern_(pattern)\n> + :\n> +#ifdef HAVE_TIFF\n> + camera_(camera),\n> +#endif\n> + streamNames_(streamNames), pattern_(pattern)\n> {\n> }\n> \n> diff --git a/src/apps/cam/file_sink.h b/src/apps/cam/file_sink.h\n> index 9ce8b619f69d..300edf8dc902 100644\n> --- a/src/apps/cam/file_sink.h\n> +++ b/src/apps/cam/file_sink.h\n> @@ -36,7 +36,9 @@ private:\n> libcamera::FrameBuffer *buffer,\n> const libcamera::ControlList &metadata);\n> \n> +#ifdef HAVE_TIFF\n> const libcamera::Camera *camera_;\n> +#endif\n> std::map streamNames_;\n> std::string pattern_;\n> std::map> mappedBuffers_;\n> \n> base-commit: 24f8ef763a60f410963fd8897a16ae077aaeff0d\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADD4ABDB16\n\tfor ;\n\tMon, 24 Oct 2022 11:43:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3DC262F16;\n\tMon, 24 Oct 2022 13:43:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3341662EC6\n\tfor ;\n\tMon, 24 Oct 2022 13:43:22 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6AE8471;\n\tMon, 24 Oct 2022 13:43:21 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666611804;\n\tbh=iWDCs3n8J0hUQWSShylXaLpcCpIyZGWXL1Va6mAuDm8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=yUJxU0YYR1cgYrUx1uutfJbOAvXPyX33b2vOiDBDphFydAzAgOxNoJauIqWRoIZmC\n\tVHSteYnYMzctUAsCUMmdS+q6C98SwbvgS/p8TE/mBwnCqNAiv4uk35VpUQNs2ltUDu\n\tMn00g0Z+AT2ZMwNxCHxa5t4A5wrstfk5ZisomcJHYGr0ghkvrd2ZqfEluGxgTD0ovV\n\twXlln2O9jntVNv2Ktvjzk5mdFdHeogdpAktW7VYvdP8lA9UYZcBsT+rHSf77Yzr3h2\n\tNQdfipXMR2Seiswo2lxvPezZtIiio0xOSE9SsZvg+5ZiwI2tx38GhI2d6GAvYVnN6H\n\tuTefQsxXNATvw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666611801;\n\tbh=iWDCs3n8J0hUQWSShylXaLpcCpIyZGWXL1Va6mAuDm8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=k24zCOPWlSNIejdtmhTe1hggqihBn9Nu+A/Ta/UNWfl9LF9tDstzlte90UrJG1YFU\n\tSgS/kc5vJ2XO+7Us9GnqVt55tiZMnYyD2lSzvc3ToEL761YKE9Nst9Uub0sX18crHP\n\tkZgdJCtJ2Sjupr/lboFY3Suv//ZA9qVWWxogSMTU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"k24zCOPW\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221024104638.1031-1-laurent.pinchart@ideasonboard.com>","References":"<20221024104638.1031-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 24 Oct 2022 12:43:19 +0100","Message-ID":"<166661179900.2560709.15928262106168148540@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] apps: cam: Fix compilation error with\n\tclang when libtiff-4 is not found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25544,"web_url":"https://patchwork.libcamera.org/comment/25544/","msgid":"","date":"2022-10-24T13:18:53","subject":"Re: [libcamera-devel] [PATCH] apps: cam: Fix compilation error with\n\tclang when libtiff-4 is not found","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Oct 24, 2022 at 12:43:19PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-10-24 11:46:38)\n> > When libtiff-4 is not found, the private camera_ member of the FileSink\n> > class is set but never used. This causes a compilation error with clang:\n> > \n> > In file included from ../../src/apps/cam/file_sink.cpp:19:\n> > ../../src/apps/cam/file_sink.h:39:27: error: private field 'camera_' is not used [-Werror,-Wunused-private-field]\n> > const libcamera::Camera *camera_;\n> > \n> > Fix by making the camera_ member field conditional on HAVE_TIFF.\n> \n> Ugh, this feels like an ugly fix. I hate it when compiler warnings\n> (which I want to keep enabled) work against us like this.\n\nI tried\n\n\t[[maybe_unused]] const libcamera::Camera *camera_;\n\nit made clang happy, but gcc choke on it, telling the attribute was\nignored. I Gave up :-)\n\n> Any other proposal is probably just a different ugly workaround on an\n> unused arg so lets fix the build and ...\n> \n> Acked-by: Kieran Bingham \n> \n> > \n> > Fixes: 6404b163bcbb (\"cam: file_sink: Add support for DNG output\")\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/apps/cam/file_sink.cpp | 8 ++++++--\n> > src/apps/cam/file_sink.h | 2 ++\n> > 2 files changed, 8 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/apps/cam/file_sink.cpp b/src/apps/cam/file_sink.cpp\n> > index 9d60c04e1cf4..4dfacc103c54 100644\n> > --- a/src/apps/cam/file_sink.cpp\n> > +++ b/src/apps/cam/file_sink.cpp\n> > @@ -21,10 +21,14 @@\n> > \n> > using namespace libcamera;\n> > \n> > -FileSink::FileSink(const libcamera::Camera *camera,\n> > +FileSink::FileSink([[maybe_unused]] const libcamera::Camera *camera,\n> > const std::map &streamNames,\n> > const std::string &pattern)\n> > - : camera_(camera), streamNames_(streamNames), pattern_(pattern)\n> > + :\n> > +#ifdef HAVE_TIFF\n> > + camera_(camera),\n> > +#endif\n> > + streamNames_(streamNames), pattern_(pattern)\n> > {\n> > }\n> > \n> > diff --git a/src/apps/cam/file_sink.h b/src/apps/cam/file_sink.h\n> > index 9ce8b619f69d..300edf8dc902 100644\n> > --- a/src/apps/cam/file_sink.h\n> > +++ b/src/apps/cam/file_sink.h\n> > @@ -36,7 +36,9 @@ private:\n> > libcamera::FrameBuffer *buffer,\n> > const libcamera::ControlList &metadata);\n> > \n> > +#ifdef HAVE_TIFF\n> > const libcamera::Camera *camera_;\n> > +#endif\n> > std::map streamNames_;\n> > std::string pattern_;\n> > std::map> mappedBuffers_;\n> > \n> > base-commit: 24f8ef763a60f410963fd8897a16ae077aaeff0d","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 156C9BD16B\n\tfor ;\n\tMon, 24 Oct 2022 13:19:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CAF362F16;\n\tMon, 24 Oct 2022 15:19:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 922E362EC6\n\tfor ;\n\tMon, 24 Oct 2022 15:19:19 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F20838BF;\n\tMon, 24 Oct 2022 15:19:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666617561;\n\tbh=ewL3OGQ9xKNwHSOqX/ODgCXbsQRym248lCvt3LPPllc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=q0OzLO92Dl5+CR41P1AySlxTmpQ1ghSKsIyItZq53PCtKxDHozsOuuIFywpGEBocd\n\t/B8gADhLuXGHynLlryDmFCqXtcRu6b8Vw7HMWKlKeByWZXjT1dKlV/CIoh0DwScQEb\n\tqYrIONd44oyIagpwxmN+Wd7Sb+GJeY8vSiWQj8tZ9eQMfmIjydIAzFijXdzrvHj4xI\n\tCdzzCJ06XPMJUigdoI+M6zsNwo9WmqnDnfneYCH2pnXfJabAenC0X2N9ZsiNqCGom4\n\tPLgp4P8GYtDQntPeUUXBV3o1ILj+nNJwNcAyCoti82MBb/UaSXLMrwFcDs29w6dnf4\n\tmz4/XZAYs+mUQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666617559;\n\tbh=ewL3OGQ9xKNwHSOqX/ODgCXbsQRym248lCvt3LPPllc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=u1w52pBPf34baZ3UsrCkLFXR7pCNLih8OKLl6jEfSjdS0INSuylFuIu2pp3Sy1S5a\n\t39mQAjPCnyPH4NJAPZwfTTAZg0rIftSvPiqkxa6fPTwcnXDIclbYnQy5OKvJP8T9nx\n\tK8sUnBpbLvrc/yDVOMGNQ8UGyb6/mqEFih5gCIiw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"u1w52pBP\"; dkim-atps=neutral","Date":"Mon, 24 Oct 2022 16:18:53 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20221024104638.1031-1-laurent.pinchart@ideasonboard.com>\n\t<166661179900.2560709.15928262106168148540@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166661179900.2560709.15928262106168148540@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] apps: cam: Fix compilation error with\n\tclang when libtiff-4 is not found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]