{"id":17688,"url":"https://patchwork.libcamera.org/api/patches/17688/?format=json","web_url":"https://patchwork.libcamera.org/patch/17688/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221024104638.1031-1-laurent.pinchart@ideasonboard.com>","date":"2022-10-24T10:46:38","name":"[libcamera-devel] apps: cam: Fix compilation error with clang when libtiff-4 is not found","commit_ref":"dac1a0549a27b72993e22f273ae05050a13c69a8","pull_url":null,"state":"accepted","archived":false,"hash":"d4e2f574d5bcb1e108a90b5bd0ab8220c047a1f0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17688/mbox/","series":[{"id":3576,"url":"https://patchwork.libcamera.org/api/series/3576/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3576","date":"2022-10-24T10:46:38","name":"[libcamera-devel] apps: cam: Fix compilation error with clang when libtiff-4 is not found","version":1,"mbox":"https://patchwork.libcamera.org/series/3576/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17688/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17688/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE72ABDB16\n\tfor ;\n\tMon, 24 Oct 2022 10:47:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAEA762F13;\n\tMon, 24 Oct 2022 12:47:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E38FD62EC6\n\tfor ;\n\tMon, 24 Oct 2022 12:47:03 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62E3F471\n\tfor ;\n\tMon, 24 Oct 2022 12:47:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666608426;\n\tbh=EiODlsPQxXHvEOcHPrX9m/Q/SkGXr/sHmiHCo/rcX0U=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=TRMcYaeVZkpCpmObRjd3jmWgS+CizIV4wm8Wdx8gsXSAUx2MVsVyB3VBgo7f38j3i\n\tjPv6K9B7EH+rf8ud4m+l+6SHcupi4AVKVkBOMjMTYXoyUySECF9AlSWnGSKV3npVtE\n\tGJt8A6Or5iEKi+va0Ur2kmD1NSILXowrQtyDgGIZApc5mk0YtyBpgxXSngX4G3oqCR\n\tRDeCndFbeuDDs/s9GG1tyY3DRMsjSFDTx4xILjhwsyqIKwNuyEI11T6T9v8fYg+2Bx\n\t+D3Ns3LIBFYqPl2aw7nfsj+Ww56Zw6XUQi5RSFle86tpqxjAjEQgE5VYKxtGUcFsS7\n\ta8RT9Zy3dFn3w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666608423;\n\tbh=EiODlsPQxXHvEOcHPrX9m/Q/SkGXr/sHmiHCo/rcX0U=;\n\th=From:To:Subject:Date:From;\n\tb=iRhHR1t2191FY3f2teUlCnnz3t0pjMFiHoZuRIrawX4uGAF0ADT2U47O+QD93O//e\n\teP2XJSKe/NtEeVLdF3YsSeRcEAR+JLaLQD+9tyGm7JAQaQiHTU2vvx5gSWPPOgpVeh\n\th+LfQfywLb39Qt5VAgChpqUmjFrfBx6O7GtrR9ZE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"iRhHR1t2\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 24 Oct 2022 13:46:38 +0300","Message-Id":"<20221024104638.1031-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.37.4","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] apps: cam: Fix compilation error with\n\tclang when libtiff-4 is not found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When libtiff-4 is not found, the private camera_ member of the FileSink\nclass is set but never used. This causes a compilation error with clang:\n\nIn file included from ../../src/apps/cam/file_sink.cpp:19:\n../../src/apps/cam/file_sink.h:39:27: error: private field 'camera_' is not used [-Werror,-Wunused-private-field]\n const libcamera::Camera *camera_;\n\nFix by making the camera_ member field conditional on HAVE_TIFF.\n\nFixes: 6404b163bcbb (\"cam: file_sink: Add support for DNG output\")\nSigned-off-by: Laurent Pinchart \n---\n src/apps/cam/file_sink.cpp | 8 ++++++--\n src/apps/cam/file_sink.h | 2 ++\n 2 files changed, 8 insertions(+), 2 deletions(-)\n\n\nbase-commit: 24f8ef763a60f410963fd8897a16ae077aaeff0d","diff":"diff --git a/src/apps/cam/file_sink.cpp b/src/apps/cam/file_sink.cpp\nindex 9d60c04e1cf4..4dfacc103c54 100644\n--- a/src/apps/cam/file_sink.cpp\n+++ b/src/apps/cam/file_sink.cpp\n@@ -21,10 +21,14 @@\n \n using namespace libcamera;\n \n-FileSink::FileSink(const libcamera::Camera *camera,\n+FileSink::FileSink([[maybe_unused]] const libcamera::Camera *camera,\n \t\t const std::map &streamNames,\n \t\t const std::string &pattern)\n-\t: camera_(camera), streamNames_(streamNames), pattern_(pattern)\n+\t:\n+#ifdef HAVE_TIFF\n+\t camera_(camera),\n+#endif\n+\t streamNames_(streamNames), pattern_(pattern)\n {\n }\n \ndiff --git a/src/apps/cam/file_sink.h b/src/apps/cam/file_sink.h\nindex 9ce8b619f69d..300edf8dc902 100644\n--- a/src/apps/cam/file_sink.h\n+++ b/src/apps/cam/file_sink.h\n@@ -36,7 +36,9 @@ private:\n \t\t\t libcamera::FrameBuffer *buffer,\n \t\t\t const libcamera::ControlList &metadata);\n \n+#ifdef HAVE_TIFF\n \tconst libcamera::Camera *camera_;\n+#endif\n \tstd::map streamNames_;\n \tstd::string pattern_;\n \tstd::map> mappedBuffers_;\n","prefixes":["libcamera-devel"]}