[{"id":25561,"web_url":"https://patchwork.libcamera.org/comment/25561/","msgid":"","date":"2022-10-24T23:49:25","subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicholas,\n\nThank you for the patch.\n\nOn Mon, Oct 24, 2022 at 12:55:35AM -0500, Nicholas Roth via libcamera-devel wrote:\n> From: Nicholas Roth \n> \n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index ba3c547e..c536852c 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -100,6 +100,13 @@ const ControlInfoMap::Map rkisp1Controls{\n> \t{ &controls::Contrast, ControlInfo(0.0f, 1.993f) },\n> \t{ &controls::Saturation, ControlInfo(0.0f, 1.993f) },\n> \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n> +\t/* libcamera requires a fixed value for minimum frame duration,\n> +\t * but this depends on the frame size and the rkisp1 device datasheets\n> +\t * measure this in pixels per second. Neither the datasheets nor the driver\n> +\t * specify a maximum. The minimum below is for 1920x1920. The maximum\n> +\t * corresponds to two seconds. */\n> +\t{ &controls::FrameDurationLimits, ControlInfo(48505, 2000000) },\n\nCould this be computed the same way we do it in the IPU3 IPA module ?\n\n> +\t{ &controls::draft::MaxLatency, ControlInfo(0) },\n\nWhy is this needed ?\n\n> \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB5A5BD16B\n\tfor ;\n\tMon, 24 Oct 2022 23:49:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C31F62F28;\n\tTue, 25 Oct 2022 01:49:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F67162EAE\n\tfor ;\n\tTue, 25 Oct 2022 01:49:51 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6CCCD3C;\n\tTue, 25 Oct 2022 01:49:50 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666655393;\n\tbh=1eQ2iKVPE4/Zf6bhJ6CiyEm5vWOIwSI1ef+rSnl7gEI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rF42YaY/8P5p098ILEIAMLcjOpwZ0njZUA/dODfGHGh2LMlSaiGT0Fx2SE9PuLf9K\n\tFzrXnxQLTZwDDsqiO74qnakO9Hn3h7daurr5F+cJtD8O5M43r/+bmCy/9mFDh5LRpa\n\tdI+sVqOYpVqR9I6nucQLctTBfu4YUXLpdhgSuCpZy+0Ku2zTvQeEo4u27dTj/mGoNG\n\tkPkh/CeResu0uGXy4gQ92TxcB8uZKKeV1LsUCtHAGBhGRGnxCPv8HhCEODYEYdmWvj\n\tKDZuwLKqfgC6ChCgzeChC8I25vuuxZJmkY4MgasIXchMQWeFlaHocZsHSFSgEvA0oa\n\tfaovRsMROTNSQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666655390;\n\tbh=1eQ2iKVPE4/Zf6bhJ6CiyEm5vWOIwSI1ef+rSnl7gEI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QVomAr8BdYpEqIbEyLlgC+fQzTaUYlBvX+UbDIeNpI2mUGX5f069Hi1K7aS8BiVno\n\tcdD5FY+7snCt6DwnoswzDsCnxi5yRIE/fjAc0kfGf3DSN+ySHHoJFcQpuS9xA9FkJb\n\tG2WL5Btrp5rqZEc97255VZVMmAoZrouccr+B9xTE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QVomAr8B\"; dkim-atps=neutral","Date":"Tue, 25 Oct 2022 02:49:25 +0300","To":"Nicholas Roth via libcamera-devel ","Message-ID":"","References":"<20221024055543.116040-1-nicholas@rothemail.net>\n\t<20221024055543.116040-4-nicholas@rothemail.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221024055543.116040-4-nicholas@rothemail.net>","Subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"nicholas@rothemail.net","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25564,"web_url":"https://patchwork.libcamera.org/comment/25564/","msgid":"<20221025001322.GI3874866@pyrite.rasen.tech>","date":"2022-10-25T00:13:22","subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Tue, Oct 25, 2022 at 02:49:25AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Hi Nicholas,\n> \n> Thank you for the patch.\n> \n> On Mon, Oct 24, 2022 at 12:55:35AM -0500, Nicholas Roth via libcamera-devel wrote:\n> > From: Nicholas Roth \n> > \n> > ---\n> > src/ipa/rkisp1/rkisp1.cpp | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> > \n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index ba3c547e..c536852c 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -100,6 +100,13 @@ const ControlInfoMap::Map rkisp1Controls{\n> > \t{ &controls::Contrast, ControlInfo(0.0f, 1.993f) },\n> > \t{ &controls::Saturation, ControlInfo(0.0f, 1.993f) },\n> > \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n> > +\t/* libcamera requires a fixed value for minimum frame duration,\n> > +\t * but this depends on the frame size and the rkisp1 device datasheets\n> > +\t * measure this in pixels per second. Neither the datasheets nor the driver\n> > +\t * specify a maximum. The minimum below is for 1920x1920. The maximum\n> > +\t * corresponds to two seconds. */\n> > +\t{ &controls::FrameDurationLimits, ControlInfo(48505, 2000000) },\n> \n> Could this be computed the same way we do it in the IPU3 IPA module ?\n> \n> > +\t{ &controls::draft::MaxLatency, ControlInfo(0) },\n> \n> Why is this needed ?\n\nThis control looks familiar in the context of android...\n\niirc from the CTS FULL support ordeal, MaxLatency needs to be between 0\nand 4 inclusive for burst capture capability [1], which is required for\nFULL (but not LIMITED).\n\n\nPaul\n\n\n[1] https://developer.android.com/reference/android/hardware/camera2/CameraMetadata#REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE\n\n> > \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n> > };\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1EBD6BDB16\n\tfor ;\n\tTue, 25 Oct 2022 00:13:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6958262F2A;\n\tTue, 25 Oct 2022 02:13:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A603E62EAE\n\tfor ;\n\tTue, 25 Oct 2022 02:13:29 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD3208BF;\n\tTue, 25 Oct 2022 02:13:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666656811;\n\tbh=wcep3lfx5LIY+CE13vsRZGKn74BqeMD3n4PW2Kt82OA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1l+33T8XI4/UVJKncDMmIRCY6mBc7J4X89k2kpa4uNZ9yQHlxNaQKgsUo0Nv0V3PS\n\tZEs72pbVgTsxXPag96Zn9lomTQIK0EzQM0O8a4vlUz/uzy/InQu0sGxTo+6Hqp3ivA\n\th+x7JlJbZUSnlL9l5kdHUAJji/qrmrFc3DPo4NYrKWRiR2oRGg0l4o2vCsN/4uBSpy\n\t/BY0AfB0UMvvQfEYkMXdKSz+w2bIha7E34gkCvFiOC4O7yl65NbSK6C6htOV4XdvHm\n\tngf3tjSKXR3rte2qborLJIHeijn/DrBgHS/vRpKi6/6jK3RlbOfkEtR8rFpljNKPJD\n\tQ2aK7F8ckI9jw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666656809;\n\tbh=wcep3lfx5LIY+CE13vsRZGKn74BqeMD3n4PW2Kt82OA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vMCuU4bA6ToU3Uok+2a0oM5+QwuQIMD6FH672VXCLcSe5Ob3McOnrGvaXCxNw9Hbw\n\t54/SGeRTpTPYqIgDNuT7Cb2niPigZe+oLP7VUuFbWtCwS89PD7C1zmIFpiV0YarD9c\n\tpl3Qcacml3po9S2RNITRae1m6Jc04lqEFytpdESw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vMCuU4bA\"; dkim-atps=neutral","Date":"Tue, 25 Oct 2022 09:13:22 +0900","To":"Laurent Pinchart ","Message-ID":"<20221025001322.GI3874866@pyrite.rasen.tech>","References":"<20221024055543.116040-1-nicholas@rothemail.net>\n\t<20221024055543.116040-4-nicholas@rothemail.net>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"nicholas@rothemail.net, Nicholas Roth via libcamera-devel\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25580,"web_url":"https://patchwork.libcamera.org/comment/25580/","msgid":"<20221025131959.lkpdivenxu64tbef@uno.localdomain>","date":"2022-10-25T13:19:59","subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Tue, Oct 25, 2022 at 09:13:22AM +0900, Paul Elder via libcamera-devel wrote:\n> On Tue, Oct 25, 2022 at 02:49:25AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > Hi Nicholas,\n> >\n> > Thank you for the patch.\n> >\n> > On Mon, Oct 24, 2022 at 12:55:35AM -0500, Nicholas Roth via libcamera-devel wrote:\n> > > From: Nicholas Roth \n> > >\n> > > ---\n> > > src/ipa/rkisp1/rkisp1.cpp | 7 +++++++\n> > > 1 file changed, 7 insertions(+)\n> > >\n> > > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > > index ba3c547e..c536852c 100644\n> > > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > > @@ -100,6 +100,13 @@ const ControlInfoMap::Map rkisp1Controls{\n> > > \t{ &controls::Contrast, ControlInfo(0.0f, 1.993f) },\n> > > \t{ &controls::Saturation, ControlInfo(0.0f, 1.993f) },\n> > > \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n> > > +\t/* libcamera requires a fixed value for minimum frame duration,\n> > > +\t * but this depends on the frame size and the rkisp1 device datasheets\n> > > +\t * measure this in pixels per second. Neither the datasheets nor the driver\n> > > +\t * specify a maximum. The minimum below is for 1920x1920. The maximum\n> > > +\t * corresponds to two seconds. */\n> > > +\t{ &controls::FrameDurationLimits, ControlInfo(48505, 2000000) },\n> >\n> > Could this be computed the same way we do it in the IPU3 IPA module ?\n> >\n> > > +\t{ &controls::draft::MaxLatency, ControlInfo(0) },\n> >\n> > Why is this needed ?\n>\n> This control looks familiar in the context of android...\n>\n> iirc from the CTS FULL support ordeal, MaxLatency needs to be between 0\n> and 4 inclusive for burst capture capability [1], which is required for\n> FULL (but not LIMITED).\n>\n\nCareful, we're claiming full per-frame control capabilities with this\nset to 0 :)\n\n\"PER_FRAME_CONTROL (v3.2) 0 Every frame has the requests immediately\napplied. Changing controls over multiple requests one after another\nwill produce results that have those controls applied atomically each\nframe.\n\nAll FULL capability devices will have this as their maxLatency.\"\n\nI would leave it unspecified so that the HAL will use -1\n\n\"UNKNOWN (v3.2) -1 Each new frame has some subset (potentially the\nentire set) of the past requests applied to the camera settings. By\nsubmitting a series of identical requests, the camera device will\neventually have the camera settings applied, but it is unknown when\nthat exact point will be.\n\nAll LEGACY capability devices will have this as their maxLatency.\"\n\nOr use the pipeline depth as its upper limit.\n\nNicholas was this to satisfy some correctness check, or are you\nactually looking into have precise per-frame control ?\n\n>\n> Paul\n>\n>\n> [1] https://developer.android.com/reference/android/hardware/camera2/CameraMetadata#REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE\n>\n> > > \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n> > > };\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2CB2BDB16\n\tfor ;\n\tTue, 25 Oct 2022 13:20:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F68262F3D;\n\tTue, 25 Oct 2022 15:20:03 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CD9A61F4C\n\tfor ;\n\tTue, 25 Oct 2022 15:20:02 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 1D9802000A;\n\tTue, 25 Oct 2022 13:20:00 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666704003;\n\tbh=M95BEZyq335joJkOLKGx3HRHri8wSTvEtF+gN2kGPP0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=VdaoS9xMz+cqf27d0IABG4VPbkYR7TnLqakyIwiPQdH07Z6ri4Co12VUXG5D7qemZ\n\t/7eOp5sbRCEE6qqM5CWWcSZg4BAMg6bYDbykmaNv0pqjco9Rma/3wiuEO0L2EO0WqK\n\torhuemV+hpOFj9wogV/iVsoyCiNxTLVArUJEihbyJtt5ZZormrZbeIRi5ut/Ou17Sa\n\t0cSvtxyc/ekh6jDa6XQbH6G9/ik4zW7aizBSYptTNWzTuwSQc7poQEdjkLwWhkb5eA\n\tPGNbjn6Nkem3IL0IUWlvs5/EAm6qUCfP3byKsTmFQB1W9pdC0BiM6js1LxwEiLJC53\n\trSv2GiVDKqsyA==","Date":"Tue, 25 Oct 2022 15:19:59 +0200","To":"paul.elder@ideasonboard.com","Message-ID":"<20221025131959.lkpdivenxu64tbef@uno.localdomain>","References":"<20221024055543.116040-1-nicholas@rothemail.net>\n\t<20221024055543.116040-4-nicholas@rothemail.net>\n\t\n\t<20221025001322.GI3874866@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221025001322.GI3874866@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"nicholas@rothemail.net, Nicholas Roth via libcamera-devel\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25581,"web_url":"https://patchwork.libcamera.org/comment/25581/","msgid":"","date":"2022-10-25T15:16:48","subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","submitter":{"id":137,"url":"https://patchwork.libcamera.org/api/people/137/","name":"Nicholas Roth","email":"nicholas@rothemail.net"},"content":"> Careful, we're claiming full per-frame control capabilities with this set to 0 :)\n \nGood catch— I’ll revert this line. I couldn’t easily find this in the ISP manual and wanted to see what we’d need for FULL instead of LIMITED support while I was debugging a camera2 crash.\n\n> On Oct 25, 2022, at 8:20 AM, Jacopo Mondi wrote:\n> \n> Careful, we're claiming full per-frame control capabilities with this\n> set to 0 :)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8B8BBD16B\n\tfor ;\n\tTue, 25 Oct 2022 15:17:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22B8E62F40;\n\tTue, 25 Oct 2022 17:17:03 +0200 (CEST)","from mail-oa1-x31.google.com (mail-oa1-x31.google.com\n\t[IPv6:2001:4860:4864:20::31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3436061F4C\n\tfor ;\n\tTue, 25 Oct 2022 17:17:01 +0200 (CEST)","by mail-oa1-x31.google.com with SMTP id\n\t586e51a60fabf-13be3ef361dso3499780fac.12\n\tfor ;\n\tTue, 25 Oct 2022 08:17:01 -0700 (PDT)","from smtpclient.apple ([2600:1700:20:20c0:8139:1a69:28ea:b117])\n\tby smtp.gmail.com with ESMTPSA id\n\th24-20020aca1818000000b003546fada8f6sm1042231oih.12.2022.10.25.08.16.59\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 25 Oct 2022 08:16:59 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666711023;\n\tbh=99sSw58P+ouue1oqEL05bp8lLt1f2PGAcf5BbDLLs4U=;\n\th=Date:References:In-Reply-To:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=S5u2RlOZqkmuvwBc2DGB0JNwZampvMYcvcfMZDn91b3dMK8kTqvgNW8QM5KmyMe7S\n\tab4cuWRfOp/rFgLqfcIIPdZgggdvNVQ/rEQ1ZpgRzOXW7fPL57F7teLTJVR001rKzi\n\tphOk+E3W30Zd+c3g3lBzKLBSjGhE5f4FLsOl5F2C2uhaVqiDxM4gMkaIUQQOSkH3LA\n\tim8NUQJePgfogzrauNC41ZhmIYKlf0hj57dxoRAaLBJ4YsfRAzQsFi/giQ1nm21pBr\n\tvVbdFMVEBcC9Bd+KVfKTA6nxxYML/o/I74EWbXa/opjEpCh0kRMlhzPr7p8VFaU0l5\n\t/K1RpA8nA+vLw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=to:in-reply-to:cc:references:message-id:date:subject:mime-version\n\t:from:content-transfer-encoding:from:to:cc:subject:date:message-id\n\t:reply-to; bh=99sSw58P+ouue1oqEL05bp8lLt1f2PGAcf5BbDLLs4U=;\n\tb=knQJuuxEUVBuRvVRgcUr44Iy5X0gWswWbtcAIyX/S18VI7vMYlnvhUqTYSp65NEvC2\n\tKL4/AFPHhlU293twBdOvr+4SXPMNOPJg+uSMUwEiSVZFg3qru9uH58yItcE39++9sXeI\n\tT3MIWt2N9i9aZBADV/ClTGcWeDDe3Jf+5JWn9bd63uzZWTYGilHP/qbWllLW/4PEF5BU\n\tMYmTpElFg4xcHUtiRlP4YQm1m6IjKAvxeomQuVMde5cobUP3rfDJk9RlWfZqEA3wZX80\n\tsQeHMUymIT5RcrAHuvE8rtPEeQ/IDMnZEumX64bDxlJ6S+Ch10+Amw6fjGKIl374stmv\n\tmSbQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"knQJuuxE\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=to:in-reply-to:cc:references:message-id:date:subject:mime-version\n\t:from:content-transfer-encoding:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=99sSw58P+ouue1oqEL05bp8lLt1f2PGAcf5BbDLLs4U=;\n\tb=eLE74rIHuqGWO05mj0yaX3Qx66ANTFXfxvqbLJLK3e6+5SgCgrdn5OFR/mLnKzgvAv\n\thEEI1BdEQ4u6VG2pmJcOVEHcSz703p36aB+g+czg1zUTy6zhDYeQA0fDEfGj1Yvlyin+\n\tNRGYZBTL+q/Z/DxnsCudDSxh1Z4omDEoYAjkqtWNlgSjYMpDtB+oU2sQymbDiKAlPBgf\n\txQ5TZGTyKgkVPFQ93SsHcQq+CmYnBJzrabrIK7Ej6z+XHh9Zba4hc45wK/Wdj/7k2Mbk\n\tG7tiyX2VQrJm9q+QIB8erYlZcMbEO/oYFDGOR58yz4lzrz7iMoZx7HNqFXNT8twWW6hu\n\tWfyg==","X-Gm-Message-State":"ACrzQf3B7cAKTO38DdG6/Gf7McrQ7RqxzABceXFjW7ZO8na2cF3eQJBs\n\tBX6swe0fCT6Lp94rhS5D3fF/7w==","X-Google-Smtp-Source":"AMsMyM4l22dk58yQxAyCfJ2udl4atDyi8JcuT4CDbbeUS6ArOJxQSK5hO9xoMx/Utbyuei9kiEaoUA==","X-Received":"by 2002:a05:6871:692:b0:131:d1d6:c1ba with SMTP id\n\tl18-20020a056871069200b00131d1d6c1bamr41652101oao.200.1666711019606; \n\tTue, 25 Oct 2022 08:16:59 -0700 (PDT)","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Mime-Version":"1.0 (1.0)","Date":"Tue, 25 Oct 2022 10:16:48 -0500","Message-Id":"","References":"<20221025131959.lkpdivenxu64tbef@uno.localdomain>","In-Reply-To":"<20221025131959.lkpdivenxu64tbef@uno.localdomain>","To":"Jacopo Mondi ","X-Mailer":"iPhone Mail (20A362)","Subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicholas Roth via libcamera-devel ","Reply-To":"Nicholas Roth ","Cc":"Nicholas Roth via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25587,"web_url":"https://patchwork.libcamera.org/comment/25587/","msgid":"","date":"2022-10-26T04:40:11","subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","submitter":{"id":137,"url":"https://patchwork.libcamera.org/api/people/137/","name":"Nicholas Roth","email":"nicholas@rothemail.net"},"content":"+Kieran Bingham since Laurent is out.\n\n> Could this be computed the same way we do it in the IPU3 IPA module ?\n\nIt looks like each of the computed IPU3 FrameDurationLimit values\ncorrespond to the minimum and maximum v4l2 blanking intervals. I suppose\nthat makes sense, though I suspect the minimum frame duration will be\nconstrained by i2c bandwidth and ISP limitations at the highest resolutions\nrather than the sensor blanking intervals based on the datasheet.\n\nI'm not really sure what the best thing to do here is. I'm concerned that\nif we follow the IPU3 computation, we could easily end up asking for the\nISP to push more pixels than it has throughput for. A very conservative\napproach might be to cap this at a few FPS, which is the advertised rate at\nthe highest resolution, but I would not enjoy using the camera that way.\nCurious to read others' thoughts on this.\n\nAs a side-note, I'm really not sure why the IPU3 IPA treats\nFrameDurationLimits as a 3-tuple, when control_ids.yaml explicitly states:\n description: |\n The minimum and maximum (in that order) frame duration,\n expressed in microseconds.\n...\n size: [2]\n\nIt looks like updateControls is only called once, during init(). We would\nneed a hook that changes this static configuration for each video mode.\n\n\nOn Tue, Oct 25, 2022 at 10:16 AM Nicholas Roth \nwrote:\n\n> > Careful, we're claiming full per-frame control capabilities with this\n> set to 0 :)\n>\n> Good catch— I’ll revert this line. I couldn’t easily find this in the ISP\n> manual and wanted to see what we’d need for FULL instead of LIMITED support\n> while I was debugging a camera2 crash.\n>\n> > On Oct 25, 2022, at 8:20 AM, Jacopo Mondi wrote:\n> >\n> > Careful, we're claiming full per-frame control capabilities with this\n> > set to 0 :)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DA2DBD16B\n\tfor ;\n\tWed, 26 Oct 2022 04:40:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DAEC62F4B;\n\tWed, 26 Oct 2022 06:40:25 +0200 (CEST)","from mail-io1-xd31.google.com (mail-io1-xd31.google.com\n\t[IPv6:2607:f8b0:4864:20::d31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A36B0603CF\n\tfor ;\n\tWed, 26 Oct 2022 06:40:23 +0200 (CEST)","by mail-io1-xd31.google.com with SMTP id l127so12381748iof.12\n\tfor ;\n\tTue, 25 Oct 2022 21:40:23 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666759225;\n\tbh=6QmOYwOFg5lFDmWOiSllJEt8KaDNSKHtWzUtXj9Oa3U=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2OaRKOuSJmYGzEx7uQXh5R7RE5szEedLtNrkDvy8LY55rm5ycmfLHaDbzJk8dlqXT\n\tWfiYlVOiSfjehcZTgxsO2UYZCVdQ9+e7RAgknwFyBBxZlSdV10WUhyjfjCTKNH+e72\n\tc3WhCk24gIb2ykUGDTlJej9vVKElCvUBPbzP16ggoq8zzZLdHmUUXPeqGcU3nvpgDQ\n\tbeM6M4yDiqDAISLgZM0kVqNHYWg1SRAYiRIDfXXOJcTGCgz09mGJXpa9/t8xRajrYx\n\tRTBAqILriOOClJoWZ0Qcxw/3GNWY02ekgaOSKLvK9H2fRzGM33g0SBb5/y+hs4k/Gs\n\tQengUuQ1nuDgw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=X0zNiIopsMlL4sKxFO7Ra1+ppOLuMTJGAq4Z2LIJUmE=;\n\tb=2w5P+Y1b7WQseHw2rc63tbxN9bZgSMA5mSh/nWavhfgxcLN0aRZy8glaKEI3a6hfdo\n\tOdvxIpHJJjp48runTEJ2Bb1RuyLoPI8J76qOMsN0EpVCF+3Ur4mGaamtwNiVTii+6Vje\n\txJWz2kPLN5TY1zF8uglqYVzG4dUdrVWIos9tLivI/aGJbITb759VayGkqLST+CcdP6Qx\n\tDrC3EuEiPiuDWUiEtVNP26rM78ZqDwT/vnRPAPVu6XBQzO4mSHbIdfiVUvG2QeL01es8\n\tjY1ASg2yZr5NDi/3B9hzsdtt5ghNB9BTIHXI4DIvCjlThJ2QCA79mWci8Li3FXfrA++I\n\tRoVw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"2w5P+Y1b\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=X0zNiIopsMlL4sKxFO7Ra1+ppOLuMTJGAq4Z2LIJUmE=;\n\tb=ZZiicUyxGNjSLnNNyjHdYZER7QbmgLaFpeFhMM7xR9GlcfWUxPrcn/OByjtXO2JilO\n\tidTRY9D2s7pV+1R4A+S9kXkhYbGKBzrxJsxmGyLm2XgeTpcLhGnlAiuE8EC3M5edzogy\n\tl8q/XYCE7q3Ed9UQ0IKiNpjrb1EV7BY5KqUSeylnmZOwelHUdsGb8NiBX/Sp0DqybGYD\n\t+tbttDhb/t8m49myxCvohedrGi6Uyoxbt+HY0ghc2r+XveEoKOwqtdX6h6pMx/nkkXlD\n\t7cgI3qen9E6bEA9BdnrfPKHpiqKFERBWqP7Ue/wtdoPfQWkmu+hzR0tvLshP1KqnXUXC\n\t0J6w==","X-Gm-Message-State":"ACrzQf3nA68EKWv2bxzDH0kKsTDsnqO24xKRax9FHJVYLhY8jOt9vbxX\n\t/9THVMjVteOpLSBsUxp9Nv+g/YOk5Zo8MwSobQRjrQ==","X-Google-Smtp-Source":"AMsMyM5gyUGpN9MzB0sg5OsjFO1CoETGkNDj1VPDYf5Mazoyd+kTjLjKiRSGWMu7to0hScfMmM6W7i8gSMqDegAg+8Y=","X-Received":"by 2002:a05:6638:2613:b0:364:7c5:81dc with SMTP id\n\tm19-20020a056638261300b0036407c581dcmr24707152jat.225.1666759222110;\n\tTue, 25 Oct 2022 21:40:22 -0700 (PDT)","MIME-Version":"1.0","References":"<20221025131959.lkpdivenxu64tbef@uno.localdomain>\n\t","In-Reply-To":"","Date":"Tue, 25 Oct 2022 23:40:11 -0500","Message-ID":"","To":"Jacopo Mondi ,\n\tKieran Bingham ","Content-Type":"multipart/alternative; boundary=\"0000000000005c495b05ebe89f02\"","Subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicholas Roth via libcamera-devel ","Reply-To":"Nicholas Roth ","Cc":"Nicholas Roth via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25592,"web_url":"https://patchwork.libcamera.org/comment/25592/","msgid":"<166677494673.3974115.17028957222137889121@Monstersaurus>","date":"2022-10-26T09:02:26","subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Nicholas Roth (2022-10-26 05:40:11)\n> +Kieran Bingham since Laurent is out.\n> \n> > Could this be computed the same way we do it in the IPU3 IPA module ?\n> \n> It looks like each of the computed IPU3 FrameDurationLimit values\n> correspond to the minimum and maximum v4l2 blanking intervals. I suppose\n> that makes sense, though I suspect the minimum frame duration will be\n> constrained by i2c bandwidth and ISP limitations at the highest resolutions\n> rather than the sensor blanking intervals based on the datasheet.\n> \n> I'm not really sure what the best thing to do here is. I'm concerned that\n> if we follow the IPU3 computation, we could easily end up asking for the\n> ISP to push more pixels than it has throughput for. A very conservative\n> approach might be to cap this at a few FPS, which is the advertised rate at\n> the highest resolution, but I would not enjoy using the camera that way.\n> Curious to read others' thoughts on this.\n> \n> As a side-note, I'm really not sure why the IPU3 IPA treats\n> FrameDurationLimits as a 3-tuple, when control_ids.yaml explicitly states:\n> description: |\n> The minimum and maximum (in that order) frame duration,\n> expressed in microseconds.\n> ...\n> size: [2]\n\nUhhh - yes, the code over at IPAIPU3::updateControls() seems quite ...\nodd. I'm not sure it's correct, it could be left over from some early\ndevelopment. I'll add it to a task to take a look at.\n\n> It looks like updateControls is only called once, during init(). We would\n> need a hook that changes this static configuration for each video mode.\n\nI believe it's supposed to be called after / during configure() too when\nmodes are updated. If it's missing, there's likely a bug there.\n\n\n\n> On Tue, Oct 25, 2022 at 10:16 AM Nicholas Roth \n> wrote:\n> \n> > > Careful, we're claiming full per-frame control capabilities with this\n> > set to 0 :)\n> >\n> > Good catch— I’ll revert this line. I couldn’t easily find this in the ISP\n> > manual and wanted to see what we’d need for FULL instead of LIMITED support\n> > while I was debugging a camera2 crash.\n> >\n> > > On Oct 25, 2022, at 8:20 AM, Jacopo Mondi wrote:\n> > >\n> > > Careful, we're claiming full per-frame control capabilities with this\n> > > set to 0 :)\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D34DBDB16\n\tfor ;\n\tWed, 26 Oct 2022 09:02:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 703FA62F4E;\n\tWed, 26 Oct 2022 11:02:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36DC362ED0\n\tfor ;\n\tWed, 26 Oct 2022 11:02:30 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D7F84F8;\n\tWed, 26 Oct 2022 11:02:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666774951;\n\tbh=rVrfNCtRXSIPKjMUbVKPcHs1Ya/BbsK1RBm3b8M8WBE=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xfFcGRzaLDhJylmD4eYypnTjQsMbR8fYU6G+o7xxWf1pA7ec5aoiHuDnTbFOXyDdD\n\t1yUnVd10qQ6yrladsSaqvS/d+LWiNNAMO6M5QXS+b1zHfCvGxbMLn3pE3TYwgJxLCJ\n\tIbIaDfsGeEq58mKgryRtY/7lZnhUYQ/OxxnpTms2u5iOgTKBD3P5mP63tg5/pn9gJ2\n\tr09QxHFA1/Yaet3WifHZLoePpjnCy5zSGrOqqhLJLWmzw1HfC8c7cyfmdLCSAfQGxC\n\tnd6Ictq2MV60ivoqiPSWcS32z8lM9acaQqJRlYEbTeApIGV87gr7VxITSCNiescJYP\n\t41AW2htQ1uEEA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666774949;\n\tbh=rVrfNCtRXSIPKjMUbVKPcHs1Ya/BbsK1RBm3b8M8WBE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=E46KnYDEFm0aVF+f1sVGWXu416bFl0igtSz4dLT35FcOcXB65i6ujKOJmG/imX4Q3\n\tFuQinFRxyGK6etStQId4+1zaTGnVgDpAcOkcx/eByw/qnjfIRCyCBj0P5sZbMRXCbf\n\tr5ZHazyHS42JczzUhLmp/JJmj/jQTiJ95WcVBkh0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"E46KnYDE\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20221025131959.lkpdivenxu64tbef@uno.localdomain>\n\t\n\t","To":"Jacopo Mondi , Nicholas Roth ","Date":"Wed, 26 Oct 2022 10:02:26 +0100","Message-ID":"<166677494673.3974115.17028957222137889121@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Nicholas Roth via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25615,"web_url":"https://patchwork.libcamera.org/comment/25615/","msgid":"","date":"2022-10-27T03:44:55","subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","submitter":{"id":137,"url":"https://patchwork.libcamera.org/api/people/137/","name":"Nicholas Roth","email":"nicholas@rothemail.net"},"content":"It looks like indeed we have a way to call updateControls() at the\nappropriate places, now that I've looked at the ISP code more closely.\n\nIt seems like we have at least the following options:\n1 Compute the durations the way IPU3 does it (probably wrong)\n2 Insert reasonable values (that sometimes might not work) and document\nthis in a bug\n3 Do nothing, document as a bug that RKISP1 does not work as an Android HAL\nwithout a special patch, including my suggested defaults there in the bug\nand the \"how to get this working on Android\" guide.\n\nPersonally, I advocate for (2). Let me know what you think.\n\n-Nicholas\n\n\nOn Wed, Oct 26, 2022 at 4:02 AM Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Quoting Nicholas Roth (2022-10-26 05:40:11)\n> > +Kieran Bingham since Laurent is out.\n> >\n> > > Could this be computed the same way we do it in the IPU3 IPA module ?\n> >\n> > It looks like each of the computed IPU3 FrameDurationLimit values\n> > correspond to the minimum and maximum v4l2 blanking intervals. I suppose\n> > that makes sense, though I suspect the minimum frame duration will be\n> > constrained by i2c bandwidth and ISP limitations at the highest\n> resolutions\n> > rather than the sensor blanking intervals based on the datasheet.\n> >\n> > I'm not really sure what the best thing to do here is. I'm concerned that\n> > if we follow the IPU3 computation, we could easily end up asking for the\n> > ISP to push more pixels than it has throughput for. A very conservative\n> > approach might be to cap this at a few FPS, which is the advertised rate\n> at\n> > the highest resolution, but I would not enjoy using the camera that way.\n> > Curious to read others' thoughts on this.\n> >\n> > As a side-note, I'm really not sure why the IPU3 IPA treats\n> > FrameDurationLimits as a 3-tuple, when control_ids.yaml explicitly\n> states:\n> > description: |\n> > The minimum and maximum (in that order) frame duration,\n> > expressed in microseconds.\n> > ...\n> > size: [2]\n>\n> Uhhh - yes, the code over at IPAIPU3::updateControls() seems quite ...\n> odd. I'm not sure it's correct, it could be left over from some early\n> development. I'll add it to a task to take a look at.\n>\n> > It looks like updateControls is only called once, during init(). We would\n> > need a hook that changes this static configuration for each video mode.\n>\n> I believe it's supposed to be called after / during configure() too when\n> modes are updated. If it's missing, there's likely a bug there.\n>\n>\n>\n> > On Tue, Oct 25, 2022 at 10:16 AM Nicholas Roth \n> > wrote:\n> >\n> > > > Careful, we're claiming full per-frame control capabilities with this\n> > > set to 0 :)\n> > >\n> > > Good catch— I’ll revert this line. I couldn’t easily find this in the\n> ISP\n> > > manual and wanted to see what we’d need for FULL instead of LIMITED\n> support\n> > > while I was debugging a camera2 crash.\n> > >\n> > > > On Oct 25, 2022, at 8:20 AM, Jacopo Mondi wrote:\n> > > >\n> > > > Careful, we're claiming full per-frame control capabilities with this\n> > > > set to 0 :)\n> > >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0983BBD16B\n\tfor ;\n\tThu, 27 Oct 2022 03:45:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FF5062F67;\n\tThu, 27 Oct 2022 05:45:08 +0200 (CEST)","from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com\n\t[IPv6:2607:f8b0:4864:20::d2f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1937361F4A\n\tfor ;\n\tThu, 27 Oct 2022 05:45:07 +0200 (CEST)","by mail-io1-xd2f.google.com with SMTP id b79so398811iof.5\n\tfor ;\n\tWed, 26 Oct 2022 20:45:07 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666842308;\n\tbh=fgNiVFa0A9Ep/fyFp0v48wD6ZFy1NP90opYaF1KcYTk=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fmk/bT/FgaPRx6vwyD7CtfZFrtccbMFO1OUBq4ytJKYzUaFPyepFR3+81AHfu0SvY\n\ttqiQyxT0Q4196O3viFzTljUZduYcZWiEFyY2i9Rsp702Ao1i+Ado3qCXdO2YChn9PB\n\t8kZBcwFE29lRYIzDl+U4eOzt2hyvavfTHNxvBiIGSH4Pi0ckZvO2apUgqEj0PaXSAF\n\tnNfN8if8Y26YzwGSCwC1RYg5HmOWYM9Xm3xxfq9lzSjiPK4hDiIQw6bQQNonmLsCAk\n\toMWX3ph2s35Vfq2LpZvyFKGjaU5uSuz7HqyzzukLsH/GG72trgCgzyt6LaoKtUPppS\n\tGXOLtJiXmf0wQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=l/HW/MNZ2YPDhLZILjAzDVwsbcsWyelA926XVJZ0J5M=;\n\tb=BU3wSAyHOCaaGcy+YdxrKNxL19iN0xjy+unN8bNTPiAfih4qoti/8nsoLUuwIsgtw3\n\tJgpieXz/dK72gLaof01l1aQkQnODu2ES0rBUy1S6EssdY3o+QZVdvISJ2ZgzubKIMqXo\n\twu77RCYG5Na/9urphVcsR6S/OLfUViY/Nm/2Cjsfi7WurH8S1Dqvf9fHJxydrdog/Zxf\n\tYOxaqNm8qW7BLIkmxEfqpZoJMsQYxOc1aF5GDX6c5kwP82bBc4SeOq1lt+YfBT+vgEJD\n\tFNH4GyjhpLzKdGOl3wWmSWjX8U7BPTtKXQ5oJlVBxXawZD5SNOW85ivmAR8Ih28vuB4V\n\t5Uww=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"BU3wSAyH\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=l/HW/MNZ2YPDhLZILjAzDVwsbcsWyelA926XVJZ0J5M=;\n\tb=6eAxyAdOH4SCMigFfwNGH+PLYLwd0GfB5RjCY5ZdtnNjLKTd/YpExbQF/glC2pDuPq\n\tyi5deo4gQVnX/jdF2h0Ovfyq0rN3C+5GHNl9Hov4qx+0h8QRvd0ZdOUG74rhcsqVZA5W\n\tZse5O3X3Auv/TRmpnZQVA8KXBiOLtfnQlcWndURtDgBc7Njzxtf53d2XkGYJEUKKTts5\n\tR9LDhFNykU0DOOnBKvD6aD2ykwgZfIIFjxcWnXKp7WdBjkdEnqR5yyX4YXAqEWWhBrM3\n\tCBtyYLwn+5H00XklCCa7wpxjqR3s3qYS+HLIRkmWsHwQo/ekAx6sb1vHTXHwKRSSyusi\n\tGmgw==","X-Gm-Message-State":"ACrzQf30F26TwZy5FW9EEiZMnCnmr5M6ZKnMmjyJVev3XnQfAtKIymSr\n\tWVqgRheySkUPgF44A6CiiRNYy1BupLWHRpQOaIDT0Q53pP84Kw==","X-Google-Smtp-Source":"AMsMyM5gThaGDJ1w7u7iw7F6TfXnh5oqM196JduGxzBar2Csl+2VBVQvffF2nnHIdHyUpUSifOR3iamEnXyi+xWmIWQ=","X-Received":"by 2002:a05:6638:4122:b0:375:2990:8909 with SMTP id\n\tay34-20020a056638412200b0037529908909mr51505jab.259.1666842305736;\n\tWed, 26 Oct 2022 20:45:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20221025131959.lkpdivenxu64tbef@uno.localdomain>\n\t\n\t\n\t<166677494673.3974115.17028957222137889121@Monstersaurus>","In-Reply-To":"<166677494673.3974115.17028957222137889121@Monstersaurus>","Date":"Wed, 26 Oct 2022 22:44:55 -0500","Message-ID":"","To":"Kieran Bingham ","Content-Type":"multipart/alternative; boundary=\"00000000000087cc7005ebfbf766\"","Subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicholas Roth via libcamera-devel ","Reply-To":"Nicholas Roth ","Cc":"Nicholas Roth via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25622,"web_url":"https://patchwork.libcamera.org/comment/25622/","msgid":"<20221027103439.gz5znwavhsuakau7@uno.localdomain>","date":"2022-10-27T10:34:39","subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Nicholas,\n\nOn Tue, Oct 25, 2022 at 11:40:11PM -0500, Nicholas Roth wrote:\n> +Kieran Bingham since Laurent is out.\n>\n> > Could this be computed the same way we do it in the IPU3 IPA module ?\n>\n> It looks like each of the computed IPU3 FrameDurationLimit values\n> correspond to the minimum and maximum v4l2 blanking intervals. I suppose\n> that makes sense, though I suspect the minimum frame duration will be\n> constrained by i2c bandwidth and ISP limitations at the highest resolutions\n> rather than the sensor blanking intervals based on the datasheet.\n>\n\nMostly for sake of discussion, as you correctly noticed we report as\nthe camera frame duration the sensor's frame duration. I think this is\ncorrect, as there might indeed be other bottlenecks in the capture\npipeline, but I guess it's hard to quantify them in terms of latency\nand they depend on the current camera configuration, ie the number\nand resolution of the streams that are processed in a given capture session.\n\nI wonder if all platforms behaves the same when overloaded, some\nmight introduce latencies, some might drop buffers ? I'm also afraid\nnot all the numbers we would need to quantify something are actually\navailable...\n\nThe sensor frame duration is shared by all streams generated from the same\nand can be reported as a camera global parameter.\n\nI2c bandwidth doesn't seem a concern to me, during streaming i2c\ntraffic should be negligible and limited to the control of a few\nsensor's parameters which are controlled at run-time, such as the\nexposure time and gain.\n\nThere might of course be multiple processing steps to take into\naccount when actually computing the full duration of the frame since\nthe time it has been produced by the sensor to the time it is\ndelivered to applications. Android in example has a dedicated\nproperty for 'stalling' streams that goes through, in example, JPEG\nencoding, something that is not exactly in scope for libcamera (and\nwhich we don't fully handle in the HAL yet).\n\n> I'm not really sure what the best thing to do here is. I'm concerned that\n> if we follow the IPU3 computation, we could easily end up asking for the\n> ISP to push more pixels than it has throughput for. A very conservative\n\nI don't have numbers here and I presume they're very platform\ndependent, but I don't think we actually hit that limit on IPU3 which\nis where the HAL has been mostly tested on. Which platform are you\nworking with ?\n\n> approach might be to cap this at a few FPS, which is the advertised rate at\n> the highest resolution, but I would not enjoy using the camera that way.\n> Curious to read others' thoughts on this.\n>\n> As a side-note, I'm really not sure why the IPU3 IPA treats\n> FrameDurationLimits as a 3-tuple, when control_ids.yaml explicitly states:\n> description: |\n> The minimum and maximum (in that order) frame duration,\n> expressed in microseconds.\n> ...\n> size: [2]\n\nWhat you see initialized with 3 values is the ControlInfo, which\nreports the max, min and default values for a control. The control\nitself accepts two values as indicated by the documentation.\n\n>\n> It looks like updateControls is only called once, during init(). We would\n> need a hook that changes this static configuration for each video mode.\n\nI do see updateControls() be called by configure() as well, and I see\nthe pipeline handler correctly updating the ControlInfoMap of camera\ncontrols. Am I missing something ?\n>\n>\n> On Tue, Oct 25, 2022 at 10:16 AM Nicholas Roth \n> wrote:\n>\n> > > Careful, we're claiming full per-frame control capabilities with this\n> > set to 0 :)\n> >\n> > Good catch— I’ll revert this line. I couldn’t easily find this in the ISP\n> > manual and wanted to see what we’d need for FULL instead of LIMITED support\n> > while I was debugging a camera2 crash.\n> >\n> > > On Oct 25, 2022, at 8:20 AM, Jacopo Mondi wrote:\n> > >\n> > > Careful, we're claiming full per-frame control capabilities with this\n> > > set to 0 :)\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54B06BD16B\n\tfor ;\n\tThu, 27 Oct 2022 10:34:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B3E062F84;\n\tThu, 27 Oct 2022 12:34:46 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E328162ED0\n\tfor ;\n\tThu, 27 Oct 2022 12:34:44 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 05AD46000D;\n\tThu, 27 Oct 2022 10:34:41 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666866886;\n\tbh=mCNqjjVfw4CLZA1E42WXxqMv4UTtWdGIZufyPVG5p5A=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Y/YIMIZd6ep6L9GPAPiFBjVJDDotK27ez5gpF9g4kOFHV6gbVLYnk2bAL8JRAvw8F\n\takRyp3lksuAHkiNClA276y8OHebobyZ9HdzSA/LS+IeyJ0KNmVm2fFPJmr99PL6Tk6\n\tlb6jA7wlcoIQqELvplILYr3uEr/av61hA0u+Zu+Q9K+43FGeJKnPl3nOEWviOKXy5f\n\tbbYNzYl+rQq06p5MS+IhX2yRuh54y4aaZzmJr07NmtkuD1uz7FMgqtKJR0YNYkjSko\n\t+Q4ecTLjj0WAfmO58WbTiXXqSn6YsjN9OXtMMN8T+oUJy/5OzPEX3jOg7gZbTV1QLg\n\tZpsN5X3sUr/3g==","Date":"Thu, 27 Oct 2022 12:34:39 +0200","To":"Nicholas Roth ","Message-ID":"<20221027103439.gz5znwavhsuakau7@uno.localdomain>","References":"<20221025131959.lkpdivenxu64tbef@uno.localdomain>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required\n\tfor the Android HAL to use it.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Nicholas Roth via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]