{"id":17686,"url":"https://patchwork.libcamera.org/api/patches/17686/?format=json","web_url":"https://patchwork.libcamera.org/patch/17686/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221024055543.116040-12-nicholas@rothemail.net>","date":"2022-10-24T05:55:43","name":"[libcamera-devel,11/11] Adds useful debug print statements.","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"68606f490f9c39d92bd50ff66d3de8bd4fd0573a","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/?format=json","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17686/mbox/","series":[{"id":3575,"url":"https://patchwork.libcamera.org/api/series/3575/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3575","date":"2022-10-24T05:55:33","name":"[libcamera-devel,01/11] Fixes Bug 156, which breaks libcamera on Android < 12.","version":1,"mbox":"https://patchwork.libcamera.org/series/3575/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17686/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17686/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2DFEBD16B\n\tfor ;\n\tMon, 24 Oct 2022 05:56:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76D2462F10;\n\tMon, 24 Oct 2022 07:56:08 +0200 (CEST)","from mail-ot1-x331.google.com (mail-ot1-x331.google.com\n\t[IPv6:2607:f8b0:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB4F962EFD\n\tfor ;\n\tMon, 24 Oct 2022 07:56:02 +0200 (CEST)","by mail-ot1-x331.google.com with SMTP id\n\tr13-20020a056830418d00b0065601df69c0so5363325otu.7\n\tfor ;\n\tSun, 23 Oct 2022 22:56:02 -0700 (PDT)","from nroth-pc.attlocal.net\n\t([2600:1700:20:20c0:7bc3:aed3:676f:10a0])\n\tby smtp.gmail.com with ESMTPSA id\n\tx15-20020a9d628f000000b0066193df8edasm3980278otk.34.2022.10.23.22.56.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 23 Oct 2022 22:56:01 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666590968;\n\tbh=HUrqt4wqP8i1FlW/s6geLVzyP/5YAcKzD5Wz9hdN3T0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=w4O4X70XIEJypD3Q0Td1qw3uqlhUjhbrAQlFcKeFrBsvNoYs9scrQxTv7onYEpWtN\n\tiV0QgiwvOzlQaArZCSQ6CunJ3aGlHt/1ZRrg3DH1izEIwXDNMw9//+eK/9W3HF3Uyp\n\teA4QXjnAj1BsypgA7WEhsq7tfi1TW8IISpEJt79fF4MYU3aXYQN2QeeOMkoPiv978T\n\tnI/EkG6EI7VbQFul8l9dnYUMC+xfB802FP41if7DYEhCBZ2etzEeXoNLao6rTBxfYG\n\tq//9dJEtTallhlrlr5+JrTTGf92DLjN0hePVHbtSpRI3gAedYqTRce856eO+KfbZud\n\ttyQTq+FvJ5GAw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=d2Wxn9GxD9kN8fj4nu1ugggjmE6Wwm8g2qACyX8n20Y=;\n\tb=Z5U275JOHe4cFOgze2NusWxZx7MkPDKEBu+QQC1J67CwcfAZilUPDZom3Tq38u/pAD\n\tTtizbHIXFqtXq70Y2NzW6MAZOwNi7ehAFS/nLqzlyXDChkpvWpGwNbdKO32EGhYbeRAN\n\tUg6r3eOBCzGF26zwf4VRdfixa+PWu2Um/IavYNyBbXDoairfuA2GT9ywlAJ0pilLGoyD\n\tbLskI3Dr/s5pL29qpwx1/fe7OIyQBs26G5ixZqAaniRxd+b8LhBzLSO1D2vk8d01HdK4\n\t5MT9OkxHuB0qt1h9uXu0f1Tll5hp4eCM+NKqdcimhF0VcWLWT6LlCjUbF6uN7oxUySSi\n\tSprg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"Z5U275JO\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=d2Wxn9GxD9kN8fj4nu1ugggjmE6Wwm8g2qACyX8n20Y=;\n\tb=PwjcVqnNWNMzlrsrSVJLwW+j8fi8jsRN3muPVdxk02IgNa85T9g+ap2P8/WdzTqFZH\n\twVGaKvkKiUtHkbNVVZkaCZoYeiM/rOuTvhsEY1trCFs2uaj65ECm23OYikfXqJ0d8YN2\n\trrvigXxHNZwZClY4KIeXUfJtkKZuCSoc49Ph1Wigv5E6UE4gpjC4Uu2TcqbwoKcox1nO\n\to5HxyceNi85MgJW+4Q324qfvZGwPeToSveA0VS08YR5oiSIN4vKUpwtnIHXB9tlWk4dF\n\tqzY+y6H2H3Dy/kRwW1MHZUAsA7aq0sNivWBGJAPxEY2ID0geVPlHrBrPVDm7rTsWMm0q\n\tWz5Q==","X-Gm-Message-State":"ACrzQf0VX3K2wfk/hYroClr3DQ9cqEYrMC2Pyud5mF6YJZ0uksJr99CD\n\tXrIeGdsX0GsjjIUhA7cNmVf8nAxPv5UIayaB","X-Google-Smtp-Source":"AMsMyM7G70LX2W6tsmg6V8E3gcRLd5mUy/nUQrLVkW0gMIjx0BjLDaACYbU7DBPPBERFK589QHuwLw==","X-Received":"by 2002:a05:6830:6002:b0:660:7be2:59b2 with SMTP id\n\tbx2-20020a056830600200b006607be259b2mr15353176otb.183.1666590961980; \n\tSun, 23 Oct 2022 22:56:01 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 24 Oct 2022 00:55:43 -0500","Message-Id":"<20221024055543.116040-12-nicholas@rothemail.net>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20221024055543.116040-1-nicholas@rothemail.net>","References":"<20221024055543.116040-1-nicholas@rothemail.net>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 11/11] Adds useful debug print statements.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicholas Roth via libcamera-devel ","Reply-To":"libcamera-devel@lists.libcamera.org","Cc":"nicholas@rothemail.net","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Nicholas Roth \n\n---\n src/android/camera_capabilities.cpp | 12 +++++++++---\n src/android/camera_hal_manager.cpp | 3 ++-\n src/libcamera/base/log.cpp | 6 +++++-\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 2 ++\n src/libcamera/v4l2_subdevice.cpp | 3 ++-\n 5 files changed, 20 insertions(+), 6 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 64bd8dde..ef0d10d0 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -374,14 +374,20 @@ void CameraCapabilities::computeHwLevel(\n \tcamera_metadata_enum_android_info_supported_hardware_level\n \t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL;\n \n-\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR))\n+\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR)) {\n+\t\tLOG(HAL, Info) << noFull << \"missing manual sensor\";\n \t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n+\t}\n \n-\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING))\n+\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING)) {\n+\t\tLOG(HAL, Info) << noFull << \"missing manual post processing\";\n \t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n+\t}\n \n-\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE))\n+\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE)) {\n+\t\tLOG(HAL, Info) << noFull << \"missing burst capture\";\n \t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n+\t}\n \n \tfound = staticMetadata_->getEntry(ANDROID_SYNC_MAX_LATENCY, &entry);\n \tif (!found || *entry.data.i32 != 0) {\ndiff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex 7512cc4e..7fac4e3f 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -140,7 +140,8 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n \t */\n \tif (!isCameraExternal && !halConfig_.exists()) {\n \t\tLOG(HAL, Error)\n-\t\t\t<< \"HAL configuration file is mandatory for internal cameras\";\n+\t\t\t<< \"HAL configuration file is mandatory for internal cameras.\"\n+\t\t\t<< \" Camera NOT loaded: \\\"\" << cam->id() << \"\\\"\";\n \t\treturn;\n \t}\n \ndiff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 55fbd7b0..b8c2c99f 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -625,8 +625,12 @@ void Logger::parseLogFile()\n void Logger::parseLogLevels()\n {\n \tconst char *debug = utils::secure_getenv(\"LIBCAMERA_LOG_LEVELS\");\n-\tif (!debug)\n+\tif (!debug) {\n+\t\tsyslog(LOG_INFO, \"Could not find LIBCAMERA_LOG_LEVELS in env\");\n \t\treturn;\n+\t} else {\n+\t\tsyslog(LOG_INFO, \"LIBCAMERA_LOG_LEVELS is %s\", debug);\n+\t}\n \n \tfor (const char *pair = debug; *debug != '\\0'; pair = debug) {\n \t\tconst char *comma = strchrnul(debug, ',');\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex 2d38f0fb..a2038704 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -33,10 +33,12 @@ bool RkISP1Path::init(MediaDevice *media)\n \tstd::string resizer = std::string(\"rkisp1_resizer_\") + name_ + \"path\";\n \tstd::string video = std::string(\"rkisp1_\") + name_ + \"path\";\n \n+\tLOG(RkISP1, Debug) << \"Creating \" << resizer;\n \tresizer_ = V4L2Subdevice::fromEntityName(media, resizer);\n \tif (resizer_->open() < 0)\n \t\treturn false;\n \n+\tLOG(RkISP1, Debug) << \"Creating \" << video;\n \tvideo_ = V4L2VideoDevice::fromEntityName(media, video);\n \tif (video_->open() < 0)\n \t\treturn false;\ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 15e8206a..8f86387b 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -392,7 +392,8 @@ int V4L2Subdevice::getSelection(unsigned int pad, unsigned int target,\n \tif (ret < 0) {\n \t\tLOG(V4L2, Error)\n \t\t\t<< \"Unable to get rectangle \" << target << \" on pad \"\n-\t\t\t<< pad << \": \" << strerror(-ret);\n+\t\t\t<< pad << \": \" << strerror(-ret) << \".\"\n+\t\t\t<< \"device path: \" << devicePath() << \" device node: \" << deviceNode();\n \t\treturn ret;\n \t}\n \n","prefixes":["libcamera-devel","11/11"]}