[{"id":25560,"web_url":"https://patchwork.libcamera.org/comment/25560/","msgid":"","date":"2022-10-24T23:45:40","subject":"Re: [libcamera-devel] [PATCH 08/11] Removes code to force using\n\tlibc++ instead of libstdc++ if available.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicholas,\n\nThank you for the patch.\n\nOn Mon, Oct 24, 2022 at 12:55:40AM -0500, Nicholas Roth via libcamera-devel wrote:\n> From: Nicholas Roth \n> \n> This breaks during cross-compilation when this is not true for the\n> meson-cross cross-compiler target.\n> \n> Error:\n> clang++: error: argument unused during compilation: '-stdlib=libc++' [-Werror,-Wunused-command-line-argument]\n\nI'm surprised, does the Android version of clang not support that\nargument ?\n\n> ---\n> meson.build | 8 --------\n> 1 file changed, 8 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 56910698..7d0588d2 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -95,14 +95,6 @@ if cc.get_id() == 'clang'\n> ]\n> endif\n> \n> - # Use libc++ by default if available instead of libstdc++ when compiling\n> - # with clang.\n> - if cc.find_library('libc++', required: false).found()\n> - cpp_arguments += [\n> - '-stdlib=libc++',\n> - ]\n> - endif\n> -\n\nThis changes the behaviour for everybody else, which is not nice. I'd\nlike to find a better way.\n\n> cpp_arguments += [\n> '-Wextra-semi',\n> '-Wthread-safety',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0069BBDB16\n\tfor ;\n\tMon, 24 Oct 2022 23:46:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5FE2862F27;\n\tTue, 25 Oct 2022 01:46:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECBFE62EAE\n\tfor ;\n\tTue, 25 Oct 2022 01:46:05 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5CF31D3C;\n\tTue, 25 Oct 2022 01:46:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666655167;\n\tbh=Plq4Tp0+W1V8VwEprqDyeobulQFXhdHfxeCPZGcVP1o=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CjsfkoxnCpPFtr5mccOKQrdWoU4yqS834mCNugWmjpQYutlOWN38JW6Bt2YQkzKfP\n\taxLRQRiFZHKJzhcvIWhfSmGMlEdtvdroamk8UEgMkI5IlMohMZSZKb8StFZmJaFvNS\n\t9/IoENeAVnskz1D2lYK8o2ARjqXVaLhoVyvO0becawdkRuGUnI3YnRs7vXHui7FeDw\n\tBqt48820IBLYfWL+3S6JRfEZ3DHvivGRQ26DO/zsQaZ89PlIBLL8OGhp7YgllFZt9r\n\tjW9MNgUKtaynW7HcpjCwI7FiiEg3GU0PU3Uo/fBrzONR4gcngTXP+k/J5IySDQTTmX\n\tfn+YguzeLl5Bg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666655165;\n\tbh=Plq4Tp0+W1V8VwEprqDyeobulQFXhdHfxeCPZGcVP1o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=f1BUyJB9Aw+wecCdWeF2loZLDPLA9sH2k4wd0bjInGyF1HxkL9IG/eYWDLYICC12n\n\trl035zZn0XE31p4eszByI7WRzcdRbxv/1lE9PgXJf/h0bPyoETqqaG8PE4sZOuVXtl\n\t8dTNDy2aFco/Z2mYTg5x+Z+DLXpkrjqKzKIhFtOE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"f1BUyJB9\"; dkim-atps=neutral","Date":"Tue, 25 Oct 2022 02:45:40 +0300","To":"Nicholas Roth via libcamera-devel ","Message-ID":"","References":"<20221024055543.116040-1-nicholas@rothemail.net>\n\t<20221024055543.116040-9-nicholas@rothemail.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221024055543.116040-9-nicholas@rothemail.net>","Subject":"Re: [libcamera-devel] [PATCH 08/11] Removes code to force using\n\tlibc++ instead of libstdc++ if available.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"nicholas@rothemail.net","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25618,"web_url":"https://patchwork.libcamera.org/comment/25618/","msgid":"","date":"2022-10-27T05:39:49","subject":"Re: [libcamera-devel] [PATCH 08/11] Removes code to force using\n\tlibc++ instead of libstdc++ if available.","submitter":{"id":137,"url":"https://patchwork.libcamera.org/api/people/137/","name":"Nicholas Roth","email":"nicholas@rothemail.net"},"content":"Looks like this pops up every so often, and the solution is to remove\n\"-stdlib=libc++\":\n\nhttps://github.com/conan-io/conan/issues/7339\nhttps://marc.info/?l=llvm-bugs&m=140601983212810&w=4\nhttps://bugs.llvm.org/show_bug.cgi?id=20395\n\nHowever, I've addressed this error here by explicitly specifying\n\"-werror=false\" in the Android build and will be dropping this commit, in\nline with the preferences I've seen expressed here.\n\nOn Mon, Oct 24, 2022 at 6:46 PM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Nicholas,\n>\n> Thank you for the patch.\n>\n> On Mon, Oct 24, 2022 at 12:55:40AM -0500, Nicholas Roth via\n> libcamera-devel wrote:\n> > From: Nicholas Roth \n> >\n> > This breaks during cross-compilation when this is not true for the\n> > meson-cross cross-compiler target.\n> >\n> > Error:\n> > clang++: error: argument unused during compilation: '-stdlib=libc++'\n> [-Werror,-Wunused-command-line-argument]\n>\n> I'm surprised, does the Android version of clang not support that\n> argument ?\n>\n> > ---\n> > meson.build | 8 --------\n> > 1 file changed, 8 deletions(-)\n> >\n> > diff --git a/meson.build b/meson.build\n> > index 56910698..7d0588d2 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -95,14 +95,6 @@ if cc.get_id() == 'clang'\n> > ]\n> > endif\n> >\n> > - # Use libc++ by default if available instead of libstdc++ when\n> compiling\n> > - # with clang.\n> > - if cc.find_library('libc++', required: false).found()\n> > - cpp_arguments += [\n> > - '-stdlib=libc++',\n> > - ]\n> > - endif\n> > -\n>\n> This changes the behaviour for everybody else, which is not nice. I'd\n> like to find a better way.\n>\n> > cpp_arguments += [\n> > '-Wextra-semi',\n> > '-Wthread-safety',\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63C5DBDB16\n\tfor ;\n\tThu, 27 Oct 2022 05:40:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 603F662F6B;\n\tThu, 27 Oct 2022 07:40:03 +0200 (CEST)","from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com\n\t[IPv6:2607:f8b0:4864:20::d2d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE47661F4A\n\tfor ;\n\tThu, 27 Oct 2022 07:40:01 +0200 (CEST)","by mail-io1-xd2d.google.com with SMTP id r73so273242iod.10\n\tfor ;\n\tWed, 26 Oct 2022 22:40:01 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666849203;\n\tbh=rofw+7CCHXIVy8qhDs+3xN5NvuFg2WMiev+fvotve4g=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0O8CVO9tKEYzQ8zTEb4RwLz8kVmTB7zyqFB0CNUD6zz9PPaf/gFhjiRh9sRgKplKM\n\taXIO+yI6ZLogOlUdJYNdSKf86yMvxX9JfKMNCWxki+ad/4430o3wSal5sDh4BK8/qO\n\tppzR88QlZGyRyOAKiWVVp8VIioEJ9+NT3Y1LvjTDSHJRH05DzgJyCXTnEtYyk6P5oc\n\tQhbKYAt0GISCKxNpqu0GemtG4EL4QcQYKPwDIG/Ro6lBYbFDmyZhQDT4M01tf4rTGg\n\tM8qNNb2NVmRffwvfGV14FlEunJN/iOyUtK8OcHjNrzDpxVqat3R5g44AV022LMk8JS\n\teLQbl5CjTCW5g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=lNHQgFcQEfke/fJ2uKcfbZZCLuu9gjXZA0spevmasCU=;\n\tb=f/EXC3aHzQBn5Z/EHOcY5TOXzl+xkdxO2Wz9ksZC/cNDW0xMM16mH+ty/aDyVqM0UX\n\t30tKCzxoXubfrnbfusU9AXrcKfJoacxG+yY4JTk6/p0q7zIXhL//f+qd7kbh5K9jWN1S\n\thRjeFN1PWO5DeuF6JJOuVkshoskfmdf17S+6G8IfE+Vedbh4hfd9jZVZ9WfQlzcHpuOm\n\t7olENbMGo2G2o9D8OvYf+4mBqZqX2lejFizJqcCGLYCeytrsnpB6JyYKjtQsIuIWywI5\n\tmKaNfFf3UPKnfUl3eE0wKOvuJ9fw7hY6PgPqcHH7nyRYxbrAKwma+I7coMtuWZt05Hyn\n\t+rdQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"f/EXC3aH\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=lNHQgFcQEfke/fJ2uKcfbZZCLuu9gjXZA0spevmasCU=;\n\tb=7R6yE2sFXKOM/MBcLjK4YtSbMvZ30vl7bnjcNB02AICQGAiQt7Eihh7DDZBX/8e+ut\n\tT0by5vP1mOXeV+jAxZyWucYgs/1lKWrtWOoMC6jdEtPConK75q8moi8IX+wQGt9GFmj8\n\t479lU1SsahwITG8tmBEFQsc0TCeBuPxlJU58cw9SoeInyHUM9wgQ6/g1C8eACK9+B3k0\n\t/To6O+dOyve+W0Fj2dvazMU13EKfRm6TsXjZ1xrdoM1ARLOGiOSzHF+zj+Gr2vfpP2fE\n\tFhfYLeewyizfdFXdkStDa2EYxdFNQvKW/l/rldqdx6kCI3JZcm0pVS7R2zB0p4G9ash/\n\tPmiQ==","X-Gm-Message-State":"ACrzQf2u1Ay2WiMuJ7KBE0DP6Qpbe/PRXZlzL/Pdx15oAaQD5ZqlEB6W\n\tXzT1SqbVx9nrr9UT6q4Zq33Q9sHIY4CJqqTchrysMEXc37aVGdJk","X-Google-Smtp-Source":"AMsMyM4TC0bP22aQcUhBfDcAljf1A8qJoW+3NsSdojRxTRnZBSfGHkWFY+t2RkElyhbsPqC5qobFsKZxDrpoeoE2rII=","X-Received":"by 2002:a02:9982:0:b0:364:6be:dbd6 with SMTP id\n\ta2-20020a029982000000b0036406bedbd6mr30660895jal.311.1666849200269;\n\tWed, 26 Oct 2022 22:40:00 -0700 (PDT)","MIME-Version":"1.0","References":"<20221024055543.116040-1-nicholas@rothemail.net>\n\t<20221024055543.116040-9-nicholas@rothemail.net>\n\t","In-Reply-To":"","Date":"Thu, 27 Oct 2022 00:39:49 -0500","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"0000000000007a018c05ebfd921c\"","Subject":"Re: [libcamera-devel] [PATCH 08/11] Removes code to force using\n\tlibc++ instead of libstdc++ if available.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicholas Roth via libcamera-devel ","Reply-To":"Nicholas Roth ","Cc":"Nicholas Roth via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]