[{"id":2373,"web_url":"https://patchwork.libcamera.org/comment/2373/","msgid":"<20190810134426.GB4788@pendragon.ideasonboard.com>","date":"2019-08-10T13:44:26","subject":"Re: [libcamera-devel] [PATCH v2 4/6] test: v4l2_videodevice: Add\n\tM2M device test","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Aug 09, 2019 at 04:04:57PM +0100, Kieran Bingham wrote:\n> The V4L2M2MDevice requires two pipelines to be configured. This makes it unsuitable\n\ns/pipelines/video devices/ ?\n\n> to reuse the existing V4L2DeviceTest test library in its current form.\n\nLine wrap ? vi wraps commit messages at a 72 characters boundary by\ndefault, did you mess it up ?\n\n> Implement a full test to run the two M2M pipelines through VIM2M.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n>  test/v4l2_videodevice/meson.build        |   1 +\n>  test/v4l2_videodevice/v4l2_m2mdevice.cpp | 212 +++++++++++++++++++++++\n>  2 files changed, 213 insertions(+)\n>  create mode 100644 test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> \n> diff --git a/test/v4l2_videodevice/meson.build b/test/v4l2_videodevice/meson.build\n> index 76be5e142bb6..ad41898b5f8b 100644\n> --- a/test/v4l2_videodevice/meson.build\n> +++ b/test/v4l2_videodevice/meson.build\n> @@ -7,6 +7,7 @@ v4l2_videodevice_tests = [\n>      [ 'stream_on_off',      'stream_on_off.cpp' ],\n>      [ 'capture_async',      'capture_async.cpp' ],\n>      [ 'buffer_sharing',     'buffer_sharing.cpp' ],\n> +    [ 'v4l2_m2mdevice',     'v4l2_m2mdevice.cpp' ],\n>  ]\n>  \n>  foreach t : v4l2_videodevice_tests\n> diff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> new file mode 100644\n> index 000000000000..0e709223ab84\n> --- /dev/null\n> +++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> @@ -0,0 +1,212 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * libcamera V4L2 M2M video device tests\n> + */\n> +\n> +#include <iostream>\n> +\n> +#include <libcamera/buffer.h>\n> +#include <libcamera/camera_manager.h>\n> +#include <libcamera/event_dispatcher.h>\n> +#include <libcamera/timer.h>\n> +\n> +#include \"device_enumerator.h\"\n> +#include \"media_device.h\"\n> +#include \"v4l2_videodevice.h\"\n> +\n> +#include \"test.h\"\n> +\n> +using namespace std;\n> +using namespace libcamera;\n> +\n> +class V4L2M2MDeviceTest : public Test\n> +{\n> +public:\n> +\tV4L2M2MDeviceTest()\n> +\t\t: vim2m_(nullptr), outputFrames_(0), captureFrames_(0)\n> +\t{\n> +\t}\n> +\n> +\tvoid outputBufferComplete(Buffer *buffer)\n> +\t{\n> +\t\tcout << \"Received output buffer \" << buffer->index() << endl;\n> +\n> +\t\toutputFrames_++;\n> +\n> +\t\t/* Requeue the buffer for further use. */\n> +\t\tvim2m_->output()->queueBuffer(buffer);\n> +\t}\n> +\n> +\tvoid receiveCaptureBuffer(Buffer *buffer)\n> +\t{\n> +\t\tcout << \"Received capture buffer \" << buffer->index() << endl;\n> +\n> +\t\tcaptureFrames_++;\n> +\n> +\t\t/* Requeue the buffer for further use. */\n> +\t\tvim2m_->capture()->queueBuffer(buffer);\n> +\t}\n> +\n> +protected:\n> +\tint init()\n> +\t{\n> +\t\tenumerator_ = DeviceEnumerator::create();\n> +\t\tif (!enumerator_) {\n> +\t\t\tcerr << \"Failed to create device enumerator\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (enumerator_->enumerate()) {\n> +\t\t\tcerr << \"Failed to enumerate media devices\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tDeviceMatch dm(\"vim2m\");\n> +\t\tdm.add(\"vim2m-source\");\n> +\t\tdm.add(\"vim2m-sink\");\n> +\n> +\t\tmedia_ = enumerator_->search(dm);\n> +\t\tif (!media_) {\n> +\t\t\tcerr << \"No vim2m device found\" << endl;\n> +\t\t\treturn TestSkip;\n> +\t\t}\n> +\n> +\t\treturn TestPass;\n> +\t}\n> +\n> +\tint run()\n> +\t{\n> +\t\tconstexpr unsigned int bufferCount = 4;\n> +\n> +\t\tEventDispatcher *dispatcher = CameraManager::instance()->eventDispatcher();\n> +\t\tTimer timeout;\n> +\t\tint ret;\n> +\n> +\t\tMediaEntity *entity = media_->getEntityByName(\"vim2m-source\");\n> +\t\tvim2m_ = new V4L2M2MDevice(entity->deviceNode());\n> +\t\tif (vim2m_->open()) {\n> +\t\t\tcerr << \"Failed to open VIM2M device\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tV4L2VideoDevice *capture = vim2m_->capture();\n> +\t\tV4L2VideoDevice *output = vim2m_->output();\n> +\n> +\t\tV4L2DeviceFormat format = {};\n> +\t\tif (capture->getFormat(&format)) {\n> +\t\t\tcerr << \"Failed to get capture format\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tformat.size.width = 640;\n> +\t\tformat.size.height = 480;\n> +\n> +\t\tif (capture->setFormat(&format)) {\n> +\t\t\tcerr << \"Failed to set capture format\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (output->setFormat(&format)) {\n> +\t\t\tcerr << \"Failed to set output format\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tcapturePool_.createBuffers(bufferCount);\n> +\t\toutputPool_.createBuffers(bufferCount);\n> +\n> +\t\tret = capture->exportBuffers(&capturePool_);\n> +\t\tif (ret) {\n> +\t\t\tcerr << \"Failed to export Capture Buffers\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tret = output->exportBuffers(&outputPool_);\n> +\t\tif (ret) {\n> +\t\t\tcerr << \"Failed to export Output Buffers\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tcapture->bufferReady.connect(this, &V4L2M2MDeviceTest::receiveCaptureBuffer);\n> +\t\toutput->bufferReady.connect(this, &V4L2M2MDeviceTest::outputBufferComplete);\n> +\n> +\t\tstd::vector<std::unique_ptr<Buffer>> captureBuffers;\n> +\t\tcaptureBuffers = capture->queueAllBuffers();\n> +\t\tif (captureBuffers.empty()) {\n> +\t\t\tcerr << \"Failed to queue all Capture Buffers\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\t/* We can't \"queueAllBuffers()\" on an output device, so we do it manually */\n> +\t\tstd::vector<std::unique_ptr<Buffer>> outputBuffers;\n> +\t\tfor (unsigned int i = 0; i < outputPool_.count(); ++i) {\n> +\t\t\tBuffer *buffer = new Buffer(i);\n> +\t\t\toutputBuffers.emplace_back(buffer);\n> +\t\t\tret = output->queueBuffer(buffer);\n> +\t\t\tif (ret) {\n> +\t\t\t\tcerr << \"Failed to queue an output buffer\" << endl;\n\n\tcerr << \"Failed to queue output buffer \" << i << endl;\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> +\t\t\t\treturn TestFail;\n> +\t\t\t}\n> +\t\t}\n> +\n> +\t\tret = capture->streamOn();\n> +\t\tif (ret) {\n> +\t\t\tcerr << \"Failed to streamOn capture\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tret = output->streamOn();\n> +\t\tif (ret) {\n> +\t\t\tcerr << \"Failed to streamOn output\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ttimeout.start(5000);\n> +\t\twhile (timeout.isRunning()) {\n> +\t\t\tdispatcher->processEvents();\n> +\t\t\tif (captureFrames_ > 30)\n> +\t\t\t\tbreak;\n> +\t\t}\n> +\n> +\t\tcerr << \"Output \" << outputFrames_ << \" frames\" << std::endl;\n> +\t\tcerr << \"Captured \" << captureFrames_ << \" frames\" << std::endl;\n> +\n> +\t\tif (captureFrames_ < 30) {\n> +\t\t\tcerr << \"Failed to capture 30 frames within timeout.\" << std::endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tret = capture->streamOff();\n> +\t\tif (ret) {\n> +\t\t\tcerr << \"Failed to StreamOff the capture device.\" << std::endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tret = output->streamOff();\n> +\t\tif (ret) {\n> +\t\t\tcerr << \"Failed to StreamOff the output device.\" << std::endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\treturn TestPass;\n> +\t}\n> +\n> +\tvoid cleanup()\n> +\t{\n> +\t\tdelete vim2m_;\n> +\t};\n> +\n> +private:\n> +\tstd::unique_ptr<DeviceEnumerator> enumerator_;\n> +\tstd::shared_ptr<MediaDevice> media_;\n> +\tV4L2M2MDevice *vim2m_;\n> +\n> +\tBufferPool capturePool_;\n> +\tBufferPool outputPool_;\n> +\n> +\tunsigned int outputFrames_;\n> +\tunsigned int captureFrames_;\n> +};\n> +\n> +TEST_REGISTER(V4L2M2MDeviceTest);","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F75860C03\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 10 Aug 2019 15:44:29 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E30267;\n\tSat, 10 Aug 2019 15:44:28 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565444668;\n\tbh=lsa2H4TkLyKeOSBNCpQp5AImdj/9UFgWN1JkEqASn/I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=E11tyU33KQa38/5TOua14PWLJ1v2M12gwL8X9fO4WeXnMfRGqp4JXQeZ13xGjeJbM\n\tFfn8lNKzdhGSYGW7fIVqFz33xX8xVmY2fntBEQz/U3xQe+eFekUATniv1//vOOYTbR\n\t+Ucb8I6a3//R2nB3/obi2kihHg1v2xkCJvQLmHb4=","Date":"Sat, 10 Aug 2019 16:44:26 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190810134426.GB4788@pendragon.ideasonboard.com>","References":"<20190809150459.14421-1-kieran.bingham@ideasonboard.com>\n\t<20190809150459.14421-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190809150459.14421-5-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] test: v4l2_videodevice: Add\n\tM2M device test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 10 Aug 2019 13:44:29 -0000"}},{"id":2381,"web_url":"https://patchwork.libcamera.org/comment/2381/","msgid":"<2dfd2cec-f81e-2685-2040-8501bb6cf4a3@ideasonboard.com>","date":"2019-08-12T09:07:41","subject":"Re: [libcamera-devel] [PATCH v2 4/6] test: v4l2_videodevice: Add\n\tM2M device test","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 10/08/2019 14:44, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Aug 09, 2019 at 04:04:57PM +0100, Kieran Bingham wrote:\n>> The V4L2M2MDevice requires two pipelines to be configured. This makes it unsuitable\n> \n> s/pipelines/video devices/ ?\n\nChanged.\n\n> \n>> to reuse the existing V4L2DeviceTest test library in its current form.\n> \n> Line wrap ? vi wraps commit messages at a 72 characters boundary by\n> default, did you mess it up ?\n\nProbably forgot to run the rewrap after modifying the string. It only\nautomatically wraps the current cursor position. It doesn't rewrap as\nyou modify existing text.\n\n\nWrapped.\n\n\n> \n>> Implement a full test to run the two M2M pipelines through VIM2M.\n>>\n>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>> ---\n>>  test/v4l2_videodevice/meson.build        |   1 +\n>>  test/v4l2_videodevice/v4l2_m2mdevice.cpp | 212 +++++++++++++++++++++++\n>>  2 files changed, 213 insertions(+)\n>>  create mode 100644 test/v4l2_videodevice/v4l2_m2mdevice.cpp\n>>\n>> diff --git a/test/v4l2_videodevice/meson.build b/test/v4l2_videodevice/meson.build\n>> index 76be5e142bb6..ad41898b5f8b 100644\n>> --- a/test/v4l2_videodevice/meson.build\n>> +++ b/test/v4l2_videodevice/meson.build\n>> @@ -7,6 +7,7 @@ v4l2_videodevice_tests = [\n>>      [ 'stream_on_off',      'stream_on_off.cpp' ],\n>>      [ 'capture_async',      'capture_async.cpp' ],\n>>      [ 'buffer_sharing',     'buffer_sharing.cpp' ],\n>> +    [ 'v4l2_m2mdevice',     'v4l2_m2mdevice.cpp' ],\n>>  ]\n>>  \n>>  foreach t : v4l2_videodevice_tests\n>> diff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n>> new file mode 100644\n>> index 000000000000..0e709223ab84\n>> --- /dev/null\n>> +++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n>> @@ -0,0 +1,212 @@\n>> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n>> +/*\n>> + * Copyright (C) 2019, Google Inc.\n>> + *\n>> + * libcamera V4L2 M2M video device tests\n>> + */\n>> +\n>> +#include <iostream>\n>> +\n>> +#include <libcamera/buffer.h>\n>> +#include <libcamera/camera_manager.h>\n>> +#include <libcamera/event_dispatcher.h>\n>> +#include <libcamera/timer.h>\n>> +\n>> +#include \"device_enumerator.h\"\n>> +#include \"media_device.h\"\n>> +#include \"v4l2_videodevice.h\"\n>> +\n>> +#include \"test.h\"\n>> +\n>> +using namespace std;\n>> +using namespace libcamera;\n>> +\n>> +class V4L2M2MDeviceTest : public Test\n>> +{\n>> +public:\n>> +\tV4L2M2MDeviceTest()\n>> +\t\t: vim2m_(nullptr), outputFrames_(0), captureFrames_(0)\n>> +\t{\n>> +\t}\n>> +\n>> +\tvoid outputBufferComplete(Buffer *buffer)\n>> +\t{\n>> +\t\tcout << \"Received output buffer \" << buffer->index() << endl;\n>> +\n>> +\t\toutputFrames_++;\n>> +\n>> +\t\t/* Requeue the buffer for further use. */\n>> +\t\tvim2m_->output()->queueBuffer(buffer);\n>> +\t}\n>> +\n>> +\tvoid receiveCaptureBuffer(Buffer *buffer)\n>> +\t{\n>> +\t\tcout << \"Received capture buffer \" << buffer->index() << endl;\n>> +\n>> +\t\tcaptureFrames_++;\n>> +\n>> +\t\t/* Requeue the buffer for further use. */\n>> +\t\tvim2m_->capture()->queueBuffer(buffer);\n>> +\t}\n>> +\n>> +protected:\n>> +\tint init()\n>> +\t{\n>> +\t\tenumerator_ = DeviceEnumerator::create();\n>> +\t\tif (!enumerator_) {\n>> +\t\t\tcerr << \"Failed to create device enumerator\" << endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\tif (enumerator_->enumerate()) {\n>> +\t\t\tcerr << \"Failed to enumerate media devices\" << endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\tDeviceMatch dm(\"vim2m\");\n>> +\t\tdm.add(\"vim2m-source\");\n>> +\t\tdm.add(\"vim2m-sink\");\n>> +\n>> +\t\tmedia_ = enumerator_->search(dm);\n>> +\t\tif (!media_) {\n>> +\t\t\tcerr << \"No vim2m device found\" << endl;\n>> +\t\t\treturn TestSkip;\n>> +\t\t}\n>> +\n>> +\t\treturn TestPass;\n>> +\t}\n>> +\n>> +\tint run()\n>> +\t{\n>> +\t\tconstexpr unsigned int bufferCount = 4;\n>> +\n>> +\t\tEventDispatcher *dispatcher = CameraManager::instance()->eventDispatcher();\n>> +\t\tTimer timeout;\n>> +\t\tint ret;\n>> +\n>> +\t\tMediaEntity *entity = media_->getEntityByName(\"vim2m-source\");\n>> +\t\tvim2m_ = new V4L2M2MDevice(entity->deviceNode());\n>> +\t\tif (vim2m_->open()) {\n>> +\t\t\tcerr << \"Failed to open VIM2M device\" << endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\tV4L2VideoDevice *capture = vim2m_->capture();\n>> +\t\tV4L2VideoDevice *output = vim2m_->output();\n>> +\n>> +\t\tV4L2DeviceFormat format = {};\n>> +\t\tif (capture->getFormat(&format)) {\n>> +\t\t\tcerr << \"Failed to get capture format\" << endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\tformat.size.width = 640;\n>> +\t\tformat.size.height = 480;\n>> +\n>> +\t\tif (capture->setFormat(&format)) {\n>> +\t\t\tcerr << \"Failed to set capture format\" << endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\tif (output->setFormat(&format)) {\n>> +\t\t\tcerr << \"Failed to set output format\" << endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\tcapturePool_.createBuffers(bufferCount);\n>> +\t\toutputPool_.createBuffers(bufferCount);\n>> +\n>> +\t\tret = capture->exportBuffers(&capturePool_);\n>> +\t\tif (ret) {\n>> +\t\t\tcerr << \"Failed to export Capture Buffers\" << endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\tret = output->exportBuffers(&outputPool_);\n>> +\t\tif (ret) {\n>> +\t\t\tcerr << \"Failed to export Output Buffers\" << endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\tcapture->bufferReady.connect(this, &V4L2M2MDeviceTest::receiveCaptureBuffer);\n>> +\t\toutput->bufferReady.connect(this, &V4L2M2MDeviceTest::outputBufferComplete);\n>> +\n>> +\t\tstd::vector<std::unique_ptr<Buffer>> captureBuffers;\n>> +\t\tcaptureBuffers = capture->queueAllBuffers();\n>> +\t\tif (captureBuffers.empty()) {\n>> +\t\t\tcerr << \"Failed to queue all Capture Buffers\" << endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\t/* We can't \"queueAllBuffers()\" on an output device, so we do it manually */\n>> +\t\tstd::vector<std::unique_ptr<Buffer>> outputBuffers;\n>> +\t\tfor (unsigned int i = 0; i < outputPool_.count(); ++i) {\n>> +\t\t\tBuffer *buffer = new Buffer(i);\n>> +\t\t\toutputBuffers.emplace_back(buffer);\n>> +\t\t\tret = output->queueBuffer(buffer);\n>> +\t\t\tif (ret) {\n>> +\t\t\t\tcerr << \"Failed to queue an output buffer\" << endl;\n> \n> \tcerr << \"Failed to queue output buffer \" << i << endl;\n> \n\nUpdated,\n\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nCollected thanks.\n\n> \n>> +\t\t\t\treturn TestFail;\n>> +\t\t\t}\n>> +\t\t}\n>> +\n>> +\t\tret = capture->streamOn();\n>> +\t\tif (ret) {\n>> +\t\t\tcerr << \"Failed to streamOn capture\" << endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\tret = output->streamOn();\n>> +\t\tif (ret) {\n>> +\t\t\tcerr << \"Failed to streamOn output\" << endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\ttimeout.start(5000);\n>> +\t\twhile (timeout.isRunning()) {\n>> +\t\t\tdispatcher->processEvents();\n>> +\t\t\tif (captureFrames_ > 30)\n>> +\t\t\t\tbreak;\n>> +\t\t}\n>> +\n>> +\t\tcerr << \"Output \" << outputFrames_ << \" frames\" << std::endl;\n>> +\t\tcerr << \"Captured \" << captureFrames_ << \" frames\" << std::endl;\n>> +\n>> +\t\tif (captureFrames_ < 30) {\n>> +\t\t\tcerr << \"Failed to capture 30 frames within timeout.\" << std::endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\tret = capture->streamOff();\n>> +\t\tif (ret) {\n>> +\t\t\tcerr << \"Failed to StreamOff the capture device.\" << std::endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\tret = output->streamOff();\n>> +\t\tif (ret) {\n>> +\t\t\tcerr << \"Failed to StreamOff the output device.\" << std::endl;\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\treturn TestPass;\n>> +\t}\n>> +\n>> +\tvoid cleanup()\n>> +\t{\n>> +\t\tdelete vim2m_;\n>> +\t};\n>> +\n>> +private:\n>> +\tstd::unique_ptr<DeviceEnumerator> enumerator_;\n>> +\tstd::shared_ptr<MediaDevice> media_;\n>> +\tV4L2M2MDevice *vim2m_;\n>> +\n>> +\tBufferPool capturePool_;\n>> +\tBufferPool outputPool_;\n>> +\n>> +\tunsigned int outputFrames_;\n>> +\tunsigned int captureFrames_;\n>> +};\n>> +\n>> +TEST_REGISTER(V4L2M2MDeviceTest);\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6293660E38\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Aug 2019 11:07:45 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FFD5327;\n\tMon, 12 Aug 2019 11:07:44 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565600865;\n\tbh=HAdsAip1cSheWeAKAFQDauBlIv6fMtN4Cpb/pS/h44o=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=IBclV9lO6BNZvkegaunOtKsXZa/cJ1+OZEM2y73BN35p9yVRh13qPPB6rNpnnhfcl\n\tsdmUqr870cm6vtfha2+vzPTY0RL8kGGBy53uZoqJvxA9a/bKzgN0ez7nc9JUXaiuZs\n\tlyg40CkRbOkb7d3APWj5D3mfkh15x4BjRAsJrnnY=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","References":"<20190809150459.14421-1-kieran.bingham@ideasonboard.com>\n\t<20190809150459.14421-5-kieran.bingham@ideasonboard.com>\n\t<20190810134426.GB4788@pendragon.ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<2dfd2cec-f81e-2685-2040-8501bb6cf4a3@ideasonboard.com>","Date":"Mon, 12 Aug 2019 10:07:41 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.8.0","MIME-Version":"1.0","In-Reply-To":"<20190810134426.GB4788@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] test: v4l2_videodevice: Add\n\tM2M device test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 12 Aug 2019 09:07:45 -0000"}}]