[{"id":25752,"web_url":"https://patchwork.libcamera.org/comment/25752/","msgid":"","date":"2022-11-09T10:38:20","subject":"Re: [libcamera-devel] [PATCH v2 07/11] [WIP] utils: libtuning:\n\tparsers: Add yaml parser","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Sat, Oct 22, 2022 at 03:23:06PM +0900, Paul Elder via libcamera-devel wrote:\n> Add a parser to libtuning for parsing configuration files in yaml\n> format.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> Obviously this doesn't work. Technically it's fine because the only user\n> of the yaml parser at the moment works fine with no input configuration\n> file.\n\nDo we need to merge this, or can it be left out for now ? I'm fine\neither way, so\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/tuning/libtuning/parsers/__init__.py | 1 +\n> utils/tuning/libtuning/parsers/yaml_parser.py | 15 +++++++++++++++\n> 2 files changed, 16 insertions(+)\n> create mode 100644 utils/tuning/libtuning/parsers/yaml_parser.py\n> \n> diff --git a/utils/tuning/libtuning/parsers/__init__.py b/utils/tuning/libtuning/parsers/__init__.py\n> index 9d20d2fc..022c1e5d 100644\n> --- a/utils/tuning/libtuning/parsers/__init__.py\n> +++ b/utils/tuning/libtuning/parsers/__init__.py\n> @@ -3,3 +3,4 @@\n> # Copyright (C) 2022, Paul Elder \n> \n> from libtuning.parsers.raspberrypi_parser import RaspberryPiParser\n> +from libtuning.parsers.yaml_parser import YamlParser\n> diff --git a/utils/tuning/libtuning/parsers/yaml_parser.py b/utils/tuning/libtuning/parsers/yaml_parser.py\n> new file mode 100644\n> index 00000000..e2ce6e20\n> --- /dev/null\n> +++ b/utils/tuning/libtuning/parsers/yaml_parser.py\n> @@ -0,0 +1,15 @@\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> +#\n> +# Copyright (C) 2022, Paul Elder \n> +\n> +from .parser import Parser\n> +\n> +\n> +class YamlParser(Parser):\n> + def __init__(self):\n> + super().__init__()\n> +\n> + # todo Implement this (it's fine for now as we don't need a config for\n> + # rkisp1 LSC)\n> + def _parse(self, config_file, modules):\n> + return {}, []","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9744BD16B\n\tfor ;\n\tWed, 9 Nov 2022 10:38:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2311F6307B;\n\tWed, 9 Nov 2022 11:38:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40B3B61F3F\n\tfor ;\n\tWed, 9 Nov 2022 11:38:40 +0100 (CET)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A40AA526;\n\tWed, 9 Nov 2022 11:38:39 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1667990322;\n\tbh=mJoWiFzx3fWfZFIgbyzwKD95LgeMvFIlfcKCBYY2DnQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BNfs3mF6n+TVWkWJg6rNvtBf+woML93duQF2ofD1J+cMGTAQpGVAwKHjLnSYjO3HR\n\taMAfGyyajDcIjcqRicLP1915HbhqRop9MZFZODcXVNhBaCei80ra/JQJxfF8ben5eF\n\trygtRXDHcF0dxSN17QX99IfCx0IqZG4thuT21UP+K9kvHbvZP08w9hcCP1sI7eroyk\n\tz8y0+MNHrSN133bfH35SKdP3Nza7jqqbj9buU1OuK0XbObPbXHijwHYPoxO9G/Om3L\n\tgjNeN9Mpx3eiVPDNWjgbKjSHxmo4aMUAD0nbvUKAflhNTPqqWAe5IvGiWg0j4UEbF9\n\tzuv28+VoacSTQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1667990319;\n\tbh=mJoWiFzx3fWfZFIgbyzwKD95LgeMvFIlfcKCBYY2DnQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=X32huE6sbq/sOxvdXlgib49WFZWv28OEjyTOSRQ2YcYGtpure5W6Jm+RSxlDuCtHH\n\tkq4Y5ElHpBeYIll2iFy9WFEuwUJLZvzCmG2zPZ1Odp50fS3sC/IRYnlvj0T0yRQ4cq\n\tVRl8IPLlAH/8Ky2Ou92ll9mp3x+A6fFjqCZCk6BQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"X32huE6s\"; dkim-atps=neutral","Date":"Wed, 9 Nov 2022 12:38:20 +0200","To":"Paul Elder ","Message-ID":"","References":"<20221022062310.2545463-1-paul.elder@ideasonboard.com>\n\t<20221022062310.2545463-8-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221022062310.2545463-8-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 07/11] [WIP] utils: libtuning:\n\tparsers: Add yaml parser","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25764,"web_url":"https://patchwork.libcamera.org/comment/25764/","msgid":"","date":"2022-11-10T07:16:20","subject":"Re: [libcamera-devel] [PATCH v2 07/11] [WIP] utils: libtuning:\n\tparsers: Add yaml parser","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Nov 09, 2022 at 12:38:20PM +0200, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> On Sat, Oct 22, 2022 at 03:23:06PM +0900, Paul Elder via libcamera-devel wrote:\n> > Add a parser to libtuning for parsing configuration files in yaml\n> > format.\n> > \n> > Signed-off-by: Paul Elder \n> > \n> > ---\n> > Obviously this doesn't work. Technically it's fine because the only user\n> > of the yaml parser at the moment works fine with no input configuration\n> > file.\n> \n> Do we need to merge this, or can it be left out for now ? I'm fine\n> either way, so\n\nWe actually don't, but I think it's better to keep it in otherwise I'm\ncertain we'll forget about it later.\n\nShould I return empty or raise NotImplementedError?\n\n> \n> Reviewed-by: Laurent Pinchart \n\n\nThanks,\n\nPaul\n\n> \n> > ---\n> > utils/tuning/libtuning/parsers/__init__.py | 1 +\n> > utils/tuning/libtuning/parsers/yaml_parser.py | 15 +++++++++++++++\n> > 2 files changed, 16 insertions(+)\n> > create mode 100644 utils/tuning/libtuning/parsers/yaml_parser.py\n> > \n> > diff --git a/utils/tuning/libtuning/parsers/__init__.py b/utils/tuning/libtuning/parsers/__init__.py\n> > index 9d20d2fc..022c1e5d 100644\n> > --- a/utils/tuning/libtuning/parsers/__init__.py\n> > +++ b/utils/tuning/libtuning/parsers/__init__.py\n> > @@ -3,3 +3,4 @@\n> > # Copyright (C) 2022, Paul Elder \n> > \n> > from libtuning.parsers.raspberrypi_parser import RaspberryPiParser\n> > +from libtuning.parsers.yaml_parser import YamlParser\n> > diff --git a/utils/tuning/libtuning/parsers/yaml_parser.py b/utils/tuning/libtuning/parsers/yaml_parser.py\n> > new file mode 100644\n> > index 00000000..e2ce6e20\n> > --- /dev/null\n> > +++ b/utils/tuning/libtuning/parsers/yaml_parser.py\n> > @@ -0,0 +1,15 @@\n> > +# SPDX-License-Identifier: GPL-2.0-or-later\n> > +#\n> > +# Copyright (C) 2022, Paul Elder \n> > +\n> > +from .parser import Parser\n> > +\n> > +\n> > +class YamlParser(Parser):\n> > + def __init__(self):\n> > + super().__init__()\n> > +\n> > + # todo Implement this (it's fine for now as we don't need a config for\n> > + # rkisp1 LSC)\n> > + def _parse(self, config_file, modules):\n> > + return {}, []","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA707BE08B\n\tfor ;\n\tThu, 10 Nov 2022 07:16:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D6566307B;\n\tThu, 10 Nov 2022 08:16:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D89AE61F38\n\tfor ;\n\tThu, 10 Nov 2022 08:16:26 +0100 (CET)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6A51E499;\n\tThu, 10 Nov 2022 08:16:25 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668064589;\n\tbh=Xz5/TISlvXBP8AkbsUIJV8qggQBGGEU9lRPP6psyRkE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=OqT8wiWta+TumRPQre5SbRgxO/Ck7GeR7aqF6+xQ11LkJypGRSxVvDP0F8FBzSYc1\n\tbe66UMKnoIuH1WgtX9Bkb+IUYXgHFeY31ymmJ4Q1cKyQ5N4M1GG4JdDLp4XeJrN+bX\n\t+DOItOtQ+uDbYtOIor7fFLNgQ2Miud68+eGsALeH1I3s9q9t+YJJUG3ZYJqaF1iVhi\n\tg7ZyoyF6u4wStkz7EjBP2/v9AprsEFxfCXD7gHgcd9PtFn4uBBeJZ+xfGe8ky8AP2j\n\ti49MzYyEsnrEsJQJiA6AHj0g06Aw7FcyaoGSkfLaCHK37IwNOYtEDixsv1yPZ3fg1Y\n\tL8VdIBDiGDh9g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668064586;\n\tbh=Xz5/TISlvXBP8AkbsUIJV8qggQBGGEU9lRPP6psyRkE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IkQFG6o2rEdIqtevNGy3gFsWGV+Kf4wPqhJmvbp2EDl0vzWi3ZYibGxoinXmRHSKl\n\tcyBHkBxHor88UoDRgBPd1/58apzCHpDJqQv6R9V2doMyOQKvPS6ixnMmbTntalc6fU\n\tQdu1B55phap1l1hU1Ep4BC+lzfbKqQ+7wSUxOYmg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IkQFG6o2\"; dkim-atps=neutral","Date":"Thu, 10 Nov 2022 16:16:20 +0900","To":"Laurent Pinchart ","Message-ID":"","References":"<20221022062310.2545463-1-paul.elder@ideasonboard.com>\n\t<20221022062310.2545463-8-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 07/11] [WIP] utils: libtuning:\n\tparsers: Add yaml parser","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25766,"web_url":"https://patchwork.libcamera.org/comment/25766/","msgid":"","date":"2022-11-10T07:35:20","subject":"Re: [libcamera-devel] [PATCH v2 07/11] [WIP] utils: libtuning:\n\tparsers: Add yaml parser","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Nov 10, 2022 at 04:16:20PM +0900, Paul Elder via libcamera-devel wrote:\n> On Wed, Nov 09, 2022 at 12:38:20PM +0200, Laurent Pinchart wrote:\n> > Hi Paul,\n> > \n> > Thank you for the patch.\n> > \n> > On Sat, Oct 22, 2022 at 03:23:06PM +0900, Paul Elder via libcamera-devel wrote:\n> > > Add a parser to libtuning for parsing configuration files in yaml\n> > > format.\n> > > \n> > > Signed-off-by: Paul Elder \n> > > \n> > > ---\n> > > Obviously this doesn't work. Technically it's fine because the only user\n> > > of the yaml parser at the moment works fine with no input configuration\n> > > file.\n> > \n> > Do we need to merge this, or can it be left out for now ? I'm fine\n> > either way, so\n> \n> We actually don't, but I think it's better to keep it in otherwise I'm\n> certain we'll forget about it later.\n> \n> Should I return empty or raise NotImplementedError?\n\nI should return empty, because this is the parser that the rkisp1 tuning\nscript uses, and it needs to return *something*.\n\nBasically I'll leave this as-is, until we have some config options. Then\nI'll implement this :)\n\n\nPaul\n\n> \n> > \n> > Reviewed-by: Laurent Pinchart \n> \n> \n> > \n> > > ---\n> > > utils/tuning/libtuning/parsers/__init__.py | 1 +\n> > > utils/tuning/libtuning/parsers/yaml_parser.py | 15 +++++++++++++++\n> > > 2 files changed, 16 insertions(+)\n> > > create mode 100644 utils/tuning/libtuning/parsers/yaml_parser.py\n> > > \n> > > diff --git a/utils/tuning/libtuning/parsers/__init__.py b/utils/tuning/libtuning/parsers/__init__.py\n> > > index 9d20d2fc..022c1e5d 100644\n> > > --- a/utils/tuning/libtuning/parsers/__init__.py\n> > > +++ b/utils/tuning/libtuning/parsers/__init__.py\n> > > @@ -3,3 +3,4 @@\n> > > # Copyright (C) 2022, Paul Elder \n> > > \n> > > from libtuning.parsers.raspberrypi_parser import RaspberryPiParser\n> > > +from libtuning.parsers.yaml_parser import YamlParser\n> > > diff --git a/utils/tuning/libtuning/parsers/yaml_parser.py b/utils/tuning/libtuning/parsers/yaml_parser.py\n> > > new file mode 100644\n> > > index 00000000..e2ce6e20\n> > > --- /dev/null\n> > > +++ b/utils/tuning/libtuning/parsers/yaml_parser.py\n> > > @@ -0,0 +1,15 @@\n> > > +# SPDX-License-Identifier: GPL-2.0-or-later\n> > > +#\n> > > +# Copyright (C) 2022, Paul Elder \n> > > +\n> > > +from .parser import Parser\n> > > +\n> > > +\n> > > +class YamlParser(Parser):\n> > > + def __init__(self):\n> > > + super().__init__()\n> > > +\n> > > + # todo Implement this (it's fine for now as we don't need a config for\n> > > + # rkisp1 LSC)\n> > > + def _parse(self, config_file, modules):\n> > > + return {}, []","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3579ABE08B\n\tfor ;\n\tThu, 10 Nov 2022 07:35:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A670C6307B;\n\tThu, 10 Nov 2022 08:35:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCD6261F38\n\tfor ;\n\tThu, 10 Nov 2022 08:35:27 +0100 (CET)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CFFB499;\n\tThu, 10 Nov 2022 08:35:25 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668065729;\n\tbh=Qf3QSe+StgLWOpUIH7XWfpip19ksjXwsDfT3Vtlpvnk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=q5vIrZ5IvGe90bGPv2FLUOet6a/OEpu8qU0QV3ZY/Ez7urZYQcn8AYP03YEaZUuKg\n\tzDMZEVXsRUXpsSx7i092vCxhndaeM5eYpYQpNdp9jlwhus6Aj6S8RL/M2fco4latNt\n\tNBSRv9jNnGskfzcBjCvFqJ2rUaUYGGLmzsjCAwutiXKZjPGiZnwIhaYJZjVgEvHtLy\n\t98JNzgLPPS0dgf6SCmCJ0c1SVDXBl60N0MKb8e5wC1w9rmrpdzHmww2d2Ak04aFybO\n\tmYaAzGuvOGvHV7oTNH4o4Apoy8r8v1PkMKoERLGzUYMVI/KQXQcDzcvpKi2iwiJIhk\n\tztoBgIXz6o5ZA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668065727;\n\tbh=Qf3QSe+StgLWOpUIH7XWfpip19ksjXwsDfT3Vtlpvnk=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=Yn2PtNmiVslOhHz+DRA6na3xEtshsKhMitNFvzOfqI8vapLgL/lzYioGBT+YbJ8qs\n\t/m58uR+xJliUX7PaTvlGF96+fGLvqre8ISCi9CG22Eg2RF1MZfNSzB6YRIqObVgJWo\n\tRWgtXsCW0K44xKrwTvdtSIO1b+8FzxOJLZsUGX8M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Yn2PtNmi\"; dkim-atps=neutral","Date":"Thu, 10 Nov 2022 16:35:20 +0900","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"","References":"<20221022062310.2545463-1-paul.elder@ideasonboard.com>\n\t<20221022062310.2545463-8-paul.elder@ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 07/11] [WIP] utils: libtuning:\n\tparsers: Add yaml parser","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]