[{"id":25493,"web_url":"https://patchwork.libcamera.org/comment/25493/","msgid":"<20221020065550.GJ3874866@pyrite.rasen.tech>","date":"2022-10-20T06:55:50","subject":"Re: [libcamera-devel] [PATCH v1 5/6] apps: Move libtiff dependency\n\tto src/apps/meson.build","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Thu, Oct 20, 2022 at 02:15:36AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> libtiff is a shared dependency between cam and qcam, move it to\n> src/apps/. The shared dependency will be used to condition compilation\n> of source files in an upcoming application static library.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/apps/cam/meson.build | 1 -\n> src/apps/meson.build | 2 ++\n> src/apps/qcam/meson.build | 5 ++---\n> 3 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\n> index 4b6099ddab63..297de64fbdd9 100644\n> --- a/src/apps/cam/meson.build\n> +++ b/src/apps/cam/meson.build\n> @@ -24,7 +24,6 @@ cam_cpp_args = []\n> libdrm = dependency('libdrm', required : false)\n> libjpeg = dependency('libjpeg', required : false)\n> libsdl2 = dependency('SDL2', required : false)\n> -libtiff = dependency('libtiff-4', required : false)\n> \n> if libdrm.found()\n> cam_cpp_args += [ '-DHAVE_KMS' ]\n> diff --git a/src/apps/meson.build b/src/apps/meson.build\n> index 159deb0b7fc2..95f1f5190c7a 100644\n> --- a/src/apps/meson.build\n> +++ b/src/apps/meson.build\n> @@ -8,6 +8,8 @@ if not libevent.found()\n> libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> endif\n> \n> +libtiff = dependency('libtiff-4', required : false)\n> +\n> subdir('lc-compliance')\n> \n> subdir('cam')\n> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> index d5916d0df532..e298101e2c43 100644\n> --- a/src/apps/qcam/meson.build\n> +++ b/src/apps/qcam/meson.build\n> @@ -38,8 +38,7 @@ qcam_resources = files([\n> \n> qt5_cpp_args = ['-DQT_NO_KEYWORDS']\n> \n> -tiff_dep = dependency('libtiff-4', required : false)\n> -if tiff_dep.found()\n> +if libtiff.found()\n> qt5_cpp_args += ['-DHAVE_TIFF']\n> qcam_sources += files([\n> '../cam/dng_writer.cpp',\n> @@ -77,7 +76,7 @@ qcam = executable('qcam', qcam_sources, resources,\n> dependencies : [\n> libatomic,\n> libcamera_public,\n> + libtiff,\n> qt5_dep,\n> - tiff_dep,\n> ],\n> cpp_args : qt5_cpp_args)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8E08C0DA4\n\tfor ;\n\tThu, 20 Oct 2022 06:55:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 906DE62E94;\n\tThu, 20 Oct 2022 08:55:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94B4C62E75\n\tfor ;\n\tThu, 20 Oct 2022 08:55:57 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42A1A570;\n\tThu, 20 Oct 2022 08:55:55 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666248958;\n\tbh=SajLjYk7MxXsLS/z4sXICZknZf4z9MmIwdjB97Hh8D4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xouIiIcCGPeKQb8vAvb4C6L0obQ1YMOzV+9rkb6Du6r5wSOPupaWwVhDuN54rOk63\n\tZ7Sk9FE7znyM9M91IElzgIfc3iuKaDG3+fSEv28kKX6rjCedQjddzwYsMdjUJ+r4NS\n\tWAqb7nnxd/ZCCUj091eOVoyX1O61rqpHRV/0TPQ5T1rh3nluOM1D9bG2wk9jyDkP6p\n\tEyympevjztElGcRkRNTzd9Ao4AO1ZKUkyuU5tgWzITelu/7RDZKMXvUaCWW/D/mOrg\n\tOWGxOwLWD7pRkCXfdIZuNlaoiqxMpupRyQcFw/3gobHFCab4Mvvqp+VwYDjXwQueXP\n\tbjPYifbCvi8vA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666248957;\n\tbh=SajLjYk7MxXsLS/z4sXICZknZf4z9MmIwdjB97Hh8D4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Z2GlnBDCEMzVZXQcaQVcmQuO93ZlEe2jpZ9X4HGXCBHQBfmp4qA6qQQeH9J6rMMt7\n\tKo1RBhGMwFpkrcOgi1sQ+HihmJ0AhI9Pv8DVpYvG987UOvwCGKES/yc4VTNfiNJw7u\n\tb+TL+UWXD1NF0iRNeQ4P6fiQxjzVDCu5ajf3fRaU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Z2GlnBDC\"; dkim-atps=neutral","Date":"Thu, 20 Oct 2022 15:55:50 +0900","To":"Laurent Pinchart ","Message-ID":"<20221020065550.GJ3874866@pyrite.rasen.tech>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20221019231537.26880-6-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 5/6] apps: Move libtiff dependency\n\tto src/apps/meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25508,"web_url":"https://patchwork.libcamera.org/comment/25508/","msgid":"<166625937341.2560709.6122408019552603619@Monstersaurus>","date":"2022-10-20T09:49:33","subject":"Re: [libcamera-devel] [PATCH v1 5/6] apps: Move libtiff dependency\n\tto src/apps/meson.build","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder via libcamera-devel (2022-10-20 07:55:50)\n> On Thu, Oct 20, 2022 at 02:15:36AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > libtiff is a shared dependency between cam and qcam, move it to\n> > src/apps/. The shared dependency will be used to condition compilation\n> > of source files in an upcoming application static library.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Paul Elder \n\nReviewed-by: Kieran Bingham \n\n> \n> > ---\n> > src/apps/cam/meson.build | 1 -\n> > src/apps/meson.build | 2 ++\n> > src/apps/qcam/meson.build | 5 ++---\n> > 3 files changed, 4 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\n> > index 4b6099ddab63..297de64fbdd9 100644\n> > --- a/src/apps/cam/meson.build\n> > +++ b/src/apps/cam/meson.build\n> > @@ -24,7 +24,6 @@ cam_cpp_args = []\n> > libdrm = dependency('libdrm', required : false)\n> > libjpeg = dependency('libjpeg', required : false)\n> > libsdl2 = dependency('SDL2', required : false)\n> > -libtiff = dependency('libtiff-4', required : false)\n> > \n> > if libdrm.found()\n> > cam_cpp_args += [ '-DHAVE_KMS' ]\n> > diff --git a/src/apps/meson.build b/src/apps/meson.build\n> > index 159deb0b7fc2..95f1f5190c7a 100644\n> > --- a/src/apps/meson.build\n> > +++ b/src/apps/meson.build\n> > @@ -8,6 +8,8 @@ if not libevent.found()\n> > libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> > endif\n> > \n> > +libtiff = dependency('libtiff-4', required : false)\n> > +\n> > subdir('lc-compliance')\n> > \n> > subdir('cam')\n> > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > index d5916d0df532..e298101e2c43 100644\n> > --- a/src/apps/qcam/meson.build\n> > +++ b/src/apps/qcam/meson.build\n> > @@ -38,8 +38,7 @@ qcam_resources = files([\n> > \n> > qt5_cpp_args = ['-DQT_NO_KEYWORDS']\n> > \n> > -tiff_dep = dependency('libtiff-4', required : false)\n> > -if tiff_dep.found()\n> > +if libtiff.found()\n> > qt5_cpp_args += ['-DHAVE_TIFF']\n> > qcam_sources += files([\n> > '../cam/dng_writer.cpp',\n> > @@ -77,7 +76,7 @@ qcam = executable('qcam', qcam_sources, resources,\n> > dependencies : [\n> > libatomic,\n> > libcamera_public,\n> > + libtiff,\n> > qt5_dep,\n> > - tiff_dep,\n> > ],\n> > cpp_args : qt5_cpp_args)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A973ABD16B\n\tfor ;\n\tThu, 20 Oct 2022 09:49:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59D7362EA3;\n\tThu, 20 Oct 2022 11:49:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DA4F62E9C\n\tfor ;\n\tThu, 20 Oct 2022 11:49:36 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8B89570;\n\tThu, 20 Oct 2022 11:49:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666259377;\n\tbh=BjLVNXW3SacHGiI1zt02+q90mOifV5etInF8vne8apw=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=lO72G7nUa45AU95E2dHzHRxoiTdwEYt+b+pgfAH62rpdGiLnjRQxBP64TgToZMmBk\n\tHsbGzAHAs6ZT6vPfLq6Pft1YKP5n4iIkmdY0H0Lqmpt0GYWGj8AopCFHj5e4WO7oSq\n\tPbOeyW5xYezAk2jIYTPfW4SVhkiJw4uQf6Sn09rFpY1qWiD2NfF5ObtKqln/AmOjb0\n\t/K58D9HbMRboCBpEiokHCnc2NWZG/tElNZJejZ+Jnx1lKr/ZKhpO41BcrvUGTHPeBe\n\trnloBmp6NEGB31vuWEeD1y1bKygXgRYeW0ej7WL8zFgU29rudVoU5+71Xy2CZJiRbw\n\tnLE2PCzI/xMPw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666259375;\n\tbh=BjLVNXW3SacHGiI1zt02+q90mOifV5etInF8vne8apw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=vhAaLLZh9yciWGY6Y2JBnYDjZU6M4ZwOrVz5XM9BcdIbZZ5LxKaXI/ngun/Q2JWpX\n\t8BgtNXrGH4Y31Ce+kGIaNJNE2YgM/eu/7gje+781Y5/eUfPWcAH3Vk7W46QXt8uX66\n\tnC2SCEawg80MzXj7VbKsf3b7fR5RzlP/AZKgBP90="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vhAaLLZh\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221020065550.GJ3874866@pyrite.rasen.tech>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-6-laurent.pinchart@ideasonboard.com>\n\t<20221020065550.GJ3874866@pyrite.rasen.tech>","To":"Laurent Pinchart ,\n\tPaul Elder via libcamera-devel , \n\tpaul.elder@ideasonboard.com","Date":"Thu, 20 Oct 2022 10:49:33 +0100","Message-ID":"<166625937341.2560709.6122408019552603619@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 5/6] apps: Move libtiff dependency\n\tto src/apps/meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]