[{"id":25491,"web_url":"https://patchwork.libcamera.org/comment/25491/","msgid":"<20221020065350.GH3874866@pyrite.rasen.tech>","date":"2022-10-20T06:53:50","subject":"Re: [libcamera-devel] [PATCH v1 4/6] apps: Move libevent dependency\n\tto src/apps/meson.build","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Thu, Oct 20, 2022 at 02:15:35AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> libtiff is a shared dependency between cam and lc-compliance, move it to\n> src/apps/. The shared dependency will be used to condition compilation\n> of source files in an upcoming application static library.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/apps/cam/meson.build | 4 +---\n> src/apps/lc-compliance/meson.build | 3 +--\n> src/apps/meson.build | 8 ++++++++\n> 3 files changed, 10 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\n> index 06dbea0645b7..4b6099ddab63 100644\n> --- a/src/apps/cam/meson.build\n> +++ b/src/apps/cam/meson.build\n> @@ -1,8 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -libevent = dependency('libevent_pthreads', required : get_option('cam'))\n> -\n> -if not libevent.found()\n> +if opt_cam.disabled() or not libevent.found()\n> cam_enabled = false\n> subdir_done()\n> endif\n> diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\n> index 8b57474be2b2..05d622be0a40 100644\n> --- a/src/apps/lc-compliance/meson.build\n> +++ b/src/apps/lc-compliance/meson.build\n> @@ -1,10 +1,9 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -libevent = dependency('libevent_pthreads', required : get_option('lc-compliance'))\n> libgtest = dependency('gtest', required : get_option('lc-compliance'),\n> fallback : ['gtest', 'gtest_dep'])\n> \n> -if not (libevent.found() and libgtest.found())\n> +if opt_lc_compliance.disabled() or not libevent.found() or not libgtest.found()\n> lc_compliance_enabled = false\n> subdir_done()\n> endif\n> diff --git a/src/apps/meson.build b/src/apps/meson.build\n> index 9e4388bd7881..159deb0b7fc2 100644\n> --- a/src/apps/meson.build\n> +++ b/src/apps/meson.build\n> @@ -1,5 +1,13 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> +opt_cam = get_option('cam')\n> +opt_lc_compliance = get_option('lc-compliance')\n> +\n> +libevent = dependency('libevent_pthreads', required : opt_cam)\n> +if not libevent.found()\n> + libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> +endif\n> +\n> subdir('lc-compliance')\n> \n> subdir('cam')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3D769C0DA4\n\tfor ;\n\tThu, 20 Oct 2022 06:54:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7CB8A62E93;\n\tThu, 20 Oct 2022 08:54:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07C1A62E75\n\tfor ;\n\tThu, 20 Oct 2022 08:53:59 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8E263570;\n\tThu, 20 Oct 2022 08:53:57 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666248840;\n\tbh=Aa4NAMugXjX9S7eZAp3yJGh7UCTVCdf1HypKKNW8J5c=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JDGE4uxnl0Q6pBYDsUbdUAnjlNRlKvkEbSNXRTaepSLl1qjF9uoD35Pp1abTWnYOj\n\tMj6jbWWIqPsRA48Vf76yELfjSyE5Kf6zwROV+xYvt6hPeOvevegFTdGbft6RNN+6Lr\n\tfJ1JbZw4m6lRQAWCt+Dsx021guooQm2kQKBqj1wVWv7BBCrad50cZ6sOKwZC/RZ12w\n\tlz4G5ePVmrg4RJp4KM4GnqIz/rMUx5+QmI0eoElUb1ipbD183tHNYO9G7ZrbBPiKS+\n\tmbqMFHDj5XR62gp/Cz7Bs06wZa7dVliFi92qcXODE/O7RLQOMd+XpMowaNUlIgWT3K\n\tFERF5fu+ROKuQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666248838;\n\tbh=Aa4NAMugXjX9S7eZAp3yJGh7UCTVCdf1HypKKNW8J5c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Hxc8AjrfQMohNXiZlzozUB55vwspYmr7LqWijeNiTRmKZewhOXCwVPULBZbro/CJw\n\tWB7L4c+UMyJ3tWRBSTrmXUizRJLKSzTXD/TSbYmSk0aUUoiW4Dsq++b0WlEMSdHDpu\n\tioZAvgFrk4BKpA2mMZmYFY+HIJgjN3PLIAJy5Ucg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Hxc8Ajrf\"; dkim-atps=neutral","Date":"Thu, 20 Oct 2022 15:53:50 +0900","To":"Laurent Pinchart ","Message-ID":"<20221020065350.GH3874866@pyrite.rasen.tech>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20221019231537.26880-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 4/6] apps: Move libevent dependency\n\tto src/apps/meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25492,"web_url":"https://patchwork.libcamera.org/comment/25492/","msgid":"<20221020065445.GI3874866@pyrite.rasen.tech>","date":"2022-10-20T06:54:45","subject":"Re: [libcamera-devel] [PATCH v1 4/6] apps: Move libevent dependency\n\tto src/apps/meson.build","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Thu, Oct 20, 2022 at 02:15:35AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> libtiff is a shared dependency between cam and lc-compliance, move it to\n\ns/libtiff/libevent/\n\n> src/apps/. The shared dependency will be used to condition compilation\n> of source files in an upcoming application static library.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/apps/cam/meson.build | 4 +---\n> src/apps/lc-compliance/meson.build | 3 +--\n> src/apps/meson.build | 8 ++++++++\n> 3 files changed, 10 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\n> index 06dbea0645b7..4b6099ddab63 100644\n> --- a/src/apps/cam/meson.build\n> +++ b/src/apps/cam/meson.build\n> @@ -1,8 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -libevent = dependency('libevent_pthreads', required : get_option('cam'))\n> -\n> -if not libevent.found()\n> +if opt_cam.disabled() or not libevent.found()\n> cam_enabled = false\n> subdir_done()\n> endif\n> diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\n> index 8b57474be2b2..05d622be0a40 100644\n> --- a/src/apps/lc-compliance/meson.build\n> +++ b/src/apps/lc-compliance/meson.build\n> @@ -1,10 +1,9 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -libevent = dependency('libevent_pthreads', required : get_option('lc-compliance'))\n> libgtest = dependency('gtest', required : get_option('lc-compliance'),\n> fallback : ['gtest', 'gtest_dep'])\n> \n> -if not (libevent.found() and libgtest.found())\n> +if opt_lc_compliance.disabled() or not libevent.found() or not libgtest.found()\n> lc_compliance_enabled = false\n> subdir_done()\n> endif\n> diff --git a/src/apps/meson.build b/src/apps/meson.build\n> index 9e4388bd7881..159deb0b7fc2 100644\n> --- a/src/apps/meson.build\n> +++ b/src/apps/meson.build\n> @@ -1,5 +1,13 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> +opt_cam = get_option('cam')\n> +opt_lc_compliance = get_option('lc-compliance')\n> +\n> +libevent = dependency('libevent_pthreads', required : opt_cam)\n> +if not libevent.found()\n> + libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> +endif\n> +\n> subdir('lc-compliance')\n> \n> subdir('cam')\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55FE2C0DA4\n\tfor ;\n\tThu, 20 Oct 2022 06:54:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1112262E93;\n\tThu, 20 Oct 2022 08:54:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4FC062E75\n\tfor ;\n\tThu, 20 Oct 2022 08:54:52 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 539B7570;\n\tThu, 20 Oct 2022 08:54:51 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666248894;\n\tbh=Yx8hJPBqtWZkDt054DHGeCnmp+jn8wYRRMhBKQlqjCE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vsAlScq3BDco7ur8DWRY4m1SEXZqahR6cmSnvMiZA1890BSobs1xzQkuebQMIqwo2\n\trgbADEktn0H+wEKnL+zO1RkvKZIKIzkAoc/zAVi07FdE2JLgnTI8oSdRuXIKHidjNe\n\tKCFxvGs9rbRtlAlIJO1FKe9qIbWUWJtJrvZ05m2Wr0Ngnz0c/R4oRuuvL9no8xulBa\n\twTAuF5nE3bLYHbv4tD5laVM5nB4lhhR5+FlyUUZbvIbP3YEQoNgQ3sLFGhLGtYtB4j\n\t1UE/UkCgSoKhu4yn1mRQ7vKjeKCz/O/NZ74bd1VpVCaWO5f3xBarFW193TwyldUUvT\n\ts+GBDVsy/3TqQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666248892;\n\tbh=Yx8hJPBqtWZkDt054DHGeCnmp+jn8wYRRMhBKQlqjCE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PuIWmXCkzj22COwBg3i5rIdG0GBQKyhe+2W6A7yroRalsk6ozKLOg+w9hVlI7WGIh\n\tS60BxAk+m6vXl/BJ4huvYmE+sK7zMiXrRGH5LKLKsWr8Ex5zOs1bM0rFALivsYvEO9\n\tE647qUmjrAHi9BbBdZEJoEuVj4LfqpZd8wsGKVkw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PuIWmXCk\"; dkim-atps=neutral","Date":"Thu, 20 Oct 2022 15:54:45 +0900","To":"Laurent Pinchart ","Message-ID":"<20221020065445.GI3874866@pyrite.rasen.tech>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20221019231537.26880-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 4/6] apps: Move libevent dependency\n\tto src/apps/meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25504,"web_url":"https://patchwork.libcamera.org/comment/25504/","msgid":"<166625679256.2560709.9553120856073763736@Monstersaurus>","date":"2022-10-20T09:06:32","subject":"Re: [libcamera-devel] [PATCH v1 4/6] apps: Move libevent dependency\n\tto src/apps/meson.build","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder via libcamera-devel (2022-10-20 07:54:45)\n> On Thu, Oct 20, 2022 at 02:15:35AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > libtiff is a shared dependency between cam and lc-compliance, move it to\n> \n> s/libtiff/libevent/\n> \n> > src/apps/. The shared dependency will be used to condition compilation\n> > of source files in an upcoming application static library.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/apps/cam/meson.build | 4 +---\n> > src/apps/lc-compliance/meson.build | 3 +--\n> > src/apps/meson.build | 8 ++++++++\n> > 3 files changed, 10 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\n> > index 06dbea0645b7..4b6099ddab63 100644\n> > --- a/src/apps/cam/meson.build\n> > +++ b/src/apps/cam/meson.build\n> > @@ -1,8 +1,6 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> > \n> > -libevent = dependency('libevent_pthreads', required : get_option('cam'))\n> > -\n> > -if not libevent.found()\n> > +if opt_cam.disabled() or not libevent.found()\n> > cam_enabled = false\n> > subdir_done()\n> > endif\n> > diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\n> > index 8b57474be2b2..05d622be0a40 100644\n> > --- a/src/apps/lc-compliance/meson.build\n> > +++ b/src/apps/lc-compliance/meson.build\n> > @@ -1,10 +1,9 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> > \n> > -libevent = dependency('libevent_pthreads', required : get_option('lc-compliance'))\n> > libgtest = dependency('gtest', required : get_option('lc-compliance'),\n> > fallback : ['gtest', 'gtest_dep'])\n> > \n> > -if not (libevent.found() and libgtest.found())\n> > +if opt_lc_compliance.disabled() or not libevent.found() or not libgtest.found()\n> > lc_compliance_enabled = false\n> > subdir_done()\n> > endif\n> > diff --git a/src/apps/meson.build b/src/apps/meson.build\n> > index 9e4388bd7881..159deb0b7fc2 100644\n> > --- a/src/apps/meson.build\n> > +++ b/src/apps/meson.build\n> > @@ -1,5 +1,13 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> > \n> > +opt_cam = get_option('cam')\n> > +opt_lc_compliance = get_option('lc-compliance')\n> > +\n> > +libevent = dependency('libevent_pthreads', required : opt_cam)\n> > +if not libevent.found()\n> > + libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> > +endif\n\nThis ... is an odd way to express this. I expect we can't do sufficient\nboolean operations with opt_cam and opt_lc_compliance?\n\nIt deserves a comment above to say why we are searching for the\ndependency twice. Though I expect anyone trying to optimise it to a\nsingle line would quickly hit whatever has caused you to break it out to\ntwo.\n\n\nReviewed-by: Kieran Bingham \n\n> > +\n> > subdir('lc-compliance')\n> > \n> > subdir('cam')\n> > -- \n> > Regards,\n> > \n> > Laurent Pinchart\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D40C8BD16B\n\tfor ;\n\tThu, 20 Oct 2022 09:06:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 414A262E9F;\n\tThu, 20 Oct 2022 11:06:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F99862E9C\n\tfor ;\n\tThu, 20 Oct 2022 11:06:35 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CE478570;\n\tThu, 20 Oct 2022 11:06:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666256797;\n\tbh=HJNEzo9ueK+oT3G3P3++TmRwYy05EWrfltXN8IETzvs=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=N6wm5P0jXGp6VZzKcpqdhRMMJXoCFSuQjHqM124ETOgPD2k6+DQP+W2QyC9bS/Kuu\n\tz8W2DPviqeQ/mZZZMSSKY8MNU4ked/nqN6z4oJELSoROL4GYPrhaBFRxOck28TgB+O\n\t2RnJuT5IqFVAtuqUiWQNXShp4M9x1DydQigZqIqSr6roi+TPlstU3o/aB/7iTLxIzh\n\tL+vknFmNRZX7PloBDZLj7mltsuYDAmIOIDo+L0AlKwTULZFe+gJk5bn+0mBzG+WTBL\n\tVl5oc1U18XUMsq3b9VNzSBGMv+ZZJRgQarLybadPrbHBdx9YSvW6qzZYtDyOMAwLmX\n\tXt/SP+Hmo1VfQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666256794;\n\tbh=HJNEzo9ueK+oT3G3P3++TmRwYy05EWrfltXN8IETzvs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=sXfJP8FvzZaQSdr7S7i9QPJ/cm7thxY2fMC7k6ezSmHWW1uhQykI9lbkl+HV1PfZa\n\t1uO6i4MlN3fn4hB0vmJkWaUCtYfnuI2Qr6TrJ/ItqzZjnPlYW9p5fVEMGiegSbrXWc\n\tqbIdbdzcoGaRLlBrI3YBZ8J6VqpAbv1B+rG3jTZA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"sXfJP8Fv\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221020065445.GI3874866@pyrite.rasen.tech>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-5-laurent.pinchart@ideasonboard.com>\n\t<20221020065445.GI3874866@pyrite.rasen.tech>","To":"Laurent Pinchart ,\n\tPaul Elder via libcamera-devel , \n\tpaul.elder@ideasonboard.com","Date":"Thu, 20 Oct 2022 10:06:32 +0100","Message-ID":"<166625679256.2560709.9553120856073763736@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 4/6] apps: Move libevent dependency\n\tto src/apps/meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25510,"web_url":"https://patchwork.libcamera.org/comment/25510/","msgid":"","date":"2022-10-20T10:09:45","subject":"Re: [libcamera-devel] [PATCH v1 4/6] apps: Move libevent dependency\n\tto src/apps/meson.build","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Oct 20, 2022 at 10:06:32AM +0100, Kieran Bingham wrote:\n> Quoting Paul Elder via libcamera-devel (2022-10-20 07:54:45)\n> > On Thu, Oct 20, 2022 at 02:15:35AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > > libtiff is a shared dependency between cam and lc-compliance, move it to\n> > \n> > s/libtiff/libevent/\n> > \n> > > src/apps/. The shared dependency will be used to condition compilation\n> > > of source files in an upcoming application static library.\n> > > \n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > src/apps/cam/meson.build | 4 +---\n> > > src/apps/lc-compliance/meson.build | 3 +--\n> > > src/apps/meson.build | 8 ++++++++\n> > > 3 files changed, 10 insertions(+), 5 deletions(-)\n> > > \n> > > diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\n> > > index 06dbea0645b7..4b6099ddab63 100644\n> > > --- a/src/apps/cam/meson.build\n> > > +++ b/src/apps/cam/meson.build\n> > > @@ -1,8 +1,6 @@\n> > > # SPDX-License-Identifier: CC0-1.0\n> > > \n> > > -libevent = dependency('libevent_pthreads', required : get_option('cam'))\n> > > -\n> > > -if not libevent.found()\n> > > +if opt_cam.disabled() or not libevent.found()\n> > > cam_enabled = false\n> > > subdir_done()\n> > > endif\n> > > diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\n> > > index 8b57474be2b2..05d622be0a40 100644\n> > > --- a/src/apps/lc-compliance/meson.build\n> > > +++ b/src/apps/lc-compliance/meson.build\n> > > @@ -1,10 +1,9 @@\n> > > # SPDX-License-Identifier: CC0-1.0\n> > > \n> > > -libevent = dependency('libevent_pthreads', required : get_option('lc-compliance'))\n> > > libgtest = dependency('gtest', required : get_option('lc-compliance'),\n> > > fallback : ['gtest', 'gtest_dep'])\n> > > \n> > > -if not (libevent.found() and libgtest.found())\n> > > +if opt_lc_compliance.disabled() or not libevent.found() or not libgtest.found()\n> > > lc_compliance_enabled = false\n> > > subdir_done()\n> > > endif\n> > > diff --git a/src/apps/meson.build b/src/apps/meson.build\n> > > index 9e4388bd7881..159deb0b7fc2 100644\n> > > --- a/src/apps/meson.build\n> > > +++ b/src/apps/meson.build\n> > > @@ -1,5 +1,13 @@\n> > > # SPDX-License-Identifier: CC0-1.0\n> > > \n> > > +opt_cam = get_option('cam')\n> > > +opt_lc_compliance = get_option('lc-compliance')\n> > > +\n> > > +libevent = dependency('libevent_pthreads', required : opt_cam)\n> > > +if not libevent.found()\n> > > + libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> > > +endif\n> \n> This ... is an odd way to express this. I expect we can't do sufficient\n> boolean operations with opt_cam and opt_lc_compliance?\n\nUnfortunately not, they're feature options, so tri-state. One\nalternative is\n\nif opt_cam.disabled() and opt_lc_compliance.disabled()\n libevent = disabler()\nelse\n libevent = dependency('libevent_pthreads', required : opt_cam.enabled() or opt_lc_compliance.enabled())\nendif\n\nbut I don't think that's better.\n\n> > > +libevent = dependency('libevent_pthreads', required : opt_cam)\n> > > +if not libevent.found()\n> > > + libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> > > +endif\n\n> It deserves a comment above to say why we are searching for the\n> dependency twice. Though I expect anyone trying to optimise it to a\n> single line would quickly hit whatever has caused you to break it out to\n> two.\n\nWould this work for you ?\n\n# libevent is needed by cam and lc-compliance. As they are both feature options,\n# they can't be combined with simple boolean logic.\n\n> Reviewed-by: Kieran Bingham \n> \n> > > +\n> > > subdir('lc-compliance')\n> > > \n> > > subdir('cam')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC8CDBD16B\n\tfor ;\n\tThu, 20 Oct 2022 10:10:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A3A962E82;\n\tThu, 20 Oct 2022 12:10:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EE90604DB\n\tfor ;\n\tThu, 20 Oct 2022 12:10:11 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FBD4570;\n\tThu, 20 Oct 2022 12:10:10 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666260613;\n\tbh=EWee5bO5GfWf/tMkrEYBoEgFnif3f4KkjIQj9blVeYQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SqgEyUjOm1rbgDp8i9W7wXreq+T7M0RODvgJYvDVORlwwwNTNXkMrHRiu2yR0EuY6\n\t8HKPcTVueu5hyI/8CVpXyK3XdqA7miAv1ZIVY+zRUFGBLkndIKz68TA44hPMI4EFYX\n\tK1JkDcLg+qoyg+muMch9VdnxU9mrt119/dAE1DzQRFFiXxstdQUJzSSS/66HYECrTp\n\tVdqOY4XFhoCJFvRJqi0R9FoUeTso9QTmQt9eP9ewP31X9QgbIqcGNQR7Y/d1NX1vGh\n\tWSKKzBouvwszCFGjx7A1TPohcCOwYOggCKEfTBAGlsmatSRc3cNxV7ZbZ36DVX4rHd\n\tmyKbMgCc7mT0g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666260610;\n\tbh=EWee5bO5GfWf/tMkrEYBoEgFnif3f4KkjIQj9blVeYQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OhpA+V8T1YretHmvMcMC2QeWPhg6mxZs0r9ey5xn1rXdL27xE8g2bZEjTb6QZTH2N\n\tn5TkNXKJ1UVQjIOAVdgEa62HnfrS4WEnNOWi3cTkMFH/fHh5hvoY0g3sLzjS5qclQK\n\tsnypEl1kerWj25a9x9ePWmWIebvMdaTzW+9EY8yQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OhpA+V8T\"; dkim-atps=neutral","Date":"Thu, 20 Oct 2022 13:09:45 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-5-laurent.pinchart@ideasonboard.com>\n\t<20221020065445.GI3874866@pyrite.rasen.tech>\n\t<166625679256.2560709.9553120856073763736@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166625679256.2560709.9553120856073763736@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v1 4/6] apps: Move libevent dependency\n\tto src/apps/meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Paul Elder via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25514,"web_url":"https://patchwork.libcamera.org/comment/25514/","msgid":"<166626249818.3490151.8689970830062526466@Monstersaurus>","date":"2022-10-20T10:41:38","subject":"Re: [libcamera-devel] [PATCH v1 4/6] apps: Move libevent dependency\n\tto src/apps/meson.build","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-10-20 11:09:45)\n> Hi Kieran,\n> \n> On Thu, Oct 20, 2022 at 10:06:32AM +0100, Kieran Bingham wrote:\n> > Quoting Paul Elder via libcamera-devel (2022-10-20 07:54:45)\n> > > On Thu, Oct 20, 2022 at 02:15:35AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > > > libtiff is a shared dependency between cam and lc-compliance, move it to\n> > > \n> > > s/libtiff/libevent/\n> > > \n> > > > src/apps/. The shared dependency will be used to condition compilation\n> > > > of source files in an upcoming application static library.\n> > > > \n> > > > Signed-off-by: Laurent Pinchart \n> > > > ---\n> > > > src/apps/cam/meson.build | 4 +---\n> > > > src/apps/lc-compliance/meson.build | 3 +--\n> > > > src/apps/meson.build | 8 ++++++++\n> > > > 3 files changed, 10 insertions(+), 5 deletions(-)\n> > > > \n> > > > diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\n> > > > index 06dbea0645b7..4b6099ddab63 100644\n> > > > --- a/src/apps/cam/meson.build\n> > > > +++ b/src/apps/cam/meson.build\n> > > > @@ -1,8 +1,6 @@\n> > > > # SPDX-License-Identifier: CC0-1.0\n> > > > \n> > > > -libevent = dependency('libevent_pthreads', required : get_option('cam'))\n> > > > -\n> > > > -if not libevent.found()\n> > > > +if opt_cam.disabled() or not libevent.found()\n> > > > cam_enabled = false\n> > > > subdir_done()\n> > > > endif\n> > > > diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\n> > > > index 8b57474be2b2..05d622be0a40 100644\n> > > > --- a/src/apps/lc-compliance/meson.build\n> > > > +++ b/src/apps/lc-compliance/meson.build\n> > > > @@ -1,10 +1,9 @@\n> > > > # SPDX-License-Identifier: CC0-1.0\n> > > > \n> > > > -libevent = dependency('libevent_pthreads', required : get_option('lc-compliance'))\n> > > > libgtest = dependency('gtest', required : get_option('lc-compliance'),\n> > > > fallback : ['gtest', 'gtest_dep'])\n> > > > \n> > > > -if not (libevent.found() and libgtest.found())\n> > > > +if opt_lc_compliance.disabled() or not libevent.found() or not libgtest.found()\n> > > > lc_compliance_enabled = false\n> > > > subdir_done()\n> > > > endif\n> > > > diff --git a/src/apps/meson.build b/src/apps/meson.build\n> > > > index 9e4388bd7881..159deb0b7fc2 100644\n> > > > --- a/src/apps/meson.build\n> > > > +++ b/src/apps/meson.build\n> > > > @@ -1,5 +1,13 @@\n> > > > # SPDX-License-Identifier: CC0-1.0\n> > > > \n> > > > +opt_cam = get_option('cam')\n> > > > +opt_lc_compliance = get_option('lc-compliance')\n> > > > +\n> > > > +libevent = dependency('libevent_pthreads', required : opt_cam)\n> > > > +if not libevent.found()\n> > > > + libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> > > > +endif\n> > \n> > This ... is an odd way to express this. I expect we can't do sufficient\n> > boolean operations with opt_cam and opt_lc_compliance?\n> \n> Unfortunately not, they're feature options, so tri-state. One\n> alternative is\n> \n> if opt_cam.disabled() and opt_lc_compliance.disabled()\n> libevent = disabler()\n> else\n> libevent = dependency('libevent_pthreads', required : opt_cam.enabled() or opt_lc_compliance.enabled())\n> endif\n> \n> but I don't think that's better.\n> \n> > > > +libevent = dependency('libevent_pthreads', required : opt_cam)\n> > > > +if not libevent.found()\n> > > > + libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> > > > +endif\n> \n> > It deserves a comment above to say why we are searching for the\n> > dependency twice. Though I expect anyone trying to optimise it to a\n> > single line would quickly hit whatever has caused you to break it out to\n> > two.\n> \n> Would this work for you ?\n> \n> # libevent is needed by cam and lc-compliance. As they are both feature options,\n> # they can't be combined with simple boolean logic.\n\nThat' solves my concern thanks. It's just an odd code pattern, that\ndoesn't read well, so the comment helps. Thanks.\n\n\n\n> \n> > Reviewed-by: Kieran Bingham \n> > \n> > > > +\n> > > > subdir('lc-compliance')\n> > > > \n> > > > subdir('cam')\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC555C0DA4\n\tfor ;\n\tThu, 20 Oct 2022 10:41:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59E1C62EAA;\n\tThu, 20 Oct 2022 12:41:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29BE2604DB\n\tfor ;\n\tThu, 20 Oct 2022 12:41:41 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D18D030A;\n\tThu, 20 Oct 2022 12:41:40 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666262502;\n\tbh=u3FXQeAvBvmky/hIyIclmoMGzspecsVS4KnPbM7o/Qk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=HugW8ZqojeNq+bs8lTTiJIsqcXd7TprgfijC2mSyz2MAzaK00csWIY02qN/46lQtv\n\tvHMhdW5qW7xQAJf59PNhaIlQjltxMJb5lYignmxbHFL9XDtmH2ZqgGQgZjWOm8ORun\n\tOEtY5e8FPJ6Y7rl7MTe/lvSVgYbIlSMGv9LeXMoxITi4TIZznSiJUcm+TUm+KlZxXX\n\tVFWju9rzRGyK5m7w9qh6WRr46I+0Rlyq9Src8JkRcp8Z18O8poJUBnGIO/HXE4irt3\n\tFwWTCkC2ZKcEF5xqnrBDo2Nt+wGOyfhjL8UQxk9CmW6rMspItc6//Q0lRut4PUkZJN\n\tL2aFLrw/7MzBw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666262500;\n\tbh=u3FXQeAvBvmky/hIyIclmoMGzspecsVS4KnPbM7o/Qk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=X7wxj1RujKTcRmUv8UX+rvuKrf4xznz52n6U5NkaWQ05dwrpTQ0QdmZ+6HFZZ9p3G\n\twVi+wnFrjOgOxP86mz0/2GEnZc/SQjpzm4atCP0zUE0sUW7a4zNUCErXSTb9h8kmTI\n\thJ+4bl1I6wGEC93FPOsWk2eQPBcRA268ewb1/UBg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"X7wxj1Ru\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-5-laurent.pinchart@ideasonboard.com>\n\t<20221020065445.GI3874866@pyrite.rasen.tech>\n\t<166625679256.2560709.9553120856073763736@Monstersaurus>\n\t","To":"Laurent Pinchart ","Date":"Thu, 20 Oct 2022 11:41:38 +0100","Message-ID":"<166626249818.3490151.8689970830062526466@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 4/6] apps: Move libevent dependency\n\tto src/apps/meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Paul Elder via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]