[{"id":25490,"web_url":"https://patchwork.libcamera.org/comment/25490/","msgid":"<20221020063654.GF3874866@pyrite.rasen.tech>","date":"2022-10-20T06:36:54","subject":"Re: [libcamera-devel] [PATCH v1 3/6] Move test applications to\n\tsrc/apps/","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Thu, Oct 20, 2022 at 02:15:34AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The cam and qcam test application share code, currently through a crude\n> hack that references the cam source files directly from the qcam\n> meson.build file. To prepare for the introduction of hosting that code\n> in a static library, move all applications to src/apps/.\n> \n> Signed-off-by: Laurent Pinchart \n\n\n\nReviewed-by: Paul Elder ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75B1DBD16B\n\tfor ;\n\tThu, 20 Oct 2022 06:37:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9A4F62E91;\n\tThu, 20 Oct 2022 08:37:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98CF162E75\n\tfor ;\n\tThu, 20 Oct 2022 08:37:01 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EDA50570;\n\tThu, 20 Oct 2022 08:36:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666247822;\n\tbh=F+D8P0pkza11rr/0j+d3BK6SmxHdkLDAcWRLoSY2Rz8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0UG9L1ygC35sOJ+zYfaXxYJBO4Vr3s6XaOmyNjm+60CZW1v541ekD9GPLOX4KVf1/\n\tvtozorulrNaf13mYcmn1bm01DmB4KwGNT/f0ibcuSTMMJV2XKc88uqAgE65s2u5wfg\n\tagyPIIOz0ANvyvrcs3zy6e+VCllKwYXQNcPc104nVauAPa020W22TM12FINisZeHuA\n\tPPaHJ801RKzT78C05vuM64+HRBr3xFt6gTx5W+SKVcgob3sKaRneZkEdUplDKMkNfw\n\tcvQ8kHGDaEtqpSbLwzyYQ7mssErZI5z5JVWzw8TIEVkfjneCHg5JnZ/I85TVlU2DHV\n\t5x+eANPMBXkmA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666247821;\n\tbh=F+D8P0pkza11rr/0j+d3BK6SmxHdkLDAcWRLoSY2Rz8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=k13hUGk+jctY78/NyT13XwpM8ex5YNWxyfkPVbEJyS7geJR3xS0irMbTQN7IuJtDB\n\t994vSI6mTUY7R20mn0Qfoc3lQMM4OxX05KDmbsdGL028q3A4dBFVqEPONAdAaKpJ58\n\tBW5oAkf/CWqEGNewAXPKFle/74C12aOJo4Lmajvo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"k13hUGk+\"; dkim-atps=neutral","Date":"Thu, 20 Oct 2022 15:36:54 +0900","To":"Laurent Pinchart ","Message-ID":"<20221020063654.GF3874866@pyrite.rasen.tech>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20221019231537.26880-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 3/6] Move test applications to\n\tsrc/apps/","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25503,"web_url":"https://patchwork.libcamera.org/comment/25503/","msgid":"<166625655109.2560709.13668702168411328130@Monstersaurus>","date":"2022-10-20T09:02:31","subject":"Re: [libcamera-devel] [PATCH v1 3/6] Move test applications to\n\tsrc/apps/","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder via libcamera-devel (2022-10-20 07:36:54)\n> On Thu, Oct 20, 2022 at 02:15:34AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > The cam and qcam test application share code, currently through a crude\n> > hack that references the cam source files directly from the qcam\n> > meson.build file. To prepare for the introduction of hosting that code\n> > in a static library, move all applications to src/apps/.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> \n> \n> Reviewed-by: Paul Elder \n\nI'm a little hesitant on this. (mostly because all of my muscle memory\nfor running cam and qcam will be broken I suspect...)\n\nBut I think it's reasonable to group applications that sit on top of\nlibcamera separately.\n\n\nReviewed-by: Kieran Bingham ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 598D7C327C\n\tfor ;\n\tThu, 20 Oct 2022 09:02:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 780EA62E9F;\n\tThu, 20 Oct 2022 11:02:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70C7262E9B\n\tfor ;\n\tThu, 20 Oct 2022 11:02:34 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDBD1D38;\n\tThu, 20 Oct 2022 11:02:33 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666256556;\n\tbh=j0AwGaN6U6hEXUXYj2gmHBYCBXnya5ynS3HbOBtK4AU=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Oyj8S9zZLtoJxBWZklVTw8cvfKuSpvXOyDHDpJG1FSJBCKR+I2C4+cL6Ks5pt3BN+\n\tvkRhM73VRdbS37wjAc0Kyd04QHxAgFAU8/3rwBPnfjO/qqs6giFlMsRVmNdCvtU6z1\n\ta7oh9a+FuSNSPy7vFQTTY6AnH6YtpmdlHbAIEVz7f6nS++9oFTOSd3JQeVhrqHMbkL\n\t83UdvqOqiThlvKsxEfak9z0ER2kGpMoxmRMlPY9SgZLBQbXn4iiIRepeSkZlgDqpku\n\tGZu01wJN2CrMjWZdceSNZNZYmbsJNS+0rXJt06r99FVY600cPyPs829p2l9IEs5b8v\n\t4u+SE1ZKb3Zlg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666256553;\n\tbh=j0AwGaN6U6hEXUXYj2gmHBYCBXnya5ynS3HbOBtK4AU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=lTC6obuDoBacErbgabAdKVlzoCZ0vJ93eKkitAKdoXaDn++6G59j7HG6MFNEyRRu5\n\t2gmB/bnPwdTQsmhZwEZyKan6WsPgbfW6dOLBvj7EmbtgFp9tF88wVQdYgUC5Lgd/w5\n\tyiuQjhfa59vWx4M2g3RbHpgLUz/gEsvyyoFfuD0E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lTC6obuD\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221020063654.GF3874866@pyrite.rasen.tech>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-4-laurent.pinchart@ideasonboard.com>\n\t<20221020063654.GF3874866@pyrite.rasen.tech>","To":"Laurent Pinchart ,\n\tPaul Elder via libcamera-devel , \n\tpaul.elder@ideasonboard.com","Date":"Thu, 20 Oct 2022 10:02:31 +0100","Message-ID":"<166625655109.2560709.13668702168411328130@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 3/6] Move test applications to\n\tsrc/apps/","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]