[{"id":25489,"web_url":"https://patchwork.libcamera.org/comment/25489/","msgid":"<20221020063351.GE3874866@pyrite.rasen.tech>","date":"2022-10-20T06:33:51","subject":"Re: [libcamera-devel] [PATCH v1 2/6] qcam: Simplify dependency\n\thandling for libtiff","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Thu, Oct 20, 2022 at 02:15:33AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> There's no need to conditionally add tiff_dep to the list of qcam\n> dependency, as a not found dependency() is ignored when listed in the\n> executable dependencies argument.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/qcam/meson.build | 14 ++++++--------\n> 1 file changed, 6 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index 9f5759ff0786..d5916d0df532 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -36,18 +36,11 @@ qcam_resources = files([\n> 'assets/feathericons/feathericons.qrc',\n> ])\n> \n> -qcam_deps = [\n> - libatomic,\n> - libcamera_public,\n> - qt5_dep,\n> -]\n> -\n> qt5_cpp_args = ['-DQT_NO_KEYWORDS']\n> \n> tiff_dep = dependency('libtiff-4', required : false)\n> if tiff_dep.found()\n> qt5_cpp_args += ['-DHAVE_TIFF']\n> - qcam_deps += [tiff_dep]\n> qcam_sources += files([\n> '../cam/dng_writer.cpp',\n> ])\n> @@ -81,5 +74,10 @@ resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n> \n> qcam = executable('qcam', qcam_sources, resources,\n> install : true,\n> - dependencies : qcam_deps,\n> + dependencies : [\n> + libatomic,\n> + libcamera_public,\n> + qt5_dep,\n> + tiff_dep,\n> + ],\n> cpp_args : qt5_cpp_args)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3AB8BD16B\n\tfor ;\n\tThu, 20 Oct 2022 06:34:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3187962E75;\n\tThu, 20 Oct 2022 08:34:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCD2762E75\n\tfor ;\n\tThu, 20 Oct 2022 08:33:58 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 39A86570;\n\tThu, 20 Oct 2022 08:33:56 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666247640;\n\tbh=uCNkiqaAnggZIFijXGGujwCs7tWZvOorVfuQcC76Y3U=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yBhX+xMHV92M3MFBwQcsrskCEUvk+WEP7qF3MWZOkt5CUJdCleLVdDmATQ+a/mM/f\n\t2ZdSFAFdzN4rlvEmHHqPa+XCGQ4d3j5la2kgi+UJt7RrvHCrvuppekPdcKGHIOMhGG\n\tRLF42YHqWIqfZSp9MEBtPg3L+BcF8JpZvwfB3OsAeUQiijPlBjSmjdR9nEst3bkRtJ\n\tNcgKlnv9ePZ4Qk3IkdIsddcXocyEQOlrVaN269W+QqpowR18hDyBJoNTPZzwK5/7oU\n\tw4kSQMPmzzJ/sPwYCYBRhXmMtZdXrH1CNJPBdSM0i/WnbZHWeaWV4RaDmKnx+pVYeg\n\t5EOMZZCE9KkHA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666247638;\n\tbh=uCNkiqaAnggZIFijXGGujwCs7tWZvOorVfuQcC76Y3U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Lf3mrbFVQ2nE/VqiNFMpbJ2DSiTtrdSGm0RwRxQsNzAjYjXACqgK+EsY5aWytuP3l\n\tI7RCfTsEF+E0DnI45KgToNqNcfpUonSy7a16itxGkkChVMtOqIgenwiTAwvMCzfRau\n\t6DTJaC9489JhRXFj4QuIN4RrKdqR11NQsnB4r+NE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Lf3mrbFV\"; dkim-atps=neutral","Date":"Thu, 20 Oct 2022 15:33:51 +0900","To":"Laurent Pinchart ","Message-ID":"<20221020063351.GE3874866@pyrite.rasen.tech>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20221019231537.26880-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 2/6] qcam: Simplify dependency\n\thandling for libtiff","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25501,"web_url":"https://patchwork.libcamera.org/comment/25501/","msgid":"<166625642039.2560709.16808534947909155710@Monstersaurus>","date":"2022-10-20T09:00:20","subject":"Re: [libcamera-devel] [PATCH v1 2/6] qcam: Simplify dependency\n\thandling for libtiff","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-10-20 00:15:33)\n> There's no need to conditionally add tiff_dep to the list of qcam\n> dependency, as a not found dependency() is ignored when listed in the\n> executable dependencies argument.\n\nHrm ... that sounds counter-intuitive ... but also makes sense.\n\n\"I depend on this ... unless you can't find it ... in which case I\ndont'...\"\n\nI can't immediately find the meson documentation to back that up. If you\nfound a reference it would be nice to add it here, but not essential.\n\nHave you tested builds both with and without libtiff-4 being available\non the system?\n\nOr do you need it to be explicitly tested?\n\n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/meson.build | 14 ++++++--------\n> 1 file changed, 6 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index 9f5759ff0786..d5916d0df532 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -36,18 +36,11 @@ qcam_resources = files([\n> 'assets/feathericons/feathericons.qrc',\n> ])\n> \n> -qcam_deps = [\n> - libatomic,\n> - libcamera_public,\n> - qt5_dep,\n> -]\n> -\n> qt5_cpp_args = ['-DQT_NO_KEYWORDS']\n> \n> tiff_dep = dependency('libtiff-4', required : false)\n> if tiff_dep.found()\n> qt5_cpp_args += ['-DHAVE_TIFF']\n> - qcam_deps += [tiff_dep]\n> qcam_sources += files([\n> '../cam/dng_writer.cpp',\n> ])\n> @@ -81,5 +74,10 @@ resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n> \n> qcam = executable('qcam', qcam_sources, resources,\n> install : true,\n> - dependencies : qcam_deps,\n> + dependencies : [\n> + libatomic,\n> + libcamera_public,\n> + qt5_dep,\n> + tiff_dep,\n> + ],\n> cpp_args : qt5_cpp_args)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE02DC0DA4\n\tfor ;\n\tThu, 20 Oct 2022 09:00:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BE2462E9D;\n\tThu, 20 Oct 2022 11:00:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DDAB362DFF\n\tfor ;\n\tThu, 20 Oct 2022 11:00:23 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6461D570;\n\tThu, 20 Oct 2022 11:00:23 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666256426;\n\tbh=Sz3dGmIqyXbuIaQm1F6nQOL58H4bdYelEFuqI0M+5Sc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=QPa3SshryICcLxYzX6i0ioT6aFVJtdhAoaOddPyDRcJR9F6uqsUfd6MMq0/nl3Vzg\n\tt91a6oKjX1MUm90L2Wzn3xrOE+ZbzEwvMtlYdvSY9Ece4svxXHkfBSnhz8srYWCHv/\n\tr+/wEVcBR1UGqgM/e/lQzPOWYToqXfG6TysvjUgDSVJe1p/9Up1hMgoY9Tgu8qIBlZ\n\twDf3gMdf2glC1Xya7HoV5j9YyV77dTvX7XMm6rljGm5DlIFGystFcOjpWlI44WgT86\n\tWlt9GF1w9ko5CLi4DSKmQVDsNzMd+yk1my5x36M8tNT3KAnSNpv/wv0wjJr9QKUso3\n\tGvvGvSKUkxbRQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666256423;\n\tbh=Sz3dGmIqyXbuIaQm1F6nQOL58H4bdYelEFuqI0M+5Sc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=KcN6YqDMqWjXMiBqqjl9YCBtOiOoYG04cTQP5iBEEge8GJPR8SSrop6aNBVFTIkkH\n\t/E9pJxiyISV6KdrCpgN279CXcphbD34QJEsxcqj2a+NeFSjT8Cl0ICAWplHhUShuXK\n\t2//WYz3s0ghjeI+/omvtzXAfZz+ulIx0hDMYSwQw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KcN6YqDM\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221019231537.26880-3-laurent.pinchart@ideasonboard.com>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-3-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 20 Oct 2022 10:00:20 +0100","Message-ID":"<166625642039.2560709.16808534947909155710@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 2/6] qcam: Simplify dependency\n\thandling for libtiff","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25505,"web_url":"https://patchwork.libcamera.org/comment/25505/","msgid":"","date":"2022-10-20T09:25:35","subject":"Re: [libcamera-devel] [PATCH v1 2/6] qcam: Simplify dependency\n\thandling for libtiff","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Oct 20, 2022 at 10:00:20AM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-10-20 00:15:33)\n> > There's no need to conditionally add tiff_dep to the list of qcam\n> > dependency, as a not found dependency() is ignored when listed in the\n> > executable dependencies argument.\n> \n> Hrm ... that sounds counter-intuitive ... but also makes sense.\n> \n> \"I depend on this ... unless you can't find it ... in which case I\n> dont'...\"\n> \n> I can't immediately find the meson documentation to back that up. If you\n> found a reference it would be nice to add it here, but not essential.\n> \n> Have you tested builds both with and without libtiff-4 being available\n> on the system?\n> \n> Or do you need it to be explicitly tested?\n\nI haven't searched the meson documentation for a confirmation, but we\nalready do that for other dependencies (libdrm, libsdl2, ...), and I've\ntested compilation with both libtiff-4 being available and unavailable.\n\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/qcam/meson.build | 14 ++++++--------\n> > 1 file changed, 6 insertions(+), 8 deletions(-)\n> > \n> > diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> > index 9f5759ff0786..d5916d0df532 100644\n> > --- a/src/qcam/meson.build\n> > +++ b/src/qcam/meson.build\n> > @@ -36,18 +36,11 @@ qcam_resources = files([\n> > 'assets/feathericons/feathericons.qrc',\n> > ])\n> > \n> > -qcam_deps = [\n> > - libatomic,\n> > - libcamera_public,\n> > - qt5_dep,\n> > -]\n> > -\n> > qt5_cpp_args = ['-DQT_NO_KEYWORDS']\n> > \n> > tiff_dep = dependency('libtiff-4', required : false)\n> > if tiff_dep.found()\n> > qt5_cpp_args += ['-DHAVE_TIFF']\n> > - qcam_deps += [tiff_dep]\n> > qcam_sources += files([\n> > '../cam/dng_writer.cpp',\n> > ])\n> > @@ -81,5 +74,10 @@ resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n> > \n> > qcam = executable('qcam', qcam_sources, resources,\n> > install : true,\n> > - dependencies : qcam_deps,\n> > + dependencies : [\n> > + libatomic,\n> > + libcamera_public,\n> > + qt5_dep,\n> > + tiff_dep,\n> > + ],\n> > cpp_args : qt5_cpp_args)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD78EC0DA4\n\tfor ;\n\tThu, 20 Oct 2022 09:26:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2001D62E9F;\n\tThu, 20 Oct 2022 11:26:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF78162E9C\n\tfor ;\n\tThu, 20 Oct 2022 11:26:01 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5C0EF570;\n\tThu, 20 Oct 2022 11:26:01 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666257964;\n\tbh=g6YXuxbs5NQQ6zPGzHZjKT2p24WWvlYTRgGjKlo/Fzc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ErcxfwmQ9yeOxMAkvw864b14rfZJAK8QqPQvQ4BDIQwUgaqHCxmygw1bbTiCw0sz3\n\tvitRhwmq4nQkPRq2JXfPLNgDXkLmTsc7cR3APio0NJfuRzy4SOyjF31zKXTyZqoP0V\n\tBfzDTwlomqgcGwHhvIYJqo9u7JsnpuWh3itSisgSndaVuBQwyB/xcHimjXCNOrLajO\n\thxwApBF+z28bHvboL3EhRdeJrsvhZfEfxsoXmM6gaTfxnn62PgcsI3vjP+RqQgENTP\n\tSdGLeAyCzGJGRx/FbdDLGgydYomPH2rt6C3poUEM62yXg1pSw2ucGjU0OOFwSXSGOE\n\tt6zDJXYY8oFkw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666257961;\n\tbh=g6YXuxbs5NQQ6zPGzHZjKT2p24WWvlYTRgGjKlo/Fzc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dxeTcf/kTMhFsXhdBsaupK6MmT6I7WjbUmILdm6p8gWdv1osnkPb5gHqt0ZxxtiXl\n\tyN24P7T6Rv/a47EDyxQQy+44Wb78kdpYTaYm1Uhhj/kCQ7uCBvRzUKaFzB9dfPeBz/\n\tkU8FUG/Os3zDGevRzq7U/kf3BfuCst3/r42kVCiY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dxeTcf/k\"; dkim-atps=neutral","Date":"Thu, 20 Oct 2022 12:25:35 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-3-laurent.pinchart@ideasonboard.com>\n\t<166625642039.2560709.16808534947909155710@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166625642039.2560709.16808534947909155710@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v1 2/6] qcam: Simplify dependency\n\thandling for libtiff","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25507,"web_url":"https://patchwork.libcamera.org/comment/25507/","msgid":"<166625931940.2560709.9297078039285838579@Monstersaurus>","date":"2022-10-20T09:48:39","subject":"Re: [libcamera-devel] [PATCH v1 2/6] qcam: Simplify dependency\n\thandling for libtiff","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-10-20 10:25:35)\n> On Thu, Oct 20, 2022 at 10:00:20AM +0100, Kieran Bingham wrote:\n> > Quoting Laurent Pinchart via libcamera-devel (2022-10-20 00:15:33)\n> > > There's no need to conditionally add tiff_dep to the list of qcam\n> > > dependency, as a not found dependency() is ignored when listed in the\n> > > executable dependencies argument.\n> > \n> > Hrm ... that sounds counter-intuitive ... but also makes sense.\n> > \n> > \"I depend on this ... unless you can't find it ... in which case I\n> > dont'...\"\n> > \n> > I can't immediately find the meson documentation to back that up. If you\n> > found a reference it would be nice to add it here, but not essential.\n> > \n> > Have you tested builds both with and without libtiff-4 being available\n> > on the system?\n> > \n> > Or do you need it to be explicitly tested?\n> \n> I haven't searched the meson documentation for a confirmation, but we\n> already do that for other dependencies (libdrm, libsdl2, ...), and I've\n> tested compilation with both libtiff-4 being available and unavailable.\n\n\nReviewed-by: Kieran Bingham \n\n\n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > src/qcam/meson.build | 14 ++++++--------\n> > > 1 file changed, 6 insertions(+), 8 deletions(-)\n> > > \n> > > diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> > > index 9f5759ff0786..d5916d0df532 100644\n> > > --- a/src/qcam/meson.build\n> > > +++ b/src/qcam/meson.build\n> > > @@ -36,18 +36,11 @@ qcam_resources = files([\n> > > 'assets/feathericons/feathericons.qrc',\n> > > ])\n> > > \n> > > -qcam_deps = [\n> > > - libatomic,\n> > > - libcamera_public,\n> > > - qt5_dep,\n> > > -]\n> > > -\n> > > qt5_cpp_args = ['-DQT_NO_KEYWORDS']\n> > > \n> > > tiff_dep = dependency('libtiff-4', required : false)\n> > > if tiff_dep.found()\n> > > qt5_cpp_args += ['-DHAVE_TIFF']\n> > > - qcam_deps += [tiff_dep]\n> > > qcam_sources += files([\n> > > '../cam/dng_writer.cpp',\n> > > ])\n> > > @@ -81,5 +74,10 @@ resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n> > > \n> > > qcam = executable('qcam', qcam_sources, resources,\n> > > install : true,\n> > > - dependencies : qcam_deps,\n> > > + dependencies : [\n> > > + libatomic,\n> > > + libcamera_public,\n> > > + qt5_dep,\n> > > + tiff_dep,\n> > > + ],\n> > > cpp_args : qt5_cpp_args)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79C62BD16B\n\tfor ;\n\tThu, 20 Oct 2022 09:48:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9A7362EA1;\n\tThu, 20 Oct 2022 11:48:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4893162E9C\n\tfor ;\n\tThu, 20 Oct 2022 11:48:42 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB524570;\n\tThu, 20 Oct 2022 11:48:41 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666259323;\n\tbh=4sRCyNWBAMPMp7+YMGdA6E/a61Ns4xho3ExgdOjYLRQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XTMUovxw6j/p48zry4OVhvZ6J4wU1Qe6vWzasFXuIzF4IW25g2M5C8oh1MtPo5K9r\n\t84mF3XN+DUWDvP8694jWiOz6oaBl5JE6Lt8KYButa8d0w4maVAfXbD4fp+xuZ5LJYD\n\t+LB6Zl53dOnGpQBEiPZPgtN4djerO0vFKKUh5yTsHaTRsMmmoqJQ6JPTr3Gub1cz6z\n\tI9qQkTOjinNC+6ptMgLTiDiaAUHmdf/9qQKWYLhTDVjM0DL355YSxjZuMBDXseWDwq\n\tAnw1xt//PmS8h9nBzEsxcLo3nIrmLCDk9vQUn+UCmhm+6RJ2FycZLZq0kdwnhSv7ah\n\tkctslHs0Fltxg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666259321;\n\tbh=4sRCyNWBAMPMp7+YMGdA6E/a61Ns4xho3ExgdOjYLRQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=DNZKdB7LmNfR1BVUzgIvo5EChjdhm+7i5zoITIiRAlRwuXUlV5UV+PZRSQZH7b91j\n\tIQo0aHdoAiK40DmRCVAiX3jnfHXVJ7Ry16EgrsAXU8Z3F8qB+Vb0K9AHoGTB1uer53\n\tq9tp2lLYBpzDpV/jwYaxuPKJKdcUHwvjQ5EaMxEI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DNZKdB7L\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-3-laurent.pinchart@ideasonboard.com>\n\t<166625642039.2560709.16808534947909155710@Monstersaurus>\n\t","To":"Laurent Pinchart ","Date":"Thu, 20 Oct 2022 10:48:39 +0100","Message-ID":"<166625931940.2560709.9297078039285838579@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 2/6] qcam: Simplify dependency\n\thandling for libtiff","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]