[{"id":25488,"web_url":"https://patchwork.libcamera.org/comment/25488/","msgid":"<20221020063155.GD3874866@pyrite.rasen.tech>","date":"2022-10-20T06:31:55","subject":"Re: [libcamera-devel] [PATCH v1 1/6] cam: Don't print DNG option\n\ttext if libtiff isn't found","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Thu, Oct 20, 2022 at 02:15:32AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> If libtiff isn't found, DNG capture support is disabled. Don't print the\n> part of the --file help text that mentions DNG in that case.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/cam/main.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index c4e18a130c02..d70130e2ab81 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -144,8 +144,10 @@ int CamApp::parseOptions(int argc, char *argv[])\n> \t\t\t \"to write files, using the default file name. Otherwise it sets the\\n\"\n> \t\t\t \"full file path and name. The first '#' character in the file name\\n\"\n> \t\t\t \"is expanded to the camera index, stream name and frame sequence number.\\n\"\n> +#ifdef HAVE_TIFF\n> \t\t\t \"If the file name ends with '.dng', then the frame will be written to\\n\"\n> \t\t\t \"the output file(s) in DNG format.\\n\"\n> +#endif\n> \t\t\t \"The default file name is 'frame-#.bin'.\",\n> \t\t\t \"file\", ArgumentOptional, \"filename\", false,\n> \t\t\t OptCamera);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36227C0DA4\n\tfor ;\n\tThu, 20 Oct 2022 06:32:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C31262E90;\n\tThu, 20 Oct 2022 08:32:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8794462E75\n\tfor ;\n\tThu, 20 Oct 2022 08:32:02 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F2C15570;\n\tThu, 20 Oct 2022 08:32:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666247523;\n\tbh=k/bjKOzEiHnaBt8h5Y4JV943hFilwUBElzzlvGdkOEc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ykLqqYXM2S9x6Y1swLsyOcPTu7+Tp35bHnLkr9ggPsOSahiUk27NkXlwcxGS0RIL8\n\tF03TxarXmTHn/LFv7Cfs4EQvok2aEF9rTnBfAP/BjHqLAbk8LQuBslu7EIjkTSqJhP\n\tdJr1OCjNY4gBIOXuDX+xVRLHDXQqQezqptsVm0zT7I9Fq4e0yYxSD/3uJUr46TpTh4\n\tGSuArSggi8U7lJmNI/5Px+E8lIiNjerQwXUMlJ1T77ulr+ctJTaVFvJXsqgnZKefjl\n\t4E/o0fRhWiqhQzNNH/Iz4ZxQJ5fa0SQlERQ4yrfLTeTZlBbxtYM/BY4efTrT+WX6bJ\n\t7C/QQb6yJeq9Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666247522;\n\tbh=k/bjKOzEiHnaBt8h5Y4JV943hFilwUBElzzlvGdkOEc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OIv+lzbgY/s7T4j5ohHLTqxnwQVPH33F8NLlABSbspPjISFnvcS+QzMui1pDvuKkT\n\tyvlgxpKbaalQp4YABF6BicY2wmm419IWX/qq3dU/uC0oNVihZOh3vIyYcgCPRZnRwU\n\toUAHCIHPVpnTx9lbePDZw3EDEZ0IgvMMqrFsExJY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OIv+lzbg\"; dkim-atps=neutral","Date":"Thu, 20 Oct 2022 15:31:55 +0900","To":"Laurent Pinchart ","Message-ID":"<20221020063155.GD3874866@pyrite.rasen.tech>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20221019231537.26880-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 1/6] cam: Don't print DNG option\n\ttext if libtiff isn't found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25500,"web_url":"https://patchwork.libcamera.org/comment/25500/","msgid":"<166625607303.2560709.18283457734414669514@Monstersaurus>","date":"2022-10-20T08:54:33","subject":"Re: [libcamera-devel] [PATCH v1 1/6] cam: Don't print DNG option\n\ttext if libtiff isn't found","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-10-20 00:15:32)\n> If libtiff isn't found, DNG capture support is disabled. Don't print the\n> part of the --file help text that mentions DNG in that case.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n> ---\n> src/cam/main.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index c4e18a130c02..d70130e2ab81 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -144,8 +144,10 @@ int CamApp::parseOptions(int argc, char *argv[])\n> \"to write files, using the default file name. Otherwise it sets the\\n\"\n> \"full file path and name. The first '#' character in the file name\\n\"\n> \"is expanded to the camera index, stream name and frame sequence number.\\n\"\n> +#ifdef HAVE_TIFF\n> \"If the file name ends with '.dng', then the frame will be written to\\n\"\n> \"the output file(s) in DNG format.\\n\"\n> +#endif\n> \"The default file name is 'frame-#.bin'.\",\n> \"file\", ArgumentOptional, \"filename\", false,\n> OptCamera);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C6D1BD16B\n\tfor ;\n\tThu, 20 Oct 2022 08:54:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3CA662E9C;\n\tThu, 20 Oct 2022 10:54:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3726562DFF\n\tfor ;\n\tThu, 20 Oct 2022 10:54:36 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B4D08570;\n\tThu, 20 Oct 2022 10:54:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666256077;\n\tbh=FGq+eDqfh5eupo5RM0nwu46t1d+XiaRkScrSZzQlzY8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ByXnfCUMcVrmxX24D6e1kJ8bH306uLsBAtuRPG+xd26zy/jr8a/jto6iccD017VGt\n\tx1MORQhRAUGLKWKCDD7x1geu18yCTJ4ieNIsEcdW4hniOYU+OFMNvVa0mvriW1nUxs\n\tlKiWRxMHC/bCJ+UOtN3s5eAr3SJfHdV/CnTCi87kd4g7a7K21YsljW9s6tZIu3E2PL\n\ttPnsl+vA3f+WUf1KTlKHeuRr4RafDeOOISnn/dGYtkPAlsNiunYS6NFAkwMCubHX1B\n\tVKho6PvEM3sbAJTY2sqzJYqrsfgeSH7kGy3TSohvg99zaOl+xiBtBCPbO5rjaHx/y7\n\tm00BwpGuHFYZQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666256075;\n\tbh=FGq+eDqfh5eupo5RM0nwu46t1d+XiaRkScrSZzQlzY8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=hx62xV9T+pIMbdOmGZW1/mcY0I7zFIonRHEXTdYnkfXF/1XXbJ0140xvPuE6cpOFY\n\tWQ3Pue0Rh6ZowR+aw595C8mFJOBorhLxjl5mULdeQyAA8xHmx8dQb2QcDR0TsxAb3V\n\tV2XeEAxY6MCuj8q8Kc3Y0nvQBOkZ1fXo9+EAmi9k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hx62xV9T\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221019231537.26880-2-laurent.pinchart@ideasonboard.com>","References":"<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>\n\t<20221019231537.26880-2-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 20 Oct 2022 09:54:33 +0100","Message-ID":"<166625607303.2560709.18283457734414669514@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 1/6] cam: Don't print DNG option\n\ttext if libtiff isn't found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]