[{"id":25481,"web_url":"https://patchwork.libcamera.org/comment/25481/","msgid":"","date":"2022-10-19T21:06:44","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Rename ov9281.json\n\tto ov9281_mono.json","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, Oct 19, 2022 at 02:57:47PM +0100, Naushir Patuck via libcamera-devel wrote:\n> The recent change to the naming scheme for the camera tuning files failed to\n> rename ov9281.json, causing the sensor to fail to load. Since this is a mono\n> sensor module, rename this file to ov9281_mono.json.\n> \n> Fixes: 820607b195ff: (\"pipeline: raspberrypi: Update naming convention for tuning files\")\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/data/meson.build | 2 +-\n> src/ipa/raspberrypi/data/{ov9281.json => ov9281_mono.json} | 0\n> 2 files changed, 1 insertion(+), 1 deletion(-)\n> rename src/ipa/raspberrypi/data/{ov9281.json => ov9281_mono.json} (100%)\n> \n> diff --git a/src/ipa/raspberrypi/data/meson.build b/src/ipa/raspberrypi/data/meson.build\n> index 6c5beb0e0f67..84c1dabbec9c 100644\n> --- a/src/ipa/raspberrypi/data/meson.build\n> +++ b/src/ipa/raspberrypi/data/meson.build\n> @@ -12,7 +12,7 @@ conf_files = files([\n> 'imx519.json',\n> 'ov5647.json',\n> 'ov5647_noir.json',\n> - 'ov9281.json',\n> + 'ov9281_mono.json',\n> 'se327m12.json',\n> 'uncalibrated.json',\n> ])\n> diff --git a/src/ipa/raspberrypi/data/ov9281.json b/src/ipa/raspberrypi/data/ov9281_mono.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/ov9281.json\n> rename to src/ipa/raspberrypi/data/ov9281_mono.json","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23939BD16B\n\tfor ;\n\tWed, 19 Oct 2022 21:07:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FDE062E67;\n\tWed, 19 Oct 2022 23:07:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAAF562E64\n\tfor ;\n\tWed, 19 Oct 2022 23:07:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3107F570;\n\tWed, 19 Oct 2022 23:07:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666213630;\n\tbh=4A6nfgjYC0cBD9W3Vv/JWz1Kc4ELV89AdJYFs3HynLw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wwCnMWMdB6zaLDIhA/Ajz4Qjzyj0gEgneJP49u9slsLKmhTfLe9+JkfdluvycqCSa\n\tvR4R0UfK7BwwXL12+GqXLMzJjseWJySN+F0iqig8ZtmHYbnv/OTMbBp76Ng2oRcqgz\n\t53OPcrfKIjzCNw7c6hl7NStyl9zGF65xEgVeVx6B38HEgmYDWWFINznJYVqVa/Rt+g\n\tBOWWCwpDRYrK5qLQHm6Om7V2aSLOiW3BMOhPnpP57iVgSo6Bc8Q46+VYFsj/oO+PqO\n\tNY7RcyjsoCYyvNjvuuAast7UQkt7zrpxFWDKySvdcw1vpzagg34IRcmjx76S9cDlKv\n\tzl3oRxB+Ew0Aw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666213628;\n\tbh=4A6nfgjYC0cBD9W3Vv/JWz1Kc4ELV89AdJYFs3HynLw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ejOJ1lSofagpwhkohpaNID/STn1AjyDideiqMI6HS4qZ47lB9+rmUQAQ7xelO8PCI\n\tTikfjok8vJW2DuBOAw4bOK2aKTScW8KwT0XmVPP+RBj2YrEfH0X+wvE9GcKwuWTzZR\n\t6NnHlEUOgEX10yggQgaHipS356WNqeIgRkyEPzoo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ejOJ1lSo\"; dkim-atps=neutral","Date":"Thu, 20 Oct 2022 00:06:44 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20221019135747.25307-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221019135747.25307-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Rename ov9281.json\n\tto ov9281_mono.json","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25509,"web_url":"https://patchwork.libcamera.org/comment/25509/","msgid":"","date":"2022-10-20T09:56:04","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Rename ov9281.json\n\tto ov9281_mono.json","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for fixing this!\n\nOn Wed, 19 Oct 2022 at 22:07, Laurent Pinchart via libcamera-devel\n wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Wed, Oct 19, 2022 at 02:57:47PM +0100, Naushir Patuck via libcamera-devel wrote:\n> > The recent change to the naming scheme for the camera tuning files failed to\n> > rename ov9281.json, causing the sensor to fail to load. Since this is a mono\n> > sensor module, rename this file to ov9281_mono.json.\n> >\n> > Fixes: 820607b195ff: (\"pipeline: raspberrypi: Update naming convention for tuning files\")\n> > Signed-off-by: Naushir Patuck \n>\n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\n>\n> > ---\n> > src/ipa/raspberrypi/data/meson.build | 2 +-\n> > src/ipa/raspberrypi/data/{ov9281.json => ov9281_mono.json} | 0\n> > 2 files changed, 1 insertion(+), 1 deletion(-)\n> > rename src/ipa/raspberrypi/data/{ov9281.json => ov9281_mono.json} (100%)\n> >\n> > diff --git a/src/ipa/raspberrypi/data/meson.build b/src/ipa/raspberrypi/data/meson.build\n> > index 6c5beb0e0f67..84c1dabbec9c 100644\n> > --- a/src/ipa/raspberrypi/data/meson.build\n> > +++ b/src/ipa/raspberrypi/data/meson.build\n> > @@ -12,7 +12,7 @@ conf_files = files([\n> > 'imx519.json',\n> > 'ov5647.json',\n> > 'ov5647_noir.json',\n> > - 'ov9281.json',\n> > + 'ov9281_mono.json',\n> > 'se327m12.json',\n> > 'uncalibrated.json',\n> > ])\n> > diff --git a/src/ipa/raspberrypi/data/ov9281.json b/src/ipa/raspberrypi/data/ov9281_mono.json\n> > similarity index 100%\n> > rename from src/ipa/raspberrypi/data/ov9281.json\n> > rename to src/ipa/raspberrypi/data/ov9281_mono.json\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A0E2C0DA4\n\tfor ;\n\tThu, 20 Oct 2022 09:56:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A1B662EA4;\n\tThu, 20 Oct 2022 11:56:18 +0200 (CEST)","from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com\n\t[IPv6:2607:f8b0:4864:20::1029])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D54BA62E9C\n\tfor ;\n\tThu, 20 Oct 2022 11:56:16 +0200 (CEST)","by mail-pj1-x1029.google.com with SMTP id\n\to17-20020a17090aac1100b0020d98b0c0f4so2919929pjq.4\n\tfor ;\n\tThu, 20 Oct 2022 02:56:16 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666259778;\n\tbh=J9Jo1nw/OG53JdiT46+bf+y4yVZfdCFwMAnr+juY7oU=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=YYsyAfKSmbRaZV7VPoLa3cv25qfyT9Y+J4U3aH7+pllL00tnVddOgzDqf8yAq7Yk5\n\tCzzhL0xt2hhCNTQM2hrrUE+A5lngf2A4kKFkfURYz05v7JeqsEWRhtaeADCC16HI5S\n\tAQrRXwoXHViKLMYRZJlmpBDmf0AtEHGXwee9vroQ9MNPRN8y2+awdmrlu2ye9eRSeI\n\tOnD/EqATwAik3PtbSS8e0J8Dn6rozICxSIJ9ledTJphvfHAvDRKIngDGjwK486sP1F\n\tjjhAlNViUUKhsNmUorIYOtLqrZ1+Du+p8a1PKU6aG21fXs9GFgdZkDIEN6hl7wso1L\n\t962R4sSuF13Ig==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=lNabN31fwdcejMZWLYRYw/QKH6QXD8OfNTjRr6QxYIg=;\n\tb=UqDIJWAn00bMPK4JmRONqCfInpcrwovVDHHnnTkSq2KtfvQiubS+RSxDW4RsXJ8NQy\n\tW2tK/w/RHDohZcXorV5CuTngm4GmPKbDTejhkHl3TL7Plgz5JSxuFOBjdQ6h+VRPG8w5\n\tpHFVmROLftGPV7DMytVmkbCis9fGElYUfMbjoeZ8lbp0GKhCkhrkNIE3RKc/PbPYJeYG\n\tJdSKUgEzHVPqFPLjuzLiLGO2PQagYaH2Tv5/vve3MpsWRiYIScT2eBEMmIwhvAFbcu2o\n\tzbk80jFDUKUXk8hXOLEOaQlWb8ZRWKMw/b+jZtqqlUsUGkrCNJkbHw1KKbc/7nlz0itn\n\ttT2g=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"UqDIJWAn\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=lNabN31fwdcejMZWLYRYw/QKH6QXD8OfNTjRr6QxYIg=;\n\tb=qmkVvOPhyiBN0ZFLKgNw0Kc/dJBnpgch+C1afbQR8ggEcEW0y5cZgZ19h2seZ1f2lD\n\tqCkA/4ZGbfZDLJyYarMoKXejHyKVfjWnDNqNpdean4jD9YF8tgW+eTzyJoWI2Wbb6nGm\n\tfDg6oajF943gXRDZUM1G7z7CWBeCww8BrjiiBYv82KHsLlQDXt2R9dUiTY7YsVBksRFJ\n\tS96LnWUybgMipyxGYcx+nfLQylqJUtAlBgUFGP66rr58j6V94xF9f+u++x+YpDa9ujrn\n\tyjgQEKoNRIEfadPjFz/SVmzGsztsiEwWr6jQssd7cnyUQDUo0Wx48UKGCHCXTpFu1zHy\n\tOqXw==","X-Gm-Message-State":"ACrzQf3dj1elpmchchVHGrla/qdSJbQcWjqaeySh1KYhYcvufi7oxJUY\n\taRlfxJsQsK7YjxcYsCwG8n9TdiHXAVnIkzK0xQauUTes3fI=","X-Google-Smtp-Source":"AMsMyM4q49slKxBUft/CX66bKC33OczHRFnHqFl5IJvOSr2XvzUsmxGBrSGjhgkopS5N2pjSScUULPOZDdc/U8fjEcA=","X-Received":"by 2002:a17:902:720a:b0:181:150c:fcc4 with SMTP id\n\tba10-20020a170902720a00b00181150cfcc4mr13275330plb.109.1666259775303;\n\tThu, 20 Oct 2022 02:56:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20221019135747.25307-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Thu, 20 Oct 2022 10:56:04 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Rename ov9281.json\n\tto ov9281_mono.json","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]