[{"id":25469,"web_url":"https://patchwork.libcamera.org/comment/25469/","msgid":"<166617975530.2560709.651699518853409977@Monstersaurus>","date":"2022-10-19T11:42:35","subject":"Re: [libcamera-devel] [PATCH v1 4/4] ipa: rkisp1: Downgrade sensor\n\tcontrols range message to Debug","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-10-19 12:04:34)\n> There's no need to print the exposure and gain control ranges as an Info\n> message. Downgrade it to Debug. While at it, print the ranges using the\n> \"[min, max]\" syntax.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index bef5211d5c34..7dd340cf50af 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -232,9 +232,9 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n> int32_t minGain = itGain->second.min().get();\n> int32_t maxGain = itGain->second.max().get();\n> \n> - LOG(IPARkISP1, Info)\n> - << \"Exposure: \" << minExposure << \"-\" << maxExposure\n> - << \" Gain: \" << minGain << \"-\" << maxGain;\n> + LOG(IPARkISP1, Debug)\n> + << \"Exposure: [\" << minExposure << \", \" << maxExposure\n> + << \"], gain: [\" << minGain << \", \" << maxGain << \"]\";\n\n\nReviewed-by: Kieran Bingham \n\n> \n> /* Clear the IPA context before the streaming session. */\n> context_.configuration = {};\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 990C4C0DA4\n\tfor ;\n\tWed, 19 Oct 2022 11:42:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F85962E57;\n\tWed, 19 Oct 2022 13:42:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7729862DFA\n\tfor ;\n\tWed, 19 Oct 2022 13:42:38 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21E775A4;\n\tWed, 19 Oct 2022 13:42:38 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666179759;\n\tbh=gAJeBCYDLRT3ki8hK9Z0JY05bXdgi+itxcmWNE7/F9Y=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=IyhkVHmnP7dNSfivmWwTgNdTfTue4S5ahERaa6P9pcMShKD9R7glRFPo78huXWBto\n\tdCFnTXdNs0b4Ql3GgDMpFtaWEhI0Oz3oPwkZxbi0Ufs0tIe53dz7wpkxWMJ25us4uh\n\tXDzDR/CbUx2JKysZninn+vJ237f97jIlN2aEs+8afNeus7vK6wAxtov/9AOe+Pr6Qa\n\tdXtx4SWz4dKgy1YjO6YJumjZ+tYuW+gPSTemDiPj8awJTIaCwmxvlQXyFPwtUbO4gc\n\tv7ZMC2/L3lCEl/21Tk1BJTvZyixAXqHfSCiNxBsPPeBGZPQEJwvGuwovHtr3M625+M\n\tTmfQ5s/HqLJzA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666179758;\n\tbh=gAJeBCYDLRT3ki8hK9Z0JY05bXdgi+itxcmWNE7/F9Y=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=ExDU6PDreltHZZbZhEXyHKcpcwxY/YPTxihGl9fOI5J1+D1qx3E6Ic1+WtOul6u+q\n\tKh1EpiCpzegTsIc5MBL6sC07HxJ1akx5k0Hs0dxFo6rTgOw5afVRJJwoSqJEgrzPKU\n\t49UtZI666JNvMQpnLhSA4s9GCzk7j14a6WbtUvhA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ExDU6PDr\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221019110434.17767-5-laurent.pinchart@ideasonboard.com>","References":"<20221019110434.17767-1-laurent.pinchart@ideasonboard.com>\n\t<20221019110434.17767-5-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 19 Oct 2022 12:42:35 +0100","Message-ID":"<166617975530.2560709.651699518853409977@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 4/4] ipa: rkisp1: Downgrade sensor\n\tcontrols range message to Debug","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25472,"web_url":"https://patchwork.libcamera.org/comment/25472/","msgid":"<20221019114932.4ynel5sfpgwhlkym@uno.localdomain>","date":"2022-10-19T11:49:32","subject":"Re: [libcamera-devel] [PATCH v1 4/4] ipa: rkisp1: Downgrade sensor\n\tcontrols range message to Debug","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Wed, Oct 19, 2022 at 12:42:35PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-10-19 12:04:34)\n> > There's no need to print the exposure and gain control ranges as an Info\n> > message. Downgrade it to Debug. While at it, print the ranges using the\n> > \"[min, max]\" syntax.\n> >\n> > Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> > ---\n> > src/ipa/rkisp1/rkisp1.cpp | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index bef5211d5c34..7dd340cf50af 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -232,9 +232,9 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n> > int32_t minGain = itGain->second.min().get();\n> > int32_t maxGain = itGain->second.max().get();\n> >\n> > - LOG(IPARkISP1, Info)\n> > - << \"Exposure: \" << minExposure << \"-\" << maxExposure\n> > - << \" Gain: \" << minGain << \"-\" << maxGain;\n> > + LOG(IPARkISP1, Debug)\n> > + << \"Exposure: [\" << minExposure << \", \" << maxExposure\n> > + << \"], gain: [\" << minGain << \", \" << maxGain << \"]\";\n>\n>\n> Reviewed-by: Kieran Bingham \n>\n> >\n> > /* Clear the IPA context before the streaming session. */\n> > context_.configuration = {};\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6769C0DA4\n\tfor ;\n\tWed, 19 Oct 2022 11:49:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A18962E5C;\n\tWed, 19 Oct 2022 13:49:40 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::224])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6120A62DFA\n\tfor ;\n\tWed, 19 Oct 2022 13:49:39 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 02609E0007;\n\tWed, 19 Oct 2022 11:49:36 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666180180;\n\tbh=GYInE3aC38iAJmCXeamIYW2PV9zM8VfbKKzdaIBHJ10=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=13h8H4zaDMDsFDitz6tKuDI6tpYlEsX2cZRwkO7ScepwAq+IxfAA/cFVUAtBBt9Ga\n\t9Gy8S+wGt7nbVK0SA2F8ojCNL+oGP7x3hQWKCiHZwmYu9Q/2RB870tijBoe3sH6bd6\n\tCWLIWSCAt+Axegs7MDEJLdZooBYZcBlaGloS8w11zp7ZhQfxZvlgW3rMF+C0uCpLzy\n\t9qGVbrniM16axMljSUhIwd1WIHlWqAmEVhGSCYNDiR/CaPqdhLT5jIXQznN9xAa1gs\n\tMM10qMkS8/lbesiZdmBGav/yl0rwD19ye9DrkXxL9lifIu3tpDJ0eSYnrgoV9jMBZB\n\tuqc+NFi6XqCtw==","Date":"Wed, 19 Oct 2022 13:49:32 +0200","To":"Kieran Bingham ","Message-ID":"<20221019114932.4ynel5sfpgwhlkym@uno.localdomain>","References":"<20221019110434.17767-1-laurent.pinchart@ideasonboard.com>\n\t<20221019110434.17767-5-laurent.pinchart@ideasonboard.com>\n\t<166617975530.2560709.651699518853409977@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166617975530.2560709.651699518853409977@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v1 4/4] ipa: rkisp1: Downgrade sensor\n\tcontrols range message to Debug","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]