[{"id":25449,"web_url":"https://patchwork.libcamera.org/comment/25449/","msgid":"","date":"2022-10-18T09:40:24","subject":"Re: [libcamera-devel] [PATCH] ipc: ipa_data_serializer: Use cend()\n\tin deserializers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Oct 18, 2022 at 06:34:49PM +0900, Paul Elder via libcamera-devel wrote:\n> The overloaded deserializers functions that called the main deserializer\n> function using iterators used cbegin() but end() instead of cend(). Make\n> all of these use cend() instead.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/ipa_data_serializer.h | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n> index 30bdaebc..54895b87 100644\n> --- a/include/libcamera/internal/ipa_data_serializer.h\n> +++ b/include/libcamera/internal/ipa_data_serializer.h\n> @@ -134,7 +134,7 @@ public:\n> \n> \tstatic std::vector deserialize(std::vector &data, ControlSerializer *cs = nullptr)\n> \t{\n> -\t\treturn deserialize(data.cbegin(), data.end(), cs);\n> +\t\treturn deserialize(data.cbegin(), data.cend(), cs);\n> \t}\n> \n> \tstatic std::vector deserialize(std::vector::const_iterator dataBegin,\n> @@ -142,13 +142,13 @@ public:\n> \t\t\t\t\t ControlSerializer *cs = nullptr)\n> \t{\n> \t\tstd::vector fds;\n> -\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.end(), cs);\n> +\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.cend(), cs);\n> \t}\n> \n> \tstatic std::vector deserialize(std::vector &data, std::vector &fds,\n> \t\t\t\t\t ControlSerializer *cs = nullptr)\n> \t{\n> -\t\treturn deserialize(data.cbegin(), data.end(), fds.cbegin(), fds.end(), cs);\n> +\t\treturn deserialize(data.cbegin(), data.cend(), fds.cbegin(), fds.cend(), cs);\n> \t}\n> \n> \tstatic std::vector deserialize(std::vector::const_iterator dataBegin,\n> @@ -240,7 +240,7 @@ public:\n> \n> \tstatic std::map deserialize(std::vector &data, ControlSerializer *cs = nullptr)\n> \t{\n> -\t\treturn deserialize(data.cbegin(), data.end(), cs);\n> +\t\treturn deserialize(data.cbegin(), data.cend(), cs);\n> \t}\n> \n> \tstatic std::map deserialize(std::vector::const_iterator dataBegin,\n> @@ -248,13 +248,13 @@ public:\n> \t\t\t\t\t ControlSerializer *cs = nullptr)\n> \t{\n> \t\tstd::vector fds;\n> -\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.end(), cs);\n> +\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.cend(), cs);\n> \t}\n> \n> \tstatic std::map deserialize(std::vector &data, std::vector &fds,\n> \t\t\t\t\t ControlSerializer *cs = nullptr)\n> \t{\n> -\t\treturn deserialize(data.cbegin(), data.end(), fds.cbegin(), fds.end(), cs);\n> +\t\treturn deserialize(data.cbegin(), data.cend(), fds.cbegin(), fds.cend(), cs);\n> \t}\n> \n> \tstatic std::map deserialize(std::vector::const_iterator dataBegin,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF59FBD16B\n\tfor ;\n\tTue, 18 Oct 2022 09:40:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D8CA62E17;\n\tTue, 18 Oct 2022 11:40:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A720B62DD1\n\tfor ;\n\tTue, 18 Oct 2022 11:40:48 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D8DE8B9;\n\tTue, 18 Oct 2022 11:40:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666086050;\n\tbh=duS3jS317OmiwJ1W16fCdUkkcU88fPY5fHzo6Wg8tIE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zaKnGqJHRKWLQUPhCxMrzZ0TmEIyV38kFjcfXjtMIN9fm2EhqoWhUqCr0rzJQF2Fi\n\tD6grZSdi7yTmm1529vvaT0N8CUYY7TZMLBXIXHOoa+iQZ6dyARUzbtizvSq4AV2YrX\n\toD5zLubF+YX2UlWaive09mYjzQcg2AUMJArJZnAwKxAnJcGQYFSolC+OfjWHnpIePP\n\tZePcrWB0dtnwfP6mXu2/uiea6xdp7rqfI6GU2fZPM0kD5U4K+lA+Icq0bURhfMZfv1\n\tctqg8RFjicbsrc3hzx7z7rBUie4b0m1Zn/4iStGogxS8olsJZ1p4vtLo3inofJCjJF\n\tqY2itWmSM7igw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666086048;\n\tbh=duS3jS317OmiwJ1W16fCdUkkcU88fPY5fHzo6Wg8tIE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ts/EVwI5RuaJf5M8vsUuo9/m0pu26q0zb4K/SYY4cWZcjbIsvrRoJwrZFjdoyrGRO\n\t8rLqz4BytAZlG2Ttkss0fwSORJWWq0ggIoxkmAEBK8Xym6xfI3ABg2BQZJndYZXvVZ\n\tGlf1ST/vsQiaaj1cSMBJxHnJlf1EpnHN6W/YLbvs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ts/EVwI5\"; dkim-atps=neutral","Date":"Tue, 18 Oct 2022 12:40:24 +0300","To":"Paul Elder ","Message-ID":"","References":"<20221018093449.3165709-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221018093449.3165709-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipc: ipa_data_serializer: Use cend()\n\tin deserializers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25450,"web_url":"https://patchwork.libcamera.org/comment/25450/","msgid":"","date":"2022-10-18T10:10:29","subject":"Re: [libcamera-devel] [PATCH] ipc: ipa_data_serializer: Use cend()\n\tin deserializers","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul,\n\nOn 10/18/22 3:04 PM, Paul Elder via libcamera-devel wrote:\n> The overloaded deserializers functions that called the main deserializer\n> function using iterators used cbegin() but end() instead of cend(). Make\n> all of these use cend() instead.\n>\n> Signed-off-by: Paul Elder \n\nReviewed-by: Umang Jain \n\n> ---\n> include/libcamera/internal/ipa_data_serializer.h | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n> index 30bdaebc..54895b87 100644\n> --- a/include/libcamera/internal/ipa_data_serializer.h\n> +++ b/include/libcamera/internal/ipa_data_serializer.h\n> @@ -134,7 +134,7 @@ public:\n> \n> \tstatic std::vector deserialize(std::vector &data, ControlSerializer *cs = nullptr)\n> \t{\n> -\t\treturn deserialize(data.cbegin(), data.end(), cs);\n> +\t\treturn deserialize(data.cbegin(), data.cend(), cs);\n> \t}\n> \n> \tstatic std::vector deserialize(std::vector::const_iterator dataBegin,\n> @@ -142,13 +142,13 @@ public:\n> \t\t\t\t\t ControlSerializer *cs = nullptr)\n> \t{\n> \t\tstd::vector fds;\n> -\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.end(), cs);\n> +\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.cend(), cs);\n> \t}\n> \n> \tstatic std::vector deserialize(std::vector &data, std::vector &fds,\n> \t\t\t\t\t ControlSerializer *cs = nullptr)\n> \t{\n> -\t\treturn deserialize(data.cbegin(), data.end(), fds.cbegin(), fds.end(), cs);\n> +\t\treturn deserialize(data.cbegin(), data.cend(), fds.cbegin(), fds.cend(), cs);\n> \t}\n> \n> \tstatic std::vector deserialize(std::vector::const_iterator dataBegin,\n> @@ -240,7 +240,7 @@ public:\n> \n> \tstatic std::map deserialize(std::vector &data, ControlSerializer *cs = nullptr)\n> \t{\n> -\t\treturn deserialize(data.cbegin(), data.end(), cs);\n> +\t\treturn deserialize(data.cbegin(), data.cend(), cs);\n> \t}\n> \n> \tstatic std::map deserialize(std::vector::const_iterator dataBegin,\n> @@ -248,13 +248,13 @@ public:\n> \t\t\t\t\t ControlSerializer *cs = nullptr)\n> \t{\n> \t\tstd::vector fds;\n> -\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.end(), cs);\n> +\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.cend(), cs);\n> \t}\n> \n> \tstatic std::map deserialize(std::vector &data, std::vector &fds,\n> \t\t\t\t\t ControlSerializer *cs = nullptr)\n> \t{\n> -\t\treturn deserialize(data.cbegin(), data.end(), fds.cbegin(), fds.end(), cs);\n> +\t\treturn deserialize(data.cbegin(), data.cend(), fds.cbegin(), fds.cend(), cs);\n> \t}\n> \n> \tstatic std::map deserialize(std::vector::const_iterator dataBegin,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAEE5C0DA4\n\tfor ;\n\tTue, 18 Oct 2022 10:10:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CDFB862E18;\n\tTue, 18 Oct 2022 12:10:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11F77603D3\n\tfor ;\n\tTue, 18 Oct 2022 12:10:36 +0200 (CEST)","from [192.168.1.105] (unknown [103.86.18.250])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7EB3E8B9;\n\tTue, 18 Oct 2022 12:10:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666087837;\n\tbh=doHd/O6TneD3rfuzagEe3bZC79b3yyWtTT223RXQS3o=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=jzHsKBut514cK1eUS9piBe0+QtGmIIeAy9h1t8KaUS+UImkTY8NjI7ZIvc6FBEM9u\n\tpIWFbEbHIBOwFimYXcCb43iBT9YQr3/0+x8tb699A1ICEvYcU7E8jFtVaQE3qONBgl\n\tAN8V8xJ0wU5iem66MtEu0/PclOtgs2vka8J4UA6w35csVz96uM+AE/IfJga6jTZJ/9\n\tM3E4KsrjijKhP/E0VouhfiD5IdeOe+ta8Ut3al1Fft+h+614ro2QqMobP7YHoHDEoV\n\tnKpV2dJ3pZyL/H3XxcCWgvX2NkksDjGo2n8yEkD2pe+UHFUvxishkpTC1yCKnivxGM\n\tsQID6oKNAF+xA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666087835;\n\tbh=doHd/O6TneD3rfuzagEe3bZC79b3yyWtTT223RXQS3o=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=dNGYFp1TnQTfkIW4nPDbPm4K3MhxuYfhwAJDN5FB7dZyEMslDNW/Utmq5XFatU5S9\n\tLY6Oe22yZyPSgyvzzwnzPFMq8Y/dIWJlQKkCvZH3GERlnVxf1LYvRLYy9zp8BqMBMg\n\t9BltFyt44TPqjGROfeYgo4NPi1BapW1H9ZPouB9k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dNGYFp1T\"; dkim-atps=neutral","Message-ID":"","Date":"Tue, 18 Oct 2022 15:40:29 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.2.1","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221018093449.3165709-1-paul.elder@ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<20221018093449.3165709-1-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] ipc: ipa_data_serializer: Use cend()\n\tin deserializers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]