[{"id":25440,"web_url":"https://patchwork.libcamera.org/comment/25440/","msgid":"","date":"2022-10-18T00:23:14","subject":"Re: [libcamera-devel] [PATCH 1/3] qcam,\n\tcam: Move DNGWriter from qcam to cam","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Oct 18, 2022 at 02:17:39AM +0900, Paul Elder via libcamera-devel wrote:\n> To prepare for adding DNG support to cam, move DNGWriter from qcam to\n> cam so that we only have inclusions from qcam to cam and not the other\n> way around.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/{qcam => cam}/dng_writer.cpp | 0\n> src/{qcam => cam}/dng_writer.h | 0\n> src/cam/meson.build | 9 +++++++++\n> src/qcam/main_window.cpp | 2 +-\n> src/qcam/meson.build | 2 +-\n> 5 files changed, 11 insertions(+), 2 deletions(-)\n> rename src/{qcam => cam}/dng_writer.cpp (100%)\n> rename src/{qcam => cam}/dng_writer.h (100%)\n> \n> diff --git a/src/qcam/dng_writer.cpp b/src/cam/dng_writer.cpp\n> similarity index 100%\n> rename from src/qcam/dng_writer.cpp\n> rename to src/cam/dng_writer.cpp\n> diff --git a/src/qcam/dng_writer.h b/src/cam/dng_writer.h\n> similarity index 100%\n> rename from src/qcam/dng_writer.h\n> rename to src/cam/dng_writer.h\n> diff --git a/src/cam/meson.build b/src/cam/meson.build\n> index 8259239f..06dbea06 100644\n> --- a/src/cam/meson.build\n> +++ b/src/cam/meson.build\n> @@ -26,6 +26,7 @@ cam_cpp_args = []\n> libdrm = dependency('libdrm', required : false)\n> libjpeg = dependency('libjpeg', required : false)\n> libsdl2 = dependency('SDL2', required : false)\n> +libtiff = dependency('libtiff-4', required : false)\n\nYou could drop the libtiff dependency from src/qcam/meson.build to avoid\nsearching for it twice, and just reuse the libtiff variable. It may be\nbetter placed in src/meson.build in that case though. Maybe that's\nsomething we can look at later, there's at least the libevent dependency\nthat could be shared similarly.\n\n> \n> if libdrm.found()\n> cam_cpp_args += [ '-DHAVE_KMS' ]\n> @@ -51,6 +52,13 @@ if libsdl2.found()\n> endif\n> endif\n> \n> +if libtiff.found()\n> + cam_cpp_args += ['-DHAVE_TIFF']\n> + cam_sources += files([\n> + 'dng_writer.cpp',\n> + ])\n> +endif\n\nThis belongs to 2/3.\n\n> +\n> cam = executable('cam', cam_sources,\n> dependencies : [\n> libatomic,\n> @@ -59,6 +67,7 @@ cam = executable('cam', cam_sources,\n> libevent,\n> libjpeg,\n> libsdl2,\n> + libtiff,\n\nThis too.\n\nReviewed-by: Laurent Pinchart \n\n> libyaml,\n> ],\n> cpp_args : cam_cpp_args,\n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index e0e5092e..f553ccb0 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -26,10 +26,10 @@\n> #include \n> #include \n> \n> +#include \"../cam/dng_writer.h\"\n> #include \"../cam/image.h\"\n> \n> #include \"cam_select_dialog.h\"\n> -#include \"dng_writer.h\"\n> #ifndef QT_NO_OPENGL\n> #include \"viewfinder_gl.h\"\n> #endif\n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index 61861ea6..9f5759ff 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -49,7 +49,7 @@ if tiff_dep.found()\n> qt5_cpp_args += ['-DHAVE_TIFF']\n> qcam_deps += [tiff_dep]\n> qcam_sources += files([\n> - 'dng_writer.cpp',\n> + '../cam/dng_writer.cpp',\n> ])\n> endif\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB5E5C0DA4\n\tfor ;\n\tTue, 18 Oct 2022 00:23:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3193962E06;\n\tTue, 18 Oct 2022 02:23:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64BDF61F55\n\tfor ;\n\tTue, 18 Oct 2022 02:23:39 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF1258F8;\n\tTue, 18 Oct 2022 02:23:38 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666052621;\n\tbh=WTGVhwWGIF/yBSoUf7QZIKngbApa7RO1jaZpsgMm6v4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fskz/GXld1Dx4vZliZk+0o8dJrMNSbri09xOHyWNmA1g4nxqjlLDgw4Ul30NhhYn/\n\tmt6yOQbvBKIt0GP3+YDrGgGfVzCTYonhuNbZdHBnYeqfbPK1gRamqix8cFNT6Abk3C\n\tW6+3vXBhtITbkulV1QTresh1/viamJ/DqvPMFPIrt6COfHvbsnz5XcqjcY8swV5XDW\n\th78j+evkKq/xXeDMb1Lu/jI53jQSy2zUYKFreBqxlzMJCu6C1GXE8rYCWqVVUFy5ZP\n\tbyjaQ8aIgZRZ5PboVtG/e6jbuTqTFlGjKv7Qq8gXjdci4E+jGRL1yFx4jrnaJUEy7I\n\tDccv5h/4fPlsA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666052618;\n\tbh=WTGVhwWGIF/yBSoUf7QZIKngbApa7RO1jaZpsgMm6v4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=E9ogoqgC4dph1msOvfTCIYdSwYd0pXmvVNa9WsA5nri7GD7W1AKPGA8OmmfceSLPt\n\tXxo+dnL8RpK0C6EEK4m4OBFIWpbp9UIB2fLBNQV3utPBwKYoxkWWgj2/Ad9fIvXePn\n\tn1PQDO5WtX1h3K9+UGRLdoT8ESmyQGsKAgORVzH4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"E9ogoqgC\"; dkim-atps=neutral","Date":"Tue, 18 Oct 2022 03:23:14 +0300","To":"Paul Elder ","Message-ID":"","References":"<20221017171741.3803909-1-paul.elder@ideasonboard.com>\n\t<20221017171741.3803909-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221017171741.3803909-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] qcam,\n\tcam: Move DNGWriter from qcam to cam","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]