[{"id":25446,"web_url":"https://patchwork.libcamera.org/comment/25446/","msgid":"<20221018081401.GD3814735@pyrite.rasen.tech>","date":"2022-10-18T08:14:01","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Reduce\n\tzero sequence warning log level","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Mon, Oct 17, 2022 at 09:36:12AM +0100, Kieran Bingham via libcamera-devel wrote:\n> The V4L2VideoDevice ensures that all sequence numbers for applications\n> commence at zero from the libcamera perspective. This should be the\n> behaviour expected by kernel drivers, but this is not always the case.\n> \n> This is handled internally to ensure consistency, and a warning is\n> printed if the device does not start from zero. It was expected that the\n> Warning would help highlight where kernel drivers should be fixed, but\n> this has led to several false positive reports of failures where people\n> have been concerned that this warning is a cause for unrelated issues.\n> \n> Lower the log level print to 'Info', to reduce the apparent severity of\n> this warning. Info is likely more appropriate that Debug to continue to\n> facilitate awareness of kernel drivers that could be improved, while not\n> appearing to be a fault.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index e30858c9fa02..c2cb9dbfe09c 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1814,7 +1814,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n> \t */\n> \tif (!firstFrame_) {\n> \t\tif (buf.sequence)\n> -\t\t\tLOG(V4L2, Warning)\n> +\t\t\tLOG(V4L2, Info)\n> \t\t\t\t<< \"Zero sequence expected for first frame (got \"\n> \t\t\t\t<< buf.sequence << \")\";\n> \t\tfirstFrame_ = buf.sequence;\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3362C0DA4\n\tfor ;\n\tTue, 18 Oct 2022 08:14:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11EB362E12;\n\tTue, 18 Oct 2022 10:14:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 807F162DD1\n\tfor ;\n\tTue, 18 Oct 2022 10:14:08 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1DD4B8CC;\n\tTue, 18 Oct 2022 10:14:06 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666080850;\n\tbh=xFWVMKKNloR1L9j7PHq5dRBOTjK7yXEgiTi58Fc6UoM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=kwpmEfb02UqsRiP+kH6Zb+1XTFnVFPiAVCElcIyp9hDJWR8jJndpCG4LV95hCyX4R\n\tcqEIuZM/tXt1R18vQiYqskiAy8d2e4LVka1pD2E7Sl7Bbd/bhMT1bJ4qFEqCh4Jxpb\n\t9PfrqlYlEJj27O8GTkKuOhxvVlobEmUAkYq0LhJNCDvKxVj7SHO6LOpVgOGbP1EzJO\n\tvyrPror3ljowmIAuqPA4WGfqhw0ySUW2xSJPSJS7S8rkks7kXqydsgCjoowDeup78m\n\tqfyG5NdrZdMtRRo/JaowuQsps3P63taUuuNak0ZzQxeq4N0fkuHfL4vArZ0Z0/W+dz\n\tunSkeQRSfq8Jw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666080848;\n\tbh=xFWVMKKNloR1L9j7PHq5dRBOTjK7yXEgiTi58Fc6UoM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XHe/jbdMVM4PN6GxaMaV3Rk/uOrY/eXvVSqegR55AKakf3zh1A0wAAzGLLr7BhZqT\n\tJbvyZdwhX/FxC7UxEJwqKsO+9x9O5vzZES3f9M2TBYU1n6TrvmR4242tPFotGJD3cJ\n\tYRfvgM2W7zWzLmlK3U2m6Q0ruJVo57f+cG4Op+Ps="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XHe/jbdM\"; dkim-atps=neutral","Date":"Tue, 18 Oct 2022 17:14:01 +0900","To":"Kieran Bingham ","Message-ID":"<20221018081401.GD3814735@pyrite.rasen.tech>","References":"<20221017083612.810332-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20221017083612.810332-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Reduce\n\tzero sequence warning log level","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25775,"web_url":"https://patchwork.libcamera.org/comment/25775/","msgid":"","date":"2022-11-11T16:16:14","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Reduce\n\tzero sequence warning log level","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch\n\nOn 10/17/22 2:06 PM, Kieran Bingham via libcamera-devel wrote:\n> The V4L2VideoDevice ensures that all sequence numbers for applications\n> commence at zero from the libcamera perspective. This should be the\n> behaviour expected by kernel drivers, but this is not always the case.\n>\n> This is handled internally to ensure consistency, and a warning is\n> printed if the device does not start from zero. It was expected that the\n> Warning would help highlight where kernel drivers should be fixed, but\n> this has led to several false positive reports of failures where people\n> have been concerned that this warning is a cause for unrelated issues.\n>\n> Lower the log level print to 'Info', to reduce the apparent severity of\n> this warning. Info is likely more appropriate that Debug to continue to\n> facilitate awareness of kernel drivers that could be improved, while not\n> appearing to be a fault.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index e30858c9fa02..c2cb9dbfe09c 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1814,7 +1814,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n> \t */\n> \tif (!firstFrame_) {\n> \t\tif (buf.sequence)\n> -\t\t\tLOG(V4L2, Warning)\n> +\t\t\tLOG(V4L2, Info)\n> \t\t\t\t<< \"Zero sequence expected for first frame (got \"\n> \t\t\t\t<< buf.sequence << \")\";\n> \t\tfirstFrame_ = buf.sequence;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8BA4EBE08B\n\tfor ;\n\tFri, 11 Nov 2022 16:16:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E252A61F3F;\n\tFri, 11 Nov 2022 17:16:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC16A61F3F\n\tfor ;\n\tFri, 11 Nov 2022 17:16:20 +0100 (CET)","from [192.168.1.104] (unknown [103.251.226.75])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 67FB133F;\n\tFri, 11 Nov 2022 17:16:19 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668183382;\n\tbh=WFEc6GRj9wrYz9yfvHIsVO76BtOa7pgbdZBvCMz2fbA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Uan7dh+rTrpvWKkAPozNOFKmZRxrD2yG34Bo8ypWeIDb928gbZpOM195K4mMZsbql\n\tJGpk0ngPfm5DJENo1h+8/WSMd4z5Y+emj1KHWBXxhW6a4l9zGRVBGfER2JiSWsFvMW\n\tZSCTqRrJCM7pBbUFZRJOEk0VXU+4EKHXpuuzKuiGsDTOKjoskBkJ9cgXEdHbmr8h2e\n\tQ1vA5Ja7Up+d+G6skIvVnB2d0ojHAOr5sv4aLd3daGqcSZvSq2+BdbjdJsCizPMNrT\n\tae1H+H88Ckk96mED0HM0GfqgNB5nADIRIDyWn+X8uyfe82g5JGMO1eVPmwN7lI6Ub2\n\tWo/lbPs/3q4HQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668183380;\n\tbh=WFEc6GRj9wrYz9yfvHIsVO76BtOa7pgbdZBvCMz2fbA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ZrARk7CPzZ8oSM6KjR4RvL6vuKvhcHdrDNDfsZ4aAu87io3kkrzhLbuE20xQoLx7a\n\tsqdjwjF66ORsy7wpMVzNVVzlb+o/YMygUTe3UyR2t0oh1a7yx/cNn4JxY0yzgf20ty\n\t3DGtCrYKNA/4Qcg21OWOhkuTOI49VhquBj4jEOWQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZrARk7CP\"; dkim-atps=neutral","Message-ID":"","Date":"Fri, 11 Nov 2022 21:46:14 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.4.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20221017083612.810332-1-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20221017083612.810332-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Reduce\n\tzero sequence warning log level","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]