[{"id":25712,"web_url":"https://patchwork.libcamera.org/comment/25712/","msgid":"","date":"2022-11-01T12:28:41","subject":"Re: [libcamera-devel] [PATCH v1 10/10] pipeline: raspberrypi: Add\n\tlibcamera-apps and picamera2 config file","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"HI Naush\n\nThanks for this patch!\n\nFinally, the only config file that anyone will ever want to use!\n\nOn Fri, 14 Oct 2022 at 14:19, Naushir Patuck via libcamera-devel\n wrote:\n>\n> Add a platform configuration file optimised for use with the Raspberry Pi\n> suite of libcamera-apps and the picamera2 framework.\n>\n> This configuration minimises the number of internal buffers allocated, with\n> the expectation that applications will always provide buffers in request for\n> any configured stream.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> .../pipeline/raspberrypi/data/meson.build | 1 +\n> .../pipeline/raspberrypi/data/rpi_apps.json | 28 +++++++++++++++++++\n> 2 files changed, 29 insertions(+)\n> create mode 100644 src/libcamera/pipeline/raspberrypi/data/rpi_apps.json\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/data/meson.build b/src/libcamera/pipeline/raspberrypi/data/meson.build\n> index 0592fc53877d..aabde57f25c6 100644\n> --- a/src/libcamera/pipeline/raspberrypi/data/meson.build\n> +++ b/src/libcamera/pipeline/raspberrypi/data/meson.build\n> @@ -3,6 +3,7 @@\n> conf_files = files([\n> 'default.json',\n> 'minimal_mem.json',\n> + 'rpi_apps.json',\n> ])\n>\n> install_data(conf_files,\n> diff --git a/src/libcamera/pipeline/raspberrypi/data/rpi_apps.json b/src/libcamera/pipeline/raspberrypi/data/rpi_apps.json\n> new file mode 100644\n> index 000000000000..6a3eebf4fac7\n> --- /dev/null\n> +++ b/src/libcamera/pipeline/raspberrypi/data/rpi_apps.json\n> @@ -0,0 +1,28 @@\n> +{\n> + \"version\": 1.0,\n> + \"target\": \"bcm2835\",\n> +\n> + \"pipeline_handler\":\n> + {\n> + # The minimum number of internal buffers to be allocated for Unicam.\n> + # This value must less than or equal to min_total_unicam_buffers.\n> + \"min_unicam_buffers\": 0,\n> +\n> + # The minimum total (internal + external) buffer count used for Unicam.\n> + # The number of internal buffers allocated for Unicam is given by:\n> + # internal buffer count = max(min_unicam_buffers,\n> + # min_total_unicam_buffers - external buffer count)\n> + \"min_total_unicam_buffers\": 4,\n> +\n> + # The number of internal buffers used for ISP Output0.\n> + \"num_output0_buffers\": 0,\n> +\n> + # Override any request from the IPA to drop a number of startup frames.\n> + \"disable_startup_frame_drops\": false,\n> +\n> + # Always process a pending request with the last captured sensor frame.\n> + # Note that this might lead to avoidable frame drops during periods\n> + # of transient heavey CPU loading.\n\ns/heavey/heavy/\n\nObviously we'll have to figure out how we arrange for our apps to pick\nup this file, but we can sleep on that.\n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\n> + \"return_newest_frames\": false\n> + }\n> +}\n> \\ No newline at end of file\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 789C5BDB16\n\tfor ;\n\tTue, 1 Nov 2022 12:28:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E606A6303F;\n\tTue, 1 Nov 2022 13:28:54 +0100 (CET)","from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com\n\t[IPv6:2607:f8b0:4864:20::1033])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 543D263009\n\tfor ;\n\tTue, 1 Nov 2022 13:28:54 +0100 (CET)","by mail-pj1-x1033.google.com with SMTP id\n\tr61-20020a17090a43c300b00212f4e9cccdso18625040pjg.5\n\tfor ;\n\tTue, 01 Nov 2022 05:28:54 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1667305734;\n\tbh=h9IYoAXhLO5t2MmxccU8j8tTL69agjLYv25YCNAkIKY=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Ct5Nca9lEs2XFGZfrvSfNlvRgw0uwiVbLu0khy0yc9+Xtq1N90nsZmz0XYj79CRhO\n\tUk4voRvy1suzB1nAgNkW2lljagILspJDcfhxY8CcsBSnZ6/lQiuHpY8AcE0cLcrgl3\n\ts6SemV4dU547lL1C/kDKxKxMm5Gc7MUNFkP0FCDiKID7/AhGfVyze1do0Q/dFJU2vQ\n\tnSVwQPWx0zP7pHwcycViulb8uuZsVaSYsMkiEaYinO/+fCoPZiw/dZFF9GjLF8XAbk\n\t3VnwaHv5HiPniRAlBe7Wm3eu4sIkYDZybYp8U23gncKOZsDQbCJ/t1ZTQEKq5HjwNj\n\tJAzcF8qeug+Bg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=4yrmzqBAHqNFHJKi2deTuSEKvRtV2yASMHRjRSLO4FM=;\n\tb=TwRT4IREvPw+VXXOjEgjXEXbkHC2UQ3Y+92FM1Qf85euF/ezPz3DKo64rG4SctfeLO\n\ts2LKUPo8pfH7Bgyy600NcJH+3/WQrkP1M2ZPgKpVsU8Lp0p9DztHxjBGBU2gJ6E7KE6f\n\tJdPpyDs7J6bzPNpZUMclzURUjdHzHkL944XEZTnTJYprM2HeZkUfJ96MSZzeTxkiPj+K\n\toGoeOh5HfHp97rxmazyu0HuE0IOAtwQ6rjf0ZB0YHfjitmde3/+3+Y3xmyRbGJ1Fqgku\n\tqTH/MrhD6MQGZTiCg9bPGBL9NJA0lS7awYZVWAwIcJdlgTrXHpKWcBpcxEJuBXbdIQGV\n\tI/DQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"TwRT4IRE\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=4yrmzqBAHqNFHJKi2deTuSEKvRtV2yASMHRjRSLO4FM=;\n\tb=BDTzu4fFRe5cnk+J2q8xxBFWBZeaYSR00M86kRnhL/kSq8COyEDxB3KSBzqJLbMSnR\n\tHui/WdZ3Rn21H+2tnCSVjDnrb/TbwtJsEuhkBsY4jDTu3lOJ2uv1nWIKUF/udCb3iQYt\n\thCZvUbxEZydyg3A+YnGhDvukZlzsQCmC91cf+4P0DjUHfh4uXya4ov5R3wgYGrxsfNu1\n\thmsxeAMWtt33cnoJMtB0tHTnQy3EUpdrYSjiBtq3/BKkRm2+vDO4c8cI8qcTpristqIb\n\tQpldADQYn9jWD5sx0aGwvVLjFrI2kbwvC827n3KzfU4xEwQ2pPakJW7px336+pmuPbc1\n\te3sQ==","X-Gm-Message-State":"ACrzQf3qHG1lYHfxfwW6xkXs3Kg7PAvwEsx/qtwbKoRTm55P3yU34Sbr\n\tgSGZNYOea8VEqikaUMSHXPOLXaXntazLfq+bQW0yhg==","X-Google-Smtp-Source":"AMsMyM5J4nSSKpj45yjCJrm0RYKUPWEuTiYL7tI4hXkQsoudAc9B8SjqrqnurwLqhexmr7jAnRP6U3VsywqzJEkAPsw=","X-Received":"by 2002:a17:902:720a:b0:181:150c:fcc4 with SMTP id\n\tba10-20020a170902720a00b00181150cfcc4mr19714722plb.109.1667305732833;\n\tTue, 01 Nov 2022 05:28:52 -0700 (PDT)","MIME-Version":"1.0","References":"<20221014131846.27169-1-naush@raspberrypi.com>\n\t<20221014131846.27169-11-naush@raspberrypi.com>","In-Reply-To":"<20221014131846.27169-11-naush@raspberrypi.com>","Date":"Tue, 1 Nov 2022 12:28:41 +0000","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v1 10/10] pipeline: raspberrypi: Add\n\tlibcamera-apps and picamera2 config file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]