[{"id":25419,"web_url":"https://patchwork.libcamera.org/comment/25419/","msgid":"<9c5a3965-a1d0-957b-512e-6b5fb04cdec5@ideasonboard.com>","date":"2022-10-14T14:18:03","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: v4l2_subdevice: Add\n\tJPEG_1X8 and BGR888_1X24 mbus formats to formatInfoMap","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Xavier,\n\nThank you for the patch.\n\nOn 10/10/22 3:54 PM, Xavier Roumegue (OSS) via libcamera-devel wrote:\n> From: Xavier Roumegue \n>\n> The warnings \"Unknown subdev format 0x4001, defaulting to RGB encoding\" and\n> \"Unknown subdev format 0x1013, defaulting to RGB encoding\" are thrown while using\n\nGlad to see these warnings are catching things what we intended for, \nsince it has recently been introduced.\n> simple pipeline handler with NXP ISI hardware.\n> The JPEG_1X8 and BGR888_1X24 media bus formats, supported by the ISI driver, are\n> missing in the V4L2SubdeviceFormatInfo structure storing the correspondence\n> between a media bus format and a colour encoding. So populate the structure with\n> the missing media bus formats.\n>\n> Signed-off-by: Xavier Roumegue \n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 9ef95963..37cd63c6 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -68,6 +68,7 @@ const std::map formatInfoMap = {\n> \t{ MEDIA_BUS_FMT_RGB565_2X8_LE, { 16, \"RGB565_2X8_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_RGB666_1X18, { 18, \"RGB666_1X18\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_RGB888_1X24, { 24, \"RGB888_1X24\", PixelFormatInfo::ColourEncodingRGB } },\n> +\t{ MEDIA_BUS_FMT_BGR888_1X24, { 24, \"BGR888_1X24\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_RGB888_2X12_BE, { 24, \"RGB888_2X12_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_RGB888_2X12_LE, { 24, \"RGB888_2X12_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_ARGB8888_1X32, { 32, \"ARGB8888_1X32\", PixelFormatInfo::ColourEncodingRGB } },\n> @@ -133,6 +134,7 @@ const std::map formatInfoMap = {\n> \t{ MEDIA_BUS_FMT_SRGGB12_1X12, { 12, \"SRGGB12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> \t/* \\todo Clarify colour encoding for HSV formats */\n> \t{ MEDIA_BUS_FMT_AHSV8888_1X32, { 32, \"AHSV8888_1X32\", PixelFormatInfo::ColourEncodingRGB } },\n> +\t{ MEDIA_BUS_FMT_JPEG_1X8, { 8, \"JPEG_1X8\", PixelFormatInfo::ColourEncodingYUV } },\n> };\n> \n> } /* namespace */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CF03C0DA4\n\tfor ;\n\tFri, 14 Oct 2022 08:49:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D781762DB5;\n\tFri, 14 Oct 2022 10:49:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6767562DAE\n\tfor ;\n\tFri, 14 Oct 2022 10:49:03 +0200 (CEST)","from [192.168.1.103] (unknown [103.238.109.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 41DEE6DE;\n\tFri, 14 Oct 2022 10:49:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665737344;\n\tbh=dt43S+g76oih7Rmu9CSyz3GRjvC2uihwYfwXjEDk3mI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=SDnR/jnIHlBW03KpOPZvJuq4bSAV9PFa3WjwdM/cd8D3YI69Bx+w9mBuyWGxs/adw\n\tAUOTXhVaEY7dOZBSqw/FiM9NK6ICPuHSvnWDbjHHCPWU2RnoDXkNyilA4VZYKR6+qN\n\tlThVrXbSRr6inPuIr5LWnA94MekiebEVA1ZTNf//b9GlmvhWijlCurqgohzQQw+u7T\n\ty+58axy5aofBjcd0d55KOakA9t3R4fx5Xq6Omlv+hd7FzFG2zc2LDNh698VwQMcJ8I\n\tcdjWDh5jLI2U5170BugBp/K5l/PmeRWcn8rAVZNVfaNwLx1KNDHINE1SfmuESX7jRb\n\tWczf2ZAfaQ55w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665737343;\n\tbh=dt43S+g76oih7Rmu9CSyz3GRjvC2uihwYfwXjEDk3mI=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=QthBfe7/d9QbPGkfcsXiYH6z6zYXyhBy/35SQup8UGhQ0Z1Wm4OMjmXRQHC+IKnhc\n\tvtEQQOQ3VPDts+pX2+9T8B1lvYwiTaCENw29+EvsoVzEBqo8tUE9qnJAQdRIPDQIC3\n\t2zseOYmoLfVl6Nh7XgeauntEU2quIBMQM2mlk9BM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QthBfe7/\"; dkim-atps=neutral","Message-ID":"<9c5a3965-a1d0-957b-512e-6b5fb04cdec5@ideasonboard.com>","Date":"Fri, 14 Oct 2022 19:48:03 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.2.1","Content-Language":"en-US","To":"\"Xavier Roumegue (OSS)\" ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221010093745.knws36r4m2ura3er@uno.localdomain>\n\t<20221010102418.430215-1-xavier.roumegue@oss.nxp.com>","In-Reply-To":"<20221010102418.430215-1-xavier.roumegue@oss.nxp.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: v4l2_subdevice: Add\n\tJPEG_1X8 and BGR888_1X24 mbus formats to formatInfoMap","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25423,"web_url":"https://patchwork.libcamera.org/comment/25423/","msgid":"","date":"2022-10-15T16:54:12","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: v4l2_subdevice: Add\n\tJPEG_1X8 and BGR888_1X24 mbus formats to formatInfoMap","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Xavier,\n\nThank you for the patch.\n\nOn Mon, Oct 10, 2022 at 12:24:18PM +0200, Xavier Roumegue (OSS) via libcamera-devel wrote:\n> From: Xavier Roumegue \n> \n> The warnings \"Unknown subdev format 0x4001, defaulting to RGB encoding\" and\n> \"Unknown subdev format 0x1013, defaulting to RGB encoding\" are thrown while using\n> simple pipeline handler with NXP ISI hardware.\n> The JPEG_1X8 and BGR888_1X24 media bus formats, supported by the ISI driver, are\n> missing in the V4L2SubdeviceFormatInfo structure storing the correspondence\n> between a media bus format and a colour encoding. So populate the structure with\n> the missing media bus formats.\n> \n> Signed-off-by: Xavier Roumegue \n> ---\n> src/libcamera/v4l2_subdevice.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 9ef95963..37cd63c6 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -68,6 +68,7 @@ const std::map formatInfoMap = {\n> \t{ MEDIA_BUS_FMT_RGB565_2X8_LE, { 16, \"RGB565_2X8_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_RGB666_1X18, { 18, \"RGB666_1X18\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_RGB888_1X24, { 24, \"RGB888_1X24\", PixelFormatInfo::ColourEncodingRGB } },\n> +\t{ MEDIA_BUS_FMT_BGR888_1X24, { 24, \"BGR888_1X24\", PixelFormatInfo::ColourEncodingRGB } },\n\nLet's put BGR before RGB to maintain some kind of ordering :-) I'll\nhandle this when applying the patch to my tree.\n\nReviewed-by: Laurent Pinchart \n\n> \t{ MEDIA_BUS_FMT_RGB888_2X12_BE, { 24, \"RGB888_2X12_BE\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_RGB888_2X12_LE, { 24, \"RGB888_2X12_LE\", PixelFormatInfo::ColourEncodingRGB } },\n> \t{ MEDIA_BUS_FMT_ARGB8888_1X32, { 32, \"ARGB8888_1X32\", PixelFormatInfo::ColourEncodingRGB } },\n> @@ -133,6 +134,7 @@ const std::map formatInfoMap = {\n> \t{ MEDIA_BUS_FMT_SRGGB12_1X12, { 12, \"SRGGB12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n> \t/* \\todo Clarify colour encoding for HSV formats */\n> \t{ MEDIA_BUS_FMT_AHSV8888_1X32, { 32, \"AHSV8888_1X32\", PixelFormatInfo::ColourEncodingRGB } },\n> +\t{ MEDIA_BUS_FMT_JPEG_1X8, { 8, \"JPEG_1X8\", PixelFormatInfo::ColourEncodingYUV } },\n> };\n> \n> } /* namespace */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8A7EBD16B\n\tfor ;\n\tSat, 15 Oct 2022 16:54:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BADE62DC6;\n\tSat, 15 Oct 2022 18:54:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A4F361F6E\n\tfor ;\n\tSat, 15 Oct 2022 18:54:35 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B7054480;\n\tSat, 15 Oct 2022 18:54:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665852877;\n\tbh=LG8N5jgz1rHkcDJXBc7jhG6MAFuIW0mgBwCnPDHrTRg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=FR385a46Ek96aZsChCYa2rjIYAAKbS3x06OF+wXqRqiEJGXZCwc/yQZP0EU+vBgxv\n\ta1e7D/e+DEKls7L70xlyW1gHUAAhi03NdgNApEkOeE3k8YUcSL+bwVGfuKIJWPD6ur\n\t9KrP/r3xwXXoL0ku/ySzTBb3SCo6QmJL49VhnOo6smklHxJqkd8ZfjB4SSGGjYi35h\n\td0Q5tQFiT7mUypa9rqFVQUR0l989+0hZJ0YXPaSRQS3ybUz/Pbw5yqk7hF1RPbAJPz\n\taiDe4mpkiW5WRhkspOo3VFphgllqOCRdQZUIwzoky7/8c5N8sJ3ZsWySgVrh3P4H7l\n\tRTdh9BYzrQ+dQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665852874;\n\tbh=LG8N5jgz1rHkcDJXBc7jhG6MAFuIW0mgBwCnPDHrTRg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aOpN2MnSFRKMsiUelWRqbltm0uRZHrCsNnmOoCZHQf4NRyY9Z3ShPvXOX76Wn0ZJJ\n\tm4uXTrx/n7ZjKyjNdE9bWzYBda85YtBfvEREno2ncWosk12DkrbIXwmGhFgob4FVXs\n\tzAMLvRwvtpY+kNdCHj9bkmsciKAV2suvvfUIMHpU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"aOpN2MnS\"; dkim-atps=neutral","Date":"Sat, 15 Oct 2022 19:54:12 +0300","To":"\"Xavier Roumegue (OSS)\" ","Message-ID":"","References":"<20221010093745.knws36r4m2ura3er@uno.localdomain>\n\t<20221010102418.430215-1-xavier.roumegue@oss.nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221010102418.430215-1-xavier.roumegue@oss.nxp.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: v4l2_subdevice: Add\n\tJPEG_1X8 and BGR888_1X24 mbus formats to formatInfoMap","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]