[{"id":25321,"web_url":"https://patchwork.libcamera.org/comment/25321/","msgid":"","date":"2022-10-06T22:17:16","subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Oct 07, 2022 at 01:15:06AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Extend the ControlInfoMap test to verify the behaviour of the default\n> 'def' argument to the ControlInfoMap constructor.\n\ns/ControlInfoMap/ControlInfo/\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> test/controls/control_info.cpp | 8 +++++---\n> 1 file changed, 5 insertions(+), 3 deletions(-)\n> \n> diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\n> index 56b4101f72fe..1176a5024b3a 100644\n> --- a/test/controls/control_info.cpp\n> +++ b/test/controls/control_info.cpp\n> @@ -27,19 +27,21 @@ protected:\n> \t\tControlInfo brightness;\n> \n> \t\tif (brightness.min().type() != ControlType::ControlTypeNone ||\n> -\t\t brightness.max().type() != ControlType::ControlTypeNone) {\n> +\t\t brightness.max().type() != ControlType::ControlTypeNone ||\n> +\t\t brightness.def().type() != ControlType::ControlTypeNone) {\n> \t\t\tcout << \"Invalid control range for Brightness\" << endl;\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> \t\t/*\n> \t\t * Test information retrieval from a control with a minimum and\n> -\t\t * a maximum value.\n> +\t\t * a maximum value, and an implicit default value.\n> \t\t */\n> \t\tControlInfo contrast(10, 200);\n> \n> \t\tif (contrast.min().get() != 10 ||\n> -\t\t contrast.max().get() != 200) {\n> +\t\t contrast.max().get() != 200 ||\n> +\t\t !contrast.def().isNone()) {\n> \t\t\tcout << \"Invalid control range for Contrast\" << endl;\n> \t\t\treturn TestFail;\n> \t\t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4149FC0DA4\n\tfor ;\n\tThu, 6 Oct 2022 22:17:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9863162CFD;\n\tFri, 7 Oct 2022 00:17:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3FDF601C7\n\tfor ;\n\tFri, 7 Oct 2022 00:17:21 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 331CC6D6\n\tfor ;\n\tFri, 7 Oct 2022 00:17:21 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665094642;\n\tbh=IybHQ8dW7CgEaVjoTVzvzFrf3XgA4KQ1GyO/TQMZOIM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=bkaxauapCotr3hySPcrMI78EC/QP086p0TuMIUEnj33az/4oyTEf8N95Y6viCQn0O\n\t+/wVOtwmPeyB6h2OSuIAC1Bi69OvoyVUgTYASbqUfic0sxy/WMTUcCzepAb+woGy2i\n\tHcjm8q2kzw2yTbB5J9b6BtSnA00kklhCFg35iHfY0lK9Mrp/kNC6DMtmt6BHhpFU71\n\t29N4tIC2A6qvrJjR2lYMacCkWtZxC5mAmy2cRUV5IFhicjKli6t5+xAKyPW34YkrTw\n\tXOb6FeSwsgTDZXowzLEmArBL9GEZ27SuUOIy0q0vAGVB2zRGidCk1h0eYDb/EDU+jA\n\tauO9LgPLFTzsQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665094641;\n\tbh=IybHQ8dW7CgEaVjoTVzvzFrf3XgA4KQ1GyO/TQMZOIM=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=UGn7Evr1MYka2v4l23ZTHZVBgH9tob1ux05ILioiWACXjM0FD8d8RUUpRAJIRK+Im\n\tkp+EYSyWfIqaFwWrxPiYP8DoISNMBUL7XEYi6V1MmpWX7uO5t0UuRM7sdWZPL1NU5r\n\t8JHFHngifyaX2EUNlZHTvKHP2ezMIDNtUWIoRhgc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UGn7Evr1\"; dkim-atps=neutral","Date":"Fri, 7 Oct 2022 01:17:16 +0300","To":"libcamera-devel@lists.libcamera.org","Message-ID":"","References":"<20221006221506.16948-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221006221506.16948-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25397,"web_url":"https://patchwork.libcamera.org/comment/25397/","msgid":"<166557084823.3760285.14089719076970156051@Monstersaurus>","date":"2022-10-12T10:34:08","subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-10-06 23:17:16)\n> On Fri, Oct 07, 2022 at 01:15:06AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > Extend the ControlInfoMap test to verify the behaviour of the default\n> > 'def' argument to the ControlInfoMap constructor.\n> \n> s/ControlInfoMap/ControlInfo/\n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > test/controls/control_info.cpp | 8 +++++---\n> > 1 file changed, 5 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\n> > index 56b4101f72fe..1176a5024b3a 100644\n> > --- a/test/controls/control_info.cpp\n> > +++ b/test/controls/control_info.cpp\n> > @@ -27,19 +27,21 @@ protected:\n> > ControlInfo brightness;\n> > \n> > if (brightness.min().type() != ControlType::ControlTypeNone ||\n> > - brightness.max().type() != ControlType::ControlTypeNone) {\n> > + brightness.max().type() != ControlType::ControlTypeNone ||\n> > + brightness.def().type() != ControlType::ControlTypeNone) {\n\nShould these use the .isNone() helper?\n\nOtherwise, or either way:\n\nReviewed-by: Kieran Bingham \n\n> > cout << \"Invalid control range for Brightness\" << endl;\n> > return TestFail;\n> > }\n> > \n> > /*\n> > * Test information retrieval from a control with a minimum and\n> > - * a maximum value.\n> > + * a maximum value, and an implicit default value.\n\nExcept the 'implicit' default value is 'not a value' ?\n\n> > */\n> > ControlInfo contrast(10, 200);\n> > \n> > if (contrast.min().get() != 10 ||\n> > - contrast.max().get() != 200) {\n> > + contrast.max().get() != 200 ||\n> > + !contrast.def().isNone()) {\n> > cout << \"Invalid control range for Contrast\" << endl;\n> > return TestFail;\n> > }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7EA44BD16B\n\tfor ;\n\tWed, 12 Oct 2022 10:34:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73FE162D92;\n\tWed, 12 Oct 2022 12:34:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EDE460485\n\tfor ;\n\tWed, 12 Oct 2022 12:34:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B95F5492;\n\tWed, 12 Oct 2022 12:34:10 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665570852;\n\tbh=BbgLULhzZshOyutqmmsvd4AUHYyiJRf4PzrlH/KKYLw=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=OYJtLjbkl5Od9BWGrTKkSGZOw4XUfkNo1WIV5J1KdOtHv0b/aHxb99AgObskfiqx2\n\tv7V5Upix3IQFCKXaC6M1ZjyKttMGYNKsBOVi1IO3UbuPP/pdloCncr0Kz4a28Kgevm\n\tOTayvv/4AfR5L/TJewgsHc32INZrCspcdngbq197uRf3ziYfrrTYcIC2JEDnaCpDzo\n\tMu0II7mk6x49qmTkm9w2cks76R0WFWyKqNNISl96EglV900mIhfBTsBgRKHaAdUQyZ\n\tDif38JUIXtJg+K93GZsJyz+2pRwJK4wUFjNFSfE+MWpe77eXxYtbTFgHRJ5dlvBEHV\n\tnmNKkLdKxOgwA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665570850;\n\tbh=BbgLULhzZshOyutqmmsvd4AUHYyiJRf4PzrlH/KKYLw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=d3xVKYPQ/w4QKp2RsSO91dHsoYpr/XPkSIuc3C5Ylu2+KiKFwj1nr9fLvnmIcBxBL\n\t0E7O6pf8arwAUrsBksgHIqx6WrKI5zVc69w5Ga6H26+KOWyduSl20pbccl1t/bfber\n\t+TdywZgb00kuxESH6dJ19Fc22LdEUkA3XcKyr3to="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"d3xVKYPQ\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20221006221506.16948-1-laurent.pinchart@ideasonboard.com>\n\t","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 12 Oct 2022 11:34:08 +0100","Message-ID":"<166557084823.3760285.14089719076970156051@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25398,"web_url":"https://patchwork.libcamera.org/comment/25398/","msgid":"<6c90f21d-3ed2-ee27-f531-7a1098fdcd37@ideasonboard.com>","date":"2022-10-12T10:40:49","subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi\n\nOn 10/7/22 3:47 AM, Laurent Pinchart via libcamera-devel wrote:\n> On Fri, Oct 07, 2022 at 01:15:06AM +0300, Laurent Pinchart via libcamera-devel wrote:\n>> Extend the ControlInfoMap test to verify the behaviour of the default\n>> 'def' argument to the ControlInfoMap constructor.\n> s/ControlInfoMap/ControlInfo/\n>\n>> Signed-off-by: Laurent Pinchart \n\nI thought I reviewed this but might have forgotten to send r-b, here it is:\n\nReviewed-by: Umang Jain \n\n>> ---\n>> test/controls/control_info.cpp | 8 +++++---\n>> 1 file changed, 5 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\n>> index 56b4101f72fe..1176a5024b3a 100644\n>> --- a/test/controls/control_info.cpp\n>> +++ b/test/controls/control_info.cpp\n>> @@ -27,19 +27,21 @@ protected:\n>> \t\tControlInfo brightness;\n>> \n>> \t\tif (brightness.min().type() != ControlType::ControlTypeNone ||\n>> -\t\t brightness.max().type() != ControlType::ControlTypeNone) {\n>> +\t\t brightness.max().type() != ControlType::ControlTypeNone ||\n>> +\t\t brightness.def().type() != ControlType::ControlTypeNone) {\n>> \t\t\tcout << \"Invalid control range for Brightness\" << endl;\n>> \t\t\treturn TestFail;\n>> \t\t}\n>> \n>> \t\t/*\n>> \t\t * Test information retrieval from a control with a minimum and\n>> -\t\t * a maximum value.\n>> +\t\t * a maximum value, and an implicit default value.\n>> \t\t */\n>> \t\tControlInfo contrast(10, 200);\n>> \n>> \t\tif (contrast.min().get() != 10 ||\n>> -\t\t contrast.max().get() != 200) {\n>> +\t\t contrast.max().get() != 200 ||\n>> +\t\t !contrast.def().isNone()) {\n>> \t\t\tcout << \"Invalid control range for Contrast\" << endl;\n>> \t\t\treturn TestFail;\n>> \t\t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DCBFC0DA4\n\tfor ;\n\tWed, 12 Oct 2022 10:40:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9148C62D98;\n\tWed, 12 Oct 2022 12:40:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0430603D7\n\tfor ;\n\tWed, 12 Oct 2022 12:40:54 +0200 (CEST)","from [192.168.1.103] (unknown [103.238.109.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA138492;\n\tWed, 12 Oct 2022 12:40:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665571256;\n\tbh=MDM8gNk1pdRbv0+xfVflGv2gwQZTuEPoLYgcZOniIw8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=KcQHeM1wZF1p2S0C4/oheY/PpLVUfKzEAmmJE5JGjTs+zgel10NGCGUsDt0Oi5csN\n\tVPG94rifLTL4ohkvjVivCo8FKZ9ZDlO2qcFOoMmovNyfsx3qlTYEE3ux0NCjPaW14Y\n\tzIUHU044kjv35uUShR/eMWtC/kDDgcLF+vqWZ/ZEcgjnPvJgBoKX+BXvTxByp/JdMd\n\tpHT2pJmWlOeVWAGXk/97EPgL74RV48sB8xGljxuLuRUJxM2ntN0JEQiA/EjueTU/HF\n\tUjUx5dmAFSuJl6jGUnObHx/gYY44esYBclfcu6THVoSMAzSEj+qP8J4YnYjnSK/mnU\n\tkVlO9lTMMhmPQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665571254;\n\tbh=MDM8gNk1pdRbv0+xfVflGv2gwQZTuEPoLYgcZOniIw8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=eUfZp11uTVNz00fepWJtUQbjLlEkDenYE6A3o3egX1w4bmb0wENDiGPcXAGmyMZbS\n\t5U45liK5cl2/HooXUYuq7faMCB8DUagwDsk1zV6x4XVtU1jR3WdopqWj2dL8ckUFAA\n\tq4jnPxRQX1QzNCAWP+8sYktJ7yhHDy2mwXLU6FPg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eUfZp11u\"; dkim-atps=neutral","Message-ID":"<6c90f21d-3ed2-ee27-f531-7a1098fdcd37@ideasonboard.com>","Date":"Wed, 12 Oct 2022 16:10:49 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.2.1","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221006221506.16948-1-laurent.pinchart@ideasonboard.com>\n\t","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25426,"web_url":"https://patchwork.libcamera.org/comment/25426/","msgid":"","date":"2022-10-16T02:13:12","subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Oct 12, 2022 at 11:34:08AM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-10-06 23:17:16)\n> > On Fri, Oct 07, 2022 at 01:15:06AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > > Extend the ControlInfoMap test to verify the behaviour of the default\n> > > 'def' argument to the ControlInfoMap constructor.\n> > \n> > s/ControlInfoMap/ControlInfo/\n> > \n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > test/controls/control_info.cpp | 8 +++++---\n> > > 1 file changed, 5 insertions(+), 3 deletions(-)\n> > > \n> > > diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\n> > > index 56b4101f72fe..1176a5024b3a 100644\n> > > --- a/test/controls/control_info.cpp\n> > > +++ b/test/controls/control_info.cpp\n> > > @@ -27,19 +27,21 @@ protected:\n> > > ControlInfo brightness;\n> > > \n> > > if (brightness.min().type() != ControlType::ControlTypeNone ||\n> > > - brightness.max().type() != ControlType::ControlTypeNone) {\n> > > + brightness.max().type() != ControlType::ControlTypeNone ||\n> > > + brightness.def().type() != ControlType::ControlTypeNone) {\n> \n> Should these use the .isNone() helper?\n\nYes they should. Should I do so in this patch or would you prefer a\nseparate one ?\n\n> Otherwise, or either way:\n> \n> Reviewed-by: Kieran Bingham \n> \n> > > cout << \"Invalid control range for Brightness\" << endl;\n> > > return TestFail;\n> > > }\n> > > \n> > > /*\n> > > * Test information retrieval from a control with a minimum and\n> > > - * a maximum value.\n> > > + * a maximum value, and an implicit default value.\n> \n> Except the 'implicit' default value is 'not a value' ?\n\nI'm not sure to follow you.\n\n> > > */\n> > > ControlInfo contrast(10, 200);\n> > > \n> > > if (contrast.min().get() != 10 ||\n> > > - contrast.max().get() != 200) {\n> > > + contrast.max().get() != 200 ||\n> > > + !contrast.def().isNone()) {\n> > > cout << \"Invalid control range for Contrast\" << endl;\n> > > return TestFail;\n> > > }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 340ACBD16B\n\tfor ;\n\tSun, 16 Oct 2022 02:13:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB98262DDB;\n\tSun, 16 Oct 2022 04:13:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B5A0603D1\n\tfor ;\n\tSun, 16 Oct 2022 04:13:35 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2588130A;\n\tSun, 16 Oct 2022 04:13:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665886416;\n\tbh=fxTmHweRUfelR8bGtoHo2pVuPNosLKGZV+3ebFRDdW4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yl1cTypepUZVFAO4DMuyw9krgtSCyR7OEnCeCQ7S+xw2hoM6fRRFzBzYAUrsdkn9t\n\t4Qnb6A2Ni1mitH22AA3lbHKn5OdtGxaaPHk1PsNdjjJCWXRKu86MWtK+97rrZA3KGY\n\t7dh1+Z8njlBZQw/mAwVfE8agJENJD+DzgcUz8nRMBcqE82DAkhrkLPHgm734hbiq7Y\n\t0q8jrcw/UzKiL1Lu8ehiWj3WIYXYF4oLWc7g6zPM0/+R5e8eP5z7DwF1cfLvHWjLSf\n\tip+Flru2Su5tdTPsz7JNuUQFUYCPF3/H4l0rG83UxiqxLAJ01wqVtRq+yw4ccI1+o6\n\tjBcAYpM2w86cg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665886415;\n\tbh=fxTmHweRUfelR8bGtoHo2pVuPNosLKGZV+3ebFRDdW4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nYLgaFg0tWVFvim2SwtW8jLiJL9vpvak2ubZ4pp+gCqBK/YG92Vs1sZn8tzlZjIZu\n\tesHPgG+u3h7kjAkkLLUzPJos3isUwvX3n20jamE6KUlXYaaYYcSp20iIaLagEYGmJr\n\tN2bcrlgwj9CUhJc1ZQLoDBdaHXLQu+EkmgLT44a8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nYLgaFg0\"; dkim-atps=neutral","Date":"Sun, 16 Oct 2022 05:13:12 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20221006221506.16948-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<166557084823.3760285.14089719076970156051@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166557084823.3760285.14089719076970156051@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25458,"web_url":"https://patchwork.libcamera.org/comment/25458/","msgid":"<166617228797.2560709.8256258147132405057@Monstersaurus>","date":"2022-10-19T09:38:07","subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-10-16 03:13:12)\n> On Wed, Oct 12, 2022 at 11:34:08AM +0100, Kieran Bingham wrote:\n> > Quoting Laurent Pinchart via libcamera-devel (2022-10-06 23:17:16)\n> > > On Fri, Oct 07, 2022 at 01:15:06AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > > > Extend the ControlInfoMap test to verify the behaviour of the default\n> > > > 'def' argument to the ControlInfoMap constructor.\n> > > \n> > > s/ControlInfoMap/ControlInfo/\n> > > \n> > > > Signed-off-by: Laurent Pinchart \n> > > > ---\n> > > > test/controls/control_info.cpp | 8 +++++---\n> > > > 1 file changed, 5 insertions(+), 3 deletions(-)\n> > > > \n> > > > diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\n> > > > index 56b4101f72fe..1176a5024b3a 100644\n> > > > --- a/test/controls/control_info.cpp\n> > > > +++ b/test/controls/control_info.cpp\n> > > > @@ -27,19 +27,21 @@ protected:\n> > > > ControlInfo brightness;\n> > > > \n> > > > if (brightness.min().type() != ControlType::ControlTypeNone ||\n> > > > - brightness.max().type() != ControlType::ControlTypeNone) {\n> > > > + brightness.max().type() != ControlType::ControlTypeNone ||\n> > > > + brightness.def().type() != ControlType::ControlTypeNone) {\n> > \n> > Should these use the .isNone() helper?\n> \n> Yes they should. Should I do so in this patch or would you prefer a\n> separate one ?\n\nUp to you.\n\n> \n> > Otherwise, or either way:\n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> > > > cout << \"Invalid control range for Brightness\" << endl;\n> > > > return TestFail;\n> > > > }\n> > > > \n> > > > /*\n> > > > * Test information retrieval from a control with a minimum and\n> > > > - * a maximum value.\n> > > > + * a maximum value, and an implicit default value.\n> > \n> > Except the 'implicit' default value is 'not a value' ?\n> \n> I'm not sure to follow you.\n\n\nIt doesn't matter, re-reading it now it's ok.\n\nBut I just found it confusing that you're extending this to state that\nthere will be an implicit default value. But the default value is\n'None'. ... as in not a value - but that's an explicit state for our\ncontrols. So it *is* the default value.\n\n\n\n> \n> > > > */\n> > > > ControlInfo contrast(10, 200);\n> > > > \n> > > > if (contrast.min().get() != 10 ||\n> > > > - contrast.max().get() != 200) {\n> > > > + contrast.max().get() != 200 ||\n> > > > + !contrast.def().isNone()) {\n> > > > cout << \"Invalid control range for Contrast\" << endl;\n> > > > return TestFail;\n> > > > }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B76EBD16B\n\tfor ;\n\tWed, 19 Oct 2022 09:38:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F25A62E41;\n\tWed, 19 Oct 2022 11:38:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E89B62E37\n\tfor ;\n\tWed, 19 Oct 2022 11:38:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B4E75903;\n\tWed, 19 Oct 2022 11:38:10 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666172292;\n\tbh=u1R6krxMvrF6mMhM8AnytcARrDq1XYswiSfZy8UA6Bg=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=17mZcJuncf7vzwLy++BXswtlgIqcU1z9BOUjUZPDsU4ERmRL7yuXZ7olFcUIXEukn\n\tAytb6I+llnPxTIuDU/clJXmSm+BVl0Mz8q2wutspWP6V5xN+VKQCZg1jcOURXkhdr9\n\tscLR789bo7t7BqKAgHOug6RsKNUzFLp0InD0KVkb0igJLH7fW+jOtc/r60/QpC/B25\n\tBvFYh09tUiL4qR/5XcMXnSQXo5FyTvBv/gZRtmuu258fktO+G2YqgRmpDtgID+6AXi\n\tNGz4eFN1/97YsLZzvS3HVGAsE49+WfGCiubFXyQUE0xHkVXfYrY5dUcgkODYtacq/f\n\t1DsbkFf+AlawQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666172290;\n\tbh=u1R6krxMvrF6mMhM8AnytcARrDq1XYswiSfZy8UA6Bg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=U8ZZ18jsk5iGu3OSizMZIZzXQnjUWb1SHb9BZ9axIy1iUMEZmnCwG6kRrinT+TeVN\n\tv+24WaqgYH5Yxy1ajQfL+WL4AAhl51zRdtgo6Lj/Udq+EDrQQORTD7Gli7cg0EMcRn\n\t1/fSC1m32p8Zikjc+s5OWgG0U6zd7uSoGH51z3d8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"U8ZZ18js\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20221006221506.16948-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<166557084823.3760285.14089719076970156051@Monstersaurus>\n\t","To":"Laurent Pinchart ","Date":"Wed, 19 Oct 2022 10:38:07 +0100","Message-ID":"<166617228797.2560709.8256258147132405057@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26106,"web_url":"https://patchwork.libcamera.org/comment/26106/","msgid":"","date":"2022-12-16T17:40:14","subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Oct 19, 2022 at 10:38:07AM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2022-10-16 03:13:12)\n> > On Wed, Oct 12, 2022 at 11:34:08AM +0100, Kieran Bingham wrote:\n> > > Quoting Laurent Pinchart via libcamera-devel (2022-10-06 23:17:16)\n> > > > On Fri, Oct 07, 2022 at 01:15:06AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > > > > Extend the ControlInfoMap test to verify the behaviour of the default\n> > > > > 'def' argument to the ControlInfoMap constructor.\n> > > > \n> > > > s/ControlInfoMap/ControlInfo/\n> > > > \n> > > > > Signed-off-by: Laurent Pinchart \n> > > > > ---\n> > > > > test/controls/control_info.cpp | 8 +++++---\n> > > > > 1 file changed, 5 insertions(+), 3 deletions(-)\n> > > > > \n> > > > > diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\n> > > > > index 56b4101f72fe..1176a5024b3a 100644\n> > > > > --- a/test/controls/control_info.cpp\n> > > > > +++ b/test/controls/control_info.cpp\n> > > > > @@ -27,19 +27,21 @@ protected:\n> > > > > ControlInfo brightness;\n> > > > > \n> > > > > if (brightness.min().type() != ControlType::ControlTypeNone ||\n> > > > > - brightness.max().type() != ControlType::ControlTypeNone) {\n> > > > > + brightness.max().type() != ControlType::ControlTypeNone ||\n> > > > > + brightness.def().type() != ControlType::ControlTypeNone) {\n> > > \n> > > Should these use the .isNone() helper?\n> > \n> > Yes they should. Should I do so in this patch or would you prefer a\n> > separate one ?\n> \n> Up to you.\n\nI'll cook a patch on top.\n\n> > > Otherwise, or either way:\n> > > \n> > > Reviewed-by: Kieran Bingham \n> > > \n> > > > > cout << \"Invalid control range for Brightness\" << endl;\n> > > > > return TestFail;\n> > > > > }\n> > > > > \n> > > > > /*\n> > > > > * Test information retrieval from a control with a minimum and\n> > > > > - * a maximum value.\n> > > > > + * a maximum value, and an implicit default value.\n> > > \n> > > Except the 'implicit' default value is 'not a value' ?\n> > \n> > I'm not sure to follow you.\n> \n> It doesn't matter, re-reading it now it's ok.\n> \n> But I just found it confusing that you're extending this to state that\n> there will be an implicit default value. But the default value is\n> 'None'. ... as in not a value - but that's an explicit state for our\n> controls. So it *is* the default value.\n> \n> > > > > */\n> > > > > ControlInfo contrast(10, 200);\n> > > > > \n> > > > > if (contrast.min().get() != 10 ||\n> > > > > - contrast.max().get() != 200) {\n> > > > > + contrast.max().get() != 200 ||\n> > > > > + !contrast.def().isNone()) {\n> > > > > cout << \"Invalid control range for Contrast\" << endl;\n> > > > > return TestFail;\n> > > > > }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60A64C31E9\n\tfor ;\n\tFri, 16 Dec 2022 17:40:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B48B9633A2;\n\tFri, 16 Dec 2022 18:40:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DE0160410\n\tfor ;\n\tFri, 16 Dec 2022 18:40:19 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88527A31;\n\tFri, 16 Dec 2022 18:40:18 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671212420;\n\tbh=VzUuDA9YWq02RDKO6zzqWHSrunirp5N89uxBHwuM2Qg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=f2cBQl5gXWIA04/4azVWoxVUNagK6WapRHpyiMWpcIX4kwXrxpDMQY98z2Pj6XJ9S\n\tDQrl+vL44OZNv9FtbvFSE21Zw8ZJ6fRXXPqdB1XzGDECi2BbPmr9n/0iUt6ZBpCGm3\n\tlAEeyAGZLPJlN8cDzq7wIjh0D39NxmW9pkGuIaM1E+DRzta+FO8wiSHkcMUwwTz3yH\n\tzFEBbeW9bd63VlIZDJMCNtF13JReU2ZqGkBxxzBcWcJAEdsORslr6O9ydadnnsZvKe\n\t6lFTvipTXokTRjpz3//3WdTJZEHBRp1s6ezvpg86Xxr4WZJiXaVm4jX2W1pcXo0oqT\n\ti8zf2qjkJHX6w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671212418;\n\tbh=VzUuDA9YWq02RDKO6zzqWHSrunirp5N89uxBHwuM2Qg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZY+PCe26SABbofqzMO8pcMlk6dQKQ2LfkyCK3Dd0SDhiOwIzdXKzen7TB/0FXPj4Y\n\tU5G+zz6Zu/vqkiP2vb1Obo1KRJ+P2f+xudPrWOvrXquZ5iNjJMUswJM2KS8ztUpxPI\n\t5UKJF9W91U+OKABBWzOrubn+JBcSQJW76WAgvSy8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZY+PCe26\"; dkim-atps=neutral","Date":"Fri, 16 Dec 2022 19:40:14 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20221006221506.16948-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<166557084823.3760285.14089719076970156051@Monstersaurus>\n\t\n\t<166617228797.2560709.8256258147132405057@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166617228797.2560709.8256258147132405057@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]