[{"id":25323,"web_url":"https://patchwork.libcamera.org/comment/25323/","msgid":"","date":"2022-10-07T09:13:30","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Rename\n\tparameter to get()","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch\n\nOn 10/7/22 1:25 AM, Laurent Pinchart via libcamera-devel wrote:\n> The CameraManager::get() function takes a string containing the ID of\n> the requested camera. This is correctly documented and implemented in\n> the .cpp file, but the header file names the parameter 'name' instead of\n> 'id'. Fix it.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n> ---\n> include/libcamera/camera_manager.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\n> index 7647c2a1c43c..4b1fb7568e83 100644\n> --- a/include/libcamera/camera_manager.h\n> +++ b/include/libcamera/camera_manager.h\n> @@ -31,7 +31,7 @@ public:\n> \tvoid stop();\n> \n> \tstd::vector> cameras() const;\n> -\tstd::shared_ptr get(const std::string &name);\n> +\tstd::shared_ptr get(const std::string &id);\n> \tstd::shared_ptr get(dev_t devnum);\n> \n> \tvoid addCamera(std::shared_ptr camera,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADC9BBD16B\n\tfor ;\n\tFri, 7 Oct 2022 09:13:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C31E262D07;\n\tFri, 7 Oct 2022 11:13:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D086A60AC2\n\tfor ;\n\tFri, 7 Oct 2022 11:13:36 +0200 (CEST)","from [192.168.1.103] (unknown [103.251.226.3])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 734374D3;\n\tFri, 7 Oct 2022 11:13:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665134018;\n\tbh=2BEqsrcSvDyDzL8GTxrYEB41DY3f2P/pT8Rpd/G+xg4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=M3Ct1gVYcLRp+CIzUw7q9ciJbo0GOVyiWQtLVqUZb2zjSleW7VFKAT01T64eMGw+u\n\tCA01ZNq2fn1JYUTjTCYPZ6uIxxBv84ACy/ONDiWTAvyPZ8Wrc3z2Wbqy5Rqi6sUc2z\n\tL0/dQkMEfNDM+eqMWmR2JO5dKGW5/jDv6uvC5qLKjp3x2qjFGNAyiK+5c5uOX8PIwR\n\t/YUvX+2gx0V6m05q7mLEXZH86vBndPvbpLz0n6j7QPJtJ9qHvPPsDbnB1CdrrZWMjA\n\tmhhc70YXD4VhyUViE/ILwSweg5GlPjTpc+TyGC551F37WIv/3fIiV6bkkkslFhED2Y\n\tUvxVYldDGBayQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665134016;\n\tbh=2BEqsrcSvDyDzL8GTxrYEB41DY3f2P/pT8Rpd/G+xg4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=n2sFsm468S3uX4AtKRT203iaiG6lcziyleCPHC3OIGgRDuwnuXNlgzBBpMBsBgUHD\n\t9v8vN07je4TwDvCvbzqzQ6eQzjj/AX1pVCv/XhxAyHqVm0mdsT+9d+lQLI4ISVO9LD\n\tBsHF6Dot5DZtFVzm2NDSJArTDpkJb7uezdxca8Cw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"n2sFsm46\"; dkim-atps=neutral","Message-ID":"","Date":"Fri, 7 Oct 2022 14:43:30 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.2.1","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221006195523.17739-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<20221006195523.17739-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Rename\n\tparameter to get()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]