{"id":17553,"url":"https://patchwork.libcamera.org/api/patches/17553/?format=json","web_url":"https://patchwork.libcamera.org/patch/17553/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221006195523.17739-1-laurent.pinchart@ideasonboard.com>","date":"2022-10-06T19:55:23","name":"[libcamera-devel] libcamera: camera_manager: Rename parameter to get()","commit_ref":"7465ee8e0cc10babbebb2124b15abb1dd8f21983","pull_url":null,"state":"accepted","archived":false,"hash":"cd08b7d199630479b1edc3494a2e4279050595bc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17553/mbox/","series":[{"id":3539,"url":"https://patchwork.libcamera.org/api/series/3539/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3539","date":"2022-10-06T19:55:23","name":"[libcamera-devel] libcamera: camera_manager: Rename parameter to get()","version":1,"mbox":"https://patchwork.libcamera.org/series/3539/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17553/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17553/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0B28BD16B\n\tfor ;\n\tThu, 6 Oct 2022 19:55:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1446F62CF4;\n\tThu, 6 Oct 2022 21:55:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF20B62CEC\n\tfor ;\n\tThu, 6 Oct 2022 21:55:28 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B4224DD\n\tfor ;\n\tThu, 6 Oct 2022 21:55:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665086130;\n\tbh=/nrFRiI4Av9jkCUdTfmNCkQUnSxGLN3jJEtZFtDeABE=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=jA3KERLAqCPuuVQS3R2Cd2t2J6e5z4NflzlRtg41IiKP1HhjX85yqN3pSomd5hbti\n\tQDXxqCv87z/VHFD4+DFMr7s/8WNpBfufXp220I1tBezAGTnvNMiJbcOY9K2S+CTPLK\n\tfSk1V4fSPREboMXvEir19G3PiPH5g7qFX5/Q6N7UuU7h8j7Hd6TRkel2cNoYtWq/iR\n\tNWm5BzqIxtXEz1D7yE8CuDnkt49Mp24DKmOtYMdoAIspd3JLSC/uvot44/ty/nUpuS\n\t7dA4v/YKU29OhhAIZ+g8C9X9tUmChXxYHPyV6GQ1uzroCpULf+5NIZrjPWGB6+Jk+C\n\tU8fo0cQoKotYg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665086128;\n\tbh=/nrFRiI4Av9jkCUdTfmNCkQUnSxGLN3jJEtZFtDeABE=;\n\th=From:To:Subject:Date:From;\n\tb=NjDZrLIPHQQLiyombLBhYiWGptrU2EI4wr37RRsjv0Vt/n8lrOMH83eTlUunSGBv4\n\tOtPTwUxGH+9dWhwlU/sDRkF2DCXZ+w7nEJbhw4xGJCr/mqQMa/mpIeKI8Dwq4mrgdH\n\tqChAZJ6SSvzA4PTcE9rcO24TEUTw1jNvebiZd5HY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NjDZrLIP\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 6 Oct 2022 22:55:23 +0300","Message-Id":"<20221006195523.17739-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: camera_manager: Rename\n\tparameter to get()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CameraManager::get() function takes a string containing the ID of\nthe requested camera. This is correctly documented and implemented in\nthe .cpp file, but the header file names the parameter 'name' instead of\n'id'. Fix it.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/camera_manager.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\nindex 7647c2a1c43c..4b1fb7568e83 100644\n--- a/include/libcamera/camera_manager.h\n+++ b/include/libcamera/camera_manager.h\n@@ -31,7 +31,7 @@ public:\n \tvoid stop();\n \n \tstd::vector> cameras() const;\n-\tstd::shared_ptr get(const std::string &name);\n+\tstd::shared_ptr get(const std::string &id);\n \tstd::shared_ptr get(dev_t devnum);\n \n \tvoid addCamera(std::shared_ptr camera,\n","prefixes":["libcamera-devel"]}