[{"id":2348,"web_url":"https://patchwork.libcamera.org/comment/2348/","msgid":"<20190808203858.GB2918@pendragon.ideasonboard.com>","date":"2019-08-08T20:38:58","subject":"Re: [libcamera-devel] [PATCH 5/6] test: v4l2_device: Remove unused\n\tfunction","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Aug 08, 2019 at 04:12:20PM +0100, Kieran Bingham wrote:\n> The 'exists()' call is not used within the code base.\n> Remove it.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  test/v4l2_videodevice/v4l2_videodevice_test.cpp | 11 -----------\n>  1 file changed, 11 deletions(-)\n> \n> diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> index b26d06ad4519..b4f4ae672580 100644\n> --- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> +++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> @@ -6,7 +6,6 @@\n>   */\n>  \n>  #include <iostream>\n> -#include <sys/stat.h>\n>  \n>  #include \"v4l2_videodevice_test.h\"\n>  \n> @@ -16,16 +15,6 @@\n>  using namespace std;\n>  using namespace libcamera;\n>  \n> -bool exists(const std::string &path)\n> -{\n> -\tstruct stat sb;\n> -\n> -\tif (stat(path.c_str(), &sb) == 0)\n> -\t\treturn true;\n> -\n> -\treturn false;\n> -}\n> -\n>  int V4L2VideoDeviceTest::init()\n>  {\n>  \tenumerator_ = DeviceEnumerator::create();","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC6846161B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  8 Aug 2019 22:39:01 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 29955CC;\n\tThu,  8 Aug 2019 22:39:01 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565296741;\n\tbh=HBq2HbSMEKVFXjZNAslawo6M3I/YPg8xps2mq0U/trY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ij/pK5yOMgHpyMM8FDtoQvMEtT15+VYVTl2VxDk2inxGn4SDYxhvIfThDWYQ51YY1\n\t+CNI9DNViJil63wihFuV6a8Qg11EHD9f1OpgCyAOifANCci21cpFXoIsfVmZM6L/Ve\n\tMzOf4YdMpyeySWw1AlHv/DEWTgFqtSaBOHsZ6LaQ=","Date":"Thu, 8 Aug 2019 23:38:58 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190808203858.GB2918@pendragon.ideasonboard.com>","References":"<20190808151221.24254-1-kieran.bingham@ideasonboard.com>\n\t<20190808151221.24254-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190808151221.24254-6-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 5/6] test: v4l2_device: Remove unused\n\tfunction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 08 Aug 2019 20:39:02 -0000"}}]