{"id":17532,"url":"https://patchwork.libcamera.org/api/patches/17532/?format=json","web_url":"https://patchwork.libcamera.org/patch/17532/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221005193944.16383-2-laurent.pinchart@ideasonboard.com>","date":"2022-10-05T19:39:43","name":"[libcamera-devel,1/2] test: Rename 't' to 'test' in meson.build","commit_ref":"2ee8faf3c89e8f5f3f7d9693d3ed8cd892bcb5ec","pull_url":null,"state":"accepted","archived":false,"hash":"3f0491006d05e09c1825f1062e0307270cb53f21","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17532/mbox/","series":[{"id":3535,"url":"https://patchwork.libcamera.org/api/series/3535/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3535","date":"2022-10-05T19:39:42","name":"test: Readability improvements for meson.build","version":1,"mbox":"https://patchwork.libcamera.org/series/3535/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17532/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17532/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57A03C327C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  5 Oct 2022 19:39:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C97562CEE;\n\tWed,  5 Oct 2022 21:39:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF9BF62CB1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  5 Oct 2022 21:39:49 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A10D415\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  5 Oct 2022 21:39:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664998791;\n\tbh=JLfZjbhU+7DJ9Eq3yHsNNOKMtV1B86MryVTMaDXZmiE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=FOFNThdgLNWI/1AJv9AXzmjvSPbdXQCEYcYRSSJnRSgB8yqV5Li8YcTWci8MfGO6v\n\toVEOJB4OKJcBsC2bmH3oZMtN+p0FgH2uSN9060RrOIqu/jMlchM9ItEQtx6wtrgwX0\n\tijnijDoeCFa7ghqvXlpHe+sGuClwOhf4v7p6JM9+dD56z27d52OC/4f28DL8Di7F4C\n\tVsnC0akwgKmMmtQAVWW/+VQzHlulDeC3KkJ7mcOEjKowF106+syBulgNv3boP9AIw1\n\tQdvRnTKopBm6AiAlt2R5uK7w2qvk2uHcTmml7Fc9+NhF9gP9H/ZcZWpqSbQS70r+LM\n\tONNeKZzgy41Ng==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664998789;\n\tbh=JLfZjbhU+7DJ9Eq3yHsNNOKMtV1B86MryVTMaDXZmiE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=V8gt/BfxdBIU8ObYgduDODfACYdyfcY6peqWJ6Q80A5wFiXfVKLIysCVtKf1PVy2M\n\tqzD+fRMUnI8DxinTacMKmB/WyBbSizly1FZ3d3ZB+RP4ONX2EplcnRfuQzxosp1x9V\n\tLbkosZS6dqhUUHergLzC9R+NklJiT1bRmNURQ44g="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"V8gt/Bfx\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed,  5 Oct 2022 22:39:43 +0300","Message-Id":"<20221005193944.16383-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20221005193944.16383-1-laurent.pinchart@ideasonboard.com>","References":"<20221005193944.16383-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] test: Rename 't' to 'test' in\n\tmeson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The 't' name is very short and not very explicit. Rename it to 'test'\ninstead.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/camera/meson.build           |  6 +++---\n test/controls/meson.build         |  6 +++---\n test/gstreamer/meson.build        |  6 +++---\n test/ipa/meson.build              |  6 +++---\n test/ipc/meson.build              |  6 +++---\n test/log/meson.build              |  6 +++---\n test/media_device/meson.build     |  6 +++---\n test/meson.build                  | 30 +++++++++++++++---------------\n test/pipeline/ipu3/meson.build    |  6 +++---\n test/pipeline/rkisp1/meson.build  |  6 +++---\n test/process/meson.build          |  6 +++---\n test/serialization/meson.build    |  6 +++---\n test/stream/meson.build           |  6 +++---\n test/v4l2_subdevice/meson.build   |  6 +++---\n test/v4l2_videodevice/meson.build |  6 +++---\n 15 files changed, 57 insertions(+), 57 deletions(-)","diff":"diff --git a/test/camera/meson.build b/test/camera/meson.build\nindex 668d5c03fb6e..df0520293bdb 100644\n--- a/test/camera/meson.build\n+++ b/test/camera/meson.build\n@@ -11,10 +11,10 @@ camera_tests = [\n     ['camera_reconfigure',      'camera_reconfigure.cpp'],\n ]\n \n-foreach t : camera_tests\n-    exe = executable(t[0], t[1],\n+foreach test : camera_tests\n+    exe = executable(test[0], test[1],\n                      dependencies : libcamera_private,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n-    test(t[0], exe, suite : 'camera', is_parallel : false)\n+    test(test[0], exe, suite : 'camera', is_parallel : false)\n endforeach\ndiff --git a/test/controls/meson.build b/test/controls/meson.build\nindex 0103543e1fc2..8cf23be6487c 100644\n--- a/test/controls/meson.build\n+++ b/test/controls/meson.build\n@@ -7,10 +7,10 @@ control_tests = [\n     ['control_value',               'control_value.cpp'],\n ]\n \n-foreach t : control_tests\n-    exe = executable(t[0], t[1],\n+foreach test : control_tests\n+    exe = executable(test[0], test[1],\n                      dependencies : libcamera_public,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n-    test(t[0], exe, suite : 'controls', is_parallel : false)\n+    test(test[0], exe, suite : 'controls', is_parallel : false)\n endforeach\ndiff --git a/test/gstreamer/meson.build b/test/gstreamer/meson.build\nindex 10058fc5206f..46f6a77a771e 100644\n--- a/test/gstreamer/meson.build\n+++ b/test/gstreamer/meson.build\n@@ -10,11 +10,11 @@ gstreamer_tests = [\n ]\n gstreamer_dep = dependency('gstreamer-1.0', required: true)\n \n-foreach t : gstreamer_tests\n-    exe = executable(t[0], t[1], 'gstreamer_test.cpp',\n+foreach test : gstreamer_tests\n+    exe = executable(test[0], test[1], 'gstreamer_test.cpp',\n                      dependencies : [libcamera_private, gstreamer_dep],\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n \n-    test(t[0], exe, suite : 'gstreamer', is_parallel : false)\n+    test(test[0], exe, suite : 'gstreamer', is_parallel : false)\n endforeach\ndiff --git a/test/ipa/meson.build b/test/ipa/meson.build\nindex 7938633e54ab..295807fd8a45 100644\n--- a/test/ipa/meson.build\n+++ b/test/ipa/meson.build\n@@ -5,11 +5,11 @@ ipa_test = [\n     ['ipa_interface_test',  'ipa_interface_test.cpp'],\n ]\n \n-foreach t : ipa_test\n-    exe = executable(t[0], [t[1], libcamera_generated_ipa_headers],\n+foreach test : ipa_test\n+    exe = executable(test[0], [test[1], libcamera_generated_ipa_headers],\n                      dependencies : libcamera_private,\n                      link_with : [libipa, test_libraries],\n                      include_directories : [libipa_includes, test_includes_internal])\n \n-    test(t[0], exe, suite : 'ipa')\n+    test(test[0], exe, suite : 'ipa')\n endforeach\ndiff --git a/test/ipc/meson.build b/test/ipc/meson.build\nindex 2a6cd7fb8433..ce21135b701d 100644\n--- a/test/ipc/meson.build\n+++ b/test/ipc/meson.build\n@@ -5,11 +5,11 @@ ipc_tests = [\n     ['unixsocket',     'unixsocket.cpp'],\n ]\n \n-foreach t : ipc_tests\n-    exe = executable(t[0], t[1],\n+foreach test : ipc_tests\n+    exe = executable(test[0], test[1],\n                      dependencies : libcamera_private,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n \n-    test(t[0], exe, suite : 'ipc')\n+    test(test[0], exe, suite : 'ipc')\n endforeach\ndiff --git a/test/log/meson.build b/test/log/meson.build\nindex ac87841a24e1..d2d51e471d52 100644\n--- a/test/log/meson.build\n+++ b/test/log/meson.build\n@@ -5,11 +5,11 @@ log_test = [\n     ['log_process', 'log_process.cpp'],\n ]\n \n-foreach t : log_test\n-    exe = executable(t[0], t[1],\n+foreach test : log_test\n+    exe = executable(test[0], test[1],\n                      dependencies : libcamera_private,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n \n-    test(t[0], exe, suite : 'log')\n+    test(test[0], exe, suite : 'log')\n endforeach\ndiff --git a/test/media_device/meson.build b/test/media_device/meson.build\nindex 83dfe8f11d2f..7d34509d6797 100644\n--- a/test/media_device/meson.build\n+++ b/test/media_device/meson.build\n@@ -14,11 +14,11 @@ lib_mdev_test = static_library('lib_mdev_test', lib_mdev_test_sources,\n                                dependencies : libcamera_private,\n                                include_directories : test_includes_internal)\n \n-foreach t : media_device_tests\n-    exe = executable(t[0], t[1],\n+foreach test : media_device_tests\n+    exe = executable(test[0], test[1],\n                      dependencies : libcamera_private,\n                      link_with : [test_libraries, lib_mdev_test],\n                      include_directories : test_includes_internal)\n \n-    test(t[0], exe, suite : 'media_device', is_parallel : false)\n+    test(test[0], exe, suite : 'media_device', is_parallel : false)\n endforeach\ndiff --git a/test/meson.build b/test/meson.build\nindex 9bf7bf34e796..4bc01d78f4e6 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -64,44 +64,44 @@ internal_non_parallel_tests = [\n     ['mapped-buffer',                   'mapped-buffer.cpp'],\n ]\n \n-foreach t : public_tests\n+foreach test : public_tests\n     deps = [libcamera_public]\n-    if t.length() > 2\n-        deps += t[2]\n+    if test.length() > 2\n+        deps += test[2]\n     endif\n \n-    exe = executable(t[0], t[1],\n+    exe = executable(test[0], test[1],\n                      dependencies : deps,\n                      link_with : test_libraries,\n                      include_directories : test_includes_public)\n \n-    test(t[0], exe)\n+    test(test[0], exe)\n endforeach\n \n-foreach t : internal_tests\n+foreach test : internal_tests\n     deps = [libcamera_private]\n-    if t.length() > 2\n-        deps += t[2]\n+    if test.length() > 2\n+        deps += test[2]\n     endif\n \n-    exe = executable(t[0], t[1],\n+    exe = executable(test[0], test[1],\n                      dependencies : deps,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n \n-    test(t[0], exe)\n+    test(test[0], exe)\n endforeach\n \n-foreach t : internal_non_parallel_tests\n+foreach test : internal_non_parallel_tests\n     deps = [libcamera_private]\n-    if t.length() > 2\n-        deps += t[2]\n+    if test.length() > 2\n+        deps += test[2]\n     endif\n \n-    exe = executable(t[0], t[1],\n+    exe = executable(test[0], test[1],\n                      dependencies : deps,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n \n-    test(t[0], exe, is_parallel : false)\n+    test(test[0], exe, is_parallel : false)\n endforeach\ndiff --git a/test/pipeline/ipu3/meson.build b/test/pipeline/ipu3/meson.build\nindex 16701080ca2b..5fcf5730b0b0 100644\n--- a/test/pipeline/ipu3/meson.build\n+++ b/test/pipeline/ipu3/meson.build\n@@ -4,11 +4,11 @@ ipu3_test = [\n     ['ipu3_pipeline_test',            'ipu3_pipeline_test.cpp'],\n ]\n \n-foreach t : ipu3_test\n-    exe = executable(t[0], t[1],\n+foreach test : ipu3_test\n+    exe = executable(test[0], test[1],\n                      dependencies : libcamera_private,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n \n-    test(t[0], exe, suite : 'ipu3', is_parallel : false)\n+    test(test[0], exe, suite : 'ipu3', is_parallel : false)\n endforeach\ndiff --git a/test/pipeline/rkisp1/meson.build b/test/pipeline/rkisp1/meson.build\nindex 364b5711a0f9..c82cc78972f6 100644\n--- a/test/pipeline/rkisp1/meson.build\n+++ b/test/pipeline/rkisp1/meson.build\n@@ -4,11 +4,11 @@ rkisp1_test = [\n     ['rkisp1_pipeline_test',            'rkisp1_pipeline_test.cpp'],\n ]\n \n-foreach t : rkisp1_test\n-    exe = executable(t[0], t[1],\n+foreach test : rkisp1_test\n+    exe = executable(test[0], test[1],\n                      dependencies : libcamera_private,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n \n-    test(t[0], exe, suite : 'rkisp1', is_parallel : false)\n+    test(test[0], exe, suite : 'rkisp1', is_parallel : false)\n endforeach\ndiff --git a/test/process/meson.build b/test/process/meson.build\nindex af86b277db63..c656d7343e54 100644\n--- a/test/process/meson.build\n+++ b/test/process/meson.build\n@@ -4,11 +4,11 @@ process_tests = [\n     ['process_test',   'process_test.cpp'],\n ]\n \n-foreach t : process_tests\n-    exe = executable(t[0], t[1],\n+foreach test : process_tests\n+    exe = executable(test[0], test[1],\n                      dependencies : libcamera_private,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n \n-    test(t[0], exe, suite : 'process', is_parallel : false)\n+    test(test[0], exe, suite : 'process', is_parallel : false)\n endforeach\ndiff --git a/test/serialization/meson.build b/test/serialization/meson.build\nindex 26e42b150b40..c4206cb3632b 100644\n--- a/test/serialization/meson.build\n+++ b/test/serialization/meson.build\n@@ -7,10 +7,10 @@ serialization_tests = [\n     ['ipa_data_serializer_test',  'ipa_data_serializer_test.cpp'],\n ]\n \n-foreach t : serialization_tests\n-    exe = executable(t[0], [t[1], 'serialization_test.cpp'],\n+foreach test : serialization_tests\n+    exe = executable(test[0], [test[1], 'serialization_test.cpp'],\n                      dependencies : libcamera_private,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n-    test(t[0], exe, suite : 'serialization', is_parallel : false)\n+    test(test[0], exe, suite : 'serialization', is_parallel : false)\n endforeach\ndiff --git a/test/stream/meson.build b/test/stream/meson.build\nindex 89f51c18a63e..3a97868bce1c 100644\n--- a/test/stream/meson.build\n+++ b/test/stream/meson.build\n@@ -5,10 +5,10 @@ stream_tests = [\n     ['stream_formats',  'stream_formats.cpp'],\n ]\n \n-foreach t : stream_tests\n-    exe = executable(t[0], t[1],\n+foreach test : stream_tests\n+    exe = executable(test[0], test[1],\n                      dependencies : libcamera_public,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n-    test(t[0], exe, suite: 'stream')\n+    test(test[0], exe, suite: 'stream')\n endforeach\ndiff --git a/test/v4l2_subdevice/meson.build b/test/v4l2_subdevice/meson.build\nindex d82be3c60b75..4e607d41fc54 100644\n--- a/test/v4l2_subdevice/meson.build\n+++ b/test/v4l2_subdevice/meson.build\n@@ -5,10 +5,10 @@ v4l2_subdevice_tests = [\n   ['test_formats',              'test_formats.cpp'],\n ]\n \n-foreach t : v4l2_subdevice_tests\n-    exe = executable(t[0], [t[1], 'v4l2_subdevice_test.cpp'],\n+foreach test : v4l2_subdevice_tests\n+    exe = executable(test[0], [test[1], 'v4l2_subdevice_test.cpp'],\n         dependencies : libcamera_private,\n         link_with : test_libraries,\n         include_directories : test_includes_internal)\n-    test(t[0], exe, suite : 'v4l2_subdevice', is_parallel : false)\n+    test(test[0], exe, suite : 'v4l2_subdevice', is_parallel : false)\n endforeach\ndiff --git a/test/v4l2_videodevice/meson.build b/test/v4l2_videodevice/meson.build\nindex 7a26f53d106a..f85374854c48 100644\n--- a/test/v4l2_videodevice/meson.build\n+++ b/test/v4l2_videodevice/meson.build\n@@ -15,10 +15,10 @@ v4l2_videodevice_tests = [\n     ['v4l2_m2mdevice',      'v4l2_m2mdevice.cpp'],\n ]\n \n-foreach t : v4l2_videodevice_tests\n-    exe = executable(t[0], [t[1], 'v4l2_videodevice_test.cpp'],\n+foreach test : v4l2_videodevice_tests\n+    exe = executable(test[0], [test[1], 'v4l2_videodevice_test.cpp'],\n                      dependencies : libcamera_private,\n                      link_with : test_libraries,\n                      include_directories : test_includes_internal)\n-    test(t[0], exe, suite : 'v4l2_videodevice', is_parallel : false)\n+    test(test[0], exe, suite : 'v4l2_videodevice', is_parallel : false)\n endforeach\n","prefixes":["libcamera-devel","1/2"]}