{"id":17516,"url":"https://patchwork.libcamera.org/api/patches/17516/?format=json","web_url":"https://patchwork.libcamera.org/patch/17516/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221003212128.32429-7-laurent.pinchart@ideasonboard.com>","date":"2022-10-03T21:21:26","name":"[libcamera-devel,6/8] libcamera: pipeline_handler: Make registerType() private","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"fe211b8624844e096b2fbff6c5815283285e0439","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17516/mbox/","series":[{"id":3528,"url":"https://patchwork.libcamera.org/api/series/3528/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3528","date":"2022-10-03T21:21:20","name":"libcamera: Use class templates for auto-registration","version":1,"mbox":"https://patchwork.libcamera.org/series/3528/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17516/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17516/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4A83C3285\n\tfor ;\n\tMon, 3 Oct 2022 21:21:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54BC060A7E;\n\tMon, 3 Oct 2022 23:21:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87A11601CB\n\tfor ;\n\tMon, 3 Oct 2022 23:21:40 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F0D3A4C\n\tfor ;\n\tMon, 3 Oct 2022 23:21:39 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664832102;\n\tbh=pGyIItIRE998V56f3sGwDeui2rRJe44G2CURlcpOr0k=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xxpUpLPIr8rxk/5POz5eA6IG8b4h0/fSbfnuMOtPNXSkaXnruoT4r5JGnqTllZccF\n\t+5ucK9BmFYaQMsWTS9VRe8thPpSmzinrkHw14IV7aH0sPE88fIT+L0P0w8nC+sD8kb\n\t2qGbuRJ4jt+Ul5NWzRtGuBX9OyOV9UvoH75Kk0aFBtJT3JtkkDIrsRb40xozrLgXIo\n\tzUIYYvRZUYiCMLuMia0X+xuENXhQcMHJsJD3ya2Oqx8twRYiQTji0AZvoTpKfN9q6d\n\tirOjAqUqMkJ6VjCntKUfYXnBwDCKPt5N5T7NhJ1E5tGD8+7sZ/CJFMmX6iQMGrustt\n\t1wGlQU54HMOXQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664832100;\n\tbh=pGyIItIRE998V56f3sGwDeui2rRJe44G2CURlcpOr0k=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=NduYlbWGJs/6a8/NljgL0Uw+THh8kz77Rrf2sUk3RigGf5S9j4VjXvgXitQxrmvIC\n\tLMRLmPQV8DwTGhl+D03YjxE04Jd4pxztTWi2xEGbsidOdBMPbBcec9ljQhWTprwUjZ\n\tHQ6+olK+slOBb1G5PBE9jG7J+OtyX5eqjFfN2sxg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NduYlbWG\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 4 Oct 2022 00:21:26 +0300","Message-Id":"<20221003212128.32429-7-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20221003212128.32429-1-laurent.pinchart@ideasonboard.com>","References":"<20221003212128.32429-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 6/8] libcamera: pipeline_handler: Make\n\tregisterType() private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The PipelineHandlerFactory::registerType() function is called by the\nPipelineHandlerFactory class only. Make it private.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/pipeline_handler.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex 46df69dc789a..ebbdf2aa391f 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -108,10 +108,11 @@ public:\n \n \tconst std::string &name() const { return name_; }\n \n-\tstatic void registerType(PipelineHandlerFactory *factory);\n \tstatic std::vector &factories();\n \n private:\n+\tstatic void registerType(PipelineHandlerFactory *factory);\n+\n \tvirtual PipelineHandler *createInstance(CameraManager *manager) const = 0;\n \n \tstd::string name_;\n","prefixes":["libcamera-devel","6/8"]}