[{"id":25294,"web_url":"https://patchwork.libcamera.org/comment/25294/","msgid":"","date":"2022-10-05T10:58:04","subject":"Re: [libcamera-devel] [PATCH 2/8] ipa: camera_sensor_helper: Make\n\tregisterType() and createInstance() private","submitter":{"id":107,"url":"https://patchwork.libcamera.org/api/people/107/","name":"Xavier Roumegue","email":"xavier.roumegue@oss.nxp.com"},"content":"Hi Laurent,\n\nThanks for the patch.\n\nOn 10/3/22 23:21, Laurent Pinchart via libcamera-devel wrote:\n> The CameraSensorHelperFactory registerType() and createInstance()\n> functions are called by the CameraSensorHelperFactory class only. Make\n> them private.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/libipa/camera_sensor_helper.h | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\n> index 2042847f29e8..410156efb2ea 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.h\n> +++ b/src/ipa/libipa/camera_sensor_helper.h\n> @@ -66,15 +66,15 @@ public:\n> \n> \tstatic std::unique_ptr create(const std::string &name);\n> \n> -\tstatic void registerType(CameraSensorHelperFactory *factory);\n> \tstatic std::vector &factories();\n> \n> -protected:\n> -\tvirtual CameraSensorHelper *createInstance() const = 0;\n> -\n> private:\n> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactory)\n> \n> +\tstatic void registerType(CameraSensorHelperFactory *factory);\n> +\n> +\tvirtual CameraSensorHelper *createInstance() const = 0;\n> +\n> \tstd::string name_;\n> };\n> \n\nReviewed-by: Xavier Roumegue ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B948C0DA4\n\tfor ;\n\tWed, 5 Oct 2022 10:58:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64B83622E8;\n\tWed, 5 Oct 2022 12:58:09 +0200 (CEST)","from EUR05-AM6-obe.outbound.protection.outlook.com\n\t(mail-am6eur05on2061.outbound.protection.outlook.com [40.107.22.61])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A688621BC\n\tfor ;\n\tWed, 5 Oct 2022 12:58:07 +0200 (CEST)","from PAXPR04MB8703.eurprd04.prod.outlook.com\n\t(2603:10a6:102:21e::22)\n\tby DBBPR04MB7964.eurprd04.prod.outlook.com (2603:10a6:10:1e9::17)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32;\n\tWed, 5 Oct 2022 10:58:05 +0000","from PAXPR04MB8703.eurprd04.prod.outlook.com\n\t([fe80::4f72:a35a:8c60:63f1]) by\n\tPAXPR04MB8703.eurprd04.prod.outlook.com\n\t([fe80::4f72:a35a:8c60:63f1%6]) with mapi id 15.20.5676.028;\n\tWed, 5 Oct 2022 10:58:05 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664967489;\n\tbh=P90TEOWOk6ABxClmjgVjwWsz64SuSeldR3BPSpUmIrw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=PDOq0VbsDQUn6oJQuQOIMnhy69z8RJuU9PsH4NqCNWMtTf0LgyJ+/rzxOWF9G4bSb\n\tStX6xmv1iFBOhvPlnnF8OzLcGFMOdKCL5jcTaWDLAQ12fLCvx4TGHXgXBImH47+pNG\n\tXkTIIwlCGr1do5P81rmrLN0Jr3pbnLfrrYwMWWk8SCbJB0+c0gqEJfeLv4T4baM3MF\n\tTx5d3a6xhbKgFWYfDpbyiNO6YMZPEOlZ3h4HT4dnaDw/sL2/uSYZ0bSdVS7hpNL/wb\n\ta6fve+MSF88fb5XIAqYZaERvbGErnNKFGWohV1T5FaNLdu8GD/ckODvkNj+yfBPdz4\n\tSYoQ5el4m1dMg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;\n\ts=selector2-NXP1-onmicrosoft-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=zStOI7aaMO0+0vSSu55mSCGcha0aJm+xrHuq6yi6qMo=;\n\tb=joWQb1MvWopI5KDy/1UvskqaiEcpK+JHuYuYKYs09X+4LOGQVA2dcVh2aYyhdsbCEU7DBm49Q/Ad7gj4xBjtV9DA9DAQsMTG+WVKbntd7CbL/YCsMdA8w5fXX3fVmMhj/SxbDw7ckFeClKEG9nICkIBYgAPo/yQnXhHu4xGo3zk="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=NXP1.onmicrosoft.com\n\theader.i=@NXP1.onmicrosoft.com\n\theader.b=\"joWQb1Mv\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=oss.nxp.com;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=D46xstV7eMtTzKNWSX5JOydD2KYAJqCTzZj2hzcWGwtx2NAA9vHcabvTvcIoQ5gS3U5yOgkWjIOMJzg2+YAXb7WJeToHI9Gxd2HsFzqY2yPodvXNaeN0tM0wvAd/vT40f1CMVaHzLzO69LhICJIADbpaPTX8TBb/SIlGsKbX5IWWxaVEHrK0fPTfM0tnLbWP4csMfqxz6lQAHak3SKEtlGU+I8pmllJ4wZYfTUaANAW4abyDkS0qVBFhXyDOTnJsDJC7b/baE5SFCqKh/RHWrLGyd5+/g7jsPAsQyQgqvR38wCSZSJ/LbzD8XLjti55UZlkxYACeBXiFAIx78vp3yw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=zStOI7aaMO0+0vSSu55mSCGcha0aJm+xrHuq6yi6qMo=;\n\tb=be1nXd5vJ8nX3bJzHcIJ2tLa06P6O/TukxNC8nD1tmFKJ37MfAXbQA1fhvMx167NYYxSmgFeEp8daC1+ZqCVuk4ZxDFwvvQ8jRV19SaLn/bEuItu02G/IbADGYhv8Oan4XGUpylrW5jj0YFLyODCGG438pU1ins4XWFjOoX4EgaYTr3VLP/S8U4w/2ON6iM/PvnTHTXO73JvKXqA/4kIrTVW7YpYREQ9IJ4IiLMXgxksrPS1gjaJ2TMKs5KMPraGbejAlB1Nhbyw70P6/R1I5jtzTOqHgFHO7FCFfL+BD+zYfAQLeGimvrXfaL3utLhgOpV3o2DowDmUlkVj8LZQ3g==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=oss.nxp.com;\n\tdmarc=pass action=none header.from=oss.nxp.com; \n\tdkim=pass header.d=oss.nxp.com; arc=none","Message-ID":"","Date":"Wed, 5 Oct 2022 12:58:04 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.3.1","Content-Language":"en-US, fr","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221003212128.32429-1-laurent.pinchart@ideasonboard.com>\n\t<20221003212128.32429-3-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20221003212128.32429-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"PR0P264CA0193.FRAP264.PROD.OUTLOOK.COM\n\t(2603:10a6:100:1f::13) To PAXPR04MB8703.eurprd04.prod.outlook.com\n\t(2603:10a6:102:21e::22)","MIME-Version":"1.0","X-MS-Exchange-MessageSentRepresentingType":"1","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"PAXPR04MB8703:EE_|DBBPR04MB7964:EE_","X-MS-Office365-Filtering-Correlation-Id":"67ab2fe2-056b-49bf-7f31-08daa6c07afb","X-MS-Exchange-SharedMailbox-RoutingAgent-Processed":"True","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;","X-Microsoft-Antispam-Message-Info":"rwOleeJrOo/EiqWlZVvYt07mGDqzWLQgr2tuXZ7ST8Pe/tcGf7ELGlukQrDFQCqLX5qIhlq4Qv7AIUGLDNhKJsjvSksZzGN2zdkmplwkJ26A4n7g8o0jVjUj5crKut7ii4veiQCU2LdMhOB5b9IrWPMiwbeKXd6k5WSCJzKk5cOHxm27OKzBMr2XvdLWvsEyi5z2C554G7Z8eUOMhm7fYAlytVZr4QOcMR0GWphOQL+mg/kxCtfRv1700VwFO0hUji91ZxXiE8eSmIikGnrO3bDOPAJqq7kHpLFLWxLwyJzwOzfK6zpGa40YwpxMW4w2vaj3zcaOLG7SyG6LKFSmMbTZiurhofYVIsumE8qIrN2CBps/DEz1DDbUzC93Oy55NDgBT2g7+84FHi4JffSAQwGFBU2UiC8Tu1g7tRH9nhhZXHWd5ZMzPMXBT0vlj9ZXaBrwNkdIBbjwao7lu9swb+yQVZQMCsFfpHUXaWW+BKLW4muWCESLN7ngzTsXTUsD7PAlcHgXljEtUbvVPZrdrEF6ZfP2jUP7PRSJnzcMIOjY8Bc/SyoVJMs5SydPZSI1G6sLl0XeqhwcxQOX0Qf3yvuu1kwxEhM4Iqc/q0qpVqEmuLvJPLAIqkNaOJb5IAg89WBwljG/A9h/dbLfAU0ggcnPI+cI0C0Fn3LmcetNghUA7TPsdNxgEqMHs7hsiIwuYwwm8cm1ZDCQW7x11iQmYDAzTcbNzCkwbR1Nni4m6kuGFscvDsWJ3wdvj/I7OHLirSPfwnsBTkW7Vow3EudR+sGQ+h5emjFeKr3dk9p2Sos=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PAXPR04MB8703.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230022)(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(451199015)(186003)(38100700002)(31696002)(86362001)(6506007)(41300700001)(53546011)(66476007)(66556008)(8936002)(52116002)(5660300002)(66946007)(6512007)(478600001)(8676002)(6486002)(316002)(2616005)(2906002)(83380400001)(31686004)(45980500001)(43740500002);\n\tDIR:OUT; SFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?2t6/9kd6C5bQ+u/osJZoDNIxR?=\n\t=?utf-8?q?Q7jKMr0x/oEfweU1YSgmpF2ovo2PEiVJQZ15TG0IjalOINqOoDjXi1qW?=\n\t=?utf-8?q?lWxeNpDCQXIqfKK5ad0q1PmXm5FBHV3dsf1b/Bp3c+Y6vNg0IPtlQF4g?=\n\t=?utf-8?q?yn+ALLvUJfg80e8RttNFqd3FmZEIXGcxWESq1EKfCKZf36ALnDL3tCpJ?=\n\t=?utf-8?q?uiuFIiTdtZo7W/kPrv/81BY0e5e5BzsQsuf4kqUSAEHxvp6WUgpnmlWC?=\n\t=?utf-8?q?b9HkhRITrrvYV1gZeKzin0a+1QlB1qJ9O+RPSgoVyUbjKJWmoUX7+FIt?=\n\t=?utf-8?q?MdB+rkUDgjqlRTRXP9HSLB0PCcNTdMWhDnMavijgecFvTK6XVV/PIOyI?=\n\t=?utf-8?q?RwF7HKIHPZY+e0XCumnMvK2npxsz6Eg6hf4oWcCs0LIAewCwU16mLX8z?=\n\t=?utf-8?q?Tt/GrI2XI0AdYGufGBzsfuU7R4/PSI4teUg8RwPvujbx5d/POWqmLTlQ?=\n\t=?utf-8?q?03XQKNbRT6FEaJQMShBSZpqzeePUDvq0qEluv37K27AsUfklYk/v2np6?=\n\t=?utf-8?q?tF+X6t4REtybCByJK1AqSRk6uvcTP9L6vAVr+9SOjZbfv1pLeL7stCtU?=\n\t=?utf-8?q?P24pY/1PFJdTAmkGV7vN5LCavAbMH0zRpnCRgvLKv7cv69Zk2jTwT8H7?=\n\t=?utf-8?q?UVakL6+tKaX7q1aObRUxCCEshaZDFibom7vO9zbaKVgxJkI41iR2pw+W?=\n\t=?utf-8?q?LJPcscHKzfWRihURZUQqvshalEY9yRnM4FzRj3fbG3646i3pZYwM7KKI?=\n\t=?utf-8?q?HOzqczXP8vK901xX0xxmT7dIJzANrbBib/V/jncKsQtZPyZY2CxpLdPR?=\n\t=?utf-8?q?8Io33nq0POaZSebDoPxNy5nqA2Qa6sqe/ihQjG1u2aZjyvHXs3KfjGlY?=\n\t=?utf-8?q?ETF3UcOEhF2BC1U3wGU+0Mgk3UXFUKGDE/5fma/k31opiNPfk5fxyOlD?=\n\t=?utf-8?q?UdPZK1Su/THrkIkijLrsqMfPgY7Y59gWNMdselwSVFhV7UwwczcPLn2s?=\n\t=?utf-8?q?w2OEzsGfLPFI1omUsG2rUaioxKGBI69TFTAAp20bm1WVH6u7bIl8AMUM?=\n\t=?utf-8?q?tvB5+H45+Dm4lOhXjDQxjxYFykpwX/KGOPgmqBwigHZhGPqNFhn/4tcR?=\n\t=?utf-8?q?e4FEUwf81rcJfSCLRFC/ASA5ig54TKsJ7pgFwA5Y/YXSlaVkocREST0N?=\n\t=?utf-8?q?6INIpttDbA5eHNdI6v31dbo4Jl0slClMY+3ZRUDEb3J3XzhPQmlOz4so?=\n\t=?utf-8?q?6vY/Vn3LOsdvB0bbb31iKa4H8111GoWfGOqLh1gqCtzWtBGjgni9Jx2R?=\n\t=?utf-8?q?bIMKXYaMNshRSSXKkmiMzGFJKfEwHdNPnZkz20WkI14z7HlPqOatI9hY?=\n\t=?utf-8?q?6Dggd/2Y5rAGid47b71yRYZHrCgWwTGtAOa2Lfrqv+OgN5Wu3BlebcK8?=\n\t=?utf-8?q?UI01iJNTZxvHWvq+axRqozLuJZv9C+5GzNZRoSmezdJVlNI7qFwEfu6a?=\n\t=?utf-8?q?MA01G7Y+CBxcyVl3VPYY04tNGHy90eKALm5BhsfIBd7HXM6MeDnGj/5H?=\n\t=?utf-8?q?NaP4Y42CbmnI8+A26zqwgQeMXjyUtbZmIpAKdSj9VY/+xFm1TUQKufKr?=\n\t=?utf-8?q?Gg5IZIQsCDlbwGf24vUmveoiwk5W99/7YVYJlZQdBKUNGDJFVxTIRHdN?=\n\t=?utf-8?q?aYdgqYwPWldmUWNvS58OjrMqD0uitinjZ5lzUxjk59dPv9i8yAD2ERFi?=\n\t=?utf-8?q?CTS4BymvCPMwdPEOjVOW8yAKWACYdnwuUHtFg=3D=3D?=","X-OriginatorOrg":"oss.nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"67ab2fe2-056b-49bf-7f31-08daa6c07afb","X-MS-Exchange-CrossTenant-AuthSource":"PAXPR04MB8703.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"05 Oct 2022 10:58:05.5146\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"pthV3c3jtjTPuJ0LT10w/ZVgTtHdkZVGQ3qma9AFjCBXQhUPvUdvCMDXQ61+l3nNWoVJQYarMygqdcgN5b5PnA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DBBPR04MB7964","Subject":"Re: [libcamera-devel] [PATCH 2/8] ipa: camera_sensor_helper: Make\n\tregisterType() and createInstance() private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"\"Xavier Roumegue \\(OSS\\) via libcamera-devel\"\n\t","Reply-To":"\"Xavier Roumegue \\(OSS\\)\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25332,"web_url":"https://patchwork.libcamera.org/comment/25332/","msgid":"<20221007133807.umniumvzdefpe6jf@uno.localdomain>","date":"2022-10-07T13:38:07","subject":"Re: [libcamera-devel] [PATCH 2/8] ipa: camera_sensor_helper: Make\n\tregisterType() and createInstance() private","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Tue, Oct 04, 2022 at 12:21:22AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The CameraSensorHelperFactory registerType() and createInstance()\n> functions are called by the CameraSensorHelperFactory class only. Make\n> them private.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/libipa/camera_sensor_helper.h | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\n> index 2042847f29e8..410156efb2ea 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.h\n> +++ b/src/ipa/libipa/camera_sensor_helper.h\n> @@ -66,15 +66,15 @@ public:\n>\n> \tstatic std::unique_ptr create(const std::string &name);\n>\n> -\tstatic void registerType(CameraSensorHelperFactory *factory);\n> \tstatic std::vector &factories();\n>\n> -protected:\n> -\tvirtual CameraSensorHelper *createInstance() const = 0;\n\nMaybe we made it protected because this was meant to be overridden by\nthe sub-classes ? Making it private is indeed fine\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> -\n> private:\n> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactory)\n>\n> +\tstatic void registerType(CameraSensorHelperFactory *factory);\n> +\n> +\tvirtual CameraSensorHelper *createInstance() const = 0;\n> +\n> \tstd::string name_;\n> };\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A4C8C0DA4\n\tfor ;\n\tFri, 7 Oct 2022 13:38:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5815662D15;\n\tFri, 7 Oct 2022 15:38:10 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4318160A88\n\tfor ;\n\tFri, 7 Oct 2022 15:38:09 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id BFF6E1BF203;\n\tFri, 7 Oct 2022 13:38:08 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665149890;\n\tbh=Lxt6FqiW/7XwnMk+mcFgG7swTTAnbnGCa5Z1Vvh3ZLo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bSCX/WrkVwK059Ct0FtFA2giAENm5cnAEJqGhSIO3SnN9yypCc95Ok6AR8O4wyofG\n\tBhIuNcAybelyf2L5FRRgzokS1lXmdnlLNjaTD0rYCHsShBJxZHVah0ZcErIf9W10pc\n\twlxsG25vNN1U2qRtjwAQ2lNEfH/s3ovJmlHt8QIUVIwWRIaNpIpPDPl8WKFGzQ4nGO\n\tynlc7NDOQ1xJwcNRh+rqaaD4GqBe/9Za5Di69Xli5X2A/CMaL6is6AU2zSrpVkVABM\n\t1rUxxVkGMyA0FOETpiDc01aFWZ2xDWtZ3swZa0SZ/7sPcLkLT+Qh38S/8w89/D3UoA\n\t6jAE3K34pAqtg==","Date":"Fri, 7 Oct 2022 15:38:07 +0200","To":"Laurent Pinchart ","Message-ID":"<20221007133807.umniumvzdefpe6jf@uno.localdomain>","References":"<20221003212128.32429-1-laurent.pinchart@ideasonboard.com>\n\t<20221003212128.32429-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221003212128.32429-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/8] ipa: camera_sensor_helper: Make\n\tregisterType() and createInstance() private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]