[{"id":25292,"web_url":"https://patchwork.libcamera.org/comment/25292/","msgid":"","date":"2022-10-05T10:56:19","subject":"Re: [libcamera-devel] [PATCH 1/8] ipa: camera_sensor_helper: Make\n\tfactory createInstance() function const","submitter":{"id":107,"url":"https://patchwork.libcamera.org/api/people/107/","name":"Xavier Roumegue","email":"xavier.roumegue@oss.nxp.com"},"content":"Hi Laurent,\n\nThanks for the patch.\n\nOn 10/3/22 23:21, Laurent Pinchart via libcamera-devel wrote:\n> The CameraSensorHelperFactory::createIsntace() function has no need to\ns/createIsntace/createInstance/\n\n> modify the factory instance. Make it const.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 6 +++---\n> src/ipa/libipa/camera_sensor_helper.h | 4 ++--\n> 2 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index d4dba4975e17..fde9bf5b8892 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -254,10 +254,10 @@ CameraSensorHelperFactory::CameraSensorHelperFactory(const std::string name)\n> */\n> std::unique_ptr CameraSensorHelperFactory::create(const std::string &name)\n> {\n> -\tstd::vector &factories =\n> +\tconst std::vector &factories =\n> \t\tCameraSensorHelperFactory::factories();\n> \n> -\tfor (CameraSensorHelperFactory *factory : factories) {\n> +\tfor (const CameraSensorHelperFactory *factory : factories) {\n> \t\tif (name != factory->name_)\n> \t\t\tcontinue;\n> \n> @@ -299,7 +299,7 @@ std::vector &CameraSensorHelperFactory::factories()\n> }\n> \n> /**\n> - * \\fn CameraSensorHelperFactory::createInstance()\n> + * \\fn CameraSensorHelperFactory::createInstance() const\n> * \\brief Create an instance of the CameraSensorHelper corresponding to the\n> * factory\n> *\n> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\n> index 7351fc7c2928..2042847f29e8 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.h\n> +++ b/src/ipa/libipa/camera_sensor_helper.h\n> @@ -70,7 +70,7 @@ public:\n> \tstatic std::vector &factories();\n> \n> protected:\n> -\tvirtual CameraSensorHelper *createInstance() = 0;\n> +\tvirtual CameraSensorHelper *createInstance() const = 0;\n> \n> private:\n> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactory)\n> @@ -85,7 +85,7 @@ public: \t\t\t\t\t\t\t\\\n> \thelper##Factory() : CameraSensorHelperFactory(name) {}\t\\\n> \t\t\t\t\t\t\t\t\\\n> private:\t\t\t\t\t\t\t\\\n> -\tCameraSensorHelper *createInstance()\t\t\t\\\n> +\tCameraSensorHelper *createInstance() const\t\t\\\n> \t{\t\t\t\t\t\t\t\\\n> \t\treturn new helper();\t\t\t\t\\\n> \t}\t\t\t\t\t\t\t\\\n\nReviewed-by: Xavier Roumegue ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 439CCBD16B\n\tfor ;\n\tWed, 5 Oct 2022 10:56:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E2F8622E3;\n\tWed, 5 Oct 2022 12:56:25 +0200 (CEST)","from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00087.outbound.protection.outlook.com [40.107.0.87])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4114601C7\n\tfor ;\n\tWed, 5 Oct 2022 12:56:23 +0200 (CEST)","from PAXPR04MB8703.eurprd04.prod.outlook.com\n\t(2603:10a6:102:21e::22)\n\tby AS8PR04MB8836.eurprd04.prod.outlook.com (2603:10a6:20b:42f::7)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32;\n\tWed, 5 Oct 2022 10:56:21 +0000","from PAXPR04MB8703.eurprd04.prod.outlook.com\n\t([fe80::4f72:a35a:8c60:63f1]) by\n\tPAXPR04MB8703.eurprd04.prod.outlook.com\n\t([fe80::4f72:a35a:8c60:63f1%6]) with mapi id 15.20.5676.028;\n\tWed, 5 Oct 2022 10:56:21 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664967385;\n\tbh=sJNIfw1eC8pCapDZXo1quOoo62TRxcP7uo2Ri0bQbc8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=kXE6X6V02IznDe1ccN4UW0dnCAs5yzIylu+sDcOwVsZL96NAjPKm3y6WtIUozql/G\n\tqpHCEvdgS7ps96QJk4xggtJeqU+0R1FvJ8R8ETjGN+TwJXgGOO516q1W9rR4BqNCQk\n\tfjzsGS686lx3cTkFYqZ1KcxlYdeCDmj1zBiBrFhFgLNAizwAwwqC6/J+S4VJSNM6oW\n\tkr7fXIAXUpedZnTno3E4+ymap6pq2NLSoC13gt2MNyag9z/5hxCirr3Df+ICVLfnQ2\n\tQSPtsQJoa/hmxGy7X5oZqeFLuAMkyFBxZAApaSrVSAm8uaCX/FcKeoCcIF4bml8yH4\n\tUhC+pAhMBRCMA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;\n\ts=selector2-NXP1-onmicrosoft-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=PyeobF0dMduh3X47DF8eZ12c1s15kFyaBV/QONkZOHo=;\n\tb=B5drzgSceixLck060Oti5Eydlsp3LzIVxGpgo6eYPx+5XHDP2nWdn5Omak2ri9L87n5Zxo+0auqE98PppO37F755Tp+PnKjC+nzL0mAO8Y751N8Ogb2Z0lPpX+6q99IUo8ILJwps8dsbnU+FUsLpPbjsl9W18kYzr3i74rc5I28="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=NXP1.onmicrosoft.com\n\theader.i=@NXP1.onmicrosoft.com\n\theader.b=\"B5drzgSc\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=oss.nxp.com;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=DMROg1v9/0Ru6oaCOdpYCuuw6GJ7uRRY0GZWFixotOK7ZvZolwnq1AMY/5iAy942NOPPkS2TlttziQhSkznH26ya0KfTvya2TzHMvOx4hnbhrmPXFpNhsKSMsv+kfpUX26abIjjj7RZfi/aAIV9+UiKZ6nA2l6cKOhX799vygVlM9sYldn7QqJGc8hA9e5gbWtWr2Hd5hh8raVQwoU1GN5c5iUVZUoqAik3lvoG5GPoY4UkIz9WiaswQxgNPxlshaZxukiTxy592QTKTtshp5KQM+CSTbQ5a0Dx1vzddZrFuCKHT8/o9TqSv/Yq4DbXvzqCzEh+rf1FpeDeHAoD/rA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=PyeobF0dMduh3X47DF8eZ12c1s15kFyaBV/QONkZOHo=;\n\tb=X20br1Xt0MJ4GB9G2ElxDpOq0HtKM0PdUuOkHEHVftNqd4D5YiPGr5xrqL4Rw+BW+UeWqCjZjEBdQcUddwl7UtoJo2k6hKclXEFBYQDbqnkku76+GqYOwwO54C/C9kvJOkeb+W8GEiMkZW3eGjaVlKtHbnFmnixo+0snmkEUutGs8vYz6AazBnk1ztwGeCwkpnm7K+SLadpvAsXQ2xUxrJd03eTYpLPFOWlX9llIw6e3AwDrTCQJZdNJ6wyZ2hRx8ZXaO1P9lue80FYZkZsrvohMWUEC6EqCNEWA3Kv4A7JUqVI27GtATOBBUze+q5a15YA7DFl0UCqsLkGkvGqplA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=oss.nxp.com;\n\tdmarc=pass action=none header.from=oss.nxp.com; \n\tdkim=pass header.d=oss.nxp.com; arc=none","Message-ID":"","Date":"Wed, 5 Oct 2022 12:56:19 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.3.1","Content-Language":"en-US, fr","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221003212128.32429-1-laurent.pinchart@ideasonboard.com>\n\t<20221003212128.32429-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20221003212128.32429-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"PR0P264CA0211.FRAP264.PROD.OUTLOOK.COM\n\t(2603:10a6:100:1f::31) To PAXPR04MB8703.eurprd04.prod.outlook.com\n\t(2603:10a6:102:21e::22)","MIME-Version":"1.0","X-MS-Exchange-MessageSentRepresentingType":"1","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"PAXPR04MB8703:EE_|AS8PR04MB8836:EE_","X-MS-Office365-Filtering-Correlation-Id":"ecb1cb8b-4a1e-469c-effa-08daa6c03cef","X-MS-Exchange-SharedMailbox-RoutingAgent-Processed":"True","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;","X-Microsoft-Antispam-Message-Info":"UcUzgHffubYnTxaaXMyzt5dG2uIIM7T8XX0ypShD/ZXVXnmyy17/wWxqOks2KowOH051rUEdUypawkqOI+YCi6xlh3g0gDLpmXusM6sAs7kYgZdNAlRKhCziZAmXuliWQ+ngHySQISp3pgaINlwnz35Ze9EpBjwUnth2PLBAQr/U958HOYgX1pBd29ty0EzagJTi9yLPTqURhH7rSU5BTqTX60eyorodgARruXpDo+UhUa/JGhRBIJx/1PJLNlxtsZpA+FuIYtrOp2yIW/nNa4F1RINCgCxFUhRkrGfMh7meOhHPLsukILvR0NJvMwqm8xIrZj+dlpmzLSzyc8cDRFzXdgflWrHtxZmkZgt+jSG0j8vpbD1HAybq6D+Y+BumFBSLPZML+eZww/yPYJrVsJn4jwfSoU2HMvzfUh4BqEp3FBM4WAZgdbIPfzj6jWWCxEnzeck6k5hJlIo75Y1Ll1dw4nDMx16sFuH7/GTG4fdVwUzrvWyupr0blPx9VAZjlijKh4YvNEMX/EVN67jTpkE46xQG1ei4bs/SLH/V4qXcS0XngIdKMcq2i+RS4uZBCXK9cz4FTTDc3j2JfHQGd6mXgAUxOstCrwXtAhBBv4NpTyF8+7ssFBf4x6uv8kOKZwjy5jdV+JLxuQf363+8EMPbh6H3Gy4vSgnbOaC/RAoQ/ZgOwh+oPjkPDASTrodql8PDcYMh51uD9s258bSTJd6vohWGkkV0M6IQ4zDCWjLzv+rmwFlkH01xiYWidIhK0BRW2/pHnfn1R9UHTvB99nbB9Vu5io5hPQCuG+NFGBw=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PAXPR04MB8703.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230022)(4636009)(39860400002)(346002)(366004)(136003)(376002)(396003)(451199015)(31686004)(2906002)(8936002)(8676002)(38100700002)(66476007)(66556008)(66946007)(316002)(478600001)(5660300002)(41300700001)(86362001)(6486002)(6506007)(31696002)(2616005)(186003)(52116002)(83380400001)(6512007)(53546011)(43740500002)(45980500001);\n\tDIR:OUT; SFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?iy+OSB0vdEmV+mSCuQ9h5LJWb?=\n\t=?utf-8?q?mnTrO6tEZ7/sUEs535olL53SqdCOrYqKMlh7fgXPizYURjxg7jzB1iqt?=\n\t=?utf-8?q?/oNfJbfrbLUWyWtuTN+3HtHnSc798ITFxMeDn1blHTLRxStP1x8GfnXc?=\n\t=?utf-8?q?s8+X9XrMBeaulZTm2x7AN/hDz4Zt6OVYErjYqr81+8juENnHvSL/csar?=\n\t=?utf-8?q?VqhOdKHSIxwlSTTpDZkeHYqr10OZM8f4nbeVVGzkTu32Gxb6p36NnR8m?=\n\t=?utf-8?q?6kMg2Iht2CDb2VxoIHDrkyeOvbT3eN8xnqPt0NvRxi37BZvLfJqIW1sG?=\n\t=?utf-8?q?lsMAbsqbpv3mdIbMWhRG4L3dKytek/ReKljVsZIJveJt55NgyzW2ZGt+?=\n\t=?utf-8?q?10A2fCatQ+WAQQok6Fxv0Nrri+8Vb26U3xr6JcpUgcgUpicugaxZRy0p?=\n\t=?utf-8?q?6tG7czcfjTzhMcwEfUCUH+2MlsqTRbmAcx0sY+pzq/xjmmjWyS79K1qK?=\n\t=?utf-8?q?OYXWyTjEAuRpUJo/DEJzsLoN5uwlSrspxZnxMQpl/82XzUJRA3JMvrLs?=\n\t=?utf-8?q?MZDpjI8fHrCl/Dd/l+L1KsgwS0hJscbC32T53BisU4RytYXbwBPHgElV?=\n\t=?utf-8?q?U9u80w1EpgxSkF4+v/1Ovbk2Dat9CZa9lOy1keQsHSqbjXU2M+P/0Bfu?=\n\t=?utf-8?q?nRwwa0IDfJ2sIYnuk6VUheHaLsnrJXsRDhNLgBCN7NoImXf7EJiVop1c?=\n\t=?utf-8?q?QQ97FSjtgVsQP+ez7E7cB2cDoBeCS/SGAyWavLkc8lE9Vnt6sRaVfrqT?=\n\t=?utf-8?q?QpVvpO6+ItnBsQdBZqNlUDyDFH6Xd9k+ZoPcuC+u1urP8a24gNZkAiGl?=\n\t=?utf-8?q?DduI4UNg7+w5VZMgv17AvVrna1vd8td3Pot1oGXKGkj6lfJCX5JW5yj1?=\n\t=?utf-8?q?bm2fxrP7OG86H9123+eDuhMrB++569jjxTeeXIR9bgoEarX3DjPvIpHX?=\n\t=?utf-8?q?pr1WN3BoIcHWB98LA2XBYSannRtw/fg+7pJRlZ0Yt1UfWdhKPxD8rnyH?=\n\t=?utf-8?q?oSex02JHYMkFGtUBM77TCN+4fJy+jUI36by00VOG33w5JUqsQ5bzPpbx?=\n\t=?utf-8?q?MsvFLh8NNQIW6VJl8R8wa/zBDdJwVHD024hwGuZItg6uDYakwacF+Ru3?=\n\t=?utf-8?q?TgkzAFUDje2j3M2vhUBGuCQ1U4D4tDCcyVzTCHel27ell0oewN8LIchX?=\n\t=?utf-8?q?uRdfoq8u6vXVYgxsEvBz3ACTWltqCfu1d6Q7k9ZIR0CX00GxRNwd6r6l?=\n\t=?utf-8?q?63vq0pDv+WpNmfIbvd1t3DzAvie09gWkYWJ+kVs5xCHaAvGT2VUiEv+B?=\n\t=?utf-8?q?bos4GUHQiMLDtL/w8McUdH1pHfSGW1uqZPBy7iX0MCYgSH5JRlTuEf3U?=\n\t=?utf-8?q?K55y0okRHb9qqEwJXgJRHFEXyvNuDcht9ABlENTTQvPKntI8eaUvdX2J?=\n\t=?utf-8?q?MsTcDNaQbIeEagZ6kz+KUl/qe93/2dUY5o+rE53KKXZpRpx/iniVvU1v?=\n\t=?utf-8?q?i+ia/vheg7n9iaR5xdty/UtfWiMPt7yCTBtaKGFdm0CZbp0H45hQt7Jh?=\n\t=?utf-8?q?hEBQpeGCwv8DoiJTT/4eM5GMre/OZqKH9clDKUF/nIRKn/BkoTUNe3wj?=\n\t=?utf-8?q?3gkorjKybZPX853B5Vk30svu+vB1N6YVREUw3ANz5gPeGjZwt1DGHPEi?=\n\t=?utf-8?q?H+8hzGwxeSCBd2dLblPlh3Z/Gb+t+Tl+aUH5L6ux9fA+9zEj4IE1gL/D?=\n\t=?utf-8?q?xNbN/1iqPh7EWO1kuq4dW/HT8RZCvRBGVX35Q=3D=3D?=","X-OriginatorOrg":"oss.nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"ecb1cb8b-4a1e-469c-effa-08daa6c03cef","X-MS-Exchange-CrossTenant-AuthSource":"PAXPR04MB8703.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"05 Oct 2022 10:56:21.6541\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"4ozCf+LeSEYd9GrEiZyIcOQsl7gXjIKHqlgF6ERgFX5tj1IlGjXC1tQAMGc/J2lCKS3/QLX9IUhMpW1Vc7hOCw==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS8PR04MB8836","Subject":"Re: [libcamera-devel] [PATCH 1/8] ipa: camera_sensor_helper: Make\n\tfactory createInstance() function const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"\"Xavier Roumegue \\(OSS\\) via libcamera-devel\"\n\t","Reply-To":"\"Xavier Roumegue \\(OSS\\)\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25330,"web_url":"https://patchwork.libcamera.org/comment/25330/","msgid":"<20221007133301.3e2ohlljuyfehgxs@uno.localdomain>","date":"2022-10-07T13:33:01","subject":"Re: [libcamera-devel] [PATCH 1/8] ipa: camera_sensor_helper: Make\n\tfactory createInstance() function const","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Tue, Oct 04, 2022 at 12:21:21AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The CameraSensorHelperFactory::createIsntace() function has no need to\n ^\n createInstance()\n\n> modify the factory instance. Make it const.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 6 +++---\n> src/ipa/libipa/camera_sensor_helper.h | 4 ++--\n> 2 files changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index d4dba4975e17..fde9bf5b8892 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -254,10 +254,10 @@ CameraSensorHelperFactory::CameraSensorHelperFactory(const std::string name)\n> */\n> std::unique_ptr CameraSensorHelperFactory::create(const std::string &name)\n> {\n> -\tstd::vector &factories =\n> +\tconst std::vector &factories =\n> \t\tCameraSensorHelperFactory::factories();\n>\n> -\tfor (CameraSensorHelperFactory *factory : factories) {\n> +\tfor (const CameraSensorHelperFactory *factory : factories) {\n> \t\tif (name != factory->name_)\n> \t\t\tcontinue;\n>\n> @@ -299,7 +299,7 @@ std::vector &CameraSensorHelperFactory::factories()\n> }\n>\n> /**\n> - * \\fn CameraSensorHelperFactory::createInstance()\n> + * \\fn CameraSensorHelperFactory::createInstance() const\n> * \\brief Create an instance of the CameraSensorHelper corresponding to the\n> * factory\n> *\n> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\n> index 7351fc7c2928..2042847f29e8 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.h\n> +++ b/src/ipa/libipa/camera_sensor_helper.h\n> @@ -70,7 +70,7 @@ public:\n> \tstatic std::vector &factories();\n>\n> protected:\n> -\tvirtual CameraSensorHelper *createInstance() = 0;\n> +\tvirtual CameraSensorHelper *createInstance() const = 0;\n>\n> private:\n> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactory)\n> @@ -85,7 +85,7 @@ public: \t\t\t\t\t\t\t\\\n> \thelper##Factory() : CameraSensorHelperFactory(name) {}\t\\\n> \t\t\t\t\t\t\t\t\\\n> private:\t\t\t\t\t\t\t\\\n> -\tCameraSensorHelper *createInstance()\t\t\t\\\n> +\tCameraSensorHelper *createInstance() const\t\t\\\n> \t{\t\t\t\t\t\t\t\\\n> \t\treturn new helper();\t\t\t\t\\\n> \t}\t\t\t\t\t\t\t\\\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A96E3BD16B\n\tfor ;\n\tFri, 7 Oct 2022 13:33:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2003D62D13;\n\tFri, 7 Oct 2022 15:33:06 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::221])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81E8F60A88\n\tfor ;\n\tFri, 7 Oct 2022 15:33:04 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 8D1FB24000B;\n\tFri, 7 Oct 2022 13:33:03 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665149586;\n\tbh=ijd6U4tjQg7Oq1zsQ4jHbY/qTJHXg4V48F+skENNzDw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zUB9qrq7r3idDW121O2KlTSZn+sqRPT+yK9O2gsmgK+ui/qBsWOb8QUPAu5jPtGMq\n\tvw3PPmsdD9gQnJWhPdphW3ifPspG91z4zic+riukFFJ3a4w2tkmY/HcglZKse2GFl8\n\tFiNYv2CUBkiK5+TMaHdalM1NPN0QqntJ2R0lpyR/UAngBwMXWibStX5/SKka9z7QeL\n\t+3E0112o5NUULbz5tBkMdXWMzhAWAuQkHTegpSrdm7aLRCSHlDhETBLY48PDW+5qzH\n\tWjNln2GOpsp+A4Twh9jJMXCS4uQ+eZT98wh9ndFZCK3zXo1IqXaA9RNSXMli4JeqWk\n\tL/ADnazpeft8g==","Date":"Fri, 7 Oct 2022 15:33:01 +0200","To":"Laurent Pinchart ","Message-ID":"<20221007133301.3e2ohlljuyfehgxs@uno.localdomain>","References":"<20221003212128.32429-1-laurent.pinchart@ideasonboard.com>\n\t<20221003212128.32429-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221003212128.32429-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/8] ipa: camera_sensor_helper: Make\n\tfactory createInstance() function const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]