[{"id":2346,"web_url":"https://patchwork.libcamera.org/comment/2346/","msgid":"<20190808202659.GA2918@pendragon.ideasonboard.com>","date":"2019-08-08T20:26:59","subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: v4l2_videodevice: Fix\n\tordering of debug statement","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Aug 08, 2019 at 04:12:17PM +0100, Kieran Bingham wrote:\n> The \"Opened device\" statement occurs before the buffertype_ is set.\n> \n> This causes all devices to report that they are [out] devices at open()\n> regardless of their type.\n> \n> As the message operates in the past-tense, move the statement to the end\n> of the function when all work has been completed.\n> \n> Fixes: 04d5be7f76fe (\"libcamera: v4l2_device: Inherit from Loggable to\n> print device node name\")\n\nNo need to wrap this line :-)\n\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index c43d7cc557a0..81098dd70190 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -314,10 +314,6 @@ int V4L2VideoDevice::open()\n> \t\treturn ret;\n> \t}\n> \n> -\tLOG(V4L2, Debug)\n> -\t\t<< \"Opened device \" << caps_.bus_info() << \": \"\n> -\t\t<< caps_.driver() << \": \" << caps_.card();\n> -\n> \tif (!caps_.hasStreaming()) {\n> \t\tLOG(V4L2, Error) << \"Device does not support streaming I/O\";\n> \t\treturn -EINVAL;\n> @@ -352,6 +348,10 @@ int V4L2VideoDevice::open()\n> \tfdEvent_->activated.connect(this, &V4L2VideoDevice::bufferAvailable);\n> \tfdEvent_->setEnabled(false);\n> \n> +\tLOG(V4L2, Debug)\n> +\t\t<< \"Opened device \" << caps_.bus_info() << \": \"\n> +\t\t<< caps_.driver() << \": \" << caps_.card();\n> +\n> \treturn 0;\n> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8598B615FF\n\tfor ;\n\tThu, 8 Aug 2019 22:27:02 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E1640CC;\n\tThu, 8 Aug 2019 22:27:01 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565296022;\n\tbh=fdbaob1E9gwXqu+4kkMBVEHHGTANy823SDH+9JkACSU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ro5zS1/lHu0yy1iFxRO7WiqXj3Naym3QlTGrMJYLxz1CeaYXi9+LmeiUEEXbtJm7h\n\tj5ZGQv5DdmO33VnQW3B+9I4PP8QMVju+qSIopMt8zcPQTjkGEVERJJRdiftx57yty0\n\tI+3+NFbi6pqI6qtvr6vJcUHZjd7Z7L1grqZNt8iU=","Date":"Thu, 8 Aug 2019 23:26:59 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190808202659.GA2918@pendragon.ideasonboard.com>","References":"<20190808151221.24254-1-kieran.bingham@ideasonboard.com>\n\t<20190808151221.24254-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190808151221.24254-3-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: v4l2_videodevice: Fix\n\tordering of debug statement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 08 Aug 2019 20:27:02 -0000"}},{"id":2357,"web_url":"https://patchwork.libcamera.org/comment/2357/","msgid":"","date":"2019-08-09T10:03:32","subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: v4l2_videodevice: Fix\n\tordering of debug statement","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 08/08/2019 21:26, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Aug 08, 2019 at 04:12:17PM +0100, Kieran Bingham wrote:\n>> The \"Opened device\" statement occurs before the buffertype_ is set.\n>>\n>> This causes all devices to report that they are [out] devices at open()\n>> regardless of their type.\n>>\n>> As the message operates in the past-tense, move the statement to the end\n>> of the function when all work has been completed.\n>>\n>> Fixes: 04d5be7f76fe (\"libcamera: v4l2_device: Inherit from Loggable to\n>> print device node name\")\n> \n> No need to wrap this line :-)\n\nIs Fixes an exception to the rule?\n\n(I usually just use vim's autowrap - so I don't take much consideration\nto the actual wrap.)\n\n\n>> Signed-off-by: Kieran Bingham \n> \n> Reviewed-by: Laurent Pinchart \n\nCollected\n\n> \n>> ---\n>> src/libcamera/v4l2_videodevice.cpp | 8 ++++----\n>> 1 file changed, 4 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n>> index c43d7cc557a0..81098dd70190 100644\n>> --- a/src/libcamera/v4l2_videodevice.cpp\n>> +++ b/src/libcamera/v4l2_videodevice.cpp\n>> @@ -314,10 +314,6 @@ int V4L2VideoDevice::open()\n>> \t\treturn ret;\n>> \t}\n>> \n>> -\tLOG(V4L2, Debug)\n>> -\t\t<< \"Opened device \" << caps_.bus_info() << \": \"\n>> -\t\t<< caps_.driver() << \": \" << caps_.card();\n>> -\n>> \tif (!caps_.hasStreaming()) {\n>> \t\tLOG(V4L2, Error) << \"Device does not support streaming I/O\";\n>> \t\treturn -EINVAL;\n>> @@ -352,6 +348,10 @@ int V4L2VideoDevice::open()\n>> \tfdEvent_->activated.connect(this, &V4L2VideoDevice::bufferAvailable);\n>> \tfdEvent_->setEnabled(false);\n>> \n>> +\tLOG(V4L2, Debug)\n>> +\t\t<< \"Opened device \" << caps_.bus_info() << \": \"\n>> +\t\t<< caps_.driver() << \": \" << caps_.card();\n>> +\n>> \treturn 0;\n>> }\n>> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 459A161620\n\tfor ;\n\tFri, 9 Aug 2019 12:03:35 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D2864CC;\n\tFri, 9 Aug 2019 12:03:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565345015;\n\tbh=MiH/NoF4SOUKSp70O40kVWOujxuJ96tmHAwZzGEzu2k=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=D8IvefjCQX1GtmPN05qDkzLnmDsdmw97aItT5IQcSltf15UluRnl4mZSG6C9ZkCm4\n\trF9z81BQ4jXJNoVyuVsOvtPk1F8qgEJXy9XWGHGkJK3KDGupRx8xqcDrpbw7RYLx+I\n\tHePcKvbtvYiqTciS0MU1oGBq2XXxwFDD5HAKOdeU=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"LibCamera Devel ","References":"<20190808151221.24254-1-kieran.bingham@ideasonboard.com>\n\t<20190808151221.24254-3-kieran.bingham@ideasonboard.com>\n\t<20190808202659.GA2918@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 9 Aug 2019 11:03:32 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.8.0","MIME-Version":"1.0","In-Reply-To":"<20190808202659.GA2918@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: v4l2_videodevice: Fix\n\tordering of debug statement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 09 Aug 2019 10:03:36 -0000"}},{"id":2361,"web_url":"https://patchwork.libcamera.org/comment/2361/","msgid":"<20190809134504.mbf5kmxdxgo2hob7@uno.localdomain>","date":"2019-08-09T13:45:04","subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: v4l2_videodevice: Fix\n\tordering of debug statement","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Thu, Aug 08, 2019 at 04:12:17PM +0100, Kieran Bingham wrote:\n> The \"Opened device\" statement occurs before the buffertype_ is set.\n>\n> This causes all devices to report that they are [out] devices at open()\n> regardless of their type.\n>\n> As the message operates in the past-tense, move the statement to the end\n> of the function when all work has been completed.\n>\n> Fixes: 04d5be7f76fe (\"libcamera: v4l2_device: Inherit from Loggable to\n> print device node name\")\n\nWith the fixes tag on a single line\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/v4l2_videodevice.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index c43d7cc557a0..81098dd70190 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -314,10 +314,6 @@ int V4L2VideoDevice::open()\n> \t\treturn ret;\n> \t}\n>\n> -\tLOG(V4L2, Debug)\n> -\t\t<< \"Opened device \" << caps_.bus_info() << \": \"\n> -\t\t<< caps_.driver() << \": \" << caps_.card();\n> -\n> \tif (!caps_.hasStreaming()) {\n> \t\tLOG(V4L2, Error) << \"Device does not support streaming I/O\";\n> \t\treturn -EINVAL;\n> @@ -352,6 +348,10 @@ int V4L2VideoDevice::open()\n> \tfdEvent_->activated.connect(this, &V4L2VideoDevice::bufferAvailable);\n> \tfdEvent_->setEnabled(false);\n>\n> +\tLOG(V4L2, Debug)\n> +\t\t<< \"Opened device \" << caps_.bus_info() << \": \"\n> +\t\t<< caps_.driver() << \": \" << caps_.card();\n> +\n> \treturn 0;\n> }\n>\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3BBE61620\n\tfor ;\n\tFri, 9 Aug 2019 15:43:40 +0200 (CEST)","from uno.localdomain\n\t(host150-24-dynamic.51-79-r.retail.telecomitalia.it [79.51.24.150])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 1EBF1240006;\n\tFri, 9 Aug 2019 13:43:39 +0000 (UTC)"],"Date":"Fri, 9 Aug 2019 15:45:04 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190809134504.mbf5kmxdxgo2hob7@uno.localdomain>","References":"<20190808151221.24254-1-kieran.bingham@ideasonboard.com>\n\t<20190808151221.24254-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"chddxobc6hpfotb4\"","Content-Disposition":"inline","In-Reply-To":"<20190808151221.24254-3-kieran.bingham@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: v4l2_videodevice: Fix\n\tordering of debug statement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 09 Aug 2019 13:43:40 -0000"}},{"id":2367,"web_url":"https://patchwork.libcamera.org/comment/2367/","msgid":"<20190809181533.GD5007@pendragon.ideasonboard.com>","date":"2019-08-09T18:15:33","subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: v4l2_videodevice: Fix\n\tordering of debug statement","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Aug 09, 2019 at 11:03:32AM +0100, Kieran Bingham wrote:\n> On 08/08/2019 21:26, Laurent Pinchart wrote:\n> > On Thu, Aug 08, 2019 at 04:12:17PM +0100, Kieran Bingham wrote:\n> >> The \"Opened device\" statement occurs before the buffertype_ is set.\n> >>\n> >> This causes all devices to report that they are [out] devices at open()\n> >> regardless of their type.\n> >>\n> >> As the message operates in the past-tense, move the statement to the end\n> >> of the function when all work has been completed.\n> >>\n> >> Fixes: 04d5be7f76fe (\"libcamera: v4l2_device: Inherit from Loggable to\n> >> print device node name\")\n> > \n> > No need to wrap this line :-)\n> \n> Is Fixes an exception to the rule?\n\nI think so. So are SoB or Rb lines.\n\n> (I usually just use vim's autowrap - so I don't take much consideration\n> to the actual wrap.)\n> \n> >> Signed-off-by: Kieran Bingham \n> > \n> > Reviewed-by: Laurent Pinchart \n> \n> Collected\n> \n> >> ---\n> >> src/libcamera/v4l2_videodevice.cpp | 8 ++++----\n> >> 1 file changed, 4 insertions(+), 4 deletions(-)\n> >>\n> >> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> >> index c43d7cc557a0..81098dd70190 100644\n> >> --- a/src/libcamera/v4l2_videodevice.cpp\n> >> +++ b/src/libcamera/v4l2_videodevice.cpp\n> >> @@ -314,10 +314,6 @@ int V4L2VideoDevice::open()\n> >> \t\treturn ret;\n> >> \t}\n> >> \n> >> -\tLOG(V4L2, Debug)\n> >> -\t\t<< \"Opened device \" << caps_.bus_info() << \": \"\n> >> -\t\t<< caps_.driver() << \": \" << caps_.card();\n> >> -\n> >> \tif (!caps_.hasStreaming()) {\n> >> \t\tLOG(V4L2, Error) << \"Device does not support streaming I/O\";\n> >> \t\treturn -EINVAL;\n> >> @@ -352,6 +348,10 @@ int V4L2VideoDevice::open()\n> >> \tfdEvent_->activated.connect(this, &V4L2VideoDevice::bufferAvailable);\n> >> \tfdEvent_->setEnabled(false);\n> >> \n> >> +\tLOG(V4L2, Debug)\n> >> +\t\t<< \"Opened device \" << caps_.bus_info() << \": \"\n> >> +\t\t<< caps_.driver() << \": \" << caps_.card();\n> >> +\n> >> \treturn 0;\n> >> }\n> >>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 864B760E2F\n\tfor ;\n\tFri, 9 Aug 2019 20:15:36 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF324CC;\n\tFri, 9 Aug 2019 20:15:35 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565374536;\n\tbh=y3Qv3YFsGyxpBzHQ+thw62PTQGdam2frp20pdVjpv9s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mP/uSSL29dDxwpt1ApdP62Yn3Ip6MiNU132Ts2XDg95ISAsn6CSSZt4DjyC86OR0i\n\taQ9hlVTc9ZLqXzOOk+JdvQlu96oQBmG3zMGn7vSzJ+C8k8NSfe98WeCZB0878G4CKP\n\tZOylCB1fbqw9IYKaTLw0ZglKinVYzFOc5HHcVaq4=","Date":"Fri, 9 Aug 2019 21:15:33 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190809181533.GD5007@pendragon.ideasonboard.com>","References":"<20190808151221.24254-1-kieran.bingham@ideasonboard.com>\n\t<20190808151221.24254-3-kieran.bingham@ideasonboard.com>\n\t<20190808202659.GA2918@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: v4l2_videodevice: Fix\n\tordering of debug statement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 09 Aug 2019 18:15:36 -0000"}}]