[{"id":25276,"web_url":"https://patchwork.libcamera.org/comment/25276/","msgid":"","date":"2022-10-04T19:41:50","subject":"Re: [libcamera-devel] [PATCH v3 4/4] ipa: raspberrypi: Fix the\n\timx296 mono tuning black level","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Oct 03, 2022 at 10:55:58AM +0100, Naushir Patuck via libcamera-devel wrote:\n> The sensor black level is 60 (in 10-bits), fix this in the mono variant tuning\n> file.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/data/imx296_mono.json | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json\n> index 490c0fda0cca..b68b11dbd609 100644\n> --- a/src/ipa/raspberrypi/data/imx296_mono.json\n> +++ b/src/ipa/raspberrypi/data/imx296_mono.json\n> @@ -5,7 +5,7 @@\n> {\n> \"rpi.black_level\":\n> {\n> - \"black_level\": 4096\n> + \"black_level\": 3840\n> }\n> },\n> {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF775C0DA4\n\tfor ;\n\tTue, 4 Oct 2022 19:41:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B031F60AB6;\n\tTue, 4 Oct 2022 21:41:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E30A2601C7\n\tfor ;\n\tTue, 4 Oct 2022 21:41:53 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 692522D9;\n\tTue, 4 Oct 2022 21:41:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664912514;\n\tbh=NH8BJZffzTwogvlZ/0QEriUTjp3APYLPc+3gN19LMlI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=hgfwxtaqvopbAOOGcx36YzpgwYq7tu9StfR5tibQqPipTrTk+18oCMLghAFov2wL3\n\t70kJ9iuRP1oAgEFGYCC3UY8cbyS68v1s/PvGGCaUO9GPDqKGckoB0fQH8NSQ1ti/3y\n\tMQeX62WOofuwNWqy0dC7YYnXo/pJxcDUPYhH4PBTKPp6ZRcshU8vbWqwkVOyox2Xwa\n\txG17QsgHYB4gz5rA7dqvWZhVJcJmeiKYUDQk3Y+/RC5Bvf6HlGqPzN6XHnSpO//8J/\n\tqy0jCea7+RXFYXmpsJ9L1eEasudgG1Z1sIMJsEQlVlm+FJBGwD9ea04m7ECMSDed0l\n\tePT0Q9vJ9yTwQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664912513;\n\tbh=NH8BJZffzTwogvlZ/0QEriUTjp3APYLPc+3gN19LMlI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Eq7um53FI5mTUGwKd3d0vUBEbrJnnqRqX128A3plus2l5zwPRpc2ZmyxE+DAE2OBZ\n\tL2kNy0CbA2TqSxpQqEi2wx5tuNgcVeCsAaUF58QyacjhgyqSwS2Eo2HDGSxsXNI+mI\n\ttNhIu7JMWo6JwZjQd2HVZUYBoqChHyuT0IKGkwew="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Eq7um53F\"; dkim-atps=neutral","Date":"Tue, 4 Oct 2022 22:41:50 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20221003095558.1993-1-naush@raspberrypi.com>\n\t<20221003095558.1993-5-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221003095558.1993-5-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 4/4] ipa: raspberrypi: Fix the\n\timx296 mono tuning black level","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]