[{"id":25274,"web_url":"https://patchwork.libcamera.org/comment/25274/","msgid":"","date":"2022-10-04T19:23:51","subject":"Re: [libcamera-devel] [PATCH v3 1/4] libcamera: bayer_format: Add\n\tunpacked mono 12-bit format to the conversion table","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Oct 03, 2022 at 10:55:55AM +0100, Naushir Patuck via libcamera-devel wrote:\n> Add BayerFormat conversions for formats::R12 (12-bit unpacked) format.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: Jacopo Mondi \n> Reviewed-by: David Plowman \n\nIf only all patches were as simple to review as this one :-)\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/bayer_format.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\n> index c2a52f4740d6..f27cc1662d25 100644\n> --- a/src/libcamera/bayer_format.cpp\n> +++ b/src/libcamera/bayer_format.cpp\n> @@ -191,6 +191,7 @@ const std::unordered_map mbusCodeToBayer{\n> \t{ MEDIA_BUS_FMT_SRGGB16_1X16, { BayerFormat::RGGB, 16, BayerFormat::Packing::None } },\n> \t{ MEDIA_BUS_FMT_Y8_1X8, { BayerFormat::MONO, 8, BayerFormat::Packing::None } },\n> \t{ MEDIA_BUS_FMT_Y10_1X10, { BayerFormat::MONO, 10, BayerFormat::Packing::None } },\n> +\t{ MEDIA_BUS_FMT_Y12_1X12, { BayerFormat::MONO, 12, BayerFormat::Packing::None } },\n> };\n> \n> } /* namespace */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DBA8BBD16B\n\tfor ;\n\tTue, 4 Oct 2022 19:23:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3091460AB5;\n\tTue, 4 Oct 2022 21:23:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B183601C7\n\tfor ;\n\tTue, 4 Oct 2022 21:23:55 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C3112D9;\n\tTue, 4 Oct 2022 21:23:54 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664911437;\n\tbh=LWyeb+OtV4ZtbldpadH7G3NY0M75Hv+JOwfPau3mBWk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=4RE6S48mLXkdsfelfni7aE7JJTUNUQrnrci7Ic8oq/dEeC9IdqQzmNwt4F89ewzWn\n\tWdxo6+dazlqQX/n2UhOTyWSnawDrx/Adkz6AyXepVcqCwaFnWOyKaivEBPISzR0u9M\n\t3HVBX9ZNzgvRs9H+r+QXFEGb2RjrA7NP7eqQTzYWHET3wHVYl4Mz28cpZCwk0bHEiP\n\tbcDxgCIVoDIirP6L68RAZDCTmyR1ULOh+Im015T4XQ96/5PHH0DOUgrGTwJCn1s2YA\n\ts7Iw/ckcWI9n73jvAkmLpdqMCSVp4sCfT6qIZH5fIUpTcDNop5z5mmj8/Unckv+GQW\n\tplLPf5quq6znQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664911434;\n\tbh=LWyeb+OtV4ZtbldpadH7G3NY0M75Hv+JOwfPau3mBWk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=W2MOAjxqcQZm2r6oRauRSsn1C83LaxEvYd1DyvkoX9hmfS6NWXdMxlDXZB+Sm8O6O\n\tVE2uWg1CwdhfuA1qp53kcDBcqgWKCLa6XdD4jY908W8QQyNohsKBkjShKuFFN/B0Cc\n\tCj+g/I7Ro9OwSVxPtgN9/T5icTfJMAm9OISryUnY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"W2MOAjxq\"; dkim-atps=neutral","Date":"Tue, 4 Oct 2022 22:23:51 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20221003095558.1993-1-naush@raspberrypi.com>\n\t<20221003095558.1993-2-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221003095558.1993-2-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/4] libcamera: bayer_format: Add\n\tunpacked mono 12-bit format to the conversion table","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]