{"id":17493,"url":"https://patchwork.libcamera.org/api/patches/17493/?format=json","web_url":"https://patchwork.libcamera.org/patch/17493/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221003083934.31629-7-naush@raspberrypi.com>","date":"2022-10-03T08:39:32","name":"[libcamera-devel,v1,6/9] ipa: raspberrypi: Add line length to DeviceStatus","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"b030a7bd69ef71ea68130cd978d10e63a15b8a5c","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17493/mbox/","series":[{"id":3523,"url":"https://patchwork.libcamera.org/api/series/3523/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3523","date":"2022-10-03T08:39:26","name":"Raspberry Pi: Horizontal blanking control","version":1,"mbox":"https://patchwork.libcamera.org/series/3523/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17493/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17493/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2BBC1C3286\n\tfor ;\n\tMon, 3 Oct 2022 08:40:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 933D462CF6;\n\tMon, 3 Oct 2022 10:40:07 +0200 (CEST)","from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB3E562CE2\n\tfor ;\n\tMon, 3 Oct 2022 10:40:01 +0200 (CEST)","by mail-wm1-x32f.google.com with SMTP id iv17so6536009wmb.4\n\tfor ;\n\tMon, 03 Oct 2022 01:40:01 -0700 (PDT)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\ti13-20020a5d55cd000000b0022ae59d472esm8922787wrw.112.2022.10.03.01.40.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 03 Oct 2022 01:40:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664786407;\n\tbh=yp1Ca44TUrCliyF0MFAjwGlo++S33jpIAjzO0B6VpRU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=OjFe1t2XF2rJZAQXdhpMzikCr7355kcMVz17Z5RHcD39zXaujl2GuFjt9bAkWr6Ty\n\tQ+L+CoEzy24RXtYGSqJb06gKHMwITCZg26o2HXtobQtuiU2sFQrFEp/FYMM406OP3i\n\tPtdvSIMygufxjg8uUr3vBSOm2R+VhK8CvsTs/NJQElFqR3/Eq2VNhfjiL0DL/rucS3\n\tx7wbacXWZ0ajv3AXtPtcPSsmeONHDkwFtD/tsrGcpxXKWebSRvitADZ7OrpsyOD8Lm\n\t4HRptnEqggl/CqWhMS/2UD8E/k9t87FFHSt9mu9pWxydFZk7MoVzzKUhaHoxX60eSW\n\t8v5Zt+ZaM9xYA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date;\n\tbh=rXNz/fXg9imuWnncnruQtP1N4L91amcYsLTGIkaMrUg=;\n\tb=Uj+qw7RB0sVlK86rryO5wmhFIQnbKA2oGDEwhQj0OSxwtZ2njfHuhFfqUfnJerPPaS\n\tVsmVKoDyPpdJxcB/idHF0H7H0TmZb6wJNeZFSK8dhGCQYqB13H88U58qgQ83RjaJDG7F\n\tXpWTG0SL5uplo5+/1dyG2E1tNxL16tYMTvL+rePiFkLhDM+0Dl4VPMXFEODmQCqWX08h\n\te/6mMXHvUFGGFDTZrpq3BNnJHwzcWojfLwE7yEY5iAnRGD0i8BuPzFERahn05pa/3D/I\n\tXsh6rZDdEmAI7lXbc4Y+rdkz6DAxKz/KmPirrUwk/+dqp4MSLud7nLiUHFwfUrQx3NXu\n\taWzQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Uj+qw7RB\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date;\n\tbh=rXNz/fXg9imuWnncnruQtP1N4L91amcYsLTGIkaMrUg=;\n\tb=mjmGUavMRoT4df1KM96XdAsXPzSo+bD+M/K+lelJEP8rPxULpsZ/iGiGciohWdxBj9\n\tsVzCR9M9BBS71kaV1rEC8gO7quK3266WKBpW8tNJI4eBKV8jXJY5td03pYQuGOCd+tyD\n\tN+S0SPDBVGsLd0fdCXTT+PwlNhA641kqmXA8CR0URByHDdZRYKteWA8KxORWJQc6GPwm\n\tQUrZSlTG08oPxxn+w1zCCjUTEbyggeURwb3ofbCyWszlJh56XDaZpgnPIZOMVhNuyKyl\n\tWEOhC4HIOYu/xWV3NYptH8WRdYc69t3OKY3/xHJ5mDPv3yAgmHWvLQ3CNmXZj872Ar27\n\tsqcA==","X-Gm-Message-State":"ACrzQf3ZT0ic3LqFgwJLCR/d4Sb6DAmhfbrl4XTpLHAjizPFTyARgW/2\n\tRAh7iStUH2h1jmEt5eopYB83REV4YbfkHw==","X-Google-Smtp-Source":"AMsMyM5VCPjYUWZ+dqtSzAvrPxyEk6ZQA+VduFzSRA9ldl4r/h2BnFKOBFcqohGn+WQlCrGqTf0QNA==","X-Received":"by 2002:a7b:ca46:0:b0:3b4:7ff2:1ca8 with SMTP id\n\tm6-20020a7bca46000000b003b47ff21ca8mr6113957wml.11.1664786401468; \n\tMon, 03 Oct 2022 01:40:01 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 3 Oct 2022 09:39:32 +0100","Message-Id":"<20221003083934.31629-7-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20221003083934.31629-1-naush@raspberrypi.com>","References":"<20221003083934.31629-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 6/9] ipa: raspberrypi: Add line length\n\tto DeviceStatus","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a lineLength field to the DeviceStatus structure to store the line length\nused for a particular frame.\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/raspberrypi/controller/device_status.cpp | 1 +\n src/ipa/raspberrypi/controller/device_status.h | 4 +++-\n src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n 3 files changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/device_status.cpp b/src/ipa/raspberrypi/controller/device_status.cpp\nindex 2360a77bf1ea..c907efdd7511 100644\n--- a/src/ipa/raspberrypi/controller/device_status.cpp\n+++ b/src/ipa/raspberrypi/controller/device_status.cpp\n@@ -12,6 +12,7 @@ std::ostream &operator<<(std::ostream &out, const DeviceStatus &d)\n {\n \tout << \"Exposure: \" << d.shutterSpeed\n \t << \" Frame length: \" << d.frameLength\n+\t << \" Line length: \" << d.lineLength\n \t << \" Gain: \" << d.analogueGain;\n \n \tif (d.aperture)\ndiff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\nindex 8f74e21b0c6e..4384c2149589 100644\n--- a/src/ipa/raspberrypi/controller/device_status.h\n+++ b/src/ipa/raspberrypi/controller/device_status.h\n@@ -19,7 +19,7 @@\n struct DeviceStatus {\n \tDeviceStatus()\n \t\t: shutterSpeed(std::chrono::seconds(0)), frameLength(0),\n-\t\t analogueGain(0.0)\n+\t\t lineLength(std::chrono::seconds(0)), analogueGain(0.0)\n \t{\n \t}\n \n@@ -29,6 +29,8 @@ struct DeviceStatus {\n \tlibcamera::utils::Duration shutterSpeed;\n \t/* frame length given in number of lines */\n \tuint32_t frameLength;\n+\t/* line length for the current frame */\n+\tlibcamera::utils::Duration lineLength;\n \tdouble analogueGain;\n \t/* 1.0/distance-in-metres, or 0 if unknown */\n \tstd::optional lensPosition;\ndiff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex b6289f151677..5d6b22ef6813 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -1108,7 +1108,9 @@ void IPARPi::fillDeviceStatus(const ControlList &sensorControls)\n \tint32_t exposureLines = sensorControls.get(V4L2_CID_EXPOSURE).get();\n \tint32_t gainCode = sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get();\n \tint32_t vblank = sensorControls.get(V4L2_CID_VBLANK).get();\n+\tint32_t hblank = sensorControls.get(V4L2_CID_HBLANK).get();\n \n+\tdeviceStatus.lineLength = (mode_.width + hblank) * (1.0s / mode_.pixelRate);\n \tdeviceStatus.shutterSpeed = helper_->exposure(exposureLines, mode_.minLineLength);\n \tdeviceStatus.analogueGain = helper_->gain(gainCode);\n \tdeviceStatus.frameLength = mode_.height + vblank;\n","prefixes":["libcamera-devel","v1","6/9"]}