[{"id":25269,"web_url":"https://patchwork.libcamera.org/comment/25269/","msgid":"","date":"2022-10-04T17:06:22","subject":"Re: [libcamera-devel] [PATCH v1 5/9] ipa: raspberrypi: Add pixel\n\tclock rate to the CameraMode structure","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Oct 03, 2022 at 09:39:31AM +0100, Naushir Patuck via libcamera-devel wrote:\n> The pixel clock rate will be used in subsequent commits to calculate line\n> length durations.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/camera_mode.h | 2 ++\n> src/ipa/raspberrypi/raspberrypi.cpp | 1 +\n> 2 files changed, 3 insertions(+)\n> \n> diff --git a/src/ipa/raspberrypi/controller/camera_mode.h b/src/ipa/raspberrypi/controller/camera_mode.h\n> index cda6ac4e200a..b8dae386aee8 100644\n> --- a/src/ipa/raspberrypi/controller/camera_mode.h\n> +++ b/src/ipa/raspberrypi/controller/camera_mode.h\n> @@ -39,4 +39,6 @@ struct CameraMode {\n> \tuint32_t minFrameLength, maxFrameLength;\n> \t/* sensitivity of this mode */\n> \tdouble sensitivity;\n> +\t/* pixel clock rate */\n> +\tuint64_t pixelRate;\n> };\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 9b0ad4361c97..b6289f151677 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -331,6 +331,7 @@ void IPARPi::setMode(const IPACameraSensorInfo &sensorInfo)\n> \tmode_.sensorHeight = sensorInfo.activeAreaSize.height;\n> \tmode_.cropX = sensorInfo.analogCrop.x;\n> \tmode_.cropY = sensorInfo.analogCrop.y;\n> +\tmode_.pixelRate = sensorInfo.pixelRate;\n> \n> \t/*\n> \t * Calculate scaling parameters. The scale_[xy] factors are determined","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EC2EC0DA4\n\tfor ;\n\tTue, 4 Oct 2022 17:06:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E88BF60AB3;\n\tTue, 4 Oct 2022 19:06:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04DFB60AAC\n\tfor ;\n\tTue, 4 Oct 2022 19:06:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 810552D9;\n\tTue, 4 Oct 2022 19:06:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664903187;\n\tbh=pYOL5cPyd0otLH9goANIUNdaJ7gzLhXGJi7S1/oPD0I=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Qkgo/KvIu7+4k9BwhdTzj5i+ZSKLIb1pL/AkB8bpqEUzCl+Cn5/fdqwVKb8s6RYvt\n\tDEhouUswlY9VabXzKH9nC/FPJDMXY2MboravPTyctSFYUkvl4NuHeWRKk1KmTKcSsx\n\tN4NX7X4fy4a70si5gvW+Lo2iqB09pqKat4wXahsplkx3YBjylkWOc5S51fWPOO2QuC\n\t+CS2UAuqHsqLp/HJcUrSsWP9PZJyqis8eZEF/9D/uOKqsd0O1W833Mct6D11oPWFoG\n\tbIYLn2SiOZEn8WAfDcP2uuM0r75gE4/WA1JtXlv34WUJNJEOqZAvu8BIam+qWi7D41\n\tEEBVS0+i0CmIA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664903185;\n\tbh=pYOL5cPyd0otLH9goANIUNdaJ7gzLhXGJi7S1/oPD0I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ln7SBsfF/n3macbI63392kStSc+Bm8xq/JGJbYsCE89p50v9P35FchT7naHsjh41t\n\tBfTjInJr5ARi9wp7hfLM1La1Rt2lkmqRPNVHVbMRDeWArCi5ARsSauCGBoGf3DweBm\n\tQOThbrvh5lv5tg+lW9BuZbCFI+70XbJhPCznAjdM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ln7SBsfF\"; dkim-atps=neutral","Date":"Tue, 4 Oct 2022 20:06:22 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20221003083934.31629-1-naush@raspberrypi.com>\n\t<20221003083934.31629-6-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221003083934.31629-6-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v1 5/9] ipa: raspberrypi: Add pixel\n\tclock rate to the CameraMode structure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]